proclaim 0.3.1 → 0.4.0

data/test/policies/proclaim/image_policy_test.rb

@@ -0,0 +1,83 @@
+require 'test_helper'
+
+class ImagePolicyTest < ActiveSupport::TestCase
+	teardown do
+		image = Proclaim::Image.new
+		FileUtils.rm_rf(File.join(Rails.public_path, image.image.cache_dir))
+		FileUtils.rm_rf(File.join(Rails.public_path, image.image.store_dir))
+	end
+
+	test "image scope" do
+		user = FactoryGirl.create(:user)
+		image = FactoryGirl.create(:image)
+
+		# Verify that a user can view the image
+		images = Pundit.policy_scope(user, Proclaim::Image)
+		assert_includes images, image
+
+		# Verify that a guest cannot see any images
+		images = Pundit.policy_scope(nil, Proclaim::Image)
+		assert_empty images
+	end
+
+	test "image caching" do
+		user = FactoryGirl.create(:user)
+		image = FactoryGirl.build(:image)
+
+		# Verify that a user can cache an image
+		policy = Proclaim::ImagePolicy.new(user, image)
+		assert policy.cache?, "A user should be able to cache images"
+
+		# Verify that a guest cannot cache an image
+		policy = Proclaim::ImagePolicy.new(nil, image)
+		refute policy.cache?, "A guest should not be able to cache images"
+	end
+
+	test "image creation" do
+		user = FactoryGirl.create(:user)
+		image = FactoryGirl.build(:image)
+
+		# Verify that a user can create an image
+		policy = Proclaim::ImagePolicy.new(user, image)
+		assert policy.create?, "A user should be able to create images"
+
+		# Verify that a guest cannot create an image
+		policy = Proclaim::ImagePolicy.new(nil, image)
+		refute policy.create?, "A guest should not be able to create images"
+	end
+
+	test "image discard" do
+		user = FactoryGirl.create(:user)
+		cached_image = FactoryGirl.build(:image)
+		saved_image = FactoryGirl.create(:image)
+
+		# Verify that a user can discard a cached image
+		policy = Proclaim::ImagePolicy.new(user, cached_image)
+		assert policy.discard?, "A user should be able to discard a cached image"
+
+		# Verify that a user can discard a saved image
+		policy = Proclaim::ImagePolicy.new(user, saved_image)
+		assert policy.discard?, "A user should be able to discard a saved image"
+
+		# Verify that a guest cannot discard a cached image
+		policy = Proclaim::ImagePolicy.new(nil, cached_image)
+		refute policy.discard?, "A guest should not be able to discard a cached image"
+
+		# Verify that a guest cannot discard a saved image
+		policy = Proclaim::ImagePolicy.new(nil, saved_image)
+		refute policy.discard?, "A guest should not be able to discard a saved image"
+	end
+
+	test "image destroy" do
+		user = FactoryGirl.create(:user)
+		image = FactoryGirl.create(:image)
+
+		# Verify that a user can destroy an image
+		policy = Proclaim::ImagePolicy.new(user, image)
+		assert policy.destroy?, "A user should be able to destroy image"
+
+		# Verify that a guest cannot destroy an image
+		policy = Proclaim::ImagePolicy.new(nil, image)
+		refute policy.destroy?, "A guest should not be able to destroy image"
+	end
+end

data/test/policies/proclaim/post_policy_test.rb

@@ -17,6 +17,17 @@ class PostPolicyTest < ActiveSupport::TestCase
 		assert_includes posts, post2
 	end
 
+	test "post index" do
+		user = FactoryGirl.create(:user)
+
+		# Verify that a user can visit the index
+		policy = Proclaim::PostPolicy.new(user, Proclaim::Post)
+		assert policy.index?, "A user should be able to visit the index"
+
+		# Verify that a guest can also visit the index
+		policy = Proclaim::PostPolicy.new(nil, Proclaim::Post)
+		assert policy.index?, "A guest should be able to visit the index"
+	end
 
 	test "post create" do
 		user = FactoryGirl.create(:user)

data/test/policies/proclaim/subscription_policy_test.rb

@@ -13,7 +13,32 @@ class SubscriptionPolicyTest < ActiveSupport::TestCase
 
 		# Verify that without a user, no subscription can be seen
 		subscriptions = Pundit.policy_scope(nil, Proclaim::Subscription)
-		assert_nil subscriptions
+		assert_empty subscriptions
+	end
+
+	test "subscription index" do
+		user = FactoryGirl.create(:user)
+
+		# Verify that a user can visit the index
+		policy = Proclaim::SubscriptionPolicy.new(user, Proclaim::Subscription)
+		assert policy.index?, "A user should be able to visit the index"
+
+		# Verify that a guest cannot visit the index
+		policy = Proclaim::SubscriptionPolicy.new(nil, Proclaim::Subscription)
+		refute policy.index?, "A guest should not be able to visit the index"
+	end
+
+	test "subscription show" do
+		user = FactoryGirl.create(:user)
+		subscription = FactoryGirl.create(:subscription)
+
+		# Verify that a user can view a subscription
+		policy = Proclaim::SubscriptionPolicy.new(user, subscription)
+		assert policy.show?, "A user should be able to view a subscription"
+
+		# Verify that a guest can also view a subscription
+		policy = Proclaim::SubscriptionPolicy.new(nil, subscription)
+		assert policy.show?, "A guest should be able to view a subscription"
 	end
 
 	test "subscription creation" do
@@ -54,7 +79,7 @@ class SubscriptionPolicyTest < ActiveSupport::TestCase
 		user = FactoryGirl.create(:user)
 		subscription = FactoryGirl.create(:subscription)
 
-		# Verify that a even a user can't update a subscription (for now)
+		# Verify that a even a user can't update a subscription
 		policy = Proclaim::SubscriptionPolicy.new(user, subscription)
 		refute policy.update?, "A user should not be able to update subscriptions!"
 
@@ -63,19 +88,6 @@ class SubscriptionPolicyTest < ActiveSupport::TestCase
 		refute policy.update?, "A guest should not be able to update subscription!"
 	end
 
-	test "subscription unsubscribe" do
-		user = FactoryGirl.create(:user)
-		subscription = FactoryGirl.create(:subscription)
-
-		# Verify that a user can unsubscribe
-		policy = Proclaim::SubscriptionPolicy.new(user, subscription)
-		assert policy.unsubscribe?, "A user should be able to unsubscribe!"
-
-		# Verify that a guest can also unsubscribe
-		policy = Proclaim::SubscriptionPolicy.new(nil, subscription)
-		assert policy.unsubscribe?, "A guest should be able to unsubscribe!"
-	end
-
 	test "subscription destroy" do
 		user = FactoryGirl.create(:user)
 		subscription = FactoryGirl.create(:subscription)

data/test/unit/proclaim/new_comment_callback_test.rb

@@ -0,0 +1,62 @@
+# == Schema Information
+#
+# Table name: proclaim_comments
+#
+#  id         :integer          not null, primary key
+#  post_id    :integer
+#  parent_id  :integer
+#  author     :string
+#  body       :text
+#  created_at :datetime         not null
+#  updated_at :datetime         not null
+#
+
+require 'test_helper'
+
+module Proclaim
+	class NewCommentCallbackTest < ActiveSupport::TestCase
+		setup do
+			@callback_called = false
+
+			Proclaim.after_new_comment do
+				@callback_called = true
+			end
+		end
+
+		teardown do
+			Proclaim.reset_new_comment_callbacks
+		end
+
+		test "ensure callback supports blocks and procs" do
+			assert_nothing_raised do
+				Proclaim.after_new_comment lambda {|comment| puts "test Proc"}
+			end
+
+			assert_nothing_raised do
+				Proclaim.after_new_comment do
+					puts "test block"
+				end
+			end
+
+			assert_raise RuntimeError do
+				Proclaim.after_new_comment :foo
+			end
+		end
+
+		test "ensure callback is called when created" do
+			comment = FactoryGirl.build(:comment)
+			refute @callback_called
+
+			comment.save
+			assert @callback_called
+		end
+
+		test "ensure callback is not called when updated" do
+			comment = FactoryGirl.create(:comment)
+			@callback_called = false
+
+			comment.save
+			refute @callback_called
+		end
+	end
+end

data/test/unit/proclaim/new_subscription_callback_test.rb

@@ -0,0 +1,62 @@
+# == Schema Information
+#
+# Table name: proclaim_comments
+#
+#  id         :integer          not null, primary key
+#  post_id    :integer
+#  parent_id  :integer
+#  author     :string
+#  body       :text
+#  created_at :datetime         not null
+#  updated_at :datetime         not null
+#
+
+require 'test_helper'
+
+module Proclaim
+	class NewSubscriptionCallbackTest < ActiveSupport::TestCase
+		setup do
+			@callback_called = false
+
+			Proclaim.after_new_subscription do
+				@callback_called = true
+			end
+		end
+
+		teardown do
+			Proclaim.reset_new_subscription_callbacks
+		end
+
+		test "ensure callback supports blocks and procs" do
+			assert_nothing_raised do
+				Proclaim.after_new_subscription lambda {|subscription| puts "test Proc"}
+			end
+
+			assert_nothing_raised do
+				Proclaim.after_new_subscription do
+					puts "test block"
+				end
+			end
+
+			assert_raise RuntimeError do
+				Proclaim.after_new_subscription :foo
+			end
+		end
+
+		test "ensure callback is called when created" do
+			subscription = FactoryGirl.build(:subscription)
+			refute @callback_called
+
+			subscription.save
+			assert @callback_called
+		end
+
+		test "ensure callback is not called when updated" do
+			subscription = FactoryGirl.create(:subscription)
+			@callback_called = false
+
+			subscription.save
+			refute @callback_called
+		end
+	end
+end

data/test/unit/proclaim/post_published_callback_test.rb

@@ -0,0 +1,74 @@
+# == Schema Information
+#
+# Table name: proclaim_comments
+#
+#  id         :integer          not null, primary key
+#  post_id    :integer
+#  parent_id  :integer
+#  author     :string
+#  body       :text
+#  created_at :datetime         not null
+#  updated_at :datetime         not null
+#
+
+require 'test_helper'
+
+module Proclaim
+	class PostPublishedCallbackTest < ActiveSupport::TestCase
+		setup do
+			@callback_called = false
+
+			Proclaim.after_post_published do
+				@callback_called = true
+			end
+		end
+
+		teardown do
+			Proclaim.reset_post_published_callbacks
+		end
+
+		test "ensure callback supports blocks and procs" do
+			assert_nothing_raised do
+				Proclaim.after_post_published lambda {|post| puts "test Proc"}
+			end
+
+			assert_nothing_raised do
+				Proclaim.after_post_published do
+					puts "test block"
+				end
+			end
+
+			assert_raise RuntimeError do
+				Proclaim.after_post_published :foo
+			end
+		end
+
+		test "ensure callback is called when published" do
+			post = FactoryGirl.build(:post)
+			refute @callback_called
+
+			post.publish
+			refute @callback_called # Not saved yet, so callbacks shouldn't happen
+
+			post.save
+			assert @callback_called
+		end
+
+		test "ensure callback is not called when created" do
+			post = FactoryGirl.build(:post)
+			refute @callback_called
+
+			post.save
+			refute @callback_called,
+			       "Callback shouldn't be called unless the post is published!"
+		end
+
+		test "ensure callback is not called when updated" do
+			post = FactoryGirl.create(:post)
+			@callback_called = false
+
+			post.save
+			refute @callback_called
+		end
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: proclaim
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Kyle Fazzari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-23 00:00:00.000000000 Z
+date: 2015-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -392,16 +392,16 @@ files:
 - app/views/proclaim/subscription_mailer/new_post_notification_email.html.erb
 - app/views/proclaim/subscription_mailer/welcome_email.html.erb
 - app/views/proclaim/subscriptions/_form.html.erb
+- app/views/proclaim/subscriptions/index.html.erb
 - app/views/proclaim/subscriptions/new.html.erb
-- app/views/proclaim/subscriptions/subscribed.html.erb
-- app/views/proclaim/subscriptions/unsubscribe.html.erb
-- app/views/proclaim/subscriptions/unsubscribed.html.erb
+- app/views/proclaim/subscriptions/show.html.erb
 - config/routes.rb
 - db/migrate/20141108222616_create_proclaim_posts.rb
 - db/migrate/20141114235359_create_proclaim_comments.rb
 - db/migrate/20141115022230_create_proclaim_comment_hierarchies.rb
 - db/migrate/20141210234057_create_proclaim_subscriptions.rb
 - db/migrate/20141222224905_create_proclaim_images.rb
+- db/migrate/20150123115226_add_name_to_subscriptions.rb
 - lib/generators/proclaim/install_generator.rb
 - lib/generators/proclaim/templates/README
 - lib/generators/proclaim/templates/initialize_proclaim.rb
@@ -464,6 +464,7 @@ files:
 - test/integration/with_javascript/post_show_test.rb
 - test/integration/with_javascript/post_subscription_test.rb
 - test/integration/without_javascript/blog_subscription_test.rb
+- test/integration/without_javascript/manage_subscriptions_test.rb
 - test/integration/without_javascript/post_test.rb
 - test/integration/without_javascript/subscription_email_test.rb
 - test/integration/without_javascript/unsubscribe_test.rb
@@ -474,6 +475,7 @@ files:
 - test/models/proclaim/post_test.rb
 - test/models/proclaim/subscription_test.rb
 - test/policies/proclaim/comment_policy_test.rb
+- test/policies/proclaim/image_policy_test.rb
 - test/policies/proclaim/post_policy_test.rb
 - test/policies/proclaim/subscription_policy_test.rb
 - test/proclaim_test.rb
@@ -482,6 +484,9 @@ files:
 - test/support/pages/posts/show_page.rb
 - test/support/wait_for_ajax.rb
 - test/test_helper.rb
+- test/unit/proclaim/new_comment_callback_test.rb
+- test/unit/proclaim/new_subscription_callback_test.rb
+- test/unit/proclaim/post_published_callback_test.rb
 - vendor/assets/images/link.png
 - vendor/assets/images/remove.png
 - vendor/assets/images/resize-bigger.png
@@ -563,7 +568,11 @@ test_files:
 - test/integration/without_javascript/post_test.rb
 - test/integration/without_javascript/subscription_email_test.rb
 - test/integration/without_javascript/unsubscribe_test.rb
+- test/integration/without_javascript/manage_subscriptions_test.rb
 - test/integration/without_javascript/blog_subscription_test.rb
+- test/unit/proclaim/new_comment_callback_test.rb
+- test/unit/proclaim/post_published_callback_test.rb
+- test/unit/proclaim/new_subscription_callback_test.rb
 - test/proclaim_test.rb
 - test/support/pages/posts/edit_page.rb
 - test/support/pages/posts/show_page.rb
@@ -588,6 +597,7 @@ test_files:
 - test/controllers/proclaim/images_controller_test.rb
 - test/controllers/proclaim/subscriptions_controller_test.rb
 - test/controllers/proclaim/posts_controller_test.rb
+- test/policies/proclaim/image_policy_test.rb
 - test/policies/proclaim/post_policy_test.rb
 - test/policies/proclaim/subscription_policy_test.rb
 - test/policies/proclaim/comment_policy_test.rb