process_helper 0.0.3 → 0.0.4.pre.beta.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d29ad0fa584a226473f5a65df1b814c0283958cb
-  data.tar.gz: 3732855e1fe9cb030c64d959555be9a342f3ae84
+  metadata.gz: 3d1de91d830fe7cc5e79d69b97de7d248351318d
+  data.tar.gz: ff9505e3dede36dbb1888c54c3d3e8a4250f5232
 SHA512:
-  metadata.gz: 2960aaf0bc89d84df0a1c580569fb715434e393a8a6e2b352b901fb1f84daf3d9b78fb8b1c9d87955332f32de00bc5ac8c3448dccbb4bcf3b35b9188bf7e3c0a
-  data.tar.gz: 194c492795fa05862416a84eb7a3d5b346f35fa469287b379c488781f68a6bca1557325cf9ac595690a407a463422484ac472623427813d1424acb99f0636f92
+  metadata.gz: b082df1e1da68ee594d86823aa064ce1342049069ac69d660cdcff25c783c465de9cb336b1d4e5ca24fd331837e09b6ba635f032102919a0581cf7cf6f94e2f3
+  data.tar.gz: 8ee4d6e370b5c534f3b8a3ff5f4fcf7dd36295ce3f3a65611e9dcc0ad9c3d6147c766d160a4312b6b7e76749bfd0af7767f1c1ee419d33e49d257822f06fc744

data/.gitignore

@@ -21,3 +21,4 @@ tmp
 *.o
 *.a
 mkmf.log
+.vscode

data/.rubocop.yml

@@ -1,5 +1,17 @@
 ---
 # https://github.com/bbatsov/rubocop/blob/master/config/default.yml
+
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+  Exclude:
+    - 'client/node_modules/**/*'
+    - 'db/**/*'
+    - 'vendor/bundle/**/*'
+
 Metrics/LineLength:
   Max: 99
 
@@ -7,23 +19,40 @@ Metrics/MethodLength:
   CountComments: false  # count full line comments?
   Max: 20
 
-Style/CaseIndentation:
-  IndentOneStep: true
+Metrics/ModuleLength:
+  Max: 300
 
-Style/FirstParameterIndentation:
-  Enabled: false
-
-Style/MultilineBlockChain:
-  Enabled: false
+Style/FileName:
+  # File names listed in AllCops:Include are excluded by default. Add extra
+  # excludes here.
+  Exclude:
+    - bin/ruby-lint
 
 Style/MultilineOperationIndentation:
-  Enabled: false
+  EnforcedStyle: indented
+
+Style/SignalException:
+  # prefer fail for app code, but rails generates raise in binstubs so allow that too
+  EnforcedStyle: semantic
 
 Style/SpaceAroundEqualsInParameterDefault:
   # compatibility with RubyMine defaults (apparently can't override?)
   EnforcedStyle: space
 
-Style/TrailingComma:
-  # can't make this only apply to arrays and not params, so it's disabled
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: no_comma
+
+Style/MultilineMethodCallIndentation:
+  # can't convince rubymine to not indent 2 spaces with mult-line method calls
   Enabled: false
-  #EnforcedStyleForMultiline: comma
+
+Style/MultilineOperationIndentation:
+  # can't convince rubymine 7 to not indent 4 spaces with mult-line expect(x).to receive ...
+  Enabled: false
+
+Style/RegexpLiteral:
+  # This is required or else rubocop argues with itself when trying to escape a slash on a single-line regex
+  AllowInnerSlashes: true

data/.rubocop_todo.yml

@@ -0,0 +1,62 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-07-25 21:30:11 -0700 using RuboCop version 0.38.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# SupportedStyles: case, end
+Style/CaseIndentation:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/ClosingParenthesisIndentation:
+  Exclude:
+    - 'spec/options/expected_exit_status_spec.rb'
+
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
+Style/FirstParameterIndentation:
+  Exclude:
+    - 'spec/error_handling_spec.rb'
+    - 'spec/input_handling_spec.rb'
+    - 'spec/options/expected_exit_status_spec.rb'
+    - 'spec/options/include_output_in_exception_spec.rb'
+    - 'spec/options/puts_output_spec.rb'
+    - 'spec/options/validation_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Exclude:
+    - 'lib/process_helper.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInArguments:
+  Exclude:
+    - 'spec/options/expected_exit_status_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+  Exclude:
+    - 'spec/input_handling_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowNamedUnderscoreVariables.
+Style/TrailingUnderscoreVariable:
+  Exclude:
+    - 'lib/process_helper.rb'

data/.ruby-version

@@ -1 +1 @@
-ruby-2.1
+ruby-2.3.3

data/.travis.yml

@@ -1,2 +1,7 @@
 ---
 sudo: false
+addons:
+    code_climate:
+        repo_token: e7445c267f016d1a041c9cd16889fa806714e9a7c9bc1fc7936465442b9a167b
+after_success:
+  - bundle exec codeclimate-test-reporter

data/README.md

@@ -1,18 +1,20 @@
-[![Travis-CI Build Status](https://travis-ci.org/thewoolleyman/process_helper.svg?branch=master)](https://travis-ci.org/thewoolleyman/process_helper) | [![Code Climate](https://codeclimate.com/github/thewoolleyman/process_helper/badges/gpa.svg)](https://codeclimate.com/github/thewoolleyman/process_helper) | [![Test Coverage](https://codeclimate.com/github/thewoolleyman/process_helper/badges/coverage.svg)](https://codeclimate.com/github/thewoolleyman/process_helper) | [Pivotal Tracker Project](https://www.pivotaltracker.com/n/projects/1117814)
+[![Travis-CI Build Status](https://travis-ci.org/thewoolleyman/process_helper.svg?branch=master)](https://travis-ci.org/thewoolleyman/process_helper) | [![Code Climate](https://codeclimate.com/github/thewoolleyman/process_helper/badges/gpa.svg)](https://codeclimate.com/github/thewoolleyman/process_helper) | [![Test Coverage](https://codeclimate.com/github/thewoolleyman/process_helper/badges/coverage.svg)](https://codeclimate.com/github/thewoolleyman/process_helper) | [![Gem Version](https://badge.fury.io/rb/process_helper.svg)](https://badge.fury.io/rb/process_helper) | [Pivotal Tracker Project](https://www.pivotaltracker.com/n/projects/1117814)
 
 # process_helper
 
-Makes it easy to spawn Ruby sub-processes with guaranteed exit status handling, passing of lines to STDIN, and capturing of STDOUT and STDERR streams.
+Makes it easy to spawn Ruby sub-processes with guaranteed exit status handling, capturing and/or suppressing combined STDOUT and STDERR streams, providing STDIN input, timeouts, and running via a pseudo terminal.
 
 ## Goals
 
 * Always raise an exception on unexpected exit status (i.e. return code or `$!`)
-* Combine and interleave STDOUT and STDERR streams into STDOUT (using [Open3.popen2e](http://ruby-doc.org/stdlib-2.1.5/libdoc/open3/rdoc/Open3.html#method-c-popen2e)),
+* Combine and interleave STDOUT and STDERR streams into STDOUT (using [Open3.popen2e](http://ruby-doc.org/stdlib-2.1.5/libdoc/open3/rdoc/Open3.html#method-c-popen2e))
+  or [PTY.spawn](https://ruby-doc.org/stdlib-2.2.3/libdoc/pty/rdoc/PTY.html#method-c-spawn),
   so you don't have to worry about how to capture the output of both streams.
 * Provide useful options for suppressing output and including output when an exception
   is raised due to an unexpected exit status
 * Provide real-time streaming of combined STDOUT/STDERR streams in addition to returning full combined output as a string returned from the method and/or in the exception.  
-* Support passing multi-line input to the STDIN stream via arrays of strings.
+* Support passing input to the STDIN stream via string or StringIO.
+* Support running commands in a pseudo terminal.
 * Allow override of the expected exit status(es) (zero is expected by default)
 * Provide short forms of all options for terse, concise usage.
 
@@ -24,7 +26,8 @@ Makes it easy to spawn Ruby sub-processes with guaranteed exit status handling,
 
 ## Why Yet Another Ruby Process Wrapper Library?
 
-There's many other libraries to make it easier to work with processes in Ruby (see the Resources section).  However, `process_helper` was created because none of them made it *easy* to run processes while meeting **all** of these requirements (redundant details are repeated above in Goals section):
+There's many other libraries to make it easier to work with processes in Ruby (see the Resources section).
+However, `process_helper` was created because none of them made it *easy* to run processes while meeting **all** of these requirements (redundant details are repeated above in Goals section):
 
 * Combine STDOUT/STDERR output streams ***interleaved chronologically as emitted***
 * Stream STDOUT/STDERR real-time ***while process is still running***, in addition to returning full output as a string and/or in an exception
@@ -32,6 +35,26 @@ There's many other libraries to make it easier to work with processes in Ruby (s
 * Can be used ***very concisely***.  I.e. All behavior can be invoked via a single mixed-in module with single public method call using terse options with sensible defaults, no need to use IO streams directly or have any blocks or local variables declared.
 
 
+## Table of Contents
+
+* [Goals](#goals)
+* [Non-Goals](#non-goals)
+* [Why Yet Another Ruby Process Wrapper Library](#why-yet-another-ruby-process-wrapper-library)
+* [Installation](#installation)
+* [Usage](#usage)
+* [Options](#options)
+  * [`:expected_exit_status` (short form `:exp_st`)](#expected_exit_status-short-form-exp_st)
+  * [`:include_output_in_exception` (short form `:out_ex`)](#include_output_in_exception-short-form-out_ex)
+  * [`:input` (short form `:in`)](#input-short-form-in)
+  * [`:pseudo_terminal` (short form `:pty`)](#pseudo_terminal-short-form-pty)
+  * [`:puts_output` (short form `:out`)](#puts_output-short-form-out)
+  * [`:timeout` (short form `:kill`)](#timeout-short-form-kill)
+* [Warnings if failure output will be suppressed based on options](#warnings-if-failure-output-will-be-suppressed-based-on-options)  
+* [Version](#version)
+* [Contributing](#contributing)
+* [(Un)License](#unlicense)
+* [Resources](#resources)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -131,6 +154,36 @@ ProcessHelper::UnexpectedExitStatusError: Command failed, pid 64947 exit 1. Comm
 "
 ```
 
+### `:input` (short form `:in`)
+
+A String or StringIO object which will be supplied as standard input to the command.
+
+The entire string will be read and piped to the command prior to outputting any output,
+but this behavior may be changed in the future to allow a separator character for
+processing input as "lines".
+
+### `:pseudo_terminal` (short form `:pty`)
+
+Valid values are `true` and `false`.  Default value is `false`.
+
+When this option is `true`, it will cause the command to be processed via 
+[PTY.spawn](https://ruby-doc.org/stdlib-2.2.3/libdoc/pty/rdoc/PTY.html#method-c-spawn)
+in a pseudo-terminal.
+
+Some commands require a terminal, or "tty" to work properly, or to work at all.
+For example, some commands may not emit colored output unless they
+detect that they are running via a terminal.
+
+It is important to note that this can change the behavior of a command.
+ 
+For example, in most default Linux and OSX (BSD) terminals, newlines (`\n`) in output
+will be translated to carriage-return + newline (`\r\n`).  This will normally
+have no effect, and can be controlled by the `onlcr (-onlcr)` option
+of the [stty command](https://www.freebsd.org/cgi/man.cgi?query=stty&sektion=1).
+Use `stty -a` to get info on the current terminal.
+ 
+Also, any input given to the command may be echoed to the output as well. 
+
 ### `:puts_output` (short form `:out`)
 
 Valid values are `:always`, `:error`, and `:never`.  Default value is `:always`.
@@ -142,18 +195,19 @@ Valid values are `:always`, `:error`, and `:never`.  Default value is `:always`.
 
 ### `:timeout` (short form `:kill`)
 
-***WARNING! This option is beta and will be changed in a future release!***
+***NOTE: This option will be changed in a future release.***
 
 Valid value is a float, e.g. `1.5`.  Default value is nil/undefined.
 
-* Currently controls how long `process_helper` will wait to read from
-  a blocked IO stream before timing out (via [IO.select](http://ruby-doc.org/core-2.2.0/IO.html#method-c-select)).  For example, invoking `cat` with no arguments, which by default will continue accepting input until killed.
+* Controls how long `process_helper` will wait to read from
+  a blocked IO stream before timing out (via [IO.select](http://ruby-doc.org/core-2.2.0/IO.html#method-c-select)).
+  For example, invoking `cat` with no arguments, which by default will continue accepting input until killed.
+* Will also kill long running processes which are ***not*** in blocked waiting on an IO stream read (i.e. kill process regardless of any IO state, not just via [IO.selects](http://ruby-doc.org/core-2.2.0/IO.html#method-c-select) timeout support).
 * If undefined (default), there will be no timeout, and `process_helper` will hang if a process hangs while waiting to read from IO.
 
 ***The following changes are planned for this option:***
 
 * Add validation of value (enforced to be a float).
-* Add ability for the timeout value to also kill long running processes which are ***not*** in blocked waiting on an IO stream read (i.e. kill process regardless of any IO state, not just via [IO.selects](http://ruby-doc.org/core-2.2.0/IO.html#method-c-select) timeout support).
 * Have both types of timeouts raise different and unique exception classes.
 * Possibly have different option names to allow different timeout values for the two types of timeouts.
 
@@ -202,14 +256,19 @@ ProcessHelper::VERSION
 
 ## Resources
 
-Other Ruby Process tools/libraries
+Other Ruby Process tools/libraries:
 
+* a [comprehensive StackOverflow article](http://stackoverflow.com/questions/7212573/when-to-use-each-method-of-launching-a-subprocess-in-ruby) describing, in detail, the myriad methods of launching Ruby subprocesses.
 * [open4](https://github.com/ahoward/open4) - a solid and useful library - the main thing I missed in it was easily combining real-time streaming interleaved STDOUT/STDERR streams
 * [open4 on ruby toolbox](https://www.ruby-toolbox.com/projects/open4) - see if there's some useful higher-level gem that depends on it and gives you functionality you may need
 * A great series of blog posts by Devver:
   * [https://devver.wordpress.com/2009/06/30/a-dozen-or-so-ways-to-start-sub-processes-in-ruby-part-1/](https://devver.wordpress.com/2009/06/30/a-dozen-or-so-ways-to-start-sub-processes-in-ruby-part-1/)
   * [https://devver.wordpress.com/2009/07/13/a-dozen-or-so-ways-to-start-sub-processes-in-ruby-part-2/](https://devver.wordpress.com/2009/07/13/a-dozen-or-so-ways-to-start-sub-processes-in-ruby-part-2/)
   * [https://devver.wordpress.com/2009/10/12/ruby-subprocesses-part_3/](https://devver.wordpress.com/2009/10/12/ruby-subprocesses-part_3/)
+* [A gist exploring ruby PTY behavior](https://gist.github.com/thewoolleyman/6a060574f22eafd42955812a1a2a7842#file-pty_check_test-rb)
 
+Some notes on why you should use printf over echo:
 
+* [echo vs. println](http://unix.stackexchange.com/a/219274)
+* [Why is printf better than echo?](http://unix.stackexchange.com/questions/65803/why-is-printf-better-than-echo/65819#65819)
 

data/lib/process_helper.rb

@@ -1,117 +1,129 @@
 require 'open3'
+require 'pty'
+require 'timeout'
 
 # Makes it easier to spawn ruby sub-processes with proper capturing of stdout and stderr streams.
 module ProcessHelper
-  PROCESS_HELPER_VERSION = '0.0.3'
+  # Don't forget to keep version in sync with gemspec
+  VERSION = '0.0.4.pre.beta.2'.freeze
+
+  # rubocop:disable Style/ModuleFunction
+  extend self
 
   def process(cmd, options = {})
     cmd = cmd.to_s
     fail ProcessHelper::EmptyCommandError, 'command must not be empty' if cmd.empty?
     options = options.dup
     options_processing(options)
+    output, process_status =
+      if options[:pseudo_terminal]
+        process_with_pseudo_terminal(cmd, options)
+      else
+        process_with_popen(cmd, options)
+      end
+    handle_exit_status(cmd, options, output, process_status)
+    output
+  end
+
+  private
+
+  def process_with_popen(cmd, options)
     Open3.popen2e(cmd) do |stdin, stdout_and_stderr, wait_thr|
-      always_puts_output = (options[:puts_output] == :always)
-      output = get_output(
-        stdin,
-        stdout_and_stderr,
-        options[:input_lines],
-        always_puts_output,
-        options[:timeout]
-      )
-      stdin.close
-      handle_exit_status(cmd, options, output, wait_thr)
-      output
+      begin
+        output = get_output(stdin, stdout_and_stderr, options)
+      rescue TimeoutError
+        # ensure the thread is killed
+        wait_thr.kill
+        raise
+      end
+      process_status = wait_thr.value
+      return [output, process_status]
     end
   end
 
-  private
+  def process_with_pseudo_terminal(cmd, options)
+    PTY.spawn(cmd) do |stdout_and_stderr, stdin, pid|
+      output = get_output(stdin, stdout_and_stderr, options)
+      process_status = PTY.check(pid)
+      # TODO: come up with a test that illustrates pid not exiting
+      fail "ERROR: pid #{pid} did not exit" unless process_status
+      return [output, process_status]
+    end
+  end
 
   def warn_if_output_may_be_suppressed_on_error(options)
-    return unless options[:puts_output] == :never
+    return unless options[:puts_output] == :never &&
+      options[:include_output_in_exception] == false
 
-    if options[:include_output_in_exception] == false
-      err_msg = 'WARNING: Check your ProcessHelper options - ' \
+    err_msg = 'WARNING: Check your ProcessHelper options - ' \
         ':puts_output is :never, and :include_output_in_exception ' \
         'is false, so all error output will be suppressed if process fails.'
-    else
-      err_msg = 'WARNING: Check your ProcessHelper options - ' \
-        ':puts_output is :never, ' \
-        'so all error output will be suppressed unless process ' \
-        "fails with an exit code other than #{options[:expected_exit_status]} " \
-        '(in which case exception will include output ' \
-        'because :include_output_in_exception is true)'
-    end
     $stderr.puts(err_msg)
   end
 
   # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
   # rubocop:disable Metrics/MethodLength, Metrics/PerceivedComplexity
-  def get_output(stdin, stdout_and_stderr, original_input_lines, always_puts_output, timeout)
-    input_lines = original_input_lines.dup
-    input_lines_processed = 0
-    current_input_line_processed = false
+  def get_output(stdin, stdout_and_stderr, options)
+    input = options[:input]
+    always_puts_output = (options[:puts_output] == :always)
+    timeout = options[:timeout]
     output = ''
     begin
-      while (output_line = readline_nonblock(stdout_and_stderr))
-        current_input_line_processed = true
-        puts output_line if always_puts_output
-        output += output_line
-        output_line = nil
-      end
-    rescue EOFError
-      input_lines_processed -= 1 if !original_input_lines.empty? && !current_input_line_processed
-      fail_unless_all_input_lines_processed(original_input_lines, input_lines_processed)
-    rescue IO::WaitReadable
-      if input_lines.empty?
-        result = IO.select([stdout_and_stderr], nil, nil, timeout)
-        retry unless result.nil?
-      else
-        current_input_line_processed = false
-        puts_input_line_to_stdin(stdin, input_lines)
-        input_lines_processed += 1
+      begin
+        until input.eof?
+          Timeout.timeout(timeout) do
+            in_ch = input.read_nonblock(1)
+            stdin.write_nonblock(in_ch)
+          end
+          stdin.flush
+        end
+        ch = nil
+        loop do
+          Timeout.timeout(timeout) do
+            ch = stdout_and_stderr.read_nonblock(1)
+          end
+          break unless ch
+          printf ch if always_puts_output
+          output += ch
+          stdout_and_stderr.flush
+        end
+      rescue EOFError
+        return output
+      rescue IO::WaitReadable
         result = IO.select([stdout_and_stderr], nil, nil, timeout)
+        raise Timeout::Error if result.nil?
+        retry
+      rescue IO::WaitWritable
+        result = IO.select(nil, [stdin], nil, timeout)
+        raise Timeout::Error if result.nil?
         retry
       end
+    rescue Timeout::Error
+      handle_timeout_error(output, options)
+    ensure
+      stdout_and_stderr.close
+      stdin.close
     end
+    # TODO: Why do we sometimes get here with no EOFError occurring, but instead
+    # via IO::WaitReadable with a nil select result? (via popen, not sure if via tty)
     output
   end
 
-  def readline_nonblock(io)
-    buffer = ''
-    while (ch = io.read_nonblock(1))
-      buffer << ch
-      if ch == "\n"
-        result = buffer
-        return result
-      end
+  def handle_timeout_error(output, options)
+    msg = "Timed out after #{options.fetch(:timeout)} seconds."
+    if options[:include_output_in_exception]
+      msg += " Command output prior to timeout: \"#{output}\""
     end
+    fail(TimeoutError, msg)
   end
 
-  def fail_unless_all_input_lines_processed(original_input_lines, input_lines_processed)
-    unprocessed_input_lines = original_input_lines.length - input_lines_processed
-    msg = "Output stream closed with #{unprocessed_input_lines} " \
-    'input lines left unprocessed:' \
-    "#{original_input_lines[-(unprocessed_input_lines)..-1]}"
-    fail(
-      ProcessHelper::UnprocessedInputError,
-      msg
-    ) unless unprocessed_input_lines == 0
-  end
-
-  def puts_input_line_to_stdin(stdin, input_lines)
-    return if input_lines.empty?
-    input_line = input_lines.shift
-    stdin.puts(input_line)
-  end
-
-  def handle_exit_status(cmd, options, output, wait_thr)
+  def handle_exit_status(cmd, options, output, process_status)
     expected_exit_status = options[:expected_exit_status]
-    exit_status = wait_thr.value
-    return if expected_exit_status.include?(exit_status.exitstatus)
+    return if expected_exit_status.include?(process_status.exitstatus)
 
-    exception_message = create_exception_message(cmd, exit_status, expected_exit_status)
+    exception_message = create_exception_message(cmd, process_status, expected_exit_status)
     if options[:include_output_in_exception]
-      exception_message += " Command Output: \"#{output}\""
+      exception_message += " Command output: \"#{output}\""
     end
     puts_output_only_on_exception(options, output)
     fail ProcessHelper::UnexpectedExitStatusError, exception_message
@@ -141,25 +153,35 @@ module ProcessHelper
   def options_processing(options)
     validate_long_vs_short_option_uniqueness(options)
     convert_short_options(options)
+    validate_input_option(options[:input]) if options[:input]
     set_option_defaults(options)
     validate_option_values(options)
     convert_scalar_expected_exit_status_to_array(options)
     warn_if_output_may_be_suppressed_on_error(options)
   end
 
+  def validate_input_option(input_option)
+    fail(
+      ProcessHelper::InvalidOptionsError,
+      "#{quote_and_join_pair(%w(input in))} options must be a String or a StringIO"
+    ) unless input_option.is_a?(String) || input_option.is_a?(StringIO)
+  end
+
   # rubocop:disable Style/AccessorMethodName
   def set_option_defaults(options)
     options[:puts_output] = :always if options[:puts_output].nil?
     options[:include_output_in_exception] = true if options[:include_output_in_exception].nil?
+    options[:pseudo_terminal] = false if options[:pseudo_terminal].nil?
     options[:expected_exit_status] = [0] if options[:expected_exit_status].nil?
-    options[:input_lines] = [] if options[:input_lines].nil?
+    options[:input] = StringIO.new(options[:input].to_s) unless options[:input].is_a?(StringIO)
   end
 
   def valid_option_pairs
     pairs = [
       %w(expected_exit_status exp_st),
       %w(include_output_in_exception out_ex),
-      %w(input_lines in),
+      %w(input in),
+      %w(pseudo_terminal pty),
       %w(puts_output out),
       %w(timeout kill),
     ]
@@ -205,6 +227,7 @@ module ProcessHelper
         next unless option == long_option_name
         validate_integer(pair, value) if option.to_s == 'expected_exit_status'
         validate_boolean(pair, value) if option.to_s == 'include_output_in_exception'
+        validate_boolean(pair, value) if option.to_s == 'pseudo_terminal'
         validate_puts_output(pair, value) if option.to_s == 'puts_output'
       end
     end
@@ -263,11 +286,15 @@ module ProcessHelper
   class InvalidOptionsError < RuntimeError
   end
 
+  # Error which is raised when any read or write operation takes longer than timeout (kill) option
+  class TimeoutError < RuntimeError
+  end
+
   # Error which is raised when a command returns an unexpected exit status (return code)
   class UnexpectedExitStatusError < RuntimeError
   end
 
-  # Error which is raised when command exists while input lines remain unprocessed
+  # Error which is raised when command exists while input remains unprocessed
   class UnprocessedInputError < RuntimeError
   end
 end

data/process_helper.gemspec

@@ -1,12 +1,10 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'process_helper'
 
 Gem::Specification.new do |spec|
   spec.name = 'process_helper'
-  spec.version = ProcessHelper::PROCESS_HELPER_VERSION
-  spec.authors = ['Glenn Oppegard', 'Chad Woolley']
+  # Don't forget to keep version in sync with ProcessHelper::Version
+  spec.version = '0.0.4.pre.beta.2'
+  spec.authors = ['Chad Woolley', 'Glenn Oppegard']
   spec.email = ['oppegard@gmail.com', 'thewoolleyman@gmail.com']
   spec.summary = "Makes it easier to spawn ruby sub-processes with proper capturing /
     of stdout and stderr streams."
@@ -21,10 +19,11 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 1.9.2'
 
   spec.add_development_dependency 'bundler', '~> 1.6'
-  spec.add_development_dependency 'codeclimate-test-reporter'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 1'
   spec.add_development_dependency 'rake', '~> 10'
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'rspec-retry', '~> 0.4'
-  spec.add_development_dependency 'rubocop', '= 0.29.1' # exact version for static analyis libs
-  spec.add_development_dependency 'ruby-lint', '= 2.0.2' # exact version for static analyis libs
+  spec.add_development_dependency 'rubocop', '= 0.38.0' # exact version for static analyis libs
+  spec.add_development_dependency 'ruby-lint', '= 2.1.0' # exact version for static analyis libs
+  spec.add_development_dependency 'simplecov', '~> 0'
 end

data/ruby-lint.yml

@@ -1,12 +1,13 @@
 ---
 # http://code.yorickpeterse.com/ruby-lint/latest/
 analysis_classes:
- - argument_amount
+# - argument_amount
  - pedantics
  - shadowing_variables
 # - undefined_methods
 # - undefined_variables
- - unused_variables
+# - unused_variables
  - useless_equality_checks
 directories:
+ - lib
  - spec

data/spec/input_handling_spec.rb

@@ -5,49 +5,32 @@ RSpec.describe 'input handling' do
 
   before do
     @clazz = Clazz.new
-    @max_process_wait = ENV['MAX_PROCESS_WAIT'] ? ENV['MAX_PROCESS_WAIT'].to_f : 0.5
   end
 
-  describe 'with non-exiting blocking cmd requiring timeout' do
-    it 'handles a single line of STDIN to STDOUT with ruby output flushing' do
-      expect do
-        clazz.process(
-          "ruby -e 'while(i=$stdin.gets) do puts i; $stdout.flush; end'",
-          input_lines: ['input1'],
-          timeout: max_process_wait
-        )
-      end.to output(/input1\n/).to_stdout
-          .and(not_output.to_stderr)
-    end
-
-    it 'handles multiple lines of STDIN to STDOUT with ruby output flushing' do
-      expect do
-        clazz.process(
-          "ruby -e 'while(i=$stdin.gets) do puts i; $stdout.flush; end'",
-          input_lines: %w(input1 input2),
-          timeout: max_process_wait
-        )
-      end.to output(/input1\ninput2\n/).to_stdout
-          .and(not_output.to_stderr)
-    end
+  it 'handles a single line of STDIN to STDOUT with ruby output flushing' do
+    expect do
+      clazz.process(
+        "ruby -e 'i=$stdin.gets; puts i; $stdout.flush'",
+        input: "input1\n"
+      )
+    end.to output(/input1\n/).to_stdout
+      .and(not_output.to_stderr)
+  end
 
-    it 'handles cat cmd' do
-      expect do
-        clazz.process(
-          # -u disables output buffering, -n numbers output lines (to distinguish from input)
-          'cat -u -n',
-          # TODO: how to send Ctrl-D to exit without timeout being required?
-          input_lines: ['line1', 'line2', 'line3', "\C-d"],
-          timeout: max_process_wait
-        )
-      end.to output(/.*1\tline1\n.*2\tline2\n.*3\tline3\n.*4\t\u0004\n/).to_stdout
-          .and(not_output.to_stderr)
-    end
+  it 'handles multiple lines of STDIN to STDOUT with ruby output flushing' do
+    expect do
+      clazz.process(
+        "ruby -e 'while(i=$stdin.gets) do puts i; $stdout.flush; ; if i =~ /2/; break; end; end'",
+        input: "input1\ninput2\n"
+      )
+    end.to output(/input1\ninput2\n/).to_stdout
+      .and(not_output.to_stderr)
+  end
 
-    it 'handles interleaved stdout and stderr based on stdin input' do
-      expect do
-        cmd =
-          'while ' \
+  it 'handles interleaved stdout and stderr based on stdin input' do
+    expect do
+      cmd =
+        'while ' \
           '  line = $stdin.readline; ' \
           '  $stdout.puts("out:#{line}"); ' \
           '  $stdout.flush; ' \
@@ -55,71 +38,63 @@ RSpec.describe 'input handling' do
           '  $stderr.flush; ' \
           '  exit 0 if line =~ /exit/; ' \
           'end'
-        clazz.process(
-          %(ruby -e '#{cmd}'),
-          input_lines: %w(line1 line2 line3 exit),
-          timeout: max_process_wait
-        )
-      end.to output(/out:line1\nerr:line1\nout:line2\nerr:line2\nout:line3\nerr:line3\n/).to_stdout
-          .and(not_output.to_stderr)
-    end
+      clazz.process(
+        %(ruby -e '#{cmd}'),
+        input: "line1\nline2\nline3\nexit\n"
+      )
+    end.to output(/out:line1\nerr:line1\nout:line2\nerr:line2\nout:line3\nerr:line3\n/).to_stdout
+      .and(not_output.to_stderr)
   end
 
-  describe 'with exiting cmd' do
-    it 'handles stdout and stderr triggered via stdin' do
-      expect do
-        clazz.process(
-          'irb -f --prompt=default',
-          input_lines: [
-            '$stdout.puts "hi"',
-            '$stdout.flush',
-            '$stderr.puts "aaa\nbbb\nccc"',
-            '$stderr.flush',
-            '$stdout.puts "bye"',
-            '$stdout.flush',
-            'exit'
-          ]
-        )
-      end.to output(/\nhi\n.*\naaa\nbbb\nccc.*\nbye\n/m).to_stdout
-          .and(not_output.to_stderr)
-    end
+  it 'handles stdout and stderr triggered via stdin' do
+    expect do
+      clazz.process(
+        'irb -f --prompt=default',
+        input: [
+          '$stdout.puts "hi"',
+          '$stdout.flush',
+          '$stderr.puts "aaa\nbbb\nccc"',
+          '$stderr.flush',
+          '$stdout.puts "bye"',
+          '$stdout.flush',
+          "exit\n"
+        ].join("\n")
+      )
+    end.to output(/\nhi\n.*\naaa\nbbb\nccc.*\nbye\n/m).to_stdout
+      .and(not_output.to_stderr)
+  end
 
-    it 'handles unexpected exit status' do
-      expect do
-        clazz.process(
-          "ruby -e 'i=$stdin.gets; $stdout.puts i; $stdout.flush; " \
+  it 'handles unexpected exit status' do
+    expect do
+      clazz.process(
+        "ruby -e 'i=$stdin.gets; $stdout.puts i; $stdout.flush; " \
           "$stderr.puts i; $stderr.flush; exit 1'",
-          puts_output: :error,
-          input_lines: ['hi']
-        )
-      end.to raise_error(
-          ProcessHelper::UnexpectedExitStatusError,
-          /Command failed/)
-          .and(output(/hi\nhi\n/).to_stdout)
-    end
+        puts_output: :error,
+        input: "hi\n"
+      )
+    end.to raise_error(
+      ProcessHelper::UnexpectedExitStatusError,
+      /Command failed/)
+      .and(output(/hi\nhi\n/).to_stdout)
+  end
 
-    it 'pipes input before processing output' do
-      expect do
-        clazz.process(
-          "ruby -e 'i=$stdin.gets; $stdout.puts i; $stdout.flush; exit'",
-          input_lines: ['hi']
-        )
-      end.to output(/hi\n/m).to_stdout
-          .and(not_output.to_stderr)
-    end
+  it 'pipes input before processing output' do
+    expect do
+      clazz.process(
+        "ruby -e 'i=$stdin.gets; $stdout.puts i; $stdout.flush; exit'",
+        input: "hi\n"
+      )
+    end.to output(/hi\n/m).to_stdout
+      .and(not_output.to_stderr)
+  end
 
-    it 'fails if unprocessed input remains when command exits' do
-      # TODO: This fails when run with code coverage instrumentation
-      #       enabled (via RubyMine).  Why???
-      expect do
-        clazz.process(
-          "ruby -e 'i=$stdin.gets; $stdout.puts i; exit'",
-          input_lines: %w(hi unprocessed)
-        )
-      end.to raise_error(
-          ProcessHelper::UnprocessedInputError,
-          /Output stream closed with 1 input lines left unprocessed/)
-          .and(output(/hi\n/).to_stdout)
-    end
+  it 'allows a StringIO as input' do
+    expect do
+      clazz.process(
+        "ruby -e 'i=$stdin.gets; $stdout.puts i; $stdout.flush; exit'",
+        input: StringIO.new("hi\n")
+      )
+    end.to output(/hi\n/m).to_stdout
+      .and(not_output.to_stderr)
   end
 end

data/spec/module_visibility_spec.rb

@@ -0,0 +1,33 @@
+require_relative 'spec_helper'
+
+RSpec.describe 'module visibility' do
+  attr_reader :clazz
+
+  before do
+    @clazz = Clazz.new
+  end
+
+  it 'can be called as an included module' do
+    expect do
+      clazz.process('echo stdout > /dev/stdout')
+    end.to output("stdout\n").to_stdout
+  end
+
+  it 'can be called as a module method' do
+    expect do
+      ProcessHelper.process('echo stdout > /dev/stdout')
+    end.to output("stdout\n").to_stdout
+  end
+
+  it 'does not expose private methods' do
+    expect(clazz.private_methods).to include(:process_with_popen)
+
+    expect do
+      clazz.process_with_popen
+    end.to raise_error(NoMethodError)
+
+    expect do
+      ProcessHelper.process_with_popen
+    end.to raise_error(NoMethodError)
+  end
+end

data/spec/options/include_output_in_exception_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe ':include_output_in_exception option' do
           )
         end.to raise_error(
             ProcessHelper::UnexpectedExitStatusError,
-            /Command Output: "ls:.*\/does_not_exist: No such file or directory\n"/)
+            /Command output: "ls:.*\/does_not_exist: No such file or directory\n"/)
             .and(output(/No such file or directory/).to_stdout)
       end
 
@@ -31,7 +31,7 @@ RSpec.describe ':include_output_in_exception option' do
             include_output_in_exception: true)
         end.to raise_error(
             ProcessHelper::UnexpectedExitStatusError,
-            /Command Output: "stdout\n"/)
+            /Command output: "stdout\n"/)
             .and(output("stdout\n").to_stdout)
       end
     end

data/spec/options/puts_output_spec.rb

@@ -70,7 +70,7 @@ RSpec.describe ':puts_output option' do
           'echo stdout > /dev/stdout',
           puts_output: :never)
       end.to not_output.to_stdout
-          .and(output(/WARNING/).to_stderr)
+          .and(not_output.to_stderr)
     end
   end
 end

data/spec/options/validation_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe 'options validation raises InvalidOptionError' do
         "'puts_output','out' options must be one of the following: :always, :error, :never")
   end
 
-  it 'when input_lines is passed invalid value'
+  it 'when input is passed invalid value'
 
   it 'when timeout is passed non-float'
 

data/spec/output_handling_spec.rb

@@ -53,9 +53,32 @@ RSpec.describe 'output handling' do
           clazz.process(
             'echo stdout > /dev/stdout',
             puts_output: :never)
-        end.to output(/unless process fails with an exit code other than \[0\]/).to_stderr
-            .and(not_output.to_stdout)
+        end.to not_output.to_stdout
+            .and(not_output.to_stderr)
       end
     end
   end
+
+  describe 'when output does not have a newline' do
+    it 'captures output' do
+      expect do
+        clazz.process(
+          'printf stdout',
+          puts_output: :always)
+      end.to output('stdout').to_stdout
+        .and(not_output.to_stderr)
+    end
+  end
+
+  describe 'when output is colored' do
+    it 'preserves color' do
+      colored_text = "\e[0;31mSTDOUT\e[0m"
+      expect do
+        clazz.process(
+          'printf "\033[0;31mSTDOUT\033[0m" > /dev/stdout',
+          puts_output: :always)
+      end.to output(colored_text).to_stdout
+        .and(not_output.to_stderr)
+    end
+  end
 end

data/spec/pty_handling_spec.rb

@@ -0,0 +1,48 @@
+require_relative 'spec_helper'
+
+RSpec.describe 'pty handling' do
+  attr_reader :clazz, :max_process_wait
+
+  before do
+    skip('pty specs do not work on travis or circle ci (try docker with -t option)') if ENV['CI']
+    @clazz = Clazz.new
+  end
+
+  it 'handles cat cmd' do
+    expect do
+      clazz.process(
+        # -u disables output buffering, -n numbers output lines (to distinguish from input)
+        'cat -u -n',
+        input: "line1\nline2\nline3\n\C-d\n",
+        pty: true
+      )
+    end.to output(/1\tline1\r\n.*2\tline2\r\n.*3\tline3\r\n/).to_stdout
+      .and(not_output.to_stderr)
+  end
+
+  it 'respects "stty -onlcr"' do
+    # NOTE: the `stty -a` default on OSX and Linux terminals seems to be 'onlcr', so all PTY slave
+    #       terminals which inherit that will transform "\n" into "\r\n".  This test shows how to
+    #       avoid that behavior by prepending 'stty -onlcr && ' to the command
+    expect do
+      clazz.process(
+        'stty -onlcr && printf "stdout\n" > /dev/stdout && printf "stderr\n" > /dev/stderr',
+        puts_output: :always,
+        pty: true
+      )
+    end.to output("stdout\nstderr\n").to_stdout
+      .and(not_output.to_stderr)
+  end
+
+  it 'does not require a newline or flush via getch' do
+    skip('TODO: this test just hangs, including in a debugger')
+    expect do
+      clazz.process(
+        %q(ruby -e 'require "io/console"; i=$stdin.getch; puts "4" + i;'),
+        input: '2',
+        pty: true
+      )
+    end.to output(/42/).to_stdout
+      .and(not_output.to_stderr)
+  end
+end

data/spec/spec_helper.rb

@@ -1,7 +1,5 @@
-if ENV['CODECLIMATE_REPO_TOKEN']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-end
+require 'simplecov'
+SimpleCov.start if ENV['CI']
 
 require 'rspec'
 require 'rspec/retry'
@@ -13,7 +11,7 @@ RSpec::Matchers.define_negated_matcher :not_raise_error, :raise_error
 # RSpec config
 RSpec.configure do |config|
   config.verbose_retry = true
-  config.default_retry_count = 5
+  config.default_retry_count = ENV['CI'] ? 3 : 0
   config.default_sleep_interval = 1
 end
 

data/spec/timeout_handling_spec.rb

@@ -0,0 +1,79 @@
+require_relative 'spec_helper'
+
+RSpec.describe 'timout handling with non-exiting blocking cmd requiring timeout' do
+  attr_reader :clazz, :max_process_wait
+
+  before do
+    @clazz = Clazz.new
+    @max_process_wait = ENV['MAX_PROCESS_WAIT'] ? ENV['MAX_PROCESS_WAIT'].to_f : 0.5
+  end
+
+  # TODO: ensure every place that can raise a timeout is specifically exercised by a test
+
+  it 'raises on a sleep' do
+    expect do
+      clazz.process(
+        'sleep 999',
+        timeout: max_process_wait
+      )
+    end.to raise_error(
+      ProcessHelper::TimeoutError,
+      "Timed out after #{@max_process_wait} seconds. Command output prior to timeout: \"\""
+    )
+  end
+
+  it 'does not raise error if timeout is not exceeded' do
+    expect do
+      clazz.process(
+        'sleep 0.01',
+        timeout: max_process_wait
+      )
+    end.to not_output.to_stdout
+      .and(not_output.to_stderr)
+  end
+
+  it 'handles a single line of STDIN to STDOUT with ruby output flushing' do
+    expect do
+      clazz.process(
+        "ruby -e 'while(i=$stdin.gets) do puts i; $stdout.flush; end'",
+        input: "input1\n",
+        puts_output: :never,
+        timeout: max_process_wait
+      )
+    end.to raise_error(
+      ProcessHelper::TimeoutError,
+      "Timed out after #{@max_process_wait} seconds. Command output prior to timeout: \"" \
+          "input1\n\""
+    )
+  end
+
+  it 'handles multiple lines of STDIN to STDOUT with ruby output flushing' do
+    expect do
+      clazz.process(
+        "ruby -e 'while(i=$stdin.gets) do puts i; $stdout.flush; end'",
+        input: "input1\ninput2\n",
+        puts_output: :never,
+        timeout: max_process_wait
+      )
+    end.to raise_error(
+      ProcessHelper::TimeoutError,
+      "Timed out after #{@max_process_wait} seconds. Command output prior to timeout: \"" \
+          "input1\ninput2\n\""
+    )
+  end
+
+  it 'handles cat cmd' do
+    expect do
+      clazz.process(
+        # -u disables output buffering, -n numbers output lines (to distinguish from input)
+        'cat -u -n',
+        input: "line1\nline2\nline3\n",
+        puts_output: :never,
+        timeout: max_process_wait
+      )
+    end.to raise_error(
+      ProcessHelper::TimeoutError,
+      /Timed out.*1\tline1\n.*2\tline2\n.*3\tline3\n/
+    )
+  end
+end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: process_helper
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4.pre.beta.2
 platform: ruby
 authors:
-- Glenn Oppegard
 - Chad Woolley
+- Glenn Oppegard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-01 00:00:00.000000000 Z
+date: 2017-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -29,16 +29,16 @@ dependencies:
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -87,28 +87,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.1
+        version: 0.38.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.1
+        version: 0.38.0
 - !ruby/object:Gem::Dependency
   name: ruby-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Wrapper around Open3#popen2e with other useful options.
 email:
 - oppegard@gmail.com
@@ -119,6 +133,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -130,14 +145,16 @@ files:
 - ruby-lint.yml
 - spec/error_handling_spec.rb
 - spec/input_handling_spec.rb
+- spec/module_visibility_spec.rb
 - spec/options/expected_exit_status_spec.rb
 - spec/options/include_output_in_exception_spec.rb
 - spec/options/puts_output_spec.rb
 - spec/options/validation_spec.rb
 - spec/output_handling_spec.rb
+- spec/pty_handling_spec.rb
 - spec/spec_helper.rb
 - spec/static_analysis_spec.rb
-- spec/version_spec.rb
+- spec/timeout_handling_spec.rb
 homepage: https://github.com/thewoolleyman/process_helper
 licenses:
 - Unlicense
@@ -153,12 +170,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Makes it easier to spawn ruby sub-processes with proper capturing / of stdout
@@ -166,11 +183,13 @@ summary: Makes it easier to spawn ruby sub-processes with proper capturing / of
 test_files:
 - spec/error_handling_spec.rb
 - spec/input_handling_spec.rb
+- spec/module_visibility_spec.rb
 - spec/options/expected_exit_status_spec.rb
 - spec/options/include_output_in_exception_spec.rb
 - spec/options/puts_output_spec.rb
 - spec/options/validation_spec.rb
 - spec/output_handling_spec.rb
+- spec/pty_handling_spec.rb
 - spec/spec_helper.rb
 - spec/static_analysis_spec.rb
-- spec/version_spec.rb
+- spec/timeout_handling_spec.rb

data/spec/version_spec.rb

@@ -1,7 +0,0 @@
-require_relative 'spec_helper'
-
-RSpec.describe 'version' do
-  it 'is semantic' do
-    expect(::ProcessHelper::PROCESS_HELPER_VERSION).to match(/^\d\.\d\.\d\.*\w*$/)
-  end
-end