process_handler 3.0.0 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3e495c8a8ec6bf3798941bd11f2792b9a28f1c95
-  data.tar.gz: 8923ae242c65ba6120b48184588b2534060ff831
+SHA256:
+  metadata.gz: e99facc49cfc6587f45cf03e92d33a940b4a0648e5a29dfce3714915d603e5b8
+  data.tar.gz: b63e820420d30df0b726d798559a39400afb4c5d09bd6b214438dd335b71e065
 SHA512:
-  metadata.gz: 337003df5486731c3b8addbb93e85159e664f20996fda1b22252e111d09831a1b735b3962f242f3f1ec44c88340025ca80356ebf468a1f610be5bc96b2870812
-  data.tar.gz: 33b8e7e9d3d0f4368a53f11610449b0e5394177cf286495a52d843885e077425d3ff486621ae9a107c8ad2e05e91ec3550b7bea80f79b4de5436c5049379bfc4
+  metadata.gz: 876e10d01a71da7f8c979f28702982c1bd4181dace88cf31b3ff30a198005a8d2270ca44f04baa8857ba99d598a54f652dd20e9e188b9174c2b5e11ea65709d3
+  data.tar.gz: b38719bc732eec253a91827c861b38f65655b327d556e1b093a257707b55268fdf652c5195f4e4a19ebcc70a280963978611ead196d21b42b85e8d1ce9fe10cd

data/.github/workflows/ci.yml

@@ -0,0 +1,25 @@
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.1']
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Run lint & tests
+        run: bundle exec rake

data/.ruby-version

@@ -1 +1 @@
-2.1
+2.7.2

data/README.md

@@ -1,6 +1,6 @@
 # ProcessHandler
 
-[![Build Status](https://travis-ci.org/salemove/process_handler.svg?branch=master)](https://travis-ci.org/salemove/process_handler)
+[![Build Status](https://github.com/salemove/process_handler/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/salemove/process_handler/actions/workflows/ci.yml?query=branch%3Amaster)
 [![Code Climate](https://codeclimate.com/github/salemove/process_handler/badges/gpa.svg)](https://codeclimate.com/github/salemove/process_handler)
 
 ProcessHandler helps to spawn and manage services. There are multiple types of processes. Every process knows how to handle `SIGINT` and `SIGTERM` signals.

data/lib/salemove/process_handler/cron_process.rb

@@ -42,16 +42,16 @@ module Salemove
       def spawn(service, blocking: true)
         @process_monitor.start
         @schedules.each do |schedule|
-          spawn_schedule(service, schedule)
+          spawn_schedule(service, **schedule)
         end
         @scheduler.join if blocking
       end
 
       def spawn_schedule(service, expression:, params:, overlap:)
         if params.empty?
-          @scheduler.repeat expression, {overlap: overlap} { service.call }
+          @scheduler.repeat(expression, {overlap: overlap}) { service.call }
         else
-          @scheduler.repeat expression, {overlap: overlap} { service.call(params) }
+          @scheduler.repeat(expression, {overlap: overlap}) { service.call(params) }
         end
       end
 

data/lib/salemove/process_handler/notifier_factory.rb

@@ -1,30 +1,17 @@
-require 'airbrake'
-require 'growl'
-require 'terminal-notifier'
-
 module Salemove
   module ProcessHandler
     class NotifierFactory
-
       def self.get_notifier(process_name, conf)
-        if conf && conf[:type] == 'airbrake'
-          notifier_name = conf[:notifier_name] || :default
-          Airbrake.configure(notifier_name) do |airbrake|
-            airbrake.environment = conf.fetch(:environment)
-            airbrake.host = conf.fetch(:host)
-            airbrake.project_id = conf.fetch(:project_id)
-            airbrake.project_key = conf.fetch(:project_key)
-            airbrake.ignore_environments = conf[:ignore_environments] if conf[:ignore_environments]
-            airbrake.whitelist_keys = [
-              /_HOST$/, /_TCP$/, /_UDP$/, /_PROTO$/, /_ADDR$/, 'PWD',
-              'GEM_HOME', 'PATH', 'SERVICE_NAME', 'RUBY_MAJOR', 'RUBY_VERSION',
-              'RACK_ENV', 'RUN_ENV', 'HOME', 'RUBYGEMS_VERSION', 'BUNDLER_VERSION'
-            ]
-          end
+        return nil unless conf
+
+        case conf[:type]
+        when 'airbrake'
           AirbrakeNotifier.new
-        elsif conf && conf[:type] == 'growl'
+        when 'sentry'
+          SentryNotifier.new
+        when 'growl'
           GrowlNotifier.new(process_name)
-        elsif conf && conf[:type] == 'terminal-notifier'
+        when 'terminal-notifier'
           TerminalNotifierWrapper.new(process_name)
         end
       end
@@ -36,6 +23,12 @@ module Salemove
       end
     end
 
+    class SentryNotifier
+      def notify_or_ignore(error, params)
+        Raven.capture_exception(error, extra: params)
+      end
+    end
+
     class GrowlNotifier
       def initialize(process_name)
         @process_name = process_name

data/lib/salemove/process_handler/pivot_process.rb

@@ -1,5 +1,6 @@
 require 'benchmark'
 require 'securerandom'
+require 'timeout'
 require_relative 'process_monitor'
 require_relative 'notifier_factory'
 
@@ -176,7 +177,7 @@ module Salemove
         end
 
         def delegate_to_service(input)
-          result = @benchmarker.call(input) { @service.call(input) }
+          result = @benchmarker.call(input) { @service.call(**input) }
 
           unless result.respond_to?(:fulfilled?)
             log_processed_request(input, result)

data/lib/salemove/process_handler/version.rb

@@ -1,5 +1,5 @@
 module Salemove
   module ProcessHandler
-    VERSION = '3.0.0'
+    VERSION = '4.1.0'
   end
 end

data/process_handler.gemspec

@@ -17,10 +17,4 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-
-  spec.add_dependency 'airbrake', '~> 7.4'
-  spec.add_dependency 'timers', '~> 4.1.2'
-  spec.add_dependency 'sucker_punch', '~> 1.1' # for async airbrake notifications
-  spec.add_dependency 'growl'
-  spec.add_dependency 'terminal-notifier'
 end

data/spec/fixtures/composite_service.rb

@@ -1,3 +1,4 @@
+require 'logger'
 require 'salemove/process_handler'
 require 'salemove/process_handler/composite_process'
 require 'salemove/process_handler/cron_process'

data/spec/process_handler/cron_process_spec.rb

@@ -42,7 +42,7 @@ describe ProcessHandler::CronProcess do
   end
 
   describe 'scheduler' do
-    let(:process) { ProcessHandler::CronProcess.new(scheduler_options: {frequency: 0.1}) }
+    let(:process) { ProcessHandler::CronProcess.new(**{scheduler_options: {frequency: 0.1}}) }
     let(:messages) { [] }
     let(:queue) { Queue.new }
 
@@ -60,7 +60,7 @@ describe ProcessHandler::CronProcess do
   end
 
   describe 'exception handler' do
-    let(:process) { ProcessHandler::CronProcess.new(params) }
+    let(:process) { ProcessHandler::CronProcess.new(**params) }
     let(:params) {{ notifier_factory: notifier_factory,
       scheduler_options: {frequency: 0.2} }}
     let(:notifier_factory) { double('NotifierFactory') }

metadata

@@ -1,85 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: process_handler
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - SaleMove TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-16 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: airbrake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '7.4'
-- !ruby/object:Gem::Dependency
-  name: timers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.1.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.1.2
-- !ruby/object:Gem::Dependency
-  name: sucker_punch
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-- !ruby/object:Gem::Dependency
-  name: growl
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: terminal-notifier
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2023-01-18 00:00:00.000000000 Z
+dependencies: []
 description: This gem helps to monitor and manage processes
 email:
 - techmovers@salemove.com
@@ -87,10 +17,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -107,7 +37,6 @@ files:
 - process_handler.gemspec
 - spec/fixtures/composite_service.rb
 - spec/fixtures/cron_service.rb
-- spec/process_handler/airbrake_spec.rb
 - spec/process_handler/composite_process_spec.rb
 - spec/process_handler/cron_process_spec.rb
 - spec/process_handler/pivot_process_spec.rb
@@ -131,15 +60,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: ''
 test_files:
 - spec/fixtures/composite_service.rb
 - spec/fixtures/cron_service.rb
-- spec/process_handler/airbrake_spec.rb
 - spec/process_handler/composite_process_spec.rb
 - spec/process_handler/cron_process_spec.rb
 - spec/process_handler/pivot_process_spec.rb

data/.travis.yml

@@ -1,6 +0,0 @@
-language: ruby
-rvm:
-  - 2.1.0
-before_script:
-  - bundle
-script: bundle exec rspec

data/spec/process_handler/airbrake_spec.rb

@@ -1,61 +0,0 @@
-require 'spec_helper'
-require 'salemove/process_handler/notifier_factory'
-require 'securerandom'
-
-describe 'Airbrake configuration' do
-  let(:environment) { 'SOME_ENVIRONMENT' }
-  let(:config) { airbrake_config.merge(type: 'airbrake') }
-  let(:airbrake_config) { base_params }
-  let(:base_params) do
-    {
-      environment: environment,
-      host: 'localhost',
-      project_id: '123456',
-      project_key: 'abc123',
-      ignore_environments: ['dev'],
-      # Airbrake module raises an error when same notifier configured multiple times
-      # Provide a random notifier name for each test case
-      notifier_name: SecureRandom.hex
-    }
-  end
-  let(:airbrake) do
-    ProcessHandler::NotifierFactory.get_notifier('Process name', config)
-  end
-
-  context 'when all params set' do
-    it 'does not raise an error' do
-      expect { airbrake }.not_to raise_error
-    end
-  end
-
-  context 'when project_id is not a number' do
-    let(:airbrake_config) { base_params.merge(project_id: 'abc') }
-
-    it 'raises error' do
-      expect { airbrake }.to raise_error
-    end
-  end
-
-  context 'when ignore_environments missing' do
-    before { base_params.delete(:ignore_environments) }
-
-    it 'does not raise an error' do
-      expect { airbrake }.not_to raise_error
-    end
-  end
-
-  shared_examples_for 'raises error if config param missing' do |key|
-    context "when #{key} missing" do
-      before { base_params.delete(key) }
-
-      it 'raises error' do
-        expect { airbrake }.to raise_error
-      end
-    end
-  end
-
-  it_behaves_like 'raises error if config param missing', :environment
-  it_behaves_like 'raises error if config param missing', :host
-  it_behaves_like 'raises error if config param missing', :project_id
-  it_behaves_like 'raises error if config param missing', :project_key
-end