process_bot 0.1.24 → 0.1.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '00099fd449ad79c57c052e10342f74b462ac806decd93e5989e0ad12620f42c3'
-  data.tar.gz: 40f29096a018160dca9e7ed7e5e0f5513876271259fe5dc44a4cdee0b8f38013
+  metadata.gz: 016c72db98675857edb0e34b274af5cc835d0cd5496d4bb6fccb7ebdaf05c555
+  data.tar.gz: 51a18efde6ff957df0dfe6f8e07e9df2f341a1519b3f17356de1ef7422f21e85
 SHA512:
-  metadata.gz: ec891a1ce47000bd291c9980baccfc42f8e35d0a39c53292759d2c4f810c223668a06c4d525690bdb230aef881cd36d34695c9ae73e33ed7c504dc16289715e4
-  data.tar.gz: b51ee6883d7f5bcb338512153f0d40073b003011de87dd91c40a5e2201b4ee58999679379f696517804112791e54450ad80a73df8341c52a46f23737ed9f0438
+  metadata.gz: f2387a26b91b32675f6679af84f4e4096bde512f62f344a962a0312abea804395e6013b88f268c20094a04724f27c71680c421f63893c785f47586b472f68ff8
+  data.tar.gz: '0491239c4e11851cfef5704cbbc9e79611c356595192f5187199fd3a7c898f7e61e5885a302ed84cdedb53692a4bf7e89369791fe69a169663273d95b5f4ebd8'

data/CHANGELOG.md

@@ -9,6 +9,8 @@
 - Guard stop-related process scanning when subprocess PID/PGID is unavailable and fail stop loudly.
 - Wait briefly for subprocess PID assignment during stop; raise if PID is still missing so stop cannot silently succeed.
 
+- Require an active runner for custom stop commands to avoid constructing a fresh runner with no PID.
+
 ## [0.1.0] - 2022-04-03
 
 - Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    process_bot (0.1.24)
+    process_bot (0.1.27)
       knjrbfw (>= 0.0.116)
       pry
       rake

data/README.md

@@ -113,7 +113,9 @@ bundle exec process_bot --command start --log-file-path /var/log/process_bot.log
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+
+To bump the patch version, run bundle, commit the version bump, build, and push the gem, run `bundle exec rake release:patch`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/Rakefile

@@ -2,11 +2,11 @@
 
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
 require "rubocop/rake_task"
 
+RSpec::Core::RakeTask.new(:spec)
 RuboCop::RakeTask.new
 
+Dir[File.expand_path("../lib/tasks/**/*.rake", __FILE__)].each { |f| load f }
+
 task default: %i[spec rubocop]

data/lib/process_bot/process/handlers/custom.rb

@@ -48,7 +48,14 @@ class ProcessBot::Process::Handlers::Custom
   end
 
   def stop(**_args)
+    runner = process.active_runner
+
+    unless runner
+      logger.logs "No active runner to stop"
+      return
+    end
+
     logger.logs "Stop related processes"
-    process.runner.stop_related_processes
+    runner.stop_related_processes
   end
 end

data/lib/process_bot/process.rb

@@ -3,7 +3,7 @@ require "json"
 require "monitor"
 require "string-cases"
 
-class ProcessBot::Process
+class ProcessBot::Process # rubocop:disable Metrics/ClassLength
   extend Forwardable
 
   def_delegator :handler_instance, :graceful
@@ -131,8 +131,15 @@ class ProcessBot::Process
   def send_control_command(command, **command_options)
     logger.logs "Sending #{command} command"
     response = client.send_command(command: command, options: options.options.merge(command_options))
-    raise "No response from ProcessBot while sending #{command}" if response == :nil
+
+    if response == :nil
+      handle_missing_control_command_response(command)
+      return if options[:ignore_no_process_bot]
+
+      raise "No response from ProcessBot while sending #{command}"
+    end
   rescue Errno::ECONNREFUSED => e
+    handle_missing_control_command_response(command)
     raise e unless options[:ignore_no_process_bot]
   end
 
@@ -140,6 +147,17 @@ class ProcessBot::Process
     current_runner_instance&.runner || @runner ||= build_runner
   end
 
+  def active_runner
+    current_runner_instance&.runner
+  end
+
+  def active_runner!
+    runner_instance = active_runner
+    return runner_instance if runner_instance
+
+    raise "Unable to stop custom process because no active runner is available. Ensure the custom command runs in foreground."
+  end
+
   def update_process_title
     process_args = {application: options[:application], handler: handler_name, id: options[:id], pid: current_pid, port: port}
     @current_process_title = "ProcessBot #{JSON.generate(process_args)}"
@@ -263,6 +281,65 @@ class ProcessBot::Process
     start_runner_instance
   end
 
+  def handle_missing_control_command_response(command)
+    return unless command == "stop"
+
+    matching_processes = matching_process_bot_processes
+    log_missing_control_response_diagnostics(matching_processes)
+    force_stop_process_bot_if_configured(matching_processes)
+  end
+
+  def log_missing_control_response_diagnostics(matching_processes)
+    logger.logs "Control command response missing; attempting diagnostics for application=#{options[:application].inspect} id=#{options[:id].inspect}"
+    logger.logs "Matching process_bot lines:\n#{matching_process_bot_processes_text(matching_processes)}"
+  end
+
+  def matching_process_bot_processes_text(lines)
+    return "(none)" if lines.empty?
+
+    lines.join("\n")
+  end
+
+  def matching_process_bot_processes
+    ps_output = Knj::Os.shellcmd("ps -eo pid,args")
+
+    ps_output
+      .to_s
+      .split("\n")
+      .select { |line| process_bot_process_line_matches?(line) }
+  end
+
+  def process_bot_process_line_matches?(line)
+    line.include?("ProcessBot {") &&
+      line.include?("\"application\":\"#{options[:application]}\"") &&
+      line.include?("\"id\":\"#{options[:id]}\"")
+  end
+
+  def force_stop_process_bot_if_configured(matching_processes)
+    return unless truthy_option?(:force_stop_on_no_response)
+
+    matching_processes.each do |line|
+      pid = line.strip.split(/\s+/, 2).first
+      next unless pid&.match?(/\A\d+\z/)
+
+      logger.logs "Force-stopping unresponsive process_bot PID #{pid}"
+      Process.kill("TERM", Integer(pid, 10))
+    rescue Errno::ESRCH
+      logger.logs "Process bot PID #{pid} already gone during force stop"
+    end
+  end
+
+  def truthy_option?(key)
+    value = options[key]
+    return false if value.nil?
+    return value if value == true || value == false
+
+    normalized = value.to_s.strip.downcase
+    return false if normalized == "false" || normalized == "0" || normalized == ""
+
+    true
+  end
+
 private
 
   attr_reader :current_runner_instance, :runner_events, :runner_monitor

data/lib/process_bot/version.rb

@@ -1,3 +1,3 @@
 module ProcessBot
-  VERSION = "0.1.24".freeze
+  VERSION = "0.1.27".freeze
 end

data/lib/tasks/release.rake

@@ -0,0 +1,171 @@
+require "English"
+require "fileutils"
+require "pathname"
+require "rubygems/version"
+require "shellwords"
+
+class ProcessBotRubygemsRelease # rubocop:disable Lint/ConstantDefinitionInBlock
+  VERSION_FILE = Pathname.new(File.expand_path("../process_bot/version.rb", __dir__)) unless const_defined?(:VERSION_FILE)
+
+  def call
+    ensure_clean_worktree!
+    checkout_master!
+    fetch!
+    merge!
+
+    next_version = determine_next_version
+
+    bump_version!(next_version)
+    commit!(next_version)
+    push!
+    gem_file = build_gem!(next_version)
+    push_gem!(gem_file)
+    delete_gem_file!(gem_file)
+  rescue StandardError
+    warn "Release failed."
+    raise
+  end
+
+private
+
+  def ensure_clean_worktree!
+    dirty_entries = git_status_lines.grep_v(%r{\A\?\? process_bot-[^/]+\.gem\z})
+    return if dirty_entries.empty?
+
+    raise "Working tree must be clean before releasing:\n#{dirty_entries.join("\n")}"
+  end
+
+  def checkout_master!
+    run!("git", "checkout", "master")
+  end
+
+  def fetch!
+    run!("git", "fetch", remote_name)
+  end
+
+  def merge!
+    run!("git", "merge", "--ff-only", "#{remote_name}/master")
+  end
+
+  def determine_next_version
+    requested_version || bumped_version
+  end
+
+  def requested_version
+    version = ENV["VERSION"]&.strip
+    return if version.to_s.empty?
+
+    Gem::Version.new(version)
+    version
+  end
+
+  def bumped_version
+    case bump_type
+    when "major"
+      [version_segments[0] + 1, 0, 0].join(".")
+    when "minor"
+      [version_segments[0], version_segments[1] + 1, 0].join(".")
+    when "patch"
+      [version_segments[0], version_segments[1], version_segments[2] + 1].join(".")
+    else
+      raise "Unsupported BUMP=#{bump_type.inspect}. Use patch, minor, major, or VERSION=x.y.z."
+    end
+  end
+
+  def version_segments
+    @version_segments ||= begin
+      segments = Gem::Version.new(current_version).segments
+      segments << 0 while segments.length < 3
+      segments
+    end
+  end
+
+  def current_version
+    @current_version ||= VERSION_FILE.read[/VERSION = "([^"]+)"\.freeze/, 1] || raise("Could not find current version")
+  end
+
+  def bump_version!(next_version)
+    raise "Next version must differ from current version" if next_version == current_version
+
+    VERSION_FILE.write(
+      VERSION_FILE.read.sub(
+        /VERSION = "[^"]+"\.freeze/,
+        %(VERSION = "#{next_version}".freeze)
+      )
+    )
+
+    run!("git", "add", VERSION_FILE.to_s)
+  end
+
+  def commit!(next_version)
+    run!("git", "commit", "-m", "Release #{next_version}")
+  end
+
+  def push!
+    run!("git", "push", remote_name, "master")
+  end
+
+  def build_gem!(next_version)
+    gem_file = "process_bot-#{next_version}.gem"
+    run!("gem", "build", "process_bot.gemspec")
+    gem_file
+  end
+
+  def push_gem!(gem_file)
+    run!("gem", "push", gem_file)
+  end
+
+  def delete_gem_file!(gem_file)
+    FileUtils.rm_f(gem_file)
+  end
+
+  def git_status_lines
+    capture!("git", "status", "--porcelain").split("\n").reject(&:empty?)
+  end
+
+  def bump_type
+    ENV.fetch("BUMP", "patch")
+  end
+
+  def remote_name
+    ENV.fetch("REMOTE", "origin")
+  end
+
+  def capture!(*command)
+    output = `#{command.map { |part| Shellwords.escape(part) }.join(" ")}`
+    raise "Command failed: #{command.join(' ')}" unless $CHILD_STATUS&.success?
+
+    output
+  end
+
+  def run!(*command)
+    return if system(*command)
+
+    raise "Command failed: #{command.join(' ')}"
+  end
+end
+
+namespace :release do
+  desc "Release a patch version from master by fetching, fast-forward merging, bumping version, pushing, and publishing"
+  task :patch do
+    ENV["BUMP"] = "patch"
+    ProcessBotRubygemsRelease.new.call
+  end
+
+  desc "Release a minor version from master by fetching, fast-forward merging, bumping version, pushing, and publishing"
+  task :minor do
+    ENV["BUMP"] = "minor"
+    ProcessBotRubygemsRelease.new.call
+  end
+
+  desc "Release a major version from master by fetching, fast-forward merging, bumping version, pushing, and publishing"
+  task :major do
+    ENV["BUMP"] = "major"
+    ProcessBotRubygemsRelease.new.call
+  end
+
+  desc "Release the gem from master by fetching, fast-forward merging, bumping version, pushing, and publishing"
+  task :rubygems do
+    ProcessBotRubygemsRelease.new.call
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: process_bot
 version: !ruby/object:Gem::Version
-  version: 0.1.24
+  version: 0.1.27
 platform: ruby
 authors:
 - kaspernj
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-02-12 00:00:00.000000000 Z
+date: 2026-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: knjrbfw
@@ -175,6 +175,7 @@ files:
 - lib/process_bot/process/runner.rb
 - lib/process_bot/process/runner_instance.rb
 - lib/process_bot/version.rb
+- lib/tasks/release.rake
 - peak_flow.yml
 - process_bot.gemspec
 homepage: https://github.com/kaspernj/process_bot