process_bot 0.1.23 → 0.1.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3af0757fbd8fdac9c26eecdd368c222da9a659d491c64ee16d5d7fa0b1235c3
-  data.tar.gz: 7faf33b03baf64de58f27086351d553f0cbf777dc78b360fbcda2d9b82aecc04
+  metadata.gz: 6e46c5f20791400dfc63138936340fc46e514d52947d2d2ba78cb208c521f442
+  data.tar.gz: 0f3ec322eb916178092eb5e7b19cab1a92421a23767fea310bf4c69319e72ca9
 SHA512:
-  metadata.gz: 36f931dc6159ac509769c9e37ca8cf42972f6035ba58f1f311b105461acc7109a8a205690366b77fdb99cdd49c0ddfded4e2bcaec69c2357f32117776b5d0d35
-  data.tar.gz: 98e49815e07c19d8bc6e374577cd83236ded5f78a295fbfbf6c662317ede6403a33254b55edd564030d3c8617fa124f0fa77d72d7a18b71d3e05f60a5e932ab8
+  metadata.gz: bd08e3680f9c436c00fed3c5ed760542cbbb4fba517021493f6d17de799ed4e781c86d652baa230f0433794a36f61861de8f52c846ff64dfda651b73ba42c3bc
+  data.tar.gz: 1b91173a14173732de83e7e00f47e95a10a0272768f5810f9ca789f12cb181fd3282bd4c0feab33a3c3f6b0074bcfac6bbb55ca753bb2e8df9c70f4cd7121464

data/CHANGELOG.md

@@ -7,6 +7,9 @@
 - Bump version to 0.1.21.
 - Add optional Sidekiq restart overlap and a new ProcessBot restart command.
 - Guard stop-related process scanning when subprocess PID/PGID is unavailable and fail stop loudly.
+- Wait briefly for subprocess PID assignment during stop; raise if PID is still missing so stop cannot silently succeed.
+
+- Require an active runner for custom stop commands to avoid constructing a fresh runner with no PID.
 
 ## [0.1.0] - 2022-04-03
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    process_bot (0.1.23)
+    process_bot (0.1.26)
       knjrbfw (>= 0.0.116)
       pry
       rake

data/README.md

@@ -113,7 +113,9 @@ bundle exec process_bot --command start --log-file-path /var/log/process_bot.log
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+
+To bump the patch version, run bundle, commit the version bump, build, and push the gem, run `bundle exec rake release:patch`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/Rakefile

@@ -2,11 +2,45 @@
 
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
 
-require "rubocop/rake_task"
+def bump_patch_version(version_path)
+  version_content = File.read(version_path)
+  version_match = version_content.match(/VERSION = "(\d+)\.(\d+)\.(\d+)"\.freeze/)
+  raise "Could not find current version in #{version_path}" unless version_match
 
-RuboCop::RakeTask.new
+  major = version_match[1].to_i
+  minor = version_match[2].to_i
+  patch = version_match[3].to_i + 1
+
+  new_version = "#{major}.#{minor}.#{patch}"
+  new_content = version_content.sub(version_match[0], "VERSION = \"#{new_version}\".freeze")
+  File.write(version_path, new_content)
+
+  new_version
+end
+
+namespace :release do
+  desc "Bump patch version, run bundle, commit version bump, build gem, and push gem"
+  task :patch do
+    version_path = "lib/process_bot/version.rb"
+    new_version = bump_patch_version(version_path)
+
+    puts "Bumped version to #{new_version}"
+
+    sh "bundle install"
+    sh "git add #{version_path}"
+    sh "git commit -m \"Bump version to #{new_version}\""
+    sh "bundle exec rake build"
+
+    gem_path = "pkg/process_bot-#{new_version}.gem"
+    raise "Expected gem file was not built: #{gem_path}" unless File.exist?(gem_path)
+
+    sh "gem push #{gem_path}"
+  end
+end
 
 task default: %i[spec rubocop]

data/lib/process_bot/process/handlers/custom.rb

@@ -49,6 +49,6 @@ class ProcessBot::Process::Handlers::Custom
 
   def stop(**_args)
     logger.logs "Stop related processes"
-    process.runner.stop_related_processes
+    process.active_runner!.stop_related_processes
   end
 end

data/lib/process_bot/process/runner.rb

@@ -139,11 +139,23 @@ class ProcessBot::Process::Runner
   end
 
   def ensure_subprocess_pgid_for_stop!
-    return if subprocess_pgid
+    wait_for_subprocess_pid_for_stop! if subprocess_pid.nil?
+
+    return true if subprocess_pgid
 
     raise "Unable to stop related processes because subprocess PGID could not be resolved (subprocess PID: #{subprocess_pid.inspect})"
   end
 
+  def wait_for_subprocess_pid_for_stop!
+    deadline = Process.clock_gettime(Process::CLOCK_MONOTONIC) + 1
+
+    sleep 0.05 while subprocess_pid.nil? && Process.clock_gettime(Process::CLOCK_MONOTONIC) < deadline
+
+    return unless subprocess_pid.nil?
+
+    raise "Unable to stop related processes because subprocess PID has not been recorded yet"
+  end
+
   def find_sidekiq_pid
     Thread.new do
       wait_for_sidekiq_pid

data/lib/process_bot/process.rb

@@ -140,6 +140,17 @@ class ProcessBot::Process
     current_runner_instance&.runner || @runner ||= build_runner
   end
 
+  def active_runner
+    current_runner_instance&.runner
+  end
+
+  def active_runner!
+    runner_instance = active_runner
+    return runner_instance if runner_instance
+
+    raise "Unable to stop custom process because no active runner is available. Ensure the custom command runs in foreground."
+  end
+
   def update_process_title
     process_args = {application: options[:application], handler: handler_name, id: options[:id], pid: current_pid, port: port}
     @current_process_title = "ProcessBot #{JSON.generate(process_args)}"

data/lib/process_bot/version.rb

@@ -1,3 +1,3 @@
 module ProcessBot
-  VERSION = "0.1.23".freeze
+  VERSION = "0.1.26".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: process_bot
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.26
 platform: ruby
 authors:
 - kaspernj
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-02-11 00:00:00.000000000 Z
+date: 2026-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: knjrbfw