proc-wait3 1.9.1 → 1.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2054430d4049b9aa27f1902f704220818bf4e6b8d7d19e428e10e3ed736d6c9
-  data.tar.gz: 9be23be7ddad009649f5ec83692102b05334a9013d99a68f1643c1c2eda37b62
+  metadata.gz: 13f18822c2208220d663b7ddf89cd3ef3763185621f23ed81bf6dced9beb8b76
+  data.tar.gz: 6a82d5550af63215cf4e62b3e390865f5f08e3b3ec30be50128791bf8b9a45a1
 SHA512:
-  metadata.gz: a6f95da3b81622fd0a4ca7be57f787ec63201be854f28bcb023aec9af3360ef8ec6af228ca3c180dfa7163831456aa57fd68ced837cb40d46f3b262e2a2b4554
-  data.tar.gz: fff3abd919e4c0f07ab666ea3f3a1db8d514fa63802fd408b57c87f0c8208d6cf4e886813605156625bc00e8b931405098e5a714d34a91a00830287974603507
+  metadata.gz: b015e49e3c835d2855552e3d54f2fdf047d11889f5db55ac2db246d277c9fe3ad1135e73e6cb01a0caa5d88bd93c3de361670d74dc78b3a5139c10ea86db46c7
+  data.tar.gz: f0134f481fa6f8d3cdbdcef1e6f380727afb894e1ed754bd77b568f3a0d43118a3c71aa93f68ea7d96b15768f569fa63199782f91c5c2d729c9efc47cdb0d0ab

checksums.yaml.gz.sig

@@ -1,5 +1,5 @@
-����M�]
-{�)��N���Xy��*\��'D.˲�g��� >BpX`�/�u���G�F'
-�R�Ѐ�gG��*%.�.{Z�:�eH\vC�R��	ZE��!��|�x��#�X����7�}e����VzT_�H���N.Z�#ڴ��%IZ �[�<C��,Ca����Ì1��`�CU�ݻ0�ٶ"iO�6���!��
T�*��R��6g!����r��!�S���^-aZhRCv��Y�OW�k��&
-?��8�lz�����
���82�&5Q�_�j���l��A����!e	�	W�&%�F<1��)D��&��k0�Y�f���25�<�(��m����=�6�]���E
-�TT���b&�)
+e��)#
+�P�H�s�/w��"�
+���񬫖|.6;_i�<;����;�"Zl{����u_dE�oM������ǑW�X��_&�i*\ak�l����GoMx|y�"@���|��4G�����jF�ح3���=��R�YK
+�Vo6�.�k0Z�����E�4Z�JJ�G�ڝ"�c�8���s�[<~Vw�a-�NF��+	{�쌌��s{�
+#����Qw��4w�j

data/CHANGES.md

@@ -1,3 +1,12 @@
+## 1.9.3 - 4-May-2024
+* Some internal refactoring where I bzero C structs before using them.
+
+## 1.9.2 - 21-Apr-2024
+* Added the P_JAILID constant for BSD platforms.
+* Added some notes to the README for coping with EINTR.
+* Added rubocop and rubocop-rspec as dev dependencies and did
+  some general rubocop cleanup.
+
 ## 1.9.1 - 8-Feb-2024
 * Replace sigset with sigaction in the pause method.
 * General cleanup and platform handling updates.

data/README.md

@@ -38,6 +38,38 @@ These methods may fail in conjunction with `fork` with `Errno::EINTR` unless
 you pass the WNOHANG flag, or explicitly ignore the `SIGCHLD` signal. Ruby's
 own `wait` methods appear to essentially be doing that behind the scenes.
 
+Note that on some platforms just setting a `SIGCHLD` handler may not be
+enough to prevent an `Errno::EINTR` from occuring since you can never be sure
+what signal it's going to receive. Since this appears to be coming from the
+guts of the Ruby core code itself IMO, it's somewhat out of my hands, but it's
+not impossible to deal with.
+
+A typical idiom would be to simulate the `TEMP_FAILURE_RETRY` macro that the GNU
+library provides. This macro wraps a given function and retries it so long as
+it doesn't fail, or the only failure is an `EINTR`. I've chosen not to integrate
+this into the code directly (yet), but you can simulate it like so:
+
+```ruby
+require 'English'
+
+begin
+  pid = fork{ sleep 1; exit 2 }
+  Process.wait3
+rescue Errno::EINTR
+  retry
+end
+
+p $CHILD_STATUS
+```
+
+For more information please see:
+
+https://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Interrupted-Primitives.html
+
+BSD provides another approach using sigaction handlers + `SA_RESTART`, but it requires knowing
+the signal type in advance. So, unless you want to apply the same handler to *every* type of
+signal, I don't find it especially useful.
+
 ## Integration with Ruby's process.c
 I considered simply providing a patch to the core process.c file, but I
 decided against it for two reasons.  First, I wanted to get something

data/Rakefile

@@ -1,6 +1,7 @@
 require 'rake'
 require 'rake/clean'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 require 'fileutils'
 require 'rbconfig'
 include RbConfig
@@ -27,7 +28,7 @@ task :build => [:clean] do |t|
 end
 
 namespace :gem do
-  desc "Create the proc-wait3 gem"
+  desc 'Create the proc-wait3 gem'
   task :create => [:clean] do
     require 'rubygems/package'
     spec = Gem::Specification.load('proc-wait3.gemspec')
@@ -35,7 +36,7 @@ namespace :gem do
     Gem::Package.build(spec)
   end
 
-  desc "Install the proc-wait3 gem"
+  desc 'Install the proc-wait3 gem'
   task :install => [:create] do |t|
     file = Dir['*.gem'].first
     sh "gem install -l #{file}"
@@ -69,9 +70,11 @@ namespace :example do
   end
 end
 
-desc "Run the test suite"
+desc 'Run the test suite'
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.rspec_opts = '-Iext'
 end
 
 task :default => [:build, :spec]
+
+RuboCop::RakeTask.new

data/examples/example_getrusage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ########################################################################
 # example_getrusage.rb
 #
@@ -11,7 +13,7 @@ require 'pp'
 
 # Show resource stats for this process for 30 seconds
 10.times do
-   pp Process.getrusage
-   puts "=" * 50
-   sleep 3 
+  pp Process.getrusage
+  puts '=' * 50
+  sleep 3
 end

data/examples/example_pause.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #######################################################################
 # example_pause.rb
 #
@@ -9,13 +11,13 @@
 require 'rbconfig'
 require 'proc/wait3'
 
-puts "Pausing.  Hit Ctrl-C to continue."
+puts 'Pausing.  Hit Ctrl-C to continue.'
 
 if RbConfig::CONFIG['host_os'] =~ /linux|darwin/i
-   Process.pause(2)
+  Process.pause(2)
 else
-   Process.pause("INT")
+  Process.pause('INT')
 end
 
-puts "Hey, thanks for hitting Ctrl-C.  Continuing..."
-puts "Done"
+puts 'Hey, thanks for hitting Ctrl-C.  Continuing...'
+puts 'Done'

data/examples/example_wait3.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #######################################################################
 # example_wait3.rb
 #
@@ -6,10 +8,11 @@
 #
 # Modify as you see fit.
 #######################################################################
+require 'English'
 require 'proc/wait3'
 
-pid = fork{ sleep 1; exit 2 }
+pid = fork { sleep 1; exit 2 }
 
 p Time.now
 Process.wait3
-p $?
+p $CHILD_STATUS

data/examples/example_wait4.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #######################################################################
 # example_wait4.rb
 #
@@ -6,9 +8,10 @@
 #
 # Modify as you see fit.
 #######################################################################
+require 'English'
 require 'proc/wait3'
 
-pid = fork{ sleep 2 }
+pid = fork { sleep 2 }
 p Time.now
 Process.wait4(pid, Process::WUNTRACED)
-p $?
+p $CHILD_STATUS

data/examples/example_waitid.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #######################################################################
 # example_waitid.rb
 #
@@ -6,9 +8,10 @@
 #
 # Modify as you see fit.
 #######################################################################
+require 'English'
 require 'proc/wait3'
 
-pid = fork{ sleep 2 }
+pid = fork { sleep 2 }
 p Time.now
 Process.waitid(Process::P_PID, pid, Process::WEXITED)
-p $?
+p $CHILD_STATUS

data/ext/extconf.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ########################################################
 # Use the mkmf.rb file that I provide, so I can use the
 # have_enum_member method
@@ -12,7 +14,7 @@ have_header('sys/wait.h')
 
 # wait3 is mandatory.
 unless have_func('wait3')
-  STDERR.puts 'wait3() function not found'
+  warn 'wait3() function not found'
   exit
 end
 
@@ -68,4 +70,7 @@ have_const('P_TASKID', 'signal.h')
 # RUSAGE_THREAD is Linux-specific
 have_const('RUSAGE_THREAD', 'sys/resource.h')
 
+# BSD
+have_const('P_JAILID', 'sys/wait.h')
+
 create_makefile('proc/wait3', 'proc')

data/ext/proc/wait3.c

@@ -154,6 +154,7 @@ static VALUE proc_wait3(int argc, VALUE *argv, VALUE mod){
       flags = NUM2INT(v_flags);
    }
 
+   bzero(&r, sizeof(r));
    pid = wait3(&status, flags, &r);
 
    if(pid < 0){
@@ -226,6 +227,7 @@ static VALUE proc_wait4(int argc, VALUE *argv, VALUE mod){
    if(RTEST(v_flags))
       flags = NUM2INT(v_flags);
 
+   bzero(&r, sizeof(r));
    pid = wait4(pid, &status, flags, &r);
 
    if(pid < 0){
@@ -587,6 +589,9 @@ static VALUE proc_pause(int argc, VALUE* argv, VALUE mod){
       int signum;
       struct sigaction act, sa;
 
+      bzero(&act, sizeof(act));
+      bzero(&sa, sizeof(sa));
+
       for(i = 0; i < len; i++){
          v_val = rb_ary_shift(v_signals);
 
@@ -752,6 +757,8 @@ static VALUE proc_getrusage(int argc, VALUE* argv, VALUE mod){
   else if(RTEST(v_children))
     who = RUSAGE_CHILDREN;
 
+  bzero(&r, sizeof(r));
+
   if(getrusage(who,&r) == -1)
     rb_sys_fail("getrusage");
 
@@ -957,12 +964,17 @@ void Init_wait3(void)
   rb_define_const(rb_mProcess, "P_PROJID", INT2FIX(P_PROJID));
 #endif
 
+#ifdef HAVE_CONST_P_JAILID
+  /* Process jail ID */
+  rb_define_const(rb_mProcess, "P_JAILID", INT2FIX(P_JAILID));
+#endif
+
 #ifdef HAVE_CONST_RUSAGE_THREAD
   rb_define_const(rb_mProcess, "RUSAGE_THREAD", INT2FIX(RUSAGE_THREAD));
 #endif
 
-  /* 1.9.0: The version of the proc-wait3 library */
-  rb_define_const(rb_mProcess, "WAIT3_VERSION", rb_str_freeze(rb_str_new2("1.9.1")));
+  /* 1.9.3: The version of the proc-wait3 library */
+  rb_define_const(rb_mProcess, "WAIT3_VERSION", rb_str_freeze(rb_str_new2("1.9.3")));
 
   /* Define this last in our Init_wait3 function */
   rb_define_readonly_variable("$last_status", &v_last_status);

data/lib/proc-wait3.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'proc/wait3'

data/proc-wait3.gemspec

@@ -2,7 +2,7 @@ require 'rubygems'
 
 Gem::Specification.new do |spec|
   spec.name       = 'proc-wait3'
-  spec.version    = '1.9.1'
+  spec.version    = '1.9.3'
   spec.author     = 'Daniel J. Berger'
   spec.license    = 'Apache-2.0'
   spec.email      = 'djberg96@gmail.com'
@@ -10,11 +10,13 @@ Gem::Specification.new do |spec|
   spec.summary    = 'Adds wait3, wait4 and other methods to the Process module'
   spec.test_file  = 'spec/proc_wait3_spec.rb'
   spec.extensions = ['ext/extconf.rb']
-  spec.files      = Dir['**/*'].reject{ |f| f.include?('git') }
+  spec.files      = Dir['**/*'].reject { |f| f.include?('git') }
   spec.cert_chain = Dir['certs/*']
 
   spec.add_development_dependency('rake')
   spec.add_development_dependency('rspec', '~> 3.9')
+  spec.add_development_dependency('rubocop')
+  spec.add_development_dependency('rubocop-rspec')
 
   spec.metadata = {
     'homepage_uri'          => 'https://github.com/djberg96/proc-wait3',
@@ -23,7 +25,8 @@ Gem::Specification.new do |spec|
     'documentation_uri'     => 'https://github.com/djberg96/proc-wait3/wiki',
     'source_code_uri'       => 'https://github.com/djberg96/proc-wait3',
     'wiki_uri'              => 'https://github.com/djberg96/proc-wait3/wiki',
-    'rubygems_mfa_required' => 'true'
+    'rubygems_mfa_required' => 'true',
+    'github_repo'           => 'https://github.com/djberg96/proc-wait3'
   }
 
   spec.description = <<-EOF

data/spec/proc_wait3_spec.rb

@@ -1,23 +1,21 @@
-#######################################################################
+# frozen_string_literal: true
+
+##############################################################################
 # proc_wait3_spec.rb
 #
-# Test suite for the Ruby proc-wait3 library. You should run these
-# via the 'rake spec' task.
-#######################################################################
-require 'proc/wait3'
-require 'rspec'
+# Test suite for the Ruby proc-wait3 library. You should run these via the
+# 'rake spec' task.
+#
+# Note that several specs are deliberately wrapped in EINTR rescue handlers
+# because I think the Ruby interpreter is sending a signal to the process
+# from somewhere in the guts of its core code. Originally I thought this was
+# a SIGCHLD but it doesn't always appear to be.
+##############################################################################
+require 'English'
+require 'spec_helper'
 require 'rbconfig'
 
 RSpec.describe Process do
-  # Something in the guts of Ruby was being a pain.
-  Signal.trap('CHLD', 'IGNORE') if RUBY_VERSION.to_f < 3
-
-  let(:solaris) { RbConfig::CONFIG['host_os'] =~ /sunos|solaris/i }
-  let(:darwin)  { RbConfig::CONFIG['host_os'] =~ /darwin|osx/i }
-  let(:hpux)    { RbConfig::CONFIG['host_os'] =~ /hpux/i }
-  let(:linux)   { RbConfig::CONFIG['host_os'] =~ /linux/i }
-  let(:bsd)     { RbConfig::CONFIG['host_os'] =~ /bsd|dragonfly/i }
-
   let(:proc_stat_members) {
     %i[
       pid status utime stime maxrss ixrss idrss isrss minflt majflt nswap
@@ -31,192 +29,175 @@ RSpec.describe Process do
     @pid = nil
   end
 
-  example "version constant is set to expected value" do
-    expect(Process::WAIT3_VERSION).to eq('1.9.1')
-    expect(Process::WAIT3_VERSION).to be_frozen
+  def call_wait3
+    described_class.wait3
+  rescue Errno::EINTR
+    retry
   end
 
-  example "wait3 method is defined" do
-    expect(Process).to respond_to(:wait3)
+  def call_wait4(*args)
+    described_class.wait4(*args)
+  rescue Errno::EINTR
+    retry
   end
 
-  example "wait3 works as expected" do
-    skip 'wait3 test skipped on this platform' if darwin
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.wait3 }.not_to raise_error
+  def call_waitid(*args)
+    described_class.waitid(*args)
+  rescue Errno::EINTR
+    retry
   end
 
-  example "wait3 returns the expected proc status members" do
-    skip 'wait3 test skipped on this platform' if darwin
-    @pid = fork{ sleep 0.5 }
-    expect{ @proc_stat = Process.wait3 }.not_to raise_error
-    expect( @proc_stat.members).to eq(proc_stat_members)
+  example 'version constant is set to expected value' do
+    expect(Process::WAIT3_VERSION).to eq('1.9.3')
+    expect(Process::WAIT3_VERSION).to be_frozen
   end
 
-  example "wait3 with WNOHANG works as expected" do
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.wait3(Process::WNOHANG) }.not_to raise_error
+  example 'wait3 method is defined' do
+    expect(described_class).to respond_to(:wait3)
   end
 
-  example "wait3 sets and returns $last_status to expected values" do
-    skip 'wait3 test skipped on this platform' if darwin
-    @pid = fork{ sleep 0.5 }
-    Process.wait3
-    expect($last_status).to be_kind_of(Struct::ProcStat)
-    expect($last_status).not_to be_nil
+  example 'wait3 works as expected' do
+    @pid = fork { sleep 0.5 }
+    expect { call_wait3 }.not_to raise_error
   end
 
-  example "wait3 sets pid and status members of $?" do
-    skip 'wait3 test skipped on this platform' if darwin
-    @pid = fork{ sleep 0.5 }
-    Process.wait3
-    expect($?).not_to be_nil
+  example 'wait3 returns the expected proc status members' do
+    @pid = fork { sleep 0.5 }
+    expect { @proc_stat = call_wait3 }.not_to raise_error
+    expect(@proc_stat.members).to eq(proc_stat_members)
   end
 
-  example "wait3 returns frozen struct" do
-    skip 'wait3 test skipped on this platform' if darwin
-    @pid = fork{ sleep 0.5 }
-    struct = Process.wait3
-    expect(struct).to be_frozen
+  example 'wait3 with WNOHANG works as expected' do
+    @pid = fork { sleep 0.5 }
+    expect { described_class.wait3(Process::WNOHANG) }.not_to raise_error
   end
 
-  example "getdtablesize works as expected" do
-    skip 'getdtablesize skipped on this platform' unless solaris
+  example 'wait3 sets and returns $last_status to expected values' do
+    @pid = fork { sleep 0.5 }
+    call_wait3
+    expect($last_status).to be_a(Struct::ProcStat)
+    expect($last_status).not_to be_nil
+  end
 
-    expect(Process).to respond_to(:getdtablesize)
-    expect(Process.getdtablesize).to be_kind_of(Fixnum)
-    assert(Process.getdtablesize > 0)
+  example 'wait3 sets pid and status members of $?' do
+    @pid = fork { sleep 0.5 }
+    call_wait3
+    expect($CHILD_STATUS).not_to be_nil
   end
 
-  example "wait4 method is defined" do
-    skip 'wait4 test skipped on this platform' if hpux
-    expect(Process).to respond_to(:wait4)
+  example 'wait3 returns frozen struct' do
+    @pid = fork { sleep 0.5 }
+    struct = call_wait3
+    expect(struct).to be_frozen
   end
 
-  example "wait4 requires at least one argument" do
-    skip 'wait4 test skipped on this platform' if hpux
-    expect{ Process.wait4 }.to raise_error(ArgumentError)
+  example 'getdtablesize works as expected', :solaris do
+    expect(described_class).to respond_to(:getdtablesize)
+    expect(described_class.getdtablesize).to be_a(Integer)
+    assert(described_class.getdtablesize > 0)
   end
 
-  example "wait4 works as expected" do
-    skip 'wait4 test skipped on this platform' if hpux || darwin
+  example 'wait4 method is defined', :skip_hpux do
+    expect(described_class).to respond_to(:wait4)
+  end
 
-    @pid = fork{ sleep 0.5 }
-    expect{ @proc_stat = Process.wait4(@pid) }.not_to raise_error
-    expect(@proc_stat).to be_kind_of(Struct::ProcStat)
+  example 'wait4 requires at least one argument', :skip_hpux do
+    expect { call_wait4 }.to raise_error(ArgumentError)
   end
 
-  example "wait4 sets and returns $last_status to expected values" do
-    skip 'wait4 test skipped on this platform' if hpux || darwin
+  example 'wait4 works as expected', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    expect { @proc_stat = call_wait4(@pid) }.not_to raise_error
+    expect(@proc_stat).to be_a(Struct::ProcStat)
+  end
 
-    @pid = fork{ sleep 0.5 }
-    Process.wait4(@pid)
-    expect($last_status).to be_kind_of(Struct::ProcStat)
+  example 'wait4 sets and returns $last_status to expected values', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    call_wait4(@pid)
+    expect($last_status).to be_a(Struct::ProcStat)
     expect($last_status).not_to be_nil
   end
 
-  example "wait4 sets pid and status members of $?" do
-    skip 'wait4 test skipped on this platform' if hpux || darwin
-
-    @pid = fork{ sleep 0.5 }
-    Process.wait4(@pid)
-    expect($?).not_to be_nil
+  example 'wait4 sets pid and status members of $?', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    call_wait4(@pid)
+    expect($CHILD_STATUS).not_to be_nil
   end
 
-  example "wait4 returns frozen struct" do
-    skip 'wait4 test skipped on this platform' if hpux || darwin
-
-    @pid = fork{ sleep 0.5 }
-    struct = Process.wait4(@pid)
+  example 'wait4 returns frozen struct', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    struct = call_wait4(@pid)
     expect(struct).to be_frozen
   end
 
-  example "waitid method is defined" do
-    skip 'waitid test skipped on this platform' if hpux || darwin || bsd
-
-    expect(Process).to respond_to(:waitid)
+  example 'waitid method is defined', :skip_hpux do
+    expect(described_class).to respond_to(:waitid)
   end
 
-  example "waitid method works as expected" do
-    skip 'waitid test skipped on this platform' if hpux || darwin || bsd
-
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.waitid(Process::P_PID, @pid, Process::WEXITED) }.not_to raise_error
+  example 'waitid method works as expected', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    expect { call_waitid(Process::P_PID, @pid, Process::WEXITED) }.not_to raise_error
   end
 
-  example "waitid method raises expected errors if wrong argument type is passed" do
-    skip 'waitid test skipped on this platform' if hpux || darwin || bsd
-
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.waitid("foo", @pid, Process::WEXITED) }.to raise_error(TypeError)
-    expect{ Process.waitid(Process::P_PID, @pid, "foo") }.to raise_error(TypeError)
-    expect{ Process.waitid(Process::P_PID, "foo", Process::WEXITED) }.to raise_error(TypeError)
+  example 'waitid method raises expected errors if wrong argument type is passed', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    expect { call_waitid('foo', @pid, Process::WEXITED) }.to raise_error(TypeError)
+    expect { call_waitid(Process::P_PID, @pid, 'foo') }.to raise_error(TypeError)
+    expect { call_waitid(Process::P_PID, 'foo', Process::WEXITED) }.to raise_error(TypeError)
   end
 
-  example "waitid method raises expected error if invalid argument is passed" do
-    skip 'waitid test skipped on this platform' if hpux || darwin || bsd
-
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.waitid(Process::P_PID, 99999999, Process::WEXITED) }.to raise_error(Errno::ECHILD)
+  example 'waitid method raises expected error if invalid argument is passed', :skip_hpux do
+    @pid = fork { sleep 0.5 }
+    expect { described_class.waitid(Process::P_PID, 99999999, Process::WEXITED) }.to raise_error(Errno::ECHILD)
   end
 
-  example "sigsend method is defined" do
-    skip 'sigsend test skipped on this platform' unless solaris
-
-    expect(Process).to respond_to(:sigsend)
+  example 'sigsend method is defined', :solaris do
+    expect(described_class).to respond_to(:sigsend)
   end
 
-  example "sigsend works as expected" do
-    skip 'sigsend test skipped on this platform' unless solaris
-
-    @pid = fork{ sleep 0.5 }
-    expect{ Process.sigsend(Process::P_PID, @pid, 0) }.not_to raise_error
+  example 'sigsend works as expected', :solaris do
+    @pid = fork { sleep 0.5 }
+    expect { described_class.sigsend(Process::P_PID, @pid, 0) }.not_to raise_error
   end
 
-  example "getrusage method is defined" do
-    expect(Process).to respond_to(:getrusage)
+  example 'getrusage method is defined' do
+    expect(described_class).to respond_to(:getrusage)
   end
 
-  example "getrusage works as expected" do
-    @pid = fork{ sleep 0.5 }
+  example 'getrusage works as expected' do
+    @pid = fork { sleep 0.5 }
 
-    expect{ Process.getrusage }.not_to raise_error
-    expect{ Process.getrusage(true) }.not_to raise_error
+    expect { described_class.getrusage }.not_to raise_error
+    expect { described_class.getrusage(true) }.not_to raise_error
   end
 
-  example "getrusage can get thread info on Linux" do
-    skip 'getrusage only tested on Linux' unless linux
-    expect{ Process.getrusage(Process::RUSAGE_THREAD) }.not_to raise_error
+  example 'getrusage can get thread info on Linux', :linux do
+    expect { described_class.getrusage(Process::RUSAGE_THREAD) }.not_to raise_error
   end
 
-  example "getrusage returns the expected struct" do
-    skip 'getrusage only tested on Linux' unless linux
-
-    @pid = fork{ sleep 0.5 }
-    expect(Process.getrusage).to be_kind_of(Struct::RUsage)
-    expect(Process.getrusage.stime).to be_kind_of(Float)
-    expect(Process.getrusage.utime).to be_kind_of(Float)
+  example 'getrusage returns the expected struct', :linux do
+    @pid = fork { sleep 0.5 }
+    expect(described_class.getrusage).to be_a(Struct::RUsage)
+    expect(described_class.getrusage.stime).to be_a(Float)
+    expect(described_class.getrusage.utime).to be_a(Float)
   end
 
-  example "pause method is defined" do
-    expect(Process).to respond_to(:pause)
+  example 'pause method is defined' do
+    expect(described_class).to respond_to(:pause)
   end
 
-  example "expected constants are defined" do
-    skip 'wait constant check skipped on this platform' if darwin || bsd
-
+  example 'expected constants are defined', :skip_darwin, :skip_bsd do
     expect(Process::WCONTINUED).not_to be_nil
     expect(Process::WEXITED).not_to be_nil
     expect(Process::WNOWAIT).not_to be_nil
     expect(Process::WSTOPPED).not_to be_nil
+  end
 
-    skip 'WTRAPPED constant check skipped on this platform' if linux
+  example 'expected constant WTRAPPED is defined', :bsd do
     expect(Process::WTRAPPED).not_to be_nil
   end
 
-  example "expected process type flag constants are defined" do
-    skip 'process type flag check skipped on this platform' if linux || darwin || bsd
-
+  example 'expected process type flag constants are defined', :solaris do
     expect(Process::P_ALL).not_to be_nil
     expect(Process::P_CID).not_to be_nil
     expect(Process::P_GID).not_to be_nil
@@ -224,18 +205,18 @@ RSpec.describe Process do
     expect(Process::P_PID).not_to be_nil
     expect(Process::P_SID).not_to be_nil
     expect(Process::P_UID).not_to be_nil
-
-    skip 'P_MYID constant check skipped on this platform' unless solaris
     expect(Process::P_MYID).not_to be_nil
   end
 
-  example "solaris-specific process type flags are defined on solaris" do
-    skip 'P_TASKID and P_PROJID constant check skipped on this platform' unless solaris
-
+  example 'solaris-specific process type flags are defined on solaris', :solaris do
     expect(Process::P_TASKID).not_to be_nil
     expect(Process::P_PROJID).not_to be_nil
   end
 
+  example 'bsd-specific process type flags are defined on BSD platforms', :bsd do
+    expect(Process::P_JAILID).not_to be_nil
+  end
+
   def after
     Process.kill(9, @pid) if @pid
   end

data/spec/spec_helper.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'rspec'
+require 'proc-wait3'
+
+RSpec.configure do |config|
+  config.filter_run_excluding(:darwin) if Gem::Platform.local.os !~ /darwin|macos/i
+  config.filter_run_excluding(:solaris) if Gem::Platform.local.os !~ /sunos|solaris/i
+  config.filter_run_excluding(:bsd) if Gem::Platform.local.os !~ /bsd|dragonfly/i
+  config.filter_run_excluding(:linux) if Gem::Platform.local.os !~ /linux/i
+
+  config.filter_run_excluding(:skip_hpux) if Gem::Platform.local.os =~ /hpux/i
+  config.filter_run_excluding(:skip_darwin) if Gem::Platform.local.os =~ /darwin|macos/i
+  config.filter_run_excluding(:skip_bsd) if Gem::Platform.local.os =~ /bsd|dragonfly/i
+  config.filter_run_excluding(:skip_linux) if Gem::Platform.local.os =~ /linux/i
+end

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: proc-wait3
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.3
 platform: ruby
 authors:
 - Daniel J. Berger
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain:
 - |
@@ -35,7 +35,7 @@ cert_chain:
   ORVCZpRuCPpmC8qmqxUnARDArzucjaclkxjLWvCVHeFa9UP7K3Nl9oTjJNv+7/jM
   WZs4eecIcUc4tKdHxcAJ0MO/Dkqq7hGaiHpwKY76wQ1+8xAh
   -----END CERTIFICATE-----
-date: 2024-02-08 00:00:00.000000000 Z
+date: 2024-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -65,6 +65,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
       The proc-wait3 library adds the wait3, wait4, waitid, pause, sigsend,
       and getrusage methods to the Process module.
@@ -92,6 +120,7 @@ files:
 - lib/proc-wait3.rb
 - proc-wait3.gemspec
 - spec/proc_wait3_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/djberg96/proc-wait3
 licenses:
 - Apache-2.0
@@ -103,7 +132,8 @@ metadata:
   source_code_uri: https://github.com/djberg96/proc-wait3
   wiki_uri: https://github.com/djberg96/proc-wait3/wiki
   rubygems_mfa_required: 'true'
-post_install_message:
+  github_repo: https://github.com/djberg96/proc-wait3
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -118,8 +148,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.4.19
+signing_key: 
 specification_version: 4
 summary: Adds wait3, wait4 and other methods to the Process module
 test_files:

metadata.gz.sig

@@ -1,2 +1,3 @@
-�2��z"+�t|��ҺL�U��P�y�OM�ي�Q�����3S��pL�8hv�.���JLUy����O�M�'q"Hl-������gіEHGh8����*��vQ�Wr���̩�_�ň찻7��H'MzQS)��e��E�F�,���#g�2>�)�=�������
-�^�ا���2�h����X����2�N�7����a����k[�>[P��iSG�|
+�bj<d������&qN�
+�溨}gdԥwf*����J�˚䋓t��!FI��`<�ѝ��Gd9ʦ��<� ���`��,{R�����y�R��#9w̻�
2zk�	T�'@��h�װh��S� �q��_�����v� jљ�J��Y�g2��~C(�>ҵpMNn�f��I��T��dE�פ�SCPn�2h��(�X$��|Rb�n6�9��O��Oȉ^�'
+p���pN���"��n-�M~е:Jc��U��lQ�c���D�z�˾����p�� "$Gu'��w'�[47����q�E�c/�JCh������$��~/��E"[7����R��β�3������Iˍ���9�s�vG��.��8�ZX�ô�B�