problem_child 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 054ff3ece80e2d56567e0852631eb17406a13935
-  data.tar.gz: f943642e28dd13536bf7daab9cd950fe7a258249
+  metadata.gz: 6b194f981f4da29f466015a0147e28f2ea7f98fe
+  data.tar.gz: a8fca157ebe6c7718ba59b46692c63d103c690ab
 SHA512:
-  metadata.gz: 3f62815854bd1f1fc0dee735893056ecd60fb683e33865c44393f581f6dc1972336b3a98bf861acb87abab73ca828ab395a3b08431e4c309f46734abcbe97df3
-  data.tar.gz: 1152a305b0aa0a5c1e0b92396f16541a9065b097df335ad8695b2fe09b16c86f14df5fbd5d07d672c61f3eef8fa83736a914854ca8851f3fb76f190c77f3971e
+  metadata.gz: b1202f58aef1959d41fb1cba180e127e389ddf26148af0ef42ac53036f18abf3eb64ed7a8c9d21cca833baf8f5e9e04143192921500f493fa03b865a272670f4
+  data.tar.gz: b472d792040dd8e939461402c16ca3e3bd4a40b9258734e62846440c2e4c5f087f42873bd09e78601bd2d987a552898e68c5f37680ad144de56fc350a27888bf

data/README.md

@@ -60,6 +60,19 @@ run ProblemChild::App
 
 *Pro-tip*: You can use any standard HTML form fields, but be sure to name one field `title`, which will become the issue title.
 
+*Pro-tip II*: Problem child can set labels. You can do this either as a hidden field:
+
+```html
+<input type="hidden" name="labels[]" value="bug" />
+```
+
+or as a checkbox:
+
+```html
+<input type="checkbox" name="labels[]" value="bug" />
+<input type="checkbox" name="labels[]" value="suggestion" />
+```
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/problem_child/fork )

data/lib/problem_child/helpers.rb

@@ -26,7 +26,7 @@ module ProblemChild
     end
 
     def issue_body
-      form_data.reject { |key, value| key == "title" || value.empty? }.map { |key,value| "* **#{key.humanize}**: #{value}"}.join("\n")
+      form_data.reject { |key, value| key == "title" || value.empty? || key == "labels" }.map { |key,value| "* **#{key.humanize}**: #{value}"}.join("\n")
     end
 
     # abstraction to allow cached form data to be used in place of default params
@@ -34,8 +34,12 @@ module ProblemChild
       session["form_data"].nil? ? params : JSON.parse(session["form_data"])
     end
 
+    def labels
+      form_data["labels"].join(",") if form_data["labels"]
+    end
+
     def create_issue
-      issue = client.create_issue(repo, form_data["title"], issue_body)
+      issue = client.create_issue(repo, form_data["title"], issue_body, :labels => labels)
       issue["number"] if issue
     end
 

data/lib/problem_child/version.rb

@@ -1,3 +1,3 @@
 module ProblemChild
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/lib/problem_child/views/form.erb

@@ -20,5 +20,6 @@
     <label for="body">Body</label>
     <textarea class="form-control" rows="10" id="body" name="body"></textarea>
   </div>
+  
   <button type="submit" class="btn btn-default">Submit</button>
 </form>

data/spec/problem_child_helpers_spec.rb

@@ -76,13 +76,12 @@ describe "ProblemChild::Helpers" do
   end
 
   it "submits the issue" do
-    expected = {"title" => "title", "foo" => "bar"}
-    @helper.params = expected
+    @helper.params = {"title" => "title", "foo" => "bar", "labels" => ["foo", "bar"]}
     with_env "GITHUB_TOKEN", "1234" do
       with_env "GITHUB_REPO", "benbalter/test-repo-ignore-me" do
 
         stub = stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
-          with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: bar\"}").
+          with(:body => "{\"labels\":[\"foo\",\"bar\"],\"title\":\"title\",\"body\":\"* **Foo**: bar\"}").
           to_return(:status => 200, :body => '{"number": 1234}', :headers => { 'Content-Type' => 'application/json' })
 
         expect(@helper.create_issue).to eql(1234)
@@ -123,4 +122,9 @@ describe "ProblemChild::Helpers" do
       end
     end
   end
+
+  it "knows the labels" do
+    @helper.params["labels"] = ["foo", "bar"]
+    expect(@helper.labels).to eql("foo,bar")
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: problem_child
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Ben Balter