problem_child 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e83ecc3d971edca9afa09d88616214477ad6674
-  data.tar.gz: 2a7a552a65d5457ec6d2008e647226e18f7a050f
+  metadata.gz: 054ff3ece80e2d56567e0852631eb17406a13935
+  data.tar.gz: f943642e28dd13536bf7daab9cd950fe7a258249
 SHA512:
-  metadata.gz: 17b494db5c8b46d04004377e62845dc8ba1cfffbeb004331acb9d1cf119a061d1bd4c8330bc798d5b4b4f122ebbd7bb053c691e94ed25ee6766936d4628abdbe
-  data.tar.gz: ebd5fecb4ed6e22c5522d678fdafc6ba5fd332849f8abdf7121ccc333d4364a9499aec40069c74ba5fbdf75f4e2906db7fb9775e9bcec9951765d12b92660187
+  metadata.gz: 3f62815854bd1f1fc0dee735893056ecd60fb683e33865c44393f581f6dc1972336b3a98bf861acb87abab73ca828ab395a3b08431e4c309f46734abcbe97df3
+  data.tar.gz: 1152a305b0aa0a5c1e0b92396f16541a9065b097df335ad8695b2fe09b16c86f14df5fbd5d07d672c61f3eef8fa83736a914854ca8851f3fb76f190c77f3971e

data/lib/problem_child.rb

@@ -57,13 +57,15 @@ module ProblemChild
 
     get "/" do
       if session[:form_data]
-        flash = :success if create_issue
+        issue = create_issue
         session[:form_data] = nil
+        access = repo_access?
       else
-        flash = nil
+        issue = nil
+        access = false
         auth!
       end
-      halt erb :form, :layout => :layout, :locals => { :repo => repo, :anonymous => anonymous_submissions?, :flash => flash }
+      halt erb :form, :layout => :layout, :locals => { :repo => repo, :anonymous => anonymous_submissions?, :issue => issue, :access => access }
     end
 
     post "/" do

data/lib/problem_child/helpers.rb

@@ -35,7 +35,15 @@ module ProblemChild
     end
 
     def create_issue
-      client.create_issue(repo, form_data["title"], issue_body)
+      issue = client.create_issue(repo, form_data["title"], issue_body)
+      issue["number"] if issue
+    end
+
+    def repo_access?
+      return true unless anonymous_submissions?
+      !client.repository(repo)["private"]
+    rescue
+      false
     end
 
     def auth!

data/lib/problem_child/version.rb

@@ -1,3 +1,3 @@
 module ProblemChild
-  VERSION = "0.2.0"
+  VERSION = "1.0.0"
 end

data/lib/problem_child/views/form.erb

@@ -5,8 +5,10 @@
 <% end %>
 </h1>
 
-<% if flash && flash == :success %>
-  <div class="alert alert-success" role="alert">Your issue was successfully submitted.</div>
+<% if issue %>
+  <div class="alert alert-success" role="alert">
+    Your issue was successfully submitted<% if access %> as <a href="http://github.com/<%= repo %>/issues/<%= issue %>"><%= repo %>#<%= issue %></a><% end %>.
+  </div>
 <% end %>
 
 <form method="post">

data/spec/problem_child_helpers_spec.rb

@@ -83,11 +83,44 @@ describe "ProblemChild::Helpers" do
 
         stub = stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
           with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: bar\"}").
-          to_return(:status => 200)
+          to_return(:status => 200, :body => '{"number": 1234}', :headers => { 'Content-Type' => 'application/json' })
 
-        @helper.create_issue
+        expect(@helper.create_issue).to eql(1234)
         expect(stub).to have_been_requested
       end
     end
   end
+
+  it "knows auth'd users can access a repo" do
+    stub_request(:get, "https://api.github.com/repos/benbalter/test-repo-ignore-me").
+      to_return(:status => 200, :body => '{"private": true}', :headers => { 'Content-Type' => 'application/json' })
+
+    with_env "GITHUB_TOKEN", nil do
+      with_env "GITHUB_REPO", "benbalter/test-repo-ignore-me" do
+        expect(@helper.repo_access?).to eql(true)
+      end
+    end
+  end
+
+  it "knows anonymous users can access public repos" do
+    stub_request(:get, "https://api.github.com/repos/benbalter/test-repo-ignore-me").
+      to_return(:status => 200, :body => '{"private": false}', :headers => { 'Content-Type' => 'application/json' })
+
+    with_env "GITHUB_TOKEN", "1234" do
+      with_env "GITHUB_REPO", "benbalter/test-repo-ignore-me" do
+        expect(@helper.repo_access?).to eql(true)
+      end
+    end
+  end
+
+  it "knows anonymous users can't access private repos" do
+    stub_request(:get, "https://api.github.com/repos/benbalter/test-repo-ignore-me").
+      to_return(:status => 200, :body => '{"private": true}', :headers => { 'Content-Type' => 'application/json' })
+
+    with_env "GITHUB_TOKEN", "1234" do
+      with_env "GITHUB_REPO", "benbalter/test-repo-ignore-me" do
+        expect(@helper.repo_access?).to eql(false)
+      end
+    end
+  end
 end

data/spec/problem_child_spec.rb

@@ -86,13 +86,14 @@ describe "logged in user" do
 
         stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
           with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: bar\"}").
-          to_return(:status => 200)
+          to_return(:status => 200, :body => '{"number": 1234}', :headers => { 'Content-Type' => 'application/json' })
 
         post "/", :title => "title", :foo => "bar"
         follow_redirect!
 
         expect(last_response.status).to eql(200)
-        expect(last_response.body).to match(/Your issue was successfully submitted/)
+        expected = '<a href="http://github.com/benbalter/test-repo-ignore-me/issues/1234">benbalter/test-repo-ignore-me#1234</a>'
+        expect(last_response.body).to match(expected)
       end
     end
   end
@@ -129,13 +130,16 @@ describe "logged out user" do
 
         stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
           with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: bar\"}").
-          to_return(:status => 200)
+          to_return(:status => 200, :body => '{"number": 1234}', :headers => { 'Content-Type' => 'application/json' })
+
+        stub_request(:get, "https://api.github.com/repos/benbalter/test-repo-ignore-me").
+          to_return(:status => 200, :body => '{"private": true}', :headers => { 'Content-Type' => 'application/json' })
 
         post "/", :title => "title", :foo => "bar"
         follow_redirect!
 
         expect(last_response.status).to eql(200)
-        expect(last_response.body).to match(/Your issue was successfully submitted/)
+        expect(last_response.body).to match(/Your issue was successfully submitted\./)
       end
     end
   end
@@ -147,14 +151,16 @@ describe "logged out user" do
 
         stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
           with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: #{long_string}\"}").
-          to_return(:status => 200)
+          to_return(:status => 200, :body => '{"number": 1234}', :headers => { 'Content-Type' => 'application/json' })
 
+        stub_request(:get, "https://api.github.com/repos/benbalter/test-repo-ignore-me").
+          to_return(:status => 200, :body => '{"private": true}', :headers => { 'Content-Type' => 'application/json' })
 
         post "/", :title => "title", :foo => long_string
         follow_redirect!
 
         expect(last_response.status).to eql(200)
-        expect(last_response.body).to match(/Your issue was successfully submitted/)
+        expect(last_response.body).to match(/Your issue was successfully submitted\./)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: problem_child
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Ben Balter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-25 00:00:00.000000000 Z
+date: 2015-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra