problem_child 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06265cd34450ea0ffaf3f55043eb05838eba1830
-  data.tar.gz: 93a4d479de486acff65c59087f2e0b844a838aef
+  metadata.gz: 9e83ecc3d971edca9afa09d88616214477ad6674
+  data.tar.gz: 2a7a552a65d5457ec6d2008e647226e18f7a050f
 SHA512:
-  metadata.gz: afdc991714c0ff6d157132bdf7897915262dd983c648ea2dc51a69124dc22a4a6ada7b24e87ef0650f28f8153a0fd797da8cd770ca2b6fd8a9207e7c339ba72c
-  data.tar.gz: b2d169245f679c9c529c7e4306a524af8cdc8a16d719c3a02181ccc7ea498abf4caa8de9c6bb6a76fd65e822bd67f5676197816dc983a2a7cb6372ca5408035d
+  metadata.gz: 17b494db5c8b46d04004377e62845dc8ba1cfffbeb004331acb9d1cf119a061d1bd4c8330bc798d5b4b4f122ebbd7bb053c691e94ed25ee6766936d4628abdbe
+  data.tar.gz: ebd5fecb4ed6e22c5522d678fdafc6ba5fd332849f8abdf7121ccc333d4364a9499aec40069c74ba5fbdf75f4e2906db7fb9775e9bcec9951765d12b92660187

data/.travis.yml

@@ -6,7 +6,9 @@ rvm:
 
 sudo: false
 cache: bundler
-
+services:
+  - memcached
+  
 env:
   global:
     GITHUB_CLIENT_ID: "1234"

data/README.md

@@ -20,6 +20,14 @@ Allows authenticated or anonymous users to fill out a standard web form to creat
   ```
 3. Follow the configuration options below
 
+## Requirements
+
+You'll need to have [Memcache](http://memcached.org/) running.
+
+On OS X, run `brew install memcached` to install, followed by `memcached` to run the memcache server.
+
+On Heroku you'll want to run `heroku addons:add memcachier:dev` to add a free Memecache instance to your app.
+
 ## Configuring
 
 You must set the following as environmental variables:

data/lib/problem_child/memcache.rb

@@ -0,0 +1,22 @@
+module ProblemChild
+  class Memcache
+
+    def self.client
+      Dalli::Client.new(server, options)
+    end
+
+    def self.options
+      {
+       :username => ENV["MEMCACHIER_USERNAME"],
+       :password => ENV["MEMCACHIER_PASSWORD"],
+       :failover => true,
+       :socket_timeout => 1.5,
+       :socket_failure_delay => 0.2
+      }
+    end
+
+    def self.server
+      ENV["MEMCACHIER_SERVERS"].split(",") unless ENV["MEMCACHIER_SERVERS"].to_s.blank?
+    end
+  end
+end

data/lib/problem_child/version.rb

@@ -1,3 +1,3 @@
 module ProblemChild
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/lib/problem_child.rb

@@ -3,10 +3,13 @@ require 'sinatra'
 require 'sinatra_auth_github'
 require 'dotenv'
 require 'json'
+require 'dalli'
+require 'rack/session/dalli'
 require 'active_support'
 require 'active_support/core_ext/string'
 require "problem_child/version"
 require "problem_child/helpers"
+require "problem_child/memcache"
 
 module ProblemChild
 
@@ -26,6 +29,10 @@ module ProblemChild
 
     include ProblemChild::Helpers
 
+    configure do
+      use Rack::Session::Dalli, cache: ProblemChild::Memcache.client
+    end
+
     set :github_options, {
       :scopes => "repo,read:org"
     }

data/problem_child.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "sinatra_auth_github", "~> 1.0"
   spec.add_dependency "activesupport", "~> 4.2"
   spec.add_dependency "rack", "1.5.2"
+  spec.add_dependency "dalli", "~> 2.7"
 
   spec.add_development_dependency "rspec", "~> 3.1"
   spec.add_development_dependency "rack-test", "~> 0.6"

data/spec/problem_child_memcache_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+
+describe "ProblemChild::MemcacheHelper" do
+
+  it "knows the server" do
+    with_env "MEMCACHIER_SERVERS", "localhost:1234" do
+      expect(ProblemChild::Memcache.server).to eql(["localhost:1234"])
+    end
+  end
+
+  it "can process multiple servers" do
+    with_env "MEMCACHIER_SERVERS", "localhost:1234, localhost:4567" do
+      expect(ProblemChild::Memcache.server).to eql(["localhost:1234", " localhost:4567"])
+    end
+  end
+
+  it "pulls the username and password" do
+    with_env "MEMCACHIER_USERNAME", "user" do
+      with_env "MEMCACHIER_PASSWORD", "pass" do
+        expected = {
+                     :username => "user",
+                     :password => "pass",
+                     :failover => true,
+                     :socket_timeout => 1.5,
+                     :socket_failure_delay => 0.2
+                   }
+        expect(ProblemChild::Memcache.options).to eql(expected)
+      end
+    end
+  end
+
+  it "returns the client" do
+    expect(ProblemChild::Memcache.client.class).to eql(Dalli::Client)
+  end
+end

data/spec/problem_child_spec.rb

@@ -107,9 +107,11 @@ describe "logged out user" do
 
   it "asks the user to log in" do
     with_env "GITHUB_ORG_ID", "balter-test-org" do
-      get "/"
-      expect(last_response.status).to eql(302)
-      expect(last_response.headers['Location']).to match(%r{^https://github\.com/login/oauth/authorize})
+      with_env "GITHUB_TOKEN", nil do
+        get "/"
+        expect(last_response.status).to eql(302)
+        expect(last_response.headers['Location']).to match(%r{^https://github\.com/login/oauth/authorize})
+      end
     end
   end
 
@@ -137,4 +139,23 @@ describe "logged out user" do
       end
     end
   end
+
+  it "supports submissions > 4k" do
+    with_env "GITHUB_TOKEN", "1234" do
+      with_env "GITHUB_REPO", "benbalter/test-repo-ignore-me" do
+        long_string =  "0" * 5000
+
+        stub_request(:post, "https://api.github.com/repos/benbalter/test-repo-ignore-me/issues").
+          with(:body => "{\"labels\":[],\"title\":\"title\",\"body\":\"* **Foo**: #{long_string}\"}").
+          to_return(:status => 200)
+
+
+        post "/", :title => "title", :foo => long_string
+        follow_redirect!
+
+        expect(last_response.status).to eql(200)
+        expect(last_response.body).to match(/Your issue was successfully submitted/)
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -15,6 +15,9 @@ RSpec.configure do |config|
   config.include(Sinatra::Auth::Github::Test::Helper)
 end
 
+ENV["GITHUB_CLIENT_ID"] = "1234"
+ENV["GITHUB_CLIENT_SECRET"] = "asdf"
+
 def with_env(key, value)
   old_env = ENV[key]
   ENV[key] = value

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: problem_child
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Ben Balter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-18 00:00:00.000000000 Z
+date: 2015-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -108,6 +108,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.5.2
+- !ruby/object:Gem::Dependency
+  name: dalli
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -225,6 +239,7 @@ files:
 - config.ru
 - lib/problem_child.rb
 - lib/problem_child/helpers.rb
+- lib/problem_child/memcache.rb
 - lib/problem_child/public/vendor/bootstrap/.bower.json
 - lib/problem_child/public/vendor/bootstrap/Gruntfile.js
 - lib/problem_child/public/vendor/bootstrap/LICENSE
@@ -278,6 +293,7 @@ files:
 - script/release
 - script/server
 - spec/problem_child_helpers_spec.rb
+- spec/problem_child_memcache_spec.rb
 - spec/problem_child_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/benbalter/problem_child
@@ -307,5 +323,6 @@ summary: Allows authenticated or anonymous users to fill out a standard web form
   creat GitHub issues.
 test_files:
 - spec/problem_child_helpers_spec.rb
+- spec/problem_child_memcache_spec.rb
 - spec/problem_child_spec.rb
 - spec/spec_helper.rb