private_please 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f5b957c5daf40f83ad7923f1bf6998d9e747704
-  data.tar.gz: 7f99f9677b8e5e163a504ffc891089ea60e4a4b8
+  metadata.gz: 1c686287e2a68e5a615222b424c30c5b69904814
+  data.tar.gz: b222e367b3d2ec2f0e3dfb0e34d6c86c18e88011
 SHA512:
-  metadata.gz: 233ec12deffb6bd4b31575d94ce5efe4e2bd98d50319b5d8489e714179d9c359ab62bb1eb9c3f40c18c266fc9b9ec62702b6415ba1c145de1175ecab60e70bb7
-  data.tar.gz: e7ea701475560b044ae7aa729fbf0afa73e9a1aa4f936d3f9a6d8fe5e2a03cecb706cb12c18b5be7dd6cc5af9f7d006c4f3b6db1b2948ad9f6f6c5974e63a1fa
+  metadata.gz: 65014fdbf7c069639cb8b7d8c49c7c71c16b8eba850a238cbc8999829f04a3f500bf3dc408a42976d6d2d38fb8cfa35f7bc86ced299a063dbe16adbe130e9531
+  data.tar.gz: ffef276c360f4547ba286db987c04aefd0f27e20540b72adcbe53eb8d191f8660481fc24cf7c47760daaffc4bf8ae620a9d621b82d2218b295cf04bcc3676ae9

data/.gitignore

@@ -3,14 +3,8 @@
 .bundle
 .config
 .yardoc
+spec/log/traces.txt
 Gemfile.lock
-InstalledFiles
-_yardoc
 coverage
-lib/bundler/man
 pkg
 rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp

data/.rubocop.yml

@@ -0,0 +1,32 @@
+inherit_from:
+  - .rubocop_todo.yml
+
+Metrics/LineLength:
+  Exclude:
+    - 'spec/**/*'
+
+Style/ExtraSpacing:
+  Enabled: false
+
+Style/MultilineTernaryOperator:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Style/SingleLineMethods:
+  Enabled: false
+EmptyLineBetweenDefs:
+  AllowAdjacentOneLineDefs: true
+
+Style/SpaceBeforeSemicolon:
+  Enabled: false
+
+Style/StructInheritance:
+  Enabled: false
+
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: comma

data/.rubocop_todo.yml

@@ -0,0 +1,24 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-01-19 17:37:21 +0100 using RuboCop version 0.36.0.
+
+# Offense count: 2
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 110
+
+# Offense count: 1
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/**/*'
+
+Style/GlobalVars:
+  Exclude:
+    - 'lib/goody_goody/analyzer.rb'
+
+Metrics/MethodLength:
+  Exclude:
+    - 'lib/goody_goody/analyzer.rb'

data/.travis.yml

@@ -1,8 +1,10 @@
 language: ruby
 rvm:
-  - "2.0.0"
-  - "2.1"
-  - "2.2"
-  - "2.3.0"
-# uncomment this line if your project needs to run something other than `rake`:
-script: bundle exec rspec --format documentation
+  - 2.0.0
+  - 2.1
+  - 2.2.4
+  - 2.3.0
+  - ruby-head
+
+script: bundle exec rspec --format documentation  --tag ~fails_on_ci --seed 2222
+

data/CHANGELOG

@@ -1,3 +1,7 @@
+v0.1.2
+    - fix : support modules' "self." methods.
+    - fixes
+
 v0.1.1
     - fix : standard libraries (set, erb) must be required.
 

data/Gemfile

@@ -3,4 +3,4 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in private_please.gemspec
 gemspec
 
-gem 'rubocop', require: false
+gem 'rubocop', '~> 0.37.2', require: false

data/README.md

@@ -8,6 +8,8 @@ This tool locates public or protected methods that can be made private.
 After you have instrumented the tests suite (see below), it watches the code as the tests are executed and identifies non-private methods that are only called privately.
 As the technique used is tracing, the execution is slowed down substantially (ex: 300%)
 
+[![asciicast](https://asciinema.org/a/4sqa7u4defes3akyst27pq066.png)](https://asciinema.org/a/4sqa7u4defes3akyst27pq066)
+
 ## Usage
 
 Add this to the top of `spec_helper.rb`:

data/lib/private_please.rb

@@ -42,3 +42,7 @@ module PrivatePlease
     instance.result.to_two_level_hash
   end
 end
+
+if PrivatePlease::Debug.enabled?
+  TRACES_LINES = File.open(File.expand_path('../../spec/log/traces.txt', __FILE__), 'w')
+end

data/lib/private_please/tracking/debug/trace_point_data_logger.rb

@@ -6,7 +6,7 @@ module PrivatePlease
     end
 
     def self.enabled?
-      defined?(TRACES_LINES)
+      ENV['PRIVATE_PLEASE_DEBUG']
     end
 
     module TracePointDataLogger

data/lib/private_please/tracking/trace_point_details.rb

@@ -18,11 +18,13 @@ module PrivatePlease
       #  Array#new
       #  Array.size
       def method_full_name
-        if module_method?
-          instance_method = defined_class.instance_methods.include?(method_id)
-          instance_method ?
-            "#{defined_class}##{method_id}" :
-            "#{defined_class}.#{method_id}"
+        defined_class_s = defined_class.to_s
+        is_module_class_method = defined_class_s.start_with?('#<Class:')
+        if is_module_class_method
+          defined_class_s.gsub!(/^#<Class:/, '').delete!('>')
+          "#{defined_class_s}.#{method_id}"
+        elsif module_method?
+          "#{defined_class}##{method_id}"
         else
           instance_method = !(_self.class == Class)
           instance_method ?

data/lib/private_please/tracking/trace_point_processor.rb

@@ -27,9 +27,16 @@ module PrivatePlease
 
       private
 
-      def remember_trace_point(tp)
-        @latest_tracepoints.push TracePointDetails.from(tp)
-        # Debug.log_to_trace_file tpd if Debug.enabled?
+      if Debug.enabled?
+        def remember_trace_point(tp)
+          tpd = TracePointDetails.from(tp)
+          @latest_tracepoints.push tpd
+          Debug.log_to_trace_file  tpd
+        end
+      else
+        def remember_trace_point(tp)
+          @latest_tracepoints.push TracePointDetails.from(tp)
+        end
       end
 
       def untracked_code?(path)
@@ -57,6 +64,7 @@ module PrivatePlease
       end
 
       def private_call?
+        return unless tp_prev  # fails sometime (ex: rspec-core) # UNTESTED
         curr_event, prev_event = tp_curr.event, tp_prev.event
         (curr_event == :call) &&
           [:line, :return, :c_return].include?(prev_event) &&

data/lib/private_please/utils/source_file_utils.rb

@@ -6,9 +6,12 @@ module PrivatePlease
       def source_path_and_lineno(klass, separator, method)
         is_instance_method = separator == '#'
         if klass.instance_of?(Module)
-          is_instance_method ?
-              klass.instance_method(method).source_location :
-              klass.singleton_method(method).source_location
+          if is_instance_method
+            klass.instance_method(method).source_location
+          else
+            klass.singleton_method(method).source_location
+          end
+
         else
           is_instance_method ?
               klass.instance_method(method).source_location :

data/lib/private_please/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module PrivatePlease
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: private_please
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Alain Ravet
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-02-12 00:00:00.000000000 Z
+date: 2016-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -89,6 +89,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
 - CHANGELOG