prioritized_callbacks 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 920ddd09c3a79727ca904220114d5ed4df1f2246422bf708b8ccdce47534dab1
-  data.tar.gz: 5d1eccf1d4632e79130cd9e388bde7f69b32e88dae781a79161b721e05adb938
+  metadata.gz: f503f82601d43373b1d6e3d8462762a03f0ceb789a0989df6c1f8931e7aec5a4
+  data.tar.gz: ff6063eb44c68edd45162cf47a4a8adb97af82e3193c45ffc28f991f777f51ef
 SHA512:
-  metadata.gz: 0d341ef80863b66a8c31cce8ce407f25475d88426b25c5aa0e4118742173db5939f6e12b5e82844d8242989d79d1ccab5244ce199ce99eb3af8f0577c693a6b8
-  data.tar.gz: 6909e13c7d26c8f4edcce63ed9a6a72530513e0ab3e8a8a9de3c32e15601fef64763aa512a0257db0401b906fe1b60f20ace242b43066bed4adade2f2262354e
+  metadata.gz: 5ae190caa8fb5d8875cf5da6f95f947eda35ec7b44661795a88d974875ad7ae0cf13f11384c36ef3c606b650e8d49848742520a4cb394b56fb7b159c2157f272
+  data.tar.gz: f3408a104daee2f7827e187dc49d849d60f7d590967d5a179a52ed217b64baa0195aae00b552515df2a1a2daac6be4e246a58e991aef9f9250e81e149e2fd63a

data/README.md

@@ -6,6 +6,16 @@ which are executed last despite of the order in which they were initially added.
 
 **WARNING!** Do not use this gem unless you know that's the only way.
 
+## Install
+
+Add the following line to Gemfile:
+
+`gem 'prioritized_callbacks'`
+
+## Compatibility
+
+It is checked against all Rails versions >= 5.0 and Ruby >= 2.7
+
 ## Usage
 
 ### Using pure ActiveSupport::Callbacks:
@@ -110,4 +120,4 @@ append_save_order :my_order, before: :default
 
 You can specify `:before` or `:after` to specify a place where new order item should be inserted.
 
-2) To set priority for specific callback, you should add `:priority` option to `before_save` or `after_save`.
+2) To set priority for specific callback, you should add `:priority` option to `before_save` or `after_save`.

data/lib/prioritized_callbacks/active_support/callbacks_class_methods_patch.rb

@@ -4,20 +4,24 @@ module PrioritizedCallbacks
       def set_callbacks_order(name, order_items)
         chain = get_callbacks(name)
         raise ArgumentError, "Callbacks for #{name} are not defined" unless chain
+        order_items = order_items.map(&:to_sym)
         set_callbacks name, chain.copy_with_new_order(order_items)
       end
 
       def append_callbacks_order(name, order_items, options = {})
         chain = get_callbacks(name)
         raise ArgumentError, "Callbacks for #{name} are not defined" unless chain
-        order = chain.config[:order]
-        insert_pos = order.size
-        if (before = options[:before])
+        order          = chain.config[:order].dup
+        insert_pos     = order.size
+        order_items    = order_items.map(&:to_sym)
+        existing_items = order & order_items
+        raise ArgumentError, "Order item(s) #{existing_items.map(&:inspect).join(', ')} already exist for #{name} callbacks" if existing_items.any?
+        if (before = options[:before]&.to_sym)
           insert_pos = order.index(before)
-          raise ArgumentError, "Order '#{before}' is not defined in #{name} callbacks" unless insert_pos
-        elsif (after = options[:after])
+          raise ArgumentError, "Order item #{before.inspect} is not defined for #{name} callbacks" unless insert_pos
+        elsif (after = options[:after]&.to_sym)
           insert_pos = order.index(after)
-          raise ArgumentError, "Order '#{after}' is not defined in #{name} callbacks" unless insert_pos
+          raise ArgumentError, "Order item #{after.inspect} is not defined for #{name} callbacks" unless insert_pos
           insert_pos += 1
         end
         order.insert insert_pos, *order_items

data/lib/prioritized_callbacks/version.rb

@@ -1,3 +1,3 @@
 module PrioritizedCallbacks
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/lib/activerecord_callbacks_spec.rb

@@ -137,4 +137,20 @@ RSpec.describe ActiveRecord::Callbacks do
   it "has proper order when new order item is appended to the beginning" do
     expect(record6.text).to eq('Y1023X4956')
   end
+
+  it "should fail when existing order item is appended" do
+    expect do
+      class FailingRecord < Record2
+        append_save_order :first, :second, :last
+      end
+    end.to raise_error(ArgumentError, 'Order item(s) :first, :last already exist for save callbacks')
+  end
+
+  it "should fail when order item doesn't exist" do
+    expect do
+      class FailingRecord < Record2
+        append_save_order :second, before: :nonexisting
+      end
+    end.to raise_error(ArgumentError, 'Order item :nonexisting is not defined for save callbacks')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: prioritized_callbacks
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Anton Argirov