primer_view_components 0.41.0 → 0.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c96d27c7589b44364a5dbcd2371bb0360b7fd629371fd224cde69914570055b
-  data.tar.gz: b33fc96b99c510c1efa1c421b20e21d5ce42e575b5b7f58472aef80d86f77c77
+  metadata.gz: 8b8def83f2582f5a2ac49a275b6f0262473510b6bc9f3931cb72115bb91e1b8d
+  data.tar.gz: ea003aff30f6d1b2570c432c2921a93e8ec9bdb9a682d39fb5d5bf4e29729418
 SHA512:
-  metadata.gz: d9cc017ed5a8295dcf4576cf9aaa555b618d5e0c1629d09d50fd716aa9313e524ef717e3ad9f906002c060bba2ae7bdece9b026d4aeccce1e7f601cc017a912b
-  data.tar.gz: 3d7eb52d24074091b151573fd63f9324538866559b0b9cf395e9889847d5faa8b0a06cd0283c7cdb71140b109feda1bf13cc39cf8c4f1d6a2d2192024adb5f02
+  metadata.gz: 314b33264d58ea808b7db78d0137cc03d151a4e6f3aab8a363a8ea4c0fecd622edfcdb6df81499f02807d0616298978e80b94865ac4b435109911056073f9503
+  data.tar.gz: 83449ea51244eec9fa28f361221b66a9bb0e6450e2a025f30e9adc5e8f848af08eb4f9057c5f0b583128799d07f8d1877659708350c59363feeea1a9ead0b31e

data/CHANGELOG.md

@@ -1,5 +1,27 @@
 # CHANGELOG
 
+## 0.43.0
+
+### Minor Changes
+
+- [#3466](https://github.com/primer/view_components/pull/3466) [`57f6c41`](https://github.com/primer/view_components/commit/57f6c41025de70dfcd6880dab7e881d182e3cbd9) Thanks [@manuelpuyol](https://github.com/manuelpuyol)! - Create Primer::CurrentAttributes allowing apps to set request specific context to components. Update IncludeFragment to add data-nonce when a current nonce is present.
+
+### Patch Changes
+
+- [#3447](https://github.com/primer/view_components/pull/3447) [`c2b88cb`](https://github.com/primer/view_components/commit/c2b88cb1d75e86fc0b410e3fc597e48326f471a5) Thanks [@bsatarnejad](https://github.com/bsatarnejad)! - Add a new custom label for close button in dialog header
+
+- [#3450](https://github.com/primer/view_components/pull/3450) [`5e86bf4`](https://github.com/primer/view_components/commit/5e86bf422b13a3818def5ceab464f8e362f9021b) Thanks [@francinelucca](https://github.com/francinelucca)! - Fix(SelectPanel): incorrect padding when no filter
+
+## 0.42.0
+
+### Minor Changes
+
+- [#3428](https://github.com/primer/view_components/pull/3428) [`1ab1b06`](https://github.com/primer/view_components/commit/1ab1b06509763ea60fc89770754edf06229b4f63) Thanks [@manuelpuyol](https://github.com/manuelpuyol)! - Create IncludeFragment component. Allow ConditionalWrapper to render components other than BaseComponent
+
+### Patch Changes
+
+- [#3429](https://github.com/primer/view_components/pull/3429) [`6ea9fd5`](https://github.com/primer/view_components/commit/6ea9fd5dc90c1964ab3882faf1733c6b49c80e21) Thanks [@manuelpuyol](https://github.com/manuelpuyol)! - Create IncludeFragment linter to migrate <include-fragment> uses
+
 ## 0.41.0
 
 ### Minor Changes

data/app/components/primer/alpha/action_menu.html.erb

@@ -3,7 +3,7 @@
     <%= render(@overlay) do |overlay| %>
       <% overlay.with_body(padding: :none) do %>
         <% if @src.present? %>
-          <include-fragment src="<%= @src %>" loading="<%= preload? ? "eager" : "lazy" %>" data-target="action-menu.includeFragment">
+          <%= render(Primer::Alpha::IncludeFragment.new(src: @src, loading: preload? ? :eager : :lazy, "data-target": "action-menu.includeFragment")) do %>
             <%= render(Primer::Alpha::ActionMenu::List.new(id: "#{@menu_id}-list", menu_id: @menu_id)) do |list| %>
               <% list.with_item(
                 aria: { disabled: true },
@@ -18,7 +18,7 @@
                 <%= render Primer::Beta::Spinner.new(aria: { label: "Loading content..." }) %>
               <% end %>
             <% end %>
-          </include-fragment>
+          <% end %>
         <% else %>
           <%= render(@list) %>
         <% end %>

data/app/components/primer/alpha/dialog/header.html.erb

@@ -13,7 +13,7 @@
       <% end %>
     </div>
     <div class="Overlay-actionWrap">
-      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id) %>
+      <%= render Primer::Beta::CloseButton.new(classes: "Overlay-closeButton", "data-close-dialog-id": @id, aria: { label: @close_label }) %>
     </div>
   </div>
   <%= filter %>

data/app/components/primer/alpha/dialog/header.rb

@@ -16,6 +16,8 @@ module Primer
         }.freeze
         VARIANT_OPTIONS = VARIANT_MAPPINGS.keys
 
+        DEFAULT_CLOSE_LABEL = "Close"
+
         # Optional filter slot for adding a filter input to the header.
         #
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
@@ -48,6 +50,7 @@ module Primer
         # @param show_divider [Boolean] Show a divider between the header and body.
         # @param visually_hide_title [Boolean] Visually hide the `title` while maintaining a label for assistive technologies.
         # @param variant [Symbol] <%= one_of(Primer::Alpha::Dialog::Header::VARIANT_OPTIONS) %>
+        # @param close_label [String] The aria-label text of the close "x" button.
         # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
         def initialize(
           id:,
@@ -56,12 +59,14 @@ module Primer
           show_divider: false,
           visually_hide_title: false,
           variant: DEFAULT_VARIANT,
+          close_label: DEFAULT_CLOSE_LABEL,
           **system_arguments
         )
           @id = id
           @title = title
           @subtitle = subtitle
           @visually_hide_title = visually_hide_title
+          @close_label = close_label
           @system_arguments = deny_tag_argument(**system_arguments)
           @system_arguments[:tag] = :div
 

data/app/components/primer/alpha/include_fragment.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Primer
+  module Alpha
+    # Use `IncludeFragment` to load HTML elements from the server.
+    # Add additional usage considerations or best practices that may aid the user to use the component correctly.
+    # @accessibility Add any accessibility considerations
+    class IncludeFragment < Primer::Component
+      status :alpha
+
+      ALLOWED_LOADING_VALUES = [:lazy, :eager].freeze
+      DEFAULT_LOADING = :eager
+
+      # @param src [String] The URL  from which to retrieve an HTML element fragment.
+      # @param loading [Symbol] <%= one_of([:lazy, :eager]) %>
+      # @param accept [String] What to send as the Accept header.
+      # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
+      def initialize(src: nil, loading: nil, accept: nil, **system_arguments)
+        @system_arguments = system_arguments
+        @system_arguments[:tag] = "include-fragment"
+        @system_arguments[:loading] = loading
+        @system_arguments[:src] = src
+        @system_arguments[:accept] = accept if accept
+
+        if loading
+          @system_arguments[:loading] = fetch_or_fallback(ALLOWED_LOADING_VALUES, loading.to_sym, DEFAULT_LOADING)
+        end
+
+        if Primer::CurrentAttributes.nonce
+          @system_arguments[:"data-nonce"] = Primer::CurrentAttributes.nonce
+        end
+      end
+
+      def call
+        render(Primer::BaseComponent.new(**@system_arguments)) { content }
+      end
+    end
+  end
+end

data/app/components/primer/alpha/select_panel.html.erb

@@ -50,7 +50,7 @@
           <% end %>
         <% end %>
       <% end %>
-      <%= render Primer::Alpha::Dialog::Body.new(mt: show_filter? ? 0 : 2, p: 0) do %>
+      <%= render Primer::Alpha::Dialog::Body.new(p: 0) do %>
         <focus-group direction="vertical" mnemonics retain>
           <live-region data-target="select-panel.liveRegion"></live-region>
           <%= render(Primer::BaseComponent.new(
@@ -62,7 +62,7 @@
           )) do %>
             <div id="<%= @body_id %>">
               <% if @src.present? %>
-                <%= render(Primer::ConditionalWrapper.new(condition: @fetch_strategy == :eventually_local, tag: "include-fragment", data: { target: "select-panel.includeFragment" }, src: @src, loading: preload? ? "eager" : "lazy", accept: "text/fragment+html")) do %>
+                <%= render(Primer::ConditionalWrapper.new(condition: @fetch_strategy == :eventually_local, component: Primer::Alpha::IncludeFragment, data: { target: "select-panel.includeFragment" }, src: @src, loading: preload? ? "eager" : "lazy", accept: "text/fragment+html")) do %>
                   <%= render(Primer::BaseComponent.new(
                     tag: :div,
                     id: "#{@panel_id}-list",

data/app/components/primer/conditional_wrapper.rb

@@ -1,14 +1,16 @@
 # frozen_string_literal: true
 
 module Primer
-  # Conditionally renders a `Primer::BaseComponent` around the given content. If the given condition
-  # is true, a `Primer::BaseComponent` will render around the content. If the condition is false, only
+  # Conditionally renders a component around the given content. If the given condition
+  # is true, the component will render around the content. If the condition is false, only
   # the content is rendered.
   class ConditionalWrapper < Primer::Component
-    # @param condition [Boolean] Whether or not to wrap the content in a `Primer::BaseComponent`.
-    # @param base_component_arguments [Hash] The arguments to pass to `Primer::BaseComponent`.
-    def initialize(condition:, **base_component_arguments)
+    # @param condition [Boolean] Whether or not to wrap the content in a component.
+    # @param component [Class] The component class to use as a wrapper, defaults to `Primer::BaseComponent`
+    # @param base_component_arguments [Hash] The arguments to pass to the component.
+    def initialize(condition:, component: Primer::BaseComponent, **base_component_arguments)
       @condition = condition
+      @component = component
       @base_component_arguments = base_component_arguments
       @trim = !!@base_component_arguments.delete(:trim)
     end
@@ -18,7 +20,7 @@ module Primer
         return @trim ? trimmed_content : content
       end
 
-      BaseComponent.new(trim: @trim, **@base_component_arguments).render_in(self) { content }
+      @component.new(trim: @trim, **@base_component_arguments).render_in(self) { content }
     end
   end
 end

data/app/lib/primer/current_attributes.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Primer
+  # `Primer::CurrentAttributes` can be used by controllers to set request-bound data
+  # that can be propagated to components.
+  class CurrentAttributes < ActiveSupport::CurrentAttributes
+    attribute :nonce
+  end
+end

data/lib/primer/view_components/linters/argument_mappers/include_fragment.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require_relative "base"
+
+module ERBLint
+  module Linters
+    module ArgumentMappers
+      # Maps attributes in the include-fragment element to arguments for the IncludeFragment component.
+      class IncludeFragment < Base
+        DEFAULT_TAG = "include-fragment"
+        ATTRIBUTES = %w[loading src accept role preload tabindex autofocus hidden].freeze
+
+        def attribute_to_args(attribute)
+          attr_name = attribute.name
+
+          { attr_name.to_sym => erb_helper.convert(attribute) }
+        end
+      end
+    end
+  end
+end

data/lib/primer/view_components/linters/include_fragment_component_migration_counter.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require_relative "base_linter"
+require_relative "autocorrectable"
+require_relative "argument_mappers/include_fragment"
+
+module ERBLint
+  module Linters
+    # Counts the number of times a HTML include-fragment is used instead of the component.
+    class IncludeFragmentComponentMigrationCounter < BaseLinter
+      include Autocorrectable
+
+      TAGS = %w[include-fragment].freeze
+      REQUIRED_ARGUMENTS = [].freeze
+      MESSAGE = "We are migrating include-fragment to use [Primer::Alpha::IncludeFragment](https://primer.style/view-components/lookbook/inspect/primer/alpha/include_fragment/default), please try to use that instead of raw HTML."
+      ARGUMENT_MAPPER = ArgumentMappers::IncludeFragment
+      COMPONENT = "Primer::Alpha::IncludeFragment"
+    end
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
   module ViewComponents
     module VERSION
       MAJOR = 0
-      MINOR = 41
+      MINOR = 43
       PATCH = 0
 
       STRING = [MAJOR, MINOR, PATCH].join(".")

data/previews/primer/alpha/dialog_preview/with_header_close_button_label.html.erb

@@ -0,0 +1,5 @@
+<%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: title, subtitle: subtitle, visually_hide_title: false)) do |dialog| %>
+  <% dialog.with_header(show_divider: show_divider, close_label: close_label) %>
+  <% dialog.with_show_button_content(button_text) %>
+  <% dialog.with_body_content("Hello World") %>
+<% end %>

data/previews/primer/alpha/dialog_preview/without_header_close_button_label.html.erb

@@ -0,0 +1,8 @@
+<%= render(Primer::Alpha::Dialog.new(id: "my-dialog", title: title, subtitle: subtitle, visually_hide_title: false)) do |dialog| %>
+  <% dialog.with_header(show_divider: show_divider, close_scheme: :none) %>
+  <% dialog.with_show_button_content(button_text) %>
+  <% dialog.with_body_content("Hello World") %>
+  <% dialog.with_footer do %>
+    <%= render(Primer::Beta::Button.new(data: { "close-dialog-id": "my-dialog" })) { "Close" } %>
+  <% end %>
+<% end %>

data/previews/primer/alpha/dialog_preview.rb

@@ -302,6 +302,38 @@ module Primer
       def with_header_filter
         render_with_template(locals: {})
       end
+
+      # @label With custom label for close button of header
+      #
+      # @param title [String] text
+      # @param subtitle [String] text
+      # @param button_text [String] text
+      # @param show_divider [Boolean] toggle
+      # @param close_label [String] text
+      def with_header_close_button_label(title: "Test Dialog", subtitle: nil, button_text: "Show Dialog", show_divider: true, close_label: "Close me!")
+        render_with_template(locals: {
+          title: title,
+          subtitle: subtitle,
+          button_text: button_text,
+          show_divider: show_divider,
+          close_label: close_label
+        })
+      end
+
+      # @label Without custom label for close button of header
+      #
+      # @param title [String] text
+      # @param subtitle [String] text
+      # @param button_text [String] text
+      # @param show_divider [Boolean] toggle
+      def without_header_close_button_label(title: "Test Dialog", subtitle: nil, button_text: "Show Dialog", show_divider: true)
+        render_with_template(locals: {
+          title: title,
+          subtitle: subtitle,
+          button_text: button_text,
+          show_divider: show_divider
+        })
+      end
     end
   end
 end

data/previews/primer/alpha/include_fragment_preview.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+# Setup Playground to use all available component props
+# Setup Features to use individual component props and combinations
+
+module Primer
+  module Alpha
+    # @label IncludeFragment
+    class IncludeFragmentPreview < ViewComponent::Preview
+      # @label Playground
+      # @param loading select [eager, lazy]
+      def playground(loading: :eager)
+        render(Primer::Alpha::IncludeFragment.new(loading: loading, src: UrlHelpers.include_fragment_deferred_path)) { "Loading..." }
+      end
+
+      # @label Default options
+      def default
+        render(Primer::Alpha::IncludeFragment.new(loading: :eager, src: UrlHelpers.include_fragment_deferred_path)) { "Loading..." }
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.41.0
+  version: 0.43.0
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-11 00:00:00.000000000 Z
+date: 2025-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -201,6 +201,7 @@ files:
 - app/components/primer/alpha/hellip_button.rb
 - app/components/primer/alpha/hidden_text_expander.rb
 - app/components/primer/alpha/image.rb
+- app/components/primer/alpha/include_fragment.rb
 - app/components/primer/alpha/layout.css
 - app/components/primer/alpha/layout.css.json
 - app/components/primer/alpha/layout.css.map
@@ -550,6 +551,7 @@ files:
 - app/lib/primer/css/layout.css.json
 - app/lib/primer/css/utilities.css
 - app/lib/primer/css/utilities.css.json
+- app/lib/primer/current_attributes.rb
 - app/lib/primer/experimental_render_helpers.rb
 - app/lib/primer/experimental_slot_helpers.rb
 - app/lib/primer/fetch_or_fallback_helper.rb
@@ -681,6 +683,7 @@ files:
 - lib/primer/view_components/linters/argument_mappers/conversion_error.rb
 - lib/primer/view_components/linters/argument_mappers/flash.rb
 - lib/primer/view_components/linters/argument_mappers/helpers/erb_block.rb
+- lib/primer/view_components/linters/argument_mappers/include_fragment.rb
 - lib/primer/view_components/linters/argument_mappers/label.rb
 - lib/primer/view_components/linters/argument_mappers/system_arguments.rb
 - lib/primer/view_components/linters/autocorrectable.rb
@@ -699,6 +702,7 @@ files:
 - lib/primer/view_components/linters/helpers/deprecated_components_helpers.rb
 - lib/primer/view_components/linters/helpers/rubocop_helpers.rb
 - lib/primer/view_components/linters/helpers/rule_helpers.rb
+- lib/primer/view_components/linters/include_fragment_component_migration_counter.rb
 - lib/primer/view_components/linters/label_component_migration_counter.rb
 - lib/primer/view_components/linters/migrate_deprecated_flash_arguments.rb
 - lib/primer/view_components/linters/migrations/iconbutton_component.rb
@@ -779,13 +783,16 @@ files:
 - previews/primer/alpha/dialog_preview/with_footer.html.erb
 - previews/primer/alpha/dialog_preview/with_form.html.erb
 - previews/primer/alpha/dialog_preview/with_header.html.erb
+- previews/primer/alpha/dialog_preview/with_header_close_button_label.html.erb
 - previews/primer/alpha/dialog_preview/with_header_filter.html.erb
 - previews/primer/alpha/dialog_preview/with_text_input.html.erb
+- previews/primer/alpha/dialog_preview/without_header_close_button_label.html.erb
 - previews/primer/alpha/dropdown_preview.rb
 - previews/primer/alpha/form_control_preview.rb
 - previews/primer/alpha/form_control_preview/playground.html.erb
 - previews/primer/alpha/hellip_button_preview.rb
 - previews/primer/alpha/hidden_text_expander_preview.rb
+- previews/primer/alpha/include_fragment_preview.rb
 - previews/primer/alpha/layout_preview.rb
 - previews/primer/alpha/menu_preview.rb
 - previews/primer/alpha/menu_preview/default.html.erb