primer_view_components 0.36.4 → 0.36.5

data/app/components/primer/beta/button.html.erb

@@ -9,8 +9,8 @@
     <% if trailing_visual %>
       <span class="Button-visual Button-trailingVisual">
         <% if @trailing_visual_counter %>
+          <span class="d-flex" aria-hidden="true"><%= trailing_visual %></span>
           <span class="sr-only">(<%= trailing_visual %>)</span>
-          <%= trailing_visual %>
         <% else %>
           <%= trailing_visual %>
         <% end %>

data/app/components/primer/beta/button.rb

@@ -70,7 +70,7 @@ module Primer
         label: Primer::Beta::Label,
         counter: lambda { |**system_arguments|
           @trailing_visual_counter = true
-          Primer::Beta::Counter.new("aria-hidden": true, **system_arguments)
+          Primer::Beta::Counter.new(**system_arguments)
         }
       }
 
@@ -108,6 +108,7 @@ module Primer
       # @param align_content [Symbol] <%= one_of(Primer::Beta::Button::ALIGN_CONTENT_OPTIONS) %>
       # @param tag [Symbol] (Primer::Beta::BaseButton::DEFAULT_TAG) <%= one_of(Primer::Beta::BaseButton::TAG_OPTIONS) %>
       # @param type [Symbol] (Primer::Beta::BaseButton::DEFAULT_TYPE) <%= one_of(Primer::Beta::BaseButton::TYPE_OPTIONS) %>
+      # @param inactive [Boolean] Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button.
       # @param disabled [Boolean] Whether or not the button is disabled. If true, this option forces `tag:` to `:button`.
       # @param label_wrap [Boolean] Whether or not the button label text wraps and the button height expands.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>

data/lib/primer/view_components/version.rb

@@ -6,7 +6,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 36
-      PATCH = 4
+      PATCH = 5
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/previews/primer/alpha/tooltip_preview.rb

@@ -65,7 +65,7 @@ module Primer
 
       # @label Tooltip with Primer::Beta::Link
       def tooltip_with_link(direction: :s, tooltip_text: "You can press a button")
-        render(Primer::Beta::Link.new(href: "#link-with-tooltip", id: "link-with-tooltip")) do |component|
+        render(Primer::Beta::Link.new(href: "#link-with-tooltip", id: "link-with-tooltip", underline: true)) do |component|
           component.with_tooltip(text: tooltip_text, direction: direction)
           "Button"
         end

data/static/arguments.json

@@ -3646,6 +3646,12 @@
         "default": "`:button`",
         "description": "One of `:button`, `:reset`, or `:submit`."
       },
+      {
+        "name": "inactive",
+        "type": "Boolean",
+        "default": "N/A",
+        "description": "Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button."
+      },
       {
         "name": "disabled",
         "type": "Boolean",

data/static/info_arch.json

@@ -12186,6 +12186,12 @@
         "default": "`:button`",
         "description": "One of `:button`, `:reset`, or `:submit`."
       },
+      {
+        "name": "inactive",
+        "type": "Boolean",
+        "default": "N/A",
+        "description": "Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button."
+      },
       {
         "name": "disabled",
         "type": "Boolean",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.36.4
+  version: 0.36.5
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-16 00:00:00.000000000 Z
+date: 2025-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview