primer_view_components 0.35.2 → 0.36.1

data/previews/primer/forms_preview.rb

@@ -3,48 +3,69 @@
 module Primer
   # :nodoc:
   class FormsPreview < ViewComponent::Preview
+    # @snapshot
     def single_text_field_form; end
 
+    # @snapshot
     def multi_text_field_form; end
 
+    # @snapshot
     def text_field_and_checkbox_form; end
 
+    # @snapshot
     def horizontal_form; end
 
+    # @snapshot
     def composed_form; end
 
+    # @snapshot
     def submit_button_form; end
 
+    # @snapshot
     def radio_button_group_form; end
 
+    # @snapshot
     def check_box_group_form; end
 
+    # @snapshot
     def array_check_box_group_form; end
 
+    # @snapshot
     def select_form; end
 
+    # @snapshot
     def action_menu_form(route_format: :html)
       render_with_template(locals: { route_format: route_format })
     end
 
+    # @snapshot
     def radio_button_with_nested_form; end
 
+    # @snapshot
     def check_box_with_nested_form; end
 
+    # @snapshot
     def caption_template_form; end
 
+    # @snapshot
     def after_content_form; end
 
+    # @snapshot
     def invalid_form; end
 
+    # @snapshot
     def multi_input_form; end
 
+    # @snapshot
     def name_with_question_mark_form; end
 
+    # @snapshot
     def immediate_validation_form; end
 
+    # @snapshot
     def example_toggle_switch_form; end
 
+    # @snapshot
     def auto_complete_form; end
   end
 end

data/static/classes.json

@@ -404,6 +404,9 @@
   "Link--underline": [
     "Primer::Beta::Link"
   ],
+  "Link-content": [
+    "Primer::Beta::Link"
+  ],
   "Overlay": [
     "Primer::Alpha::Dialog",
     "Primer::Alpha::Overlay"

data/static/form_previews.json

@@ -0,0 +1,113 @@
+[
+  {
+    "name": "forms",
+    "lookup_path": "primer/forms",
+    "examples": [
+      {
+        "preview_path": "primer/forms/single_text_field_form",
+        "name": "single_text_field_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/multi_text_field_form",
+        "name": "multi_text_field_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/text_field_and_checkbox_form",
+        "name": "text_field_and_checkbox_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/horizontal_form",
+        "name": "horizontal_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/composed_form",
+        "name": "composed_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/submit_button_form",
+        "name": "submit_button_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/radio_button_group_form",
+        "name": "radio_button_group_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/check_box_group_form",
+        "name": "check_box_group_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/array_check_box_group_form",
+        "name": "array_check_box_group_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/select_form",
+        "name": "select_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/action_menu_form",
+        "name": "action_menu_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/radio_button_with_nested_form",
+        "name": "radio_button_with_nested_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/check_box_with_nested_form",
+        "name": "check_box_with_nested_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/caption_template_form",
+        "name": "caption_template_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/after_content_form",
+        "name": "after_content_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/invalid_form",
+        "name": "invalid_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/multi_input_form",
+        "name": "multi_input_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/name_with_question_mark_form",
+        "name": "name_with_question_mark_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/immediate_validation_form",
+        "name": "immediate_validation_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/example_toggle_switch_form",
+        "name": "example_toggle_switch_form",
+        "snapshot": "true"
+      },
+      {
+        "preview_path": "primer/forms/auto_complete_form",
+        "name": "auto_complete_form",
+        "snapshot": "true"
+      }
+    ]
+  }
+]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.35.2
+  version: 0.36.1
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-11-21 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -398,6 +398,7 @@ files:
 - app/components/primer/beta/link.css
 - app/components/primer/beta/link.css.json
 - app/components/primer/beta/link.css.map
+- app/components/primer/beta/link.html.erb
 - app/components/primer/beta/link.pcss
 - app/components/primer/beta/link.rb
 - app/components/primer/beta/markdown.rb
@@ -654,6 +655,7 @@ files:
 - lib/primer/static/generate_arguments.rb
 - lib/primer/static/generate_audited_at.rb
 - lib/primer/static/generate_constants.rb
+- lib/primer/static/generate_form_previews.rb
 - lib/primer/static/generate_info_arch.rb
 - lib/primer/static/generate_previews.rb
 - lib/primer/static/generate_statuses.rb
@@ -724,7 +726,6 @@ files:
 - lib/rubocop/cop/primer/deprecated_layout_component.rb
 - lib/rubocop/cop/primer/no_tag_memoize.rb
 - lib/rubocop/cop/primer/primer_octicon.rb
-- lib/rubocop/cop/primer/system_argument_instead_of_class.rb
 - lib/rubocop/cop/primer/test_selector.rb
 - lib/tasks/custom_utilities.yml
 - previews/pages/forms/01_introduction.md.erb
@@ -943,6 +944,7 @@ files:
 - static/audited_at.json
 - static/classes.json
 - static/constants.json
+- static/form_previews.json
 - static/info_arch.json
 - static/previews.json
 - static/statuses.json

data/lib/rubocop/cop/primer/system_argument_instead_of_class.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require "rubocop"
-require "primer/classify/utilities"
-
-# :nocov:
-module RuboCop
-  module Cop
-    module Primer
-      # This cop ensures that components use System Arguments instead of CSS classes.
-      #
-      # bad
-      # Component.new(classes: "mr-1")
-      #
-      # good
-      # Component.new(mr: 1)
-      class SystemArgumentInsteadOfClass < BaseCop
-        INVALID_MESSAGE = <<~STR
-          Avoid using CSS classes when you can use System Arguments: https://primer.style/view-components/system-arguments.
-        STR
-
-        def on_send(node)
-          return unless valid_node?(node)
-          return unless node.arguments?
-
-          # we are looking for hash arguments and they are always last
-          kwargs = node.arguments.last
-
-          return unless kwargs.type == :hash
-
-          # find classes pair
-          classes_arg = kwargs.pairs.find { |kwarg| kwarg.key.value == :classes }
-
-          return if classes_arg.nil?
-          return unless classes_arg.value.type == :str
-
-          # get actual classes
-          classes = classes_arg.value.value
-
-          system_arguments = ::Primer::Classify::Utilities.classes_to_hash(classes)
-
-          # no classes are fixable
-          return if system_arguments[:classes] == classes
-
-          add_offense(classes_arg, message: INVALID_MESSAGE)
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            args = ::Primer::Classify::Utilities.classes_to_args(node.value.value)
-            corrector.replace(node.loc.expression, args)
-          end
-        end
-      end
-    end
-  end
-end