primer_view_components 0.0.94 → 0.0.96

data/lib/primer/forms/builder.rb

@@ -14,8 +14,8 @@ module Primer
         super(*args, classify(options), &block)
       end
 
-      def check_box(*args, **options, &block)
-        super(*args, classify(options), &block)
+      def check_box(method, options = {}, checked_value = 1, unchecked_value = 0, &block)
+        super(method, classify(options), checked_value, unchecked_value, &block)
       end
 
       def radio_button(*args, **options, &block)

data/lib/primer/forms/check_box.html.erb

@@ -1,5 +1,9 @@
 <div class="FormControl-checkbox-wrap">
-  <%= builder.check_box(@input.name, **@input.input_arguments) %>
+  <% if @input.scheme == :array %>
+    <%= builder.check_box(@input.name, @input.input_arguments, checked_value, nil) %>
+  <% else %>
+    <%= builder.check_box(@input.name, @input.input_arguments) %>
+  <% end %>
   <span class="FormControl-checkbox-labelWrap">
     <%= builder.label(@input.name, **@input.label_arguments) do %>
       <%= @input.label %>

data/lib/primer/forms/check_box.rb

@@ -10,6 +10,17 @@ module Primer
         @input = input
         @input.add_label_classes("FormControl-label")
         @input.add_input_classes("FormControl-checkbox")
+
+        return unless @input.scheme == :array
+
+        @input.input_arguments[:multiple] = true
+        @input.label_arguments[:value] = checked_value
+      end
+
+      private
+
+      def checked_value
+        @input.value || "1"
       end
     end
   end

data/lib/primer/forms/dsl/check_box_group_input.rb

@@ -7,7 +7,8 @@ module Primer
       class CheckBoxGroupInput < Input
         attr_reader :label, :check_boxes
 
-        def initialize(label: nil, **system_arguments)
+        def initialize(name: nil, label: nil, **system_arguments)
+          @name = name
           @label = label
           @check_boxes = []
 
@@ -31,9 +32,21 @@ module Primer
         end
 
         def check_box(**system_arguments)
-          @check_boxes << CheckBoxInput.new(
-            builder: @builder, form: @form, **system_arguments
-          )
+          args = {
+            name: @name,
+            **system_arguments,
+            builder: @builder,
+            form: @form,
+            scheme: scheme
+          }
+
+          @check_boxes << CheckBoxInput.new(**args)
+        end
+
+        private
+
+        def scheme
+          @name ? :array : :boolean
         end
       end
     end

data/lib/primer/forms/dsl/check_box_input.rb

@@ -5,11 +5,20 @@ module Primer
     module Dsl
       # :nodoc:
       class CheckBoxInput < Input
-        attr_reader :name, :label
+        DEFAULT_SCHEME = :boolean
+        SCHEMES = [DEFAULT_SCHEME, :array].freeze
+
+        attr_reader :name, :label, :value, :scheme
+
+        def initialize(name:, label:, value: nil, scheme: DEFAULT_SCHEME, **system_arguments)
+          raise ArgumentError, "Check box scheme must be one of #{SCHEMES.join(', ')}" unless SCHEMES.include?(scheme)
+
+          raise ArgumentError, "Check box needs an explicit value if scheme is array" if scheme == :array && value.nil?
 
-        def initialize(name:, label:, **system_arguments)
           @name = name
           @label = label
+          @value = value
+          @scheme = scheme
 
           super(**system_arguments)
         end
@@ -21,6 +30,16 @@ module Primer
         def type
           :check_box
         end
+
+        private
+
+        def caption_template_name
+          @caption_template_name ||= if @scheme == :array
+                                       :"#{name}_#{value}"
+                                     else
+                                       name.to_sym
+                                     end
+        end
       end
     end
   end

data/lib/primer/view_components/engine.rb

@@ -30,12 +30,13 @@ module Primer
         app.config.assets.precompile += %w[primer_view_components] if app.config.respond_to?(:assets)
       end
 
-      initializer "primer.forms.eager_load_actions" do
+      initializer "primer.eager_load_actions" do
         ActiveSupport.on_load(:after_initialize) do
           if Rails.application.config.eager_load
             Primer::Forms::Base.compile!
             Primer::Forms::Base.descendants.each(&:compile!)
             Primer::Forms::BaseComponent.descendants.each(&:compile!)
+            Primer::Octicon::Cache.preload!
           end
         end
       end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 94
+      PATCH = 96
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/tasks/coverage.rake

@@ -5,7 +5,7 @@ namespace :coverage do
     require "simplecov"
     require "simplecov-console"
 
-    SimpleCov.minimum_coverage 100
+    SimpleCov.minimum_coverage 99
 
     SimpleCov.collate Dir["simplecov-resultset-*/.resultset.json"], "rails" do
       formatter SimpleCov::Formatter::Console

data/lib/tasks/docs.rake

@@ -131,7 +131,7 @@ namespace :docs do
         f.puts("componentId: #{data[:component_id]}")
         f.puts("status: #{data[:status]}")
         f.puts("source: #{data[:source]}")
-        f.puts("storybook: #{data[:storybook]}")
+        f.puts("lookbook: #{data[:lookbook]}") if preview_exists?(component)
         f.puts("---")
         f.puts
         f.puts("import Example from '#{data[:example_path]}'")
@@ -276,8 +276,8 @@ namespace :docs do
       raise
     end
 
-    File.open("static/arguments.yml", "w") do |f|
-      f.puts YAML.dump(args_for_components)
+    File.open("static/arguments.json", "w") do |f|
+      f.puts JSON.pretty_generate(args_for_components)
     end
 
     # Build system arguments docs from BaseComponent
@@ -371,27 +371,25 @@ namespace :docs do
 
       yard_example_tags = initialize_method.tags(:example)
 
-      path = Pathname.new("test/previews/primer/docs/#{short_name.underscore}_preview.rb")
+      path = Pathname.new("test/previews/docs/#{short_name.underscore}_preview.rb")
       path.dirname.mkdir unless path.dirname.exist?
 
       File.open(path, "w") do |f|
-        f.puts("module Primer")
-        f.puts("  module Docs")
-        f.puts("    class #{short_name}Preview < ViewComponent::Preview")
+        f.puts("module Docs")
+        f.puts("  class #{short_name}Preview < ViewComponent::Preview")
 
         yard_example_tags.each_with_index do |tag, index|
           name, _, code = parse_example_tag(tag)
           method_name = name.split("|").first.downcase.parameterize.underscore
-          f.puts("      def #{method_name}; end")
+          f.puts("    def #{method_name}; end")
           f.puts unless index == yard_example_tags.size - 1
-          path = Pathname.new("test/previews/primer/docs/#{short_name.underscore}_preview/#{method_name}.html.erb")
+          path = Pathname.new("test/previews/docs/#{short_name.underscore}_preview/#{method_name}.html.erb")
           path.dirname.mkdir unless path.dirname.exist?
           File.open(path, "w") do |view_file|
             view_file.puts(code.to_s)
           end
         end
 
-        f.puts("    end")
         f.puts("  end")
         f.puts("end")
       end
@@ -399,7 +397,7 @@ namespace :docs do
   end
 
   def generate_yard_registry
-    ENV["SKIP_STORYBOOK_PRELOAD"] = "1"
+    ENV["RAILS_ENV"] = "test"
     require File.expand_path("./../../demo/config/environment.rb", __dir__)
     require "primer/view_components"
     require "yard/docs_helper"
@@ -465,7 +463,7 @@ namespace :docs do
       component_id: short_name.underscore,
       status: status.capitalize,
       source: source_url(component),
-      storybook: storybook_url(component),
+      lookbook: lookbook_url(component),
       path: "docs/content/components/#{status_path}#{short_name.downcase}.md",
       example_path: example_path(component),
       require_js_path: require_js_path(component)
@@ -478,10 +476,16 @@ namespace :docs do
     "https://github.com/primer/view_components/tree/main/app/components/#{path}.rb"
   end
 
-  def storybook_url(component)
-    path = component.name.split("::").map { |n| n.underscore.dasherize }.join("-")
+  def lookbook_url(component)
+    path = component.name.underscore.gsub("_component", "")
 
-    "https://primer.style/view-components/stories/?path=/story/#{path}"
+    "https://primer.style/view-components/lookbook/inspect/#{path}/default/"
+  end
+
+  def preview_exists?(component)
+    path = component.name.underscore
+
+    File.exist?("test/previews/#{path}_preview.rb")
   end
 
   def example_path(component)

data/lib/tasks/static.rake

@@ -2,7 +2,7 @@
 
 namespace :static do
   task :dump do
-    ENV["SKIP_STORYBOOK_PRELOAD"] = "1"
+    ENV["RAILS_ENV"] = "test"
     require File.expand_path("./../../demo/config/environment.rb", __dir__)
     require "primer/view_components"
     # Loads all components for `.descendants` to work properly

data/lib/tasks/test.rake

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "rake/testtask"
+
+namespace :test do
+  desc "Run all tests"
+  task all: [:fast, :system]
+
+  Rake::TestTask.new(:single) do |t|
+    ENV["TZ"] = "Asia/Taipei"
+
+    t.libs << "test"
+    t.libs << "lib"
+    t.test_files = FileList[ENV["TESTS"]]
+  end
+
+  Rake::TestTask.new(:fast) do |t|
+    ENV["TZ"] = "Asia/Taipei"
+
+    t.libs << "test"
+    t.libs << "lib"
+    t.test_files = FileList[
+      "test/components/**/*_test.rb",
+      "test/lib/**/*_test.rb",
+      "test/primer/**/*_test.rb",
+      "test/linters/**/*_test.rb",
+      "test/rubocop/**/*_test.rb"
+    ]
+  end
+
+  Rake::TestTask.new(:system) do |t|
+    ENV["TZ"] = "Asia/Taipei"
+
+    t.libs << "test"
+    t.libs << "lib"
+    t.test_files = FileList["test/system/**/*_test.rb", "test/previews/**/*_test.rb"]
+  end
+
+  Rake::TestTask.new(:bench) do |t|
+    t.libs << "test"
+    t.test_files = FileList["test/benchmarks/**/bench_*.rb"]
+    t.verbose = true
+  end
+end
+
+task :test do
+  if ENV["TESTS"]
+    Rake::Task["test:single"].invoke
+  else
+    Rake::Task["test:all"].invoke
+  end
+end
+
+task bench: "test:bench"

data/lib/tasks/utilities.rake

@@ -4,6 +4,7 @@ namespace :utilities do
   task :build do
     require "yaml"
     require "json"
+    ENV["RAILS_ENV"] = "test"
     require File.expand_path("./../../demo/config/environment.rb", __dir__)
     require "primer/classify/utilities"