primer_view_components 0.0.78 → 0.0.81

data/app/components/primer/blankslate_component.html.erb

@@ -5,7 +5,7 @@
   <% elsif @icon.present? %>
     <%= primer_octicon @icon, size: @icon_size, classes: "blankslate-icon" %>
   <% elsif @image_src.present? && @image_alt.present? %>
-    <%= image_tag "#{@image_src}", class: "mb-3", size: "56x56", alt: "#{@image_alt}" %>
+    <%= image_tag @image_src.to_s, class: "mb-3", size: "56x56", alt: @image_alt.to_s %>
   <% end %>
 
   <% if @title.present? %>
@@ -24,7 +24,7 @@
 
   <% if @link_text.present? && @link_url.present? %>
     <p>
-      <%= link_to "#{@link_url}" do %><%= @link_text %><% end %>
+      <%= link_to @link_url.to_s do %><%= @link_text %><% end %>
     </p>
   <% end %>
 <% end %>

data/app/components/primer/button_component.rb

@@ -65,12 +65,10 @@ module Primer
     renders_one :tooltip, lambda { |**system_arguments|
       raise ArgumentError, "Buttons with a tooltip must have a unique `id` set on the `Button`." if @id.blank? && !Rails.env.production?
 
-      @system_arguments = system_arguments
-
-      @system_arguments[:for_id] = @id
-      @system_arguments[:type] ||= :description
+      system_arguments[:for_id] = @id
+      system_arguments[:type] ||= :description
 
-      Primer::Alpha::Tooltip.new(**@system_arguments)
+      Primer::Alpha::Tooltip.new(**system_arguments)
     }
 
     # @example Schemes

data/app/components/primer/link_component.rb

@@ -24,12 +24,10 @@ module Primer
     renders_one :tooltip, lambda { |**system_arguments|
       raise ArgumentError, "Links with a tooltip must have a unique `id` set on the `LinkComponent`." if @id.blank? && !Rails.env.production?
 
-      @system_arguments = system_arguments
-
-      @system_arguments[:for_id] = @id
-      @system_arguments[:type] ||= :description
+      system_arguments[:for_id] = @id
+      system_arguments[:type] ||= :description
 
-      Primer::Alpha::Tooltip.new(**@system_arguments)
+      Primer::Alpha::Tooltip.new(**system_arguments)
     }
 
     # @example Default

data/app/components/primer/octicon_component.rb

@@ -8,10 +8,12 @@ module Primer
   class OcticonComponent < Primer::Component
     status :beta
 
+    SIZE_XSMALL = :xsmall
     SIZE_DEFAULT = :small
     SIZE_MEDIUM = :medium
 
     SIZE_MAPPINGS = {
+      SIZE_XSMALL => 12,
       SIZE_DEFAULT => 16,
       SIZE_MEDIUM => 24
     }.freeze

data/lib/primer/view_components/linters/disallow_action_list.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+require "pathname"
+require_relative "helpers/rubocop_helpers"
+
+module ERBLint
+  module Linters
+    # Finds usages of ActionList CSS classes.
+    class DisallowActionList < Linter
+      include ERBLint::LinterRegistry
+      include TagTreeHelpers
+
+      class ConfigSchema < LinterConfig
+        property :ignore_files, accepts: array_of?(String), default: -> { [] }
+      end
+      self.config_schema = ConfigSchema
+
+      def run(processed_source)
+        return if ignored?(processed_source.filename)
+
+        class_regex = /ActionList[\w-]*/
+        tags, * = build_tag_tree(processed_source)
+
+        tags.each do |tag|
+          next if tag.closing?
+
+          classes =
+            if (class_attrib = tag.attributes["class"])
+              loc = class_attrib.value_node.loc
+              loc.source_buffer.source[loc.begin_pos...loc.end_pos]
+            else
+              ""
+            end
+
+          indices = [].tap do |results|
+            classes.scan(class_regex) do
+              results << Regexp.last_match.offset(0)
+            end
+          end
+
+          next if indices.empty?
+
+          indices.each do |(start_idx, end_idx)|
+            new_loc = class_attrib.value_node.loc.with(
+              begin_pos: class_attrib.value_node.loc.begin_pos + start_idx,
+              end_pos: class_attrib.value_node.loc.begin_pos + end_idx
+            )
+
+            add_offense(
+              new_loc,
+              "ActionList classes are only designed to be used by Primer View Components and " \
+                "should be considered private. Please reach out in the #primer-rails Slack channel."
+            )
+          end
+        end
+      end
+
+      private
+
+      def ignored?(filename)
+        filename = Pathname(filename)
+
+        begin
+          filename = filename.relative_path_from(Pathname(Dir.getwd))
+        rescue ArgumentError
+          # raised if the filename does not have Dir.getwd as a prefix
+        end
+
+        @config.ignore_files.any? { |pattern| filename.fnmatch?(pattern) }
+      end
+    end
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 78
+      PATCH = 81
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

data/lib/rubocop/config/default.yml

@@ -1,9 +1,33 @@
 require:
   - rubocop/cop/primer
+  - rubocop-rails
 
-AllCops:
-  DisabledByDefault: true
+####### RUBOCOP'S DEFAULTS #######
+# we don't want these in .erb files
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# lots of false-positives in .erb files
+Layout/InitialIndentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# lots of false-positives - this cop is meant for Ruby code, not .erb
+Layout/TrailingEmptyLines:
+  Enabled: false
+
+# it's often not desirable to add unnecessary newlines into .erb files, as
+# they will appear in the rendered HTML
+Layout/LineLength:
+  Enabled: false
+
+# calling .html_safe in templates is ok
+Rails/OutputSafety:
+  Enabled: false
 
+####### PRIMER COPS #######
 Primer/SystemArgumentInsteadOfClass:
   Enabled: true
 

data/lib/rubocop/cop/primer/deprecated_arguments.rb

@@ -33,22 +33,6 @@ module RuboCop
         # }
         #
         DEPRECATED = {
-          is_label_inline: {
-            true => nil,
-            false => nil
-          },
-          with_icon: {
-            true => nil,
-            false => nil
-          },
-          is_label_visible: {
-            false => "visually_hide_label: true",
-            true => "visually_hide_label: false"
-          },
-          is_clearable: {
-            false => "show_clear_button: false",
-            true => "show_clear_button: true"
-          },
           bg: {
             white: "bg: :primary",
             gray_light: "bg: :secondary",

data/static/arguments.yml

@@ -885,7 +885,7 @@
   - name: size
     type: Symbol
     default: "`:small`"
-    description: One of `:small` (`16`) and `:medium` (`24`).
+    description: One of `:xsmall` (`12`), `:small` (`16`), or `:medium` (`24`).
   - name: use_symbol
     type: Boolean
     default: "`false`"

data/static/constants.json

@@ -644,14 +644,17 @@
   "Primer::OcticonComponent": {
     "SIZE_DEFAULT": "small",
     "SIZE_MAPPINGS": {
+      "xsmall": 12,
       "small": 16,
       "medium": 24
     },
     "SIZE_MEDIUM": "medium",
     "SIZE_OPTIONS": [
+      "xsmall",
       "small",
       "medium"
-    ]
+    ],
+    "SIZE_XSMALL": "xsmall"
   },
   "Primer::OcticonSymbolsComponent": {
   },

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.78
+  version: 0.0.81
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-08 00:00:00.000000000 Z
+date: 2022-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -536,6 +536,7 @@ files:
 - lib/primer/view_components/linters/button_component_migration_counter.rb
 - lib/primer/view_components/linters/clipboard_copy_component_migration_counter.rb
 - lib/primer/view_components/linters/close_button_component_migration_counter.rb
+- lib/primer/view_components/linters/disallow_action_list.rb
 - lib/primer/view_components/linters/flash_migration_counter.rb
 - lib/primer/view_components/linters/helpers/rubocop_helpers.rb
 - lib/primer/view_components/linters/label_component_migration_counter.rb
@@ -594,7 +595,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: ViewComponents for the Primer Design System