primer_view_components 0.0.66 → 0.0.69

data/app/components/primer/alpha/tooltip.ts

@@ -0,0 +1,377 @@
+import type {AnchorAlignment, AnchorSide} from '@primer/behaviors'
+import {getAnchoredPosition} from '@primer/behaviors'
+
+const TOOLTIP_OPEN_CLASS = 'tooltip-open'
+
+type Direction = 'n' | 's' | 'e' | 'w' | 'ne' | 'se' | 'nw' | 'sw'
+
+const DIRECTION_CLASSES = [
+  'tooltip-n',
+  'tooltip-s',
+  'tooltip-e',
+  'tooltip-w',
+  'tooltip-ne',
+  'tooltip-se',
+  'tooltip-nw',
+  'tooltip-sw'
+]
+
+class TooltipElement extends HTMLElement {
+  styles() {
+    return `
+      :host {
+        position: absolute;
+        z-index: 1000000;
+        padding: .5em .75em;
+        font: normal normal 11px/1.5 -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji";
+        -webkit-font-smoothing: subpixel-antialiased;
+        color: var(--color-fg-on-emphasis);
+        text-align: center;
+        text-decoration: none;
+        text-shadow: none;
+        text-transform: none;
+        letter-spacing: normal;
+        word-wrap: break-word;
+        white-space: pre;
+        background: var(--color-neutral-emphasis-plus);
+        border-radius: 6px;
+        opacity: 0;
+        max-width: 250px;
+        word-wrap: break-word;
+        white-space: normal
+      }
+      
+      :host:before{
+        position: absolute;
+        z-index: 1000001;
+        color: var(--color-neutral-emphasis-plus);
+        content: "";
+        border: 6px solid transparent;
+        opacity: 0
+      }
+      
+      @keyframes tooltip-appear {
+        from {
+          opacity: 0
+        }
+        to {
+          opacity: 1
+        }
+      }
+      
+      :host:after{
+        position: absolute;
+        display: block;
+        right: 0;
+        left: 0;
+        height: 12px;
+        content: ""
+      }
+      
+      :host(.${TOOLTIP_OPEN_CLASS}),
+      :host(.${TOOLTIP_OPEN_CLASS}):before {
+        animation-name: tooltip-appear;
+        animation-duration: .1s;
+        animation-fill-mode: forwards;
+        animation-timing-function: ease-in;
+        animation-delay: .4s
+      }
+      
+      :host(.tooltip-s):before,
+      :host(.tooltip-se):before,
+      :host(.tooltip-sw):before {
+        right: 50%;
+        bottom: 100%;
+        margin-right: -6px;
+        border-bottom-color: var(--color-neutral-emphasis-plus)
+      }
+      
+      :host(.tooltip-s):after,
+      :host(.tooltip-se):after,
+      :host(.tooltip-sw):after {
+        bottom: 100%
+      }
+      
+      :host(.tooltip-n):before,
+      :host(.tooltip-ne):before,
+      :host(.tooltip-nw):before {
+        top: 100%;
+        right: 50%;
+        margin-right: -6px;
+        border-top-color: var(--color-neutral-emphasis-plus)
+      }
+      
+      :host(.tooltip-n):after,
+      :host(.tooltip-ne):after,
+      :host(.tooltip-nw):after {
+        top: 100%
+      }
+      
+      :host(.tooltip-se):before,
+      :host(.tooltip-ne):before {
+        right: auto
+      }
+      
+      :host(.tooltip-sw):before,
+      :host(.tooltip-nw):before {
+        right: 0;
+        margin-right: 6px
+      }
+      
+      :host(.tooltip-w):before {
+        top: 50%;
+        bottom: 50%;
+        left: 100%;
+        margin-top: -6px;
+        border-left-color: var(--color-neutral-emphasis-plus)
+      }
+      
+      :host(.tooltip-e):before {
+        top: 50%;
+        right: 100%;
+        bottom: 50%;
+        margin-top: -6px;
+        border-right-color: var(--color-neutral-emphasis-plus)
+      }
+    `
+  }
+
+  #abortController: AbortController | undefined
+  #align: AnchorAlignment = 'center'
+  #side: AnchorSide = 'outside-bottom'
+  #allowUpdatePosition = false
+
+  get htmlFor(): string {
+    return this.getAttribute('for') || ''
+  }
+
+  set htmlFor(value: string) {
+    this.setAttribute('for', value)
+  }
+
+  get type(): 'description' | 'label' {
+    const type = this.getAttribute('data-type')
+    return type === 'label' ? 'label' : 'description'
+  }
+
+  set type(value: 'description' | 'label') {
+    this.setAttribute('data-type', value)
+  }
+
+  get direction(): Direction {
+    return (this.getAttribute('data-direction') || 's') as Direction
+  }
+
+  set direction(value: Direction) {
+    this.setAttribute('data-direction', value)
+  }
+
+  get control(): HTMLElement | null {
+    return this.ownerDocument.getElementById(this.htmlFor)
+  }
+
+  constructor() {
+    super()
+    const shadow = this.attachShadow({mode: 'open'})
+    shadow.innerHTML = `
+      <style>
+        ${this.styles()}
+      </style>
+      <slot></slot>
+    `
+  }
+
+  connectedCallback() {
+    this.hidden = true
+    this.#allowUpdatePosition = true
+
+    if (!this.id) {
+      this.id = `tooltip-${Date.now()}-${(Math.random() * 10000).toFixed(0)}`
+    }
+
+    if (!this.control) return
+
+    this.setAttribute('role', 'tooltip')
+
+    this.#abortController?.abort()
+    this.#abortController = new AbortController()
+    const {signal} = this.#abortController
+
+    this.addEventListener('mouseleave', this, {signal})
+    this.control.addEventListener('mouseenter', this, {signal})
+    this.control.addEventListener('mouseleave', this, {signal})
+    this.control.addEventListener('focus', this, {signal})
+    this.control.addEventListener('blur', this, {signal})
+    this.ownerDocument.addEventListener('keydown', this, {signal})
+  }
+
+  disconnectedCallback() {
+    this.#abortController?.abort()
+  }
+
+  handleEvent(event: Event) {
+    if (!this.control) return
+
+    // Ensures that tooltip stays open when hovering between tooltip and element
+    // WCAG Success Criterion 1.4.13 Hoverable
+    if ((event.type === 'mouseenter' || event.type === 'focus') && this.hidden) {
+      this.hidden = false
+    } else if (event.type === 'blur') {
+      this.hidden = true
+    } else if (
+      event.type === 'mouseleave' &&
+      (event as MouseEvent).relatedTarget !== this.control &&
+      (event as MouseEvent).relatedTarget !== this
+    ) {
+      this.hidden = true
+    } else if (event.type === 'keydown' && (event as KeyboardEvent).key === 'Escape' && !this.hidden) {
+      this.hidden = true
+    }
+  }
+
+  static observedAttributes = ['data-type', 'data-direction', 'id', 'hidden']
+
+  attributeChangedCallback(name: string) {
+    if (name === 'id' || name === 'data-type') {
+      if (!this.id || !this.control) return
+      if (this.type === 'label') {
+        this.control.setAttribute('aria-labelledby', this.id)
+      } else {
+        let describedBy = this.control.getAttribute('aria-describedby')
+        describedBy ? (describedBy = `${describedBy} ${this.id}`) : (describedBy = this.id)
+        this.control.setAttribute('aria-describedby', describedBy)
+      }
+    } else if (name === 'hidden') {
+      if (this.hidden) {
+        this.classList.remove(TOOLTIP_OPEN_CLASS, ...DIRECTION_CLASSES)
+      } else {
+        this.classList.add(TOOLTIP_OPEN_CLASS)
+        for (const tooltip of this.ownerDocument.querySelectorAll<HTMLElement>(this.tagName)) {
+          if (tooltip !== this) tooltip.hidden = true
+        }
+        this.#updatePosition()
+      }
+    } else if (name === 'data-direction') {
+      this.classList.remove(...DIRECTION_CLASSES)
+      const direction = this.direction
+      if (direction === 'n') {
+        this.#align = 'center'
+        this.#side = 'outside-top'
+      } else if (direction === 'ne') {
+        this.#align = 'start'
+        this.#side = 'outside-top'
+      } else if (direction === 'e') {
+        this.#align = 'center'
+        this.#side = 'outside-right'
+      } else if (direction === 'se') {
+        this.#align = 'start'
+        this.#side = 'outside-bottom'
+      } else if (direction === 's') {
+        this.#align = 'center'
+        this.#side = 'outside-bottom'
+      } else if (direction === 'sw') {
+        this.#align = 'end'
+        this.#side = 'outside-bottom'
+      } else if (direction === 'w') {
+        this.#align = 'center'
+        this.#side = 'outside-left'
+      } else if (direction === 'nw') {
+        this.#align = 'end'
+        this.#side = 'outside-top'
+      }
+    }
+  }
+
+  // `getAnchoredPosition` may calibrate `anchoredSide` but does not recalibrate `align`.
+  //  Therefore, we need to determine which `align` is best based on the initial `getAnchoredPosition` calcluation.
+  //  Related: https://github.com/primer/behaviors/issues/63
+  #adjustedAnchorAlignment(anchorSide: AnchorSide): AnchorAlignment | undefined {
+    if (!this.control) return
+
+    const tooltipPosition = this.getBoundingClientRect()
+    const targetPosition = this.control.getBoundingClientRect()
+    const tooltipWidth = tooltipPosition.width
+
+    const tooltipCenter = tooltipPosition.left + tooltipWidth / 2
+    const targetCenter = targetPosition.x + targetPosition.width / 2
+
+    if (Math.abs(tooltipCenter - targetCenter) < 2 || anchorSide === 'outside-left' || anchorSide === 'outside-right') {
+      return 'center'
+    } else if (tooltipPosition.left === targetPosition.left) {
+      return 'start'
+    } else if (tooltipPosition.right === targetPosition.right) {
+      return 'end'
+    } else if (tooltipCenter < targetCenter) {
+      if (tooltipPosition.left === 0) return 'start'
+      return 'end'
+    } else {
+      if (tooltipPosition.right === 0) return 'end'
+      return 'start'
+    }
+  }
+
+  #updatePosition() {
+    if (!this.control) return
+    if (!this.#allowUpdatePosition || this.hidden) return
+
+    const TOOLTIP_OFFSET = 10
+
+    this.style.left = `0px` // Ensures we have reliable tooltip width in `getAnchoredPosition`
+    let position = getAnchoredPosition(this, this.control, {
+      side: this.#side,
+      align: this.#align,
+      anchorOffset: TOOLTIP_OFFSET
+    })
+    let anchorSide = position.anchorSide
+
+    // We need to set tooltip position in order to determine ideal align.
+    this.style.top = `${position.top}px`
+    this.style.left = `${position.left}px`
+    let direction: Direction = 's'
+
+    const align = this.#adjustedAnchorAlignment(anchorSide)
+    if (!align) return
+
+    this.style.left = `0px` // Reset tooltip position again to ensure accurate width in `getAnchoredPosition`
+    position = getAnchoredPosition(this, this.control, {side: anchorSide, align, anchorOffset: TOOLTIP_OFFSET})
+    anchorSide = position.anchorSide
+
+    this.style.top = `${position.top}px`
+    this.style.left = `${position.left}px`
+
+    if (anchorSide === 'outside-left') {
+      direction = 'w'
+    } else if (anchorSide === 'outside-right') {
+      direction = 'e'
+    } else if (anchorSide === 'outside-top') {
+      if (align === 'center') {
+        direction = 'n'
+      } else if (align === 'start') {
+        direction = 'ne'
+      } else {
+        direction = 'nw'
+      }
+    } else {
+      if (align === 'center') {
+        direction = 's'
+      } else if (align === 'start') {
+        direction = 'se'
+      } else {
+        direction = 'sw'
+      }
+    }
+
+    this.classList.add(`tooltip-${direction}`)
+  }
+}
+
+if (!window.customElements.get('tool-tip')) {
+  window.TooltipElement = TooltipElement
+  window.customElements.define('tool-tip', TooltipElement)
+}
+
+declare global {
+  interface Window {
+    TooltipElement: typeof TooltipElement
+  }
+}

data/app/components/primer/base_component.rb

@@ -5,7 +5,7 @@ require "primer/classify"
 module Primer
   # All Primer ViewComponents accept a standard set of options called system arguments, mimicking the [styled-system API](https://styled-system.com/table) used by [Primer React](https://primer.style/components/system-props).
   #
-  # Under the hood, system arguments are [mapped](https://github.com/primer/view_components/blob/main/app/lib/primer/classify.rb) to Primer CSS classes, with any remaining options passed to Rails' [`content_tag`](https://api.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag).
+  # Under the hood, system arguments are [mapped](https://github.com/primer/view_components/blob/main/lib/primer/classify.rb) to Primer CSS classes, with any remaining options passed to Rails' [`content_tag`](https://api.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag).
   #
   # ## Responsive values
   #
@@ -85,7 +85,7 @@ module Primer
     #
     # | Name | Type | Description |
     # | :- | :- | :- |
-    # | `clearfix` | Boolean | Wether to assign the `clearfix` class. |
+    # | `clearfix` | Boolean | Whether to assign the `clearfix` class. |
     # | `col` | Integer | Number of columns. <%= one_of(Primer::Classify::Utilities.mappings(:col)) %> |
     # | `container` | Symbol | Size of the container. <%= one_of(Primer::Classify::Utilities.mappings(:container)) %> |
     #

data/app/components/primer/beta/auto_complete/auto_complete.html.erb

@@ -1,6 +1,14 @@
-<%= label %>
 <%= render Primer::BaseComponent.new(**@system_arguments) do %>
-  <%= input %>
-  <%= icon %>
+  <label for="<%= @input_id %>">
+    <% if @is_label_visible %>
+      <%= @label_text %>
+    <% else %>
+      <span class="sr-only"><%= @label_text %></span>
+    <% end %>
+    <% if icon.present? %>
+      <%= icon %>
+    <% end %>
+  </label>
+  <input id="<%= @input_id %>" name="<%= @input_id %>" type="text" class="form-control" autocomplete="off">
   <%= results %>
 <% end %>

data/app/components/primer/beta/auto_complete.rb

@@ -7,41 +7,14 @@ module Primer
     # @accessibility
     #   Always set an accessible label to help the user interact with the component.
     #
-    #   * Set the `label` slot to render a visible label. Alternatively, associate an existing visible text element
-    #   as a label by setting `aria-labelledby`.
-    #   * If you must use a non-visible label, set `:"aria-label"` on `AutoComplete` and Primer
-    #   will apply it to the correct elements. However, please note that a visible label should almost
-    #   always be used unless there is compelling reason not to. A placeholder is not a label.
+    #   * `label_text` is required and visible by default.
+    #   * If you must use a non-visible label, set `is_label_visible` to `false`.
+    #   However, please note that a visible label should almost always
+    #   be used unless there is compelling reason not to. A placeholder is not a label.
     class AutoComplete < Primer::Component
       status :beta
 
-      # Optionally render a visible label. See <%= link_to_accessibility %>
-      #
-      # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      renders_one :label, lambda { |**system_arguments|
-        deny_tag_argument(**system_arguments)
-        system_arguments[:for] = @input_id
-        system_arguments[:tag] = :label
-        Primer::BaseComponent.new(**system_arguments)
-      }
-
-      # Required input used to search for results
-      #
-      # @param type [Symbol] <%= one_of(Primer::Beta::AutoComplete::Input::TYPE_OPTIONS) %>
-      # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      renders_one :input, lambda { |**system_arguments|
-        aria_label = aria("label", system_arguments) || @aria_label
-        if aria_label.present?
-          system_arguments[:"aria-label"] = aria_label
-          system_arguments[:aria]&.delete(:label)
-        end
-
-        name = system_arguments[:name] || @input_id
-        Input.new(id: @input_id, name: name, **system_arguments)
-      }
-
       # Optional icon to be rendered before the input. Has the same arguments as <%= link_to_component(Primer::OcticonComponent) %>.
-      #
       renders_one :icon, Primer::OcticonComponent
 
       # Customizable results list.
@@ -56,34 +29,17 @@ module Primer
           system_arguments[:classes]
         )
 
-        aria_label = system_arguments[:"aria-label"] || system_arguments.dig(:aria, :label) || @aria_label
-        system_arguments[:"aria-label"] = aria_label if aria_label.present?
-        system_arguments[:aria]&.delete(:label)
-
         Primer::BaseComponent.new(**system_arguments)
       }
 
       # @example Default
-      #   <%= render(Primer::Beta::AutoComplete.new(src: "/auto_complete", input_id: "fruits-input-1", list_id: "fruits-popup-1", position: :relative)) do |c| %>
-      #     <% c.label(classes:"").with_content("Fruits") %>
-      #     <% c.input(type: :text) %>
-      #   <% end %>
+      #   <%= render(Primer::Beta::AutoComplete.new(label_text: "Fruits", src: "/auto_complete", input_id: "fruits-input-1", list_id: "fruits-popup-1", position: :relative)) %>
       #
-      # @example With `aria-label`
-      #   <%= render(Primer::Beta::AutoComplete.new("aria-label": "Fruits", src: "/auto_complete", input_id: "fruits-input-2", list_id: "fruits-popup-2", position: :relative)) do |c| %>
-      #     <% c.input(type: :text) %>
-      #   <% end %>
-      #
-      # @example With `aria-labelledby`
-      #   <%= render(Primer::HeadingComponent.new(tag: :h2, id: "search-1")) { "Search" } %>
-      #   <%= render(Primer::Beta::AutoComplete.new(src: "/auto_complete", input_id: "fruits-input-3", list_id: "fruits-popup-2", position: :relative)) do |c| %>
-      #     <% c.input("aria-labelledby": "search-1") %>
-      #   <% end %>
+      # @example With Non-Visible Label
+      #   <%= render(Primer::Beta::AutoComplete.new(label_text: "Fruits", src: "/auto_complete", input_id: "fruits-input-2", list_id: "fruits-popup-2", is_label_visible: false, position: :relative)) %>
       #
-      # @example With custom classes for the results
-      #   <%= render(Primer::Beta::AutoComplete.new(src: "/auto_complete", input_id: "fruits-input-4", list_id: "fruits-popup-3", position: :relative)) do |c| %>
-      #     <% c.label(classes:"").with_content("Fruits") %>
-      #     <% c.input(type: :text) %>
+      # @example With Custom Classes for the Results
+      #   <%= render(Primer::Beta::AutoComplete.new(label_text: "Fruits", src: "/auto_complete", input_id: "fruits-input-3", list_id: "fruits-popup-3", position: :relative)) do |c| %>
       #     <% c.results(classes: "custom-class") do %>
       #       <%= render(Primer::Beta::AutoComplete::Item.new(selected: true, value: "apple")) do |c| %>
       #         Apple
@@ -95,22 +51,25 @@ module Primer
       #   <% end %>
       #
       # @example With Icon
-      #   <%= render(Primer::Beta::AutoComplete.new(src: "/auto_complete", list_id: "fruits-popup-4", input_id: "fruits-input-4", position: :relative)) do |c| %>
-      #     <% c.label(classes:"").with_content("Fruits") %>
-      #     <% c.input(type: :text) %>
+      #   <%= render(Primer::Beta::AutoComplete.new(label_text: "Fruits", src: "/auto_complete", list_id: "fruits-popup-4", input_id: "fruits-input-4", position: :relative)) do |c| %>
       #     <% c.icon(icon: :search) %>
       #   <% end %>
       #
+      # @example With Icon and Non-Visible Label
+      #   <%= render(Primer::Beta::AutoComplete.new(label_text: "Fruits", src: "/auto_complete", list_id: "fruits-popup-5", input_id: "fruits-input-5", is_label_visible: false, position: :relative)) do |c| %>
+      #     <% c.icon(icon: :search) %>
+      #   <% end %>
+      # @param label_text [String] The label of the input.
       # @param src [String] The route to query.
       # @param input_id [String] Id of the input element.
       # @param list_id [String] Id of the list element.
+      # @param is_label_visible [Boolean] Controls if the label is visible. If `false`, screen reader only text will be added.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-      def initialize(src:, list_id:, input_id:, **system_arguments)
+      def initialize(label_text:, src:, list_id:, input_id:, is_label_visible: true, **system_arguments)
+        @label_text = label_text
         @list_id = list_id
         @input_id = input_id
-        @aria_label = aria("label", system_arguments)
-
-        system_arguments.delete(:"aria-label") && system_arguments[:aria]&.delete(:label)
+        @is_label_visible = is_label_visible
 
         @system_arguments = deny_tag_argument(**system_arguments)
         @system_arguments[:tag] = "auto-complete"
@@ -118,44 +77,10 @@ module Primer
         @system_arguments[:for] = list_id
       end
 
-      # add `results` without needing to explicitly call it in the view
+      # add `results` without needing to explicitly call them in the view
       def before_render
-        raise ArgumentError, "Missing `input` slot" if input.blank?
-        raise ArgumentError, "Accessible label is required." if label.blank? && input.missing_label?
-
         results(classes: "") unless results
       end
-
-      # This component is part of `Primer::Beta::AutoCompleteComponent` and should not be
-      # used as a standalone component.
-      class Input < Primer::Component
-        DEFAULT_TYPE = :text
-        TYPE_OPTIONS = [DEFAULT_TYPE, :search].freeze
-
-        # @param type [Symbol] <%= one_of(Primer::Beta::AutoComplete::Input::TYPE_OPTIONS) %>
-        # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
-        def initialize(type: DEFAULT_TYPE, **system_arguments)
-          @system_arguments = deny_tag_argument(**system_arguments)
-          @system_arguments[:tag] = :input
-
-          @aria_label = system_arguments[:"aria-label"]
-          @aria_labelledby = system_arguments[:"aria-labelledby"] || system_arguments.dig(:aria, :labelledby)
-
-          @system_arguments[:type] = fetch_or_fallback(TYPE_OPTIONS, type, DEFAULT_TYPE)
-          @system_arguments[:classes] = class_names(
-            "form-control",
-            system_arguments[:classes]
-          )
-        end
-
-        def missing_label?
-          @aria_label.blank? && @aria_labelledby.blank?
-        end
-
-        def call
-          render(Primer::BaseComponent.new(**@system_arguments))
-        end
-      end
     end
   end
 end

data/app/components/primer/beta/blankslate.html.erb

@@ -5,9 +5,13 @@
     <%= heading %>
     <%= description %>
 
-    <%= primary_action %>
+    <% if primary_action.present? %>
+      <div class="blankslate-action">
+        <%= primary_action %>
+      </div>
+    <% end %>
     <% if secondary_action.present? %>
-      <div class="mt-3">
+      <div class="blankslate-action">
         <%= secondary_action %>
       </div>
     <% end %>

data/app/components/primer/beta/blankslate.rb

@@ -5,9 +5,11 @@ module Primer
     # Use `Blankslate` when there is a lack of content within a page or section. Use as placeholder to tell users why something isn't there.
     #
     # @accessibility
-    #   - Set the `heading` level based on what is appropriate for your page hierarchy. <%= link_to_heading_practices %>
-    #   - `secondary_action` can be set to provide more information that is relevant in the context of the `Blankslate`.
+    #   - The blankslate uses a semantic heading that must be set at the appropriate level based on the hierarchy of the page.
+    #   - All blankslate visuals have been programmed as decorative images, using `aria-hidden=”true”` and `img alt=””`,  which will hide the visual from screen reader users.
+    #   - The blankslate supports a primary and secondary action. Both actions have been built as semantic links with primary and secondary styling.
     #   - `secondary_action` text should be meaningful out of context and clearly describe the destination. Avoid using vague text like, "Learn more" or "Click here".
+    #   - The blankslate can leverage the spinner component, which will communicate to screen reader users that the content is still loading.
     class Blankslate < Primer::Component
       status :beta
 
@@ -24,20 +26,19 @@ module Primer
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :visual, types: {
         icon: lambda { |**system_arguments|
-          system_arguments[:mb] = 3
           system_arguments[:size] ||= :medium
           system_arguments[:classes] = class_names("blankslate-icon", system_arguments[:classes])
 
           Primer::OcticonComponent.new(**system_arguments)
         },
         spinner: lambda { |**system_arguments|
-          system_arguments[:mb] = 3
+          system_arguments[:classes] = class_names("blankslate-image", system_arguments[:classes])
 
           Primer::SpinnerComponent.new(**system_arguments)
         },
         image: lambda { |**system_arguments|
-          system_arguments[:mb] = 3
           system_arguments[:size] = "56x56"
+          system_arguments[:classes] = class_names("blankslate-image", system_arguments[:classes])
 
           Primer::Image.new(**system_arguments)
         }
@@ -50,8 +51,7 @@ module Primer
       renders_one :heading, lambda { |tag:, **system_arguments|
         deny_tag_argument(**system_arguments)
         system_arguments[:tag] = tag
-        system_arguments[:mb] = 1
-        system_arguments[:classes] = class_names("h2", system_arguments[:classes])
+        system_arguments[:classes] = class_names("blankslate-heading", system_arguments[:classes])
 
         Primer::HeadingComponent.new(**system_arguments)
       }
@@ -64,7 +64,7 @@ module Primer
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :description, lambda { |**system_arguments|
         deny_tag_argument(**system_arguments)
-        system_arguments[:tag] = :div
+        system_arguments[:tag] = :p
 
         Primer::BaseComponent.new(**system_arguments)
       }
@@ -80,7 +80,6 @@ module Primer
         deny_tag_argument(**system_arguments)
         system_arguments[:tag] = :a
         system_arguments[:href] = href
-        system_arguments[:mt] = 5
         system_arguments[:size] = :medium
         system_arguments[:scheme] ||= :primary
 
@@ -96,8 +95,6 @@ module Primer
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :secondary_action, lambda { |href:, **system_arguments|
         system_arguments[:href] = href
-        # Padding is needed to increase touch area.
-        system_arguments[:p] = 3
 
         Primer::LinkComponent.new(**system_arguments)
       }

data/app/components/primer/beta/truncate.rb

@@ -92,6 +92,7 @@ module Primer
           @system_arguments[:tag] = system_arguments[:tag] || :span
           @system_arguments[:classes] = class_names(
             "Truncate-text",
+            system_arguments[:classes],
             "Truncate-text--primary": priority,
             "Truncate-text--expandable": expandable
           )