primer_view_components 0.0.49 → 0.0.53

data/lib/rubocop/cop/primer/system_argument_instead_of_class.rb

@@ -3,7 +3,9 @@
 require "rubocop"
 require "primer/classify/utilities"
 require "primer/view_components/statuses"
+require_relative "../../../../app/lib/primer/view_helper"
 
+# :nocov:
 module RuboCop
   module Cop
     module Primer
@@ -20,8 +22,7 @@ module RuboCop
         STR
 
         def on_send(node)
-          return unless node.method_name == :new
-          return unless ::Primer::ViewComponents::STATUSES.key?(node.receiver.const_name)
+          return unless valid_node?(node)
           return unless node.arguments?
 
           # we are looking for hash arguments and they are always last
@@ -48,26 +49,21 @@ module RuboCop
 
         def autocorrect(node)
           lambda do |corrector|
-            system_arguments = ::Primer::Classify::Utilities.classes_to_hash(node.value.value)
-            corrector.replace(node.loc.expression, arguments_as_string(system_arguments))
+            args = ::Primer::Classify::Utilities.classes_to_args(node.value.value)
+            corrector.replace(node.loc.expression, args)
           end
         end
 
         private
 
-        def arguments_as_string(system_arguments)
-          system_arguments.map do |key, value|
-            val = case value
-                  when Symbol
-                    ":#{value}"
-                  when String
-                    value.to_json
-                  else
-                    value
-                  end
+        # We only verify SystemArguments if it's a `.new` call on a component or
+        # a ViewHleper call.
+        def valid_node?(node)
+          view_helpers.include?(node.method_name) || (node.method_name == :new && ::Primer::ViewComponents::STATUSES.key?(node.receiver.const_name))
+        end
 
-            "#{key}: #{val}"
-          end.join(", ")
+        def view_helpers
+          ::Primer::ViewHelper::HELPERS.keys.map { |key| "primer_#{key}".to_sym }
         end
       end
     end

data/lib/rubocop/cop/primer.rb

@@ -1,4 +1,3 @@
 # frozen_string_literal: true
 
-require "rubocop/cop/primer/no_tag_memoize"
-require "rubocop/cop/primer/system_argument_instead_of_class"
+Dir[File.join(__dir__, "primer", "*.rb")].sort.each { |file| require file }

data/lib/tasks/coverage.rake

@@ -9,6 +9,10 @@ namespace :coverage do
 
     SimpleCov.collate Dir["simplecov-resultset-*/.resultset.json"], "rails" do
       formatter SimpleCov::Formatter::Console
+
+      add_group "Ignored Code" do |src_file|
+        File.readlines(src_file.filename).grep(/:nocov:/).any?
+      end
     end
   end
 end

data/lib/tasks/docs.rake

@@ -74,6 +74,7 @@ namespace :docs do
       Primer::TimelineItemComponent,
       Primer::Tooltip,
       Primer::Truncate,
+      Primer::Beta::Truncate,
       Primer::UnderlineNavComponent
     ]
 
@@ -238,7 +239,7 @@ namespace :docs do
           f.puts
           html = view_context.render(inline: code)
           html.scan(/class="([^"]*)"/) do |classnames|
-            classes_found_in_examples.concat(classnames[0].split(" ").reject { |c| c.starts_with?("octicon", "js", "my-") }.map { ".#{_1}"})
+            classes_found_in_examples.concat(classnames[0].split.reject { |c| c.starts_with?("octicon", "js", "my-") }.map { ".#{_1}" })
           end
           f.puts("<Example src=\"#{html.tr('"', "\'").delete("\n")}\" />")
           f.puts
@@ -382,7 +383,7 @@ namespace :docs do
   end
 
   def pretty_default_value(tag, component)
-    params = tag.object.parameters.find { |param| [tag.name.to_s, tag.name.to_s + ":"].include?(param[0]) }
+    params = tag.object.parameters.find { |param| [tag.name.to_s, "#{tag.name}:"].include?(param[0]) }
     default = tag.defaults&.first || params&.second
 
     return "N/A" unless default

data/lib/tasks/utilities.rake

@@ -8,19 +8,23 @@ namespace :utilities do
     require "primer/classify/utilities"
 
     # Keys that are looked for to be included in the utilities.yml file
+    # rubocop:disable Lint/ConstantDefinitionInBlock
     SUPPORTED_KEYS = %i[
       anim
       d
       float
+      height
       hide
       m mt mr mb ml mx my
       p pt pr pb pl px py
       position
       wb
+      width
       v
     ].freeze
 
     BREAKPOINTS = [nil, "sm", "md", "lg", "xl"].freeze
+    # rubocop:enable Lint/ConstantDefinitionInBlock
 
     css_data =
       JSON.parse(
@@ -36,7 +40,7 @@ namespace :utilities do
     css_data.each do |selector|
       selector.sub!(/^./, "")
       # Next if selector has ancestors or sibling selectors
-      next if selector.match?(/[:><~\[\.]/)
+      next if selector.match?(/[:><~\[.]/)
       next unless SUPPORTED_KEYS.any? { |key| selector.start_with?("#{key}-") }
 
       # Dupe so we still have the selector at the end of slicing it up
@@ -48,7 +52,7 @@ namespace :utilities do
         next unless classname.match?(Regexp.new(k))
 
         key = v
-        classname.sub!(Regexp.new(k + "-"), "")
+        classname.sub!(Regexp.new("#{k}-"), "")
       end
 
       # If we didn't find a replacement, grab the first text before hyphen
@@ -64,7 +68,7 @@ namespace :utilities do
       end
 
       # Change the rest from hypens to underscores
-      classname.sub!(/\-/, "_")
+      classname.sub!(/-/, "_")
 
       # convert padding/margin negative values ie n7 to -7
       classname.sub!(/^n/, "-") if classname.match?(/^n[0-9]/)

data/lib/yard/docs_helper.rb

@@ -1,13 +1,16 @@
 # frozen_string_literal: true
 
+# :nocov:
+
 module YARD
   # Helper methods to use for yard documentation
   module DocsHelper
     def one_of(enumerable, lower: false, sort: true)
       # Sort the array if requested
       if sort
-        compare = ->(a, b) { a.class == b.class ? a <=> b : a.class.to_s <=> b.class.to_s }
-        enumerable = enumerable.sort { |a, b| compare.call(a, b) }
+        enumerable = enumerable.sort do |a, b|
+          a.instance_of?(b.class) ? a <=> b : a.class.to_s <=> b.class.to_s
+        end
       end
 
       values =
@@ -58,7 +61,7 @@ module YARD
     def status_module_and_short_name(component)
       name_with_status = component.name.gsub(/Primer::|Component/, "")
 
-      m = name_with_status.match(/(?<status>Beta|Alpha|Deprecated)?(::)?(?<name>.*)/)
+      m = name_with_status.match(/(?<status>Beta|Alpha|Deprecated)?(?<_colons>::)?(?<name>.*)/)
       [m[:status]&.downcase, m[:name].gsub("::", "")]
     end
 

data/static/arguments.yml

@@ -143,6 +143,13 @@
     type: Hash
     default: N/A
     description: "[System arguments](/system-arguments)"
+- component: Truncate
+  source: https://github.com/primer/view_components/tree/main/app/components/primer/beta/truncate.rb
+  parameters:
+  - name: system_arguments
+    type: Hash
+    default: N/A
+    description: "[System arguments](/system-arguments)"
 - component: Blankslate
   source: https://github.com/primer/view_components/tree/main/app/components/primer/blankslate_component.rb
   parameters:
@@ -562,10 +569,6 @@
     type: Symbol
     default: "`:span`"
     description: One of `:a`, `:div`, `:span`, or `:summary`.
-  - name: title
-    type: String
-    default: N/A
-    description: "`title` attribute for the component element."
   - name: scheme
     type: Symbol
     default: "`nil`"

data/static/classes.yml

@@ -10,6 +10,9 @@
 - ".Box-footer"
 - ".Box-header"
 - ".Box-row"
+- ".Box-row--blue"
+- ".Box-row--gray"
+- ".Box-row--yellow"
 - ".BtnGroup"
 - ".BtnGroup-item"
 - ".Counter"
@@ -49,6 +52,10 @@
 - ".TimelineItem-avatar"
 - ".TimelineItem-badge"
 - ".TimelineItem-body"
+- ".Truncate"
+- ".Truncate-text"
+- ".Truncate-text--expandable"
+- ".Truncate-text--primary"
 - ".UnderlineNav"
 - ".UnderlineNav--right"
 - ".UnderlineNav-actions"
@@ -168,6 +175,7 @@
 - ".tabnav-tabs"
 - ".text-bold"
 - ".text-left"
+- ".text-normal"
 - ".tooltipped"
 - ".tooltipped-n"
 - ".tooltipped-no-delay"

data/static/constants.json

@@ -85,16 +85,28 @@
   "Primer::Beta::Text": {
     "DEFAULT_TAG": "span"
   },
+  "Primer::Beta::Truncate": {
+    "TruncateText": "Primer::Beta::Truncate::TruncateText"
+  },
+  "Primer::Beta::Truncate::TruncateText": {
+  },
   "Primer::BlankslateComponent": {
   },
   "Primer::BorderBoxComponent": {
     "DEFAULT_PADDING": "default",
+    "DEFAULT_ROW_SCHEME": "default",
     "PADDING_MAPPINGS": {
       "default": "",
       "condensed": "Box--condensed",
       "spacious": "Box--spacious"
     },
-    "PADDING_SUGGESTION": "Perhaps you could consider using :padding options of default, condensed, and spacious?"
+    "PADDING_SUGGESTION": "Perhaps you could consider using :padding options of default, condensed, and spacious?",
+    "ROW_SCHEME_MAPPINGS": {
+      "default": "",
+      "neutral": "Box-row--gray",
+      "info": "Box-row--blue",
+      "warning": "Box-row--yellow"
+    }
   },
   "Primer::BoxComponent": {
   },

data/static/statuses.json

@@ -8,6 +8,8 @@
   "Primer::Beta::Avatar": "beta",
   "Primer::Beta::AvatarStack": "beta",
   "Primer::Beta::Text": "beta",
+  "Primer::Beta::Truncate": "beta",
+  "Primer::Beta::Truncate::TruncateText": "alpha",
   "Primer::BlankslateComponent": "beta",
   "Primer::BorderBoxComponent": "beta",
   "Primer::BoxComponent": "stable",
@@ -15,7 +17,7 @@
   "Primer::BreadcrumbComponent::ItemComponent": "alpha",
   "Primer::ButtonComponent": "beta",
   "Primer::ButtonGroup": "beta",
-  "Primer::ClipboardCopy": "alpha",
+  "Primer::ClipboardCopy": "beta",
   "Primer::CloseButton": "beta",
   "Primer::CounterComponent": "beta",
   "Primer::DetailsComponent": "beta",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.49
+  version: 0.0.53
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-27 00:00:00.000000000 Z
+date: 2021-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -42,16 +42,16 @@ dependencies:
   name: octicons
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.0.0
+        version: '15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.0.0
+        version: '15'
 - !ruby/object:Gem::Dependency
   name: view_component
   requirement: !ruby/object:Gem::Requirement
@@ -218,14 +218,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '0.82'
+        version: 1.13.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '0.82'
+        version: 1.13.0
 - !ruby/object:Gem::Dependency
   name: rubocop-github
   requirement: !ruby/object:Gem::Requirement
@@ -324,6 +324,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -367,6 +381,8 @@ files:
 - app/components/primer/beta/avatar_stack.html.erb
 - app/components/primer/beta/avatar_stack.rb
 - app/components/primer/beta/text.rb
+- app/components/primer/beta/truncate.html.erb
+- app/components/primer/beta/truncate.rb
 - app/components/primer/blankslate_component.html.erb
 - app/components/primer/blankslate_component.rb
 - app/components/primer/border_box_component.html.erb
@@ -476,6 +492,7 @@ files:
 - lib/primer/classify/grid.rb
 - lib/primer/classify/utilities.rb
 - lib/primer/classify/utilities.yml
+- lib/primer/classify/validation.rb
 - lib/primer/view_components.rb
 - lib/primer/view_components/constants.rb
 - lib/primer/view_components/engine.rb
@@ -483,20 +500,26 @@ files:
 - lib/primer/view_components/linters/argument_mappers/base.rb
 - lib/primer/view_components/linters/argument_mappers/button.rb
 - lib/primer/view_components/linters/argument_mappers/clipboard_copy.rb
+- lib/primer/view_components/linters/argument_mappers/close_button.rb
 - lib/primer/view_components/linters/argument_mappers/conversion_error.rb
+- lib/primer/view_components/linters/argument_mappers/flash.rb
+- lib/primer/view_components/linters/argument_mappers/helpers/erb_block.rb
 - lib/primer/view_components/linters/argument_mappers/label.rb
 - lib/primer/view_components/linters/argument_mappers/system_arguments.rb
 - lib/primer/view_components/linters/autocorrectable.rb
+- lib/primer/view_components/linters/base_linter.rb
 - lib/primer/view_components/linters/button_component_migration_counter.rb
 - lib/primer/view_components/linters/clipboard_copy_component_migration_counter.rb
+- lib/primer/view_components/linters/close_button_component_migration_counter.rb
 - lib/primer/view_components/linters/flash_component_migration_counter.rb
-- lib/primer/view_components/linters/helpers.rb
 - lib/primer/view_components/linters/label_component_migration_counter.rb
 - lib/primer/view_components/statuses.rb
 - lib/primer/view_components/version.rb
 - lib/rubocop/config/default.yml
 - lib/rubocop/cop/primer.rb
+- lib/rubocop/cop/primer/deprecated_arguments.rb
 - lib/rubocop/cop/primer/no_tag_memoize.rb
+- lib/rubocop/cop/primer/primer_octicon.rb
 - lib/rubocop/cop/primer/system_argument_instead_of_class.rb
 - lib/tasks/constants.rake
 - lib/tasks/coverage.rake