primer_view_components 0.0.16 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa20e643699f825d7867ba90c89def4cb5a4718782a55e1c7f7442cf8544732c
-  data.tar.gz: 4f01e3f6a5a2418b9318362820f08c37ad0dcc420aa62d55e12016f7e56b7e88
+  metadata.gz: 70daa13e7909487e01c01f4759a88740922070c985ac9604df738614d48c57a1
+  data.tar.gz: 257383c54d408d94c8aac723804a1db9b75dee88527f60ce101f70514259567c
 SHA512:
-  metadata.gz: 02be1d647c02508fbc4fb7fd9339d221b7625a5fe047c2e14e5901d809e8c4edbffb1559f4c06dbbb95971e6697b76acd8b096f60087d14941dcddf20c58ff87
-  data.tar.gz: 265ee51bd35a72bb183df848780a9d47b3203a06bb77ee53f7cfb606897785175bc347d48082bd7a0286081235155c4dae4c702fa752dc863342017a1a254d39
+  metadata.gz: 65bef1719944f20523e8670d382474fa15a49cd03eab6a39578ad3901933668c3d2bcfdff9da7e46ba9fdac8587447b92984a6e4c67028732f9ba2f18dc9cf52
+  data.tar.gz: b578660620dc448087463fd24361c652a8fd9ead88cd6693a658af94f497eb68361e3236cb43386da66f58666c72051d5728bb67b4be6c832ee815c54f59e4c8

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## main
 
+## 0.0.17
+
+* Ensure all components support inline styles.
+
+    *Joel Hawksley*
+
 ## 0.0.16
 
 * Adding a `spinner` slot to the `BlankslateComponent` that uses the `SpinnerComponent` added in `0.0.10`.

data/app/components/primer/base_component.rb

@@ -34,6 +34,7 @@ module Primer
   # | `data` | `Hash` | Data attributes: `data: { foo: :bar }` renders `data-foo='bar'`. |
   # | `aria` | `Hash` | Aria attributes: `aria: { label: "foo" }` renders `aria-label='foo'`. |
   # | `title` | `String` | The `title` attribute. |
+  # | `style` | `String` | Inline styles. |
   # | `hidden` | `Boolean` | Whether to assign the `hidden` attribute. |
   class BaseComponent < Primer::Component
     TEST_SELECTOR_TAG = :test_selector

data/app/components/primer/component.rb

@@ -6,5 +6,6 @@ module Primer
     include ClassNameHelper
     include FetchOrFallbackHelper
     include OcticonsHelper
+    include JoinStyleArgumentsHelper
   end
 end

data/app/components/primer/flash_component.rb

@@ -57,9 +57,7 @@ module Primer
       @system_arguments[:mb] ||= spacious ? 4 : nil
     end
 
-    class Actions < ViewComponent::Slot
-      include ClassNameHelper
-
+    class Actions < Primer::Slot
       attr_reader :system_arguments
 
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>

data/app/components/primer/link_component.rb

@@ -18,7 +18,7 @@ module Primer
       @system_arguments[:href] = href
       @system_arguments[:classes] = class_names(
         @system_arguments[:classes],
-        "muted-link" => fetch_or_fallback([true, false], muted, false)
+        "muted-link" => fetch_or_fallback_boolean(muted, false)
       )
     end
 

data/app/components/primer/popover_component.rb

@@ -57,7 +57,7 @@ module Primer
       body.present?
     end
 
-    class Heading < ViewComponent::Slot
+    class Heading < Primer::Slot
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(**system_arguments)
         @system_arguments = system_arguments

data/app/components/primer/progress_bar_component.rb

@@ -55,8 +55,7 @@ module Primer
       items.any?
     end
 
-    class Item < ViewComponent::Slot
-      include ClassNameHelper
+    class Item < Primer::Slot
       attr_reader :system_arguments
 
       # @param percentage [Integer] Percentage completion of item.
@@ -68,7 +67,8 @@ module Primer
 
         @system_arguments[:tag] = :span
         @system_arguments[:bg] = bg
-        @system_arguments[:style] = "width: #{@percentage}%;"
+        @system_arguments[:style] =
+          join_style_arguments(@system_arguments[:style], "width: #{@percentage}%;")
         @system_arguments[:classes] = class_names("Progress-item", @system_arguments[:classes])
       end
     end

data/app/components/primer/slot.rb

@@ -5,5 +5,6 @@ module Primer
   class Slot < ViewComponent::Slot
     include ClassNameHelper
     include FetchOrFallbackHelper
+    include JoinStyleArgumentsHelper
   end
 end

data/app/components/primer/spinner_component.rb

@@ -26,14 +26,14 @@ module Primer
     #   <%= render(Primer::SpinnerComponent.new(size: :large)) %>
     #
     # @param size [Symbol] <%= one_of(Primer::SpinnerComponent::SIZE_MAPPINGS) %>
-    def initialize(size: DEFAULT_SIZE, style: DEFAULT_STYLE, **system_arguments)
+    def initialize(size: DEFAULT_SIZE, **system_arguments)
       @system_arguments = system_arguments
       @system_arguments[:tag] = :svg
+      @system_arguments[:style] ||= DEFAULT_STYLE
       @system_arguments[:width] = SIZE_MAPPINGS[fetch_or_fallback(SIZE_OPTIONS, size, DEFAULT_SIZE)]
       @system_arguments[:height] = SIZE_MAPPINGS[fetch_or_fallback(SIZE_OPTIONS, size, DEFAULT_SIZE)]
       @system_arguments[:viewBox] = "0 0 16 16"
       @system_arguments[:fill] = :none
-      @system_arguments[:style] = DEFAULT_STYLE unless style.nil?
     end
   end
 end

data/app/components/primer/view_components.rb

@@ -15,6 +15,7 @@ require "octicons_helper/helper"
 require "primer/class_name_helper"
 require "primer/classify"
 require "primer/fetch_or_fallback_helper"
+require "primer/join_style_arguments_helper"
 
 # Base configurations
 

data/lib/primer/fetch_or_fallback_helper.rb

@@ -37,5 +37,13 @@ module Primer
         fallback
       end
     end
+
+    def fetch_or_fallback_boolean(given_value, fallback = false)
+      if [true, false].include?(given_value)
+        given_value
+      else
+        fallback
+      end
+    end
   end
 end

data/lib/primer/join_style_arguments_helper.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Primer
+  module JoinStyleArgumentsHelper
+    # Join two `style` arguments
+    #
+    # join_style_arguments("width: 100%", "height: 100%") =>
+    #   "width: 100%;height: 100%"
+    def join_style_arguments(*args)
+      args.compact.join(";")
+    end
+  end
+end

data/lib/primer/view_components/version.rb

@@ -5,7 +5,7 @@ module Primer
     module VERSION
       MAJOR = 0
       MINOR = 0
-      PATCH = 16
+      PATCH = 17
 
       STRING = [MAJOR, MINOR, PATCH].join(".")
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: primer_view_components
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.0.17
 platform: ruby
 authors:
 - GitHub Open Source
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-25 00:00:00.000000000 Z
+date: 2020-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -237,6 +237,7 @@ files:
 - lib/primer/class_name_helper.rb
 - lib/primer/classify.rb
 - lib/primer/fetch_or_fallback_helper.rb
+- lib/primer/join_style_arguments_helper.rb
 - lib/primer/view_components.rb
 - lib/primer/view_components/engine.rb
 - lib/primer/view_components/version.rb