prima-twig 1.3.0 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 94183c3b380822569fa755c6cd914da1eb15d36378d93a8faf827cf8b2a8a119
-  data.tar.gz: 865c21d79254b4b4ad2e8034d665f74301585fd50f4fd20b019e0c6bde977183
+  metadata.gz: 975828594ae14f606a510643c544f4cd363ef6d86be3df0e2e3a1681e4422389
+  data.tar.gz: 6e30a88cd7ecf87e520b0c96c946a58cd6a5abd022840eae4fee841a9a5fd8d7
 SHA512:
-  metadata.gz: 7604f33c35162fde446fb5e91e92451745d7eab126d09f417c36c835254949f2690c77c3f4ebbd8248c885c6c19b7786498da0cfbfe44adcb798b5641e53613f
-  data.tar.gz: 24f093ea1a89deef5debd86afdf69b5dbb43f5f1a6aef9bc68f8a8a0b9e2e938baee20ba897116d8a2d66e5e8d7b8d60a9e1f6af267973003e7357c34d138884
+  metadata.gz: 7c2c214e6a37ee5103ff495cfb63717bde238d740810426dd2639d25d57b7d6825659749c423b8e55518f20866b05f4c940f465124d38b3a43cc50725bca322a
+  data.tar.gz: 1e7127439d07ff017821ca372dcde66465aa7eb43a25391ee6ccd7bd033e41f6639402edadfcecb434dfbc728a30b9a633b3e8bc1fddb41f59fbd0b8a03d1b4e

data/bin/twig-feature

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 
 require 'rubygems'
-require_relative '../lib/prima_twig.rb'
-require_relative '../lib/prima_aws_client.rb'
+require_relative '../lib/prima_twig'
+require_relative '../lib/prima_aws_client'
 require 'digest'
 require 'json'
 require 'launchy'
@@ -14,11 +14,11 @@ class Release
   include Command
   include PrimaAwsClient
 
-  def initialize(update_gem=true)
+  def initialize(update_gem = true)
     @prima = Prima.new
     if update_gem
       output 'Controllo se ci sono aggiornamenti da fare (potrebbe richiedere qualche minuto)'
-      unless `gem update prima-twig`=="Updating installed gems\nNothing to update\n"
+      unless `gem update prima-twig` == "Updating installed gems\nNothing to update\n"
         output 'Gemma prima-twig aggiornata'
         exec "twig feature #{ARGV.join ' '}"
       end
@@ -47,20 +47,23 @@ class Release
       'legion' => {},
       'vianello' => {},
       'domus' => {},
-      'toretto' => {}
+      'toretto' => {},
+      'lira' => {},
+      'frontale' => {},
+      'baggio' => {}
     }
     @base_stack_name_alb = 'ecs-alb-http-public-qa-'
     @base_stack_name_alb_ws = 'ecs-alb-ws-public-qa-'
     @cloudflare = Rubyflare.connect_with(ENV['CLOUDFLARE_EMAIL'], ENV['CLOUDFLARE_APIKEY'])
     @config = YAML.load_file 'twig.yml'
-    @gh = Octokit::Client.new(:access_token => @config['github'])
+    @gh = Octokit::Client.new(access_token: @config['github'])
   end
 
   def execute!(args)
     case args[0]
     when 'qainit'
-      abort('Non sei nella cartella di qainit') unless Dir.pwd.match 'qainit$' or Dir.pwd.match '/drone/src'
-      if ['terminate', 'stop', 'shutdown', 'halt', 'destroy'].include? args[1]
+      abort('Non sei nella cartella di qainit') unless Dir.pwd.match('qainit$') || Dir.pwd.match('/drone/src')
+      if %w[terminate stop shutdown halt destroy].include? args[1]
         qainit_deploy_shutdown!
       elsif 'update' == args[1]
         qainit_deploy_update!
@@ -75,13 +78,11 @@ class Release
     when 'suite'
       abort('Non sei nella cartella di qainit') unless Dir.pwd.match 'qainit$'
       if 'deploy' == args[1]
-        suite_py_branches()
+        suite_py_branches
         qainit_deploy!(true)
       end
     when 'deploy'
-      if 'lock' == args[1]
-        deploy_lock!
-      end
+      deploy_lock! if 'lock' == args[1]
     when 'aggregator'
       if 'enable' == args[1]
         aggregator_enable!
@@ -103,25 +104,25 @@ class Release
   def aggregator_disable!
     output 'Disable aggregator'
 
-    output "Recupero le informazioni relative al puntamento dei record DNS..."
-    output "Recupero le informazioni sui QA attivi..."
-    stack_list, envs = get_stacks()
+    output 'Recupero le informazioni relative al puntamento dei record DNS...'
+    output 'Recupero le informazioni sui QA attivi...'
+    stack_list, envs = get_stacks
 
     env_hash = nil
-    unless envs.empty?
-      env_hash = envs.detect do |key, tags|
+    if envs.empty?
+      output 'Nessun QA trovato'.red
+      exit
+    else
+      env_hash = envs.detect do |_key, tags|
         aggregator_enabled = tags.detect do |tag|
-          tag.key === "hostname_pattern_priority" and tag.value === "1"
+          tag.key === 'hostname_pattern_priority' and tag.value === '1'
         end.is_a?(Aws::CloudFormation::Types::Tag)
         aggregator_enabled
       end[0]
-      dns_records = @cloudflare.get("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records", {per_page: 100, type: 'CNAME', content: get_alb_host(@base_stack_name_alb + env_hash[3..8])})
-      stop_if dns_records.body[:result].empty?, "I record DNS degli aggregatori non stanno puntando ad un QA".red
-      change_hostname_priority(env_hash, hostname_pattern_priority())
+      dns_records = @cloudflare.get('zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records', { per_page: 100, type: 'CNAME', content: get_alb_host(@base_stack_name_alb + env_hash[3..8]) })
+      stop_if dns_records.body[:result].empty?, 'I record DNS degli aggregatori non stanno puntando ad un QA'.red
+      change_hostname_priority(env_hash, hostname_pattern_priority)
       dns_to_staging(env_hash)
-    else
-      output 'Nessun QA trovato'.red
-      exit
     end
 
     output 'Finito!'.green
@@ -134,46 +135,46 @@ class Release
     dns_records = @cloudflare.get('zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records', { per_page: 100, type: 'CNAME', content: 'staging.prima.it' })
     stop_if dns_records.body[:result].empty?, "I record DNS degli aggregatori stanno gia' puntando ad un QA".red
 
-    output "Recupero le informazioni sui QA attivi..."
-    stack_list, envs = get_stacks()
+    output 'Recupero le informazioni sui QA attivi...'
+    stack_list, envs = get_stacks
 
     env_hash = nil
-    unless envs.empty?
+    if envs.empty?
+      output 'Nessun QA trovato'.red
+      exit
+    else
       env_hash = choose do |menu|
-        menu.prompt = "Scegli il QA al quale vuoi far puntare gli ambienti di staging dei comparatori: ".cyan
+        menu.prompt = 'Scegli il QA al quale vuoi far puntare gli ambienti di staging dei comparatori: '.cyan
         menu.shell  = true
         envs.each do |key, env|
-          title = ""
+          title = ''
           env.each do |e|
             title << "\n#{e.key.upcase}: #{e.value}"
           end
-          msg = "#{@prima.reduce_size(title, 1000)}".light_blue
+          msg = @prima.reduce_size(title, 1000).to_s.light_blue
           menu.choice(msg) { key }
         end
       end
-    else
-      output "Nessun QA trovato".red
-      exit
     end
 
-    change_hostname_priority(env_hash, "1")
+    change_hostname_priority(env_hash, '1')
 
     dns_records.body[:result].each do |dns|
-      if dns[:name] =~ /^\w+\-\w+\-staging\.prima\.it$/
+      if dns[:name] =~ /^\w+-\w+-staging\.prima\.it$/
         output "Changing #{dns[:name]} DNS record"
-        @cloudflare.put("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records/#{dns[:id]}", {type: 'CNAME', name: dns[:name], content: get_alb_host(@base_stack_name_alb + env_hash[3..8]), proxied: true, ttl: 1})
+        @cloudflare.put("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records/#{dns[:id]}", { type: 'CNAME', name: dns[:name], content: get_alb_host(@base_stack_name_alb + env_hash[3..8]), proxied: true, ttl: 1 })
       end
     end
 
-    output "Finito!".green
+    output 'Finito!'.green
   end
 
   def change_hostname_priority(env_hash, hostname_pattern_priority)
     cluster_stack_name = "ecs-cluster-#{env_hash}"
     tags = get_stack_tags(cluster_stack_name).map do |tag|
-      if tag.key === "hostname_pattern_priority"
+      if tag.key === 'hostname_pattern_priority'
         {
-          key: "hostname_pattern_priority",
+          key: 'hostname_pattern_priority',
           value: hostname_pattern_priority
         }
       else
@@ -198,14 +199,14 @@ class Release
 
     stack_name_web = "ecs-task-web-#{env_hash}"
     parameters = get_stack_parameters(stack_name_web).map do |param|
-      if param.parameter_key === "HostnamePatternPriority"
+      if param.parameter_key === 'HostnamePatternPriority'
         {
-          parameter_key: "HostnamePatternPriority",
+          parameter_key: 'HostnamePatternPriority',
           parameter_value: hostname_pattern_priority
         }
-      elsif param.parameter_key === "HostnamePatternAggregatorPriority"
+      elsif param.parameter_key === 'HostnamePatternAggregatorPriority'
         {
-          parameter_key: "HostnamePatternAggregatorPriority",
+          parameter_key: 'HostnamePatternAggregatorPriority',
           parameter_value: (hostname_pattern_priority.to_i + 1).to_s
         }
       else
@@ -219,22 +220,25 @@ class Release
   end
 
   def dns_to_staging(env_hash)
-    output "Recupero le informazioni relative al puntamento dei record DNS..."
-    dns_records = @cloudflare.get("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records", {per_page: 100, type: 'CNAME', content: get_alb_host(@base_stack_name_alb + env_hash[3..8])})
+    output 'Recupero le informazioni relative al puntamento dei record DNS...'
+    dns_records = @cloudflare.get('zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records', { per_page: 100, type: 'CNAME', content: get_alb_host(@base_stack_name_alb + env_hash[3..8]) })
     dns_records.body[:result].each do |dns|
-      if dns[:name] =~ /^\w+\-\w+\-staging\.prima\.it$/
+      if dns[:name] =~ /^\w+-\w+-staging\.prima\.it$/
         output "Changing #{dns[:name]} DNS record"
-        @cloudflare.put("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records/#{dns[:id]}", {type: 'CNAME', name: dns[:name], content: 'staging.prima.it', proxied: true, ttl: 1})
+        @cloudflare.put("zones/1fb634f19c43dfb0162cc4cb91915da2/dns_records/#{dns[:id]}", { type: 'CNAME', name: dns[:name], content: 'staging.prima.it', proxied: true, ttl: 1 })
       end
     end
   end
 
   def deploy_shutdown!
-    output "Recupero le informazioni sui QA attivi..."
+    output 'Recupero le informazioni sui QA attivi...'
     stack_list, envs = get_stacks
 
     env_hash = nil
-    unless envs.empty?
+    if envs.empty?
+      output 'Nessun environment trovato'.red
+      exit
+    else
       env_hash = choose do |menu|
         menu.prompt = "Scegli l'environment che vuoi spegnere: ".cyan
         menu.shell  = true
@@ -248,9 +252,6 @@ class Release
           menu.choice(msg) { key }
         end
       end
-    else
-      output 'Nessun environment trovato'.red
-      exit
     end
 
     cluster_stack_name = nil
@@ -261,6 +262,7 @@ class Release
           cluster_stack_name = stack.stack_name
         else
           break unless stack.stack_name.match(/#{env_hash}$/)
+
           stacks_to_delete.push(stack.stack_name)
           delete_stack(stack.stack_name)
         end
@@ -269,138 +271,134 @@ class Release
 
     cluster_stack_name = "ecs-cluster-#{env_hash}"
     aggregator_enabled = get_stack_tags(cluster_stack_name).detect do |tag|
-      tag.key === "hostname_pattern_priority" and tag.value === "1"
+      tag.key === 'hostname_pattern_priority' and tag.value === '1'
     end.is_a?(Aws::CloudFormation::Types::Tag)
 
-    if aggregator_enabled
-      dns_to_staging(env_hash)
-    end
+    dns_to_staging(env_hash) if aggregator_enabled
 
     # Se non ha finito di cancellare le altre non si puo' cancellare il cluster
-    output "Attendo 10 secondi per poter eliminare il cluster ECS"
+    output 'Attendo 10 secondi per poter eliminare il cluster ECS'
 
     while stacks_to_delete.length > 0
       sleep 13
       stacks_to_delete.each do |stack_name|
-        stacks_to_delete = stacks_to_delete - [stack_name] unless stack_exists?(stack_name)
+        stacks_to_delete -= [stack_name] unless stack_exists?(stack_name)
       end
-      output "Stack ancora attivi: #{stacks_to_delete.length.to_s}. Attendo altri 10 secondi per eliminare il cluster ECS"
+      output "Stack ancora attivi: #{stacks_to_delete.length}. Attendo altri 10 secondi per eliminare il cluster ECS"
     end
 
     delete_stack(cluster_stack_name)
     delete_stack(@base_stack_name_alb + env_hash[3..8])
     delete_stack(@base_stack_name_alb_ws + env_hash[3..8])
-    output "Finito!".green
+    output 'Finito!'.green
   end
 
   def deploy_lock!
-    output "Deploy update menu"
+    output 'Deploy update menu'
     `git pull`
 
-    output "Recupero le informazioni sui QA attivi..."
-    stack_list, envs = get_clusters()
+    output 'Recupero le informazioni sui QA attivi...'
+    stack_list, envs = get_clusters
 
     env_hash = nil
-    unless envs.empty?
+    if envs.empty?
+      output 'Nessun QA trovato'.red
+      exit
+    else
       env_hash = choose do |menu|
-        menu.prompt = "Scegli il QA che vuoi proteggere dallo spegnimento automatico: ".cyan
+        menu.prompt = 'Scegli il QA che vuoi proteggere dallo spegnimento automatico: '.cyan
         menu.shell  = true
         envs.each do |key, env|
-          title = ""
+          title = ''
           env.each do |e|
-            title << "#{e.value}" if e.key == 'qainit'
+            title << e.value.to_s if e.key == 'qainit'
           end
-          msg = "#{@prima.reduce_size(title, 1000)}".light_blue
+          msg = @prima.reduce_size(title, 1000).to_s.light_blue
           menu.choice(msg) { key }
         end
       end
-    else
-      output "Nessun QA trovato".red
-      exit
     end
 
     cluster_stack_name = "ecs-cluster-#{env_hash}"
     if stack_exists?(cluster_stack_name)
       tags = get_stack_tags(cluster_stack_name)
-      tag_keep_data = Aws::CloudFormation::Types::Tag.new({key:'AUTOMATIC_DELETION_PROTECTION', value:'true'})
+      tag_keep_data = Aws::CloudFormation::Types::Tag.new({ key: 'AUTOMATIC_DELETION_PROTECTION', value: 'true' })
       tags.push tag_keep_data
     end
 
     update_cluster_stack(cluster_stack_name, tags, get_stack_parameters(cluster_stack_name))
 
-    output "Finito!".green
+    output 'Finito!'.green
   end
 
   def deploy_update!
-    output "Deploy update menu"
+    output 'Deploy update menu'
     `git pull`
 
-    output "Recupero le informazioni sui QA attivi..."
-    stack_list, envs = get_stacks()
+    output 'Recupero le informazioni sui QA attivi...'
+    stack_list, envs = get_stacks
 
     env_hash = nil
-    unless envs.empty?
+    if envs.empty?
+      output 'Nessun QA trovato'.red
+      exit
+    else
       env_hash = choose do |menu|
-        menu.prompt = "Scegli il QA che vuoi aggiornare: ".cyan
+        menu.prompt = 'Scegli il QA che vuoi aggiornare: '.cyan
         menu.shell  = true
         envs.each do |key, env|
-          title = ""
+          title = ''
           env.each do |e|
             title << "\n#{e.key.upcase}: #{e.value}"
           end
-          msg = "#{@prima.reduce_size(title, 1000)}".light_blue
+          msg = @prima.reduce_size(title, 1000).to_s.light_blue
           menu.choice(msg) { key }
         end
       end
-    else
-      output "Nessun QA trovato".red
-      exit
     end
 
     envs[env_hash].each do |env|
-      unless ['hostname_pattern_priority', 'AUTOMATIC_DELETION_PROTECTION'].include? env.key
+      unless %w[hostname_pattern_priority AUTOMATIC_DELETION_PROTECTION].include? env.key
         @projects[env.key] = select_branch_to_deploy(env.key, env.value)
       end
     end
     deploy_feature!
 
-    output "Finito!".green
+    output 'Finito!'.green
   end
 
   def get_default_branch_name(projects)
     projects.each_key do |project|
-      return projects[project]['name'] if not projects[project]['default_branch']
+      return projects[project]['name'] unless projects[project]['default_branch']
     end
   end
 
-  def suite_py_branches()
-    if File.exist?("suitepy-projects.yml")
-      arg_projects = YAML.load(File.read("suitepy-projects.yml"))
+  def suite_py_branches
+    if File.exist?('suitepy-projects.yml')
+      arg_projects = YAML.load(File.read('suitepy-projects.yml'))
 
       @projects.merge!(arg_projects)
 
       `rm suitepy-projects.yml`
 
       @projects.each_key do |project|
-        if @projects[project].empty?
-          @projects[project] = choose_branch_to_deploy(project, true)
-        end
+        @projects[project] = choose_branch_to_deploy(project, true) if @projects[project].empty?
       end
     end
   end
 
-  def get_git_user()
+  def get_git_user
     `git config user.name`.gsub(/[^A-Za-z]/, '').gsub("\n", '')
   end
 
-  def get_git_mail()
+  def get_git_mail
     `git config user.email`.gsub("\n", '')
   end
 
   def qainit_deploy!(quiet = false)
-    `git checkout master && git pull && git remote prune origin`
+    `git checkout master && git fetch && git pull && git remote prune origin`
 
-    `git branch -r | awk '{print $1}' | egrep -v -f /dev/fd/0 <(git branch -vv | grep origin) | awk '{print $1}' | xargs git branch -D`
+    `git fetch -p && for branch in $(git branch -vv | grep ': gone]' | awk '{print $1}'); do git branch -D $branch; done`
 
     default_name = get_default_branch_name @projects
     feature_number = ''
@@ -417,7 +415,7 @@ class Release
       `git checkout -b #{branch_name}`
     end
 
-    File.open("projects.yml", "w") { |file| file.write(@projects.to_yaml) }
+    File.open('projects.yml', 'w') { |file| file.write(@projects.to_yaml) }
 
     update_drone_yml!
 
@@ -436,7 +434,7 @@ class Release
     git_user = get_git_user
     # stampiamo la lista
     chosen_branch = choose do |menu|
-      menu.prompt = "Scegli il QA che vuoi aggiornare: ".cyan
+      menu.prompt = 'Scegli il QA che vuoi aggiornare: '.cyan
       menu.shell = true
       former_branches.delete('master')
       former_branches.each_with_index do |branch, index|
@@ -451,14 +449,14 @@ class Release
     # aggiornare il commit (revision a cui fa riferimento)
 
     # leggo il file projects.yml / recupero i nomi dei branch / riscrivo tutto
-    projects = YAML.load(File.read("projects.yml"))
+    projects = YAML.load(File.read('projects.yml'))
 
     projects.each do |key, project|
       @projects[key] = select_branch_to_deploy(key, project['name'])
       @projects[key]['default_branch'] = project['default_branch']
     end
 
-    File.open("projects.yml", "w") { |file| file.write(@projects.to_yaml) }
+    File.open('projects.yml', 'w') { |file| file.write(@projects.to_yaml) }
 
     update_drone_yml!
 
@@ -474,7 +472,7 @@ class Release
     if selection.nil?
       # stampiamo la lista
       chosen_branch = choose do |menu|
-        menu.prompt = "Scegli il QA che vuoi spegnere: ".cyan
+        menu.prompt = 'Scegli il QA che vuoi spegnere: '.cyan
         menu.shell = true
         git_user = get_git_user
         former_branches.delete('master')
@@ -493,10 +491,10 @@ class Release
   end
 
   def qainit_drone_shutdown!
-    output "Recupero le informazioni sui QA attivi..."
+    output 'Recupero le informazioni sui QA attivi...'
     stack_list, envs = get_stacks
 
-    env_hash = "qa-" + get_deploy_id
+    env_hash = 'qa-' + get_deploy_id
 
     cluster_stack_name = nil
     stacks_to_delete = []
@@ -506,6 +504,7 @@ class Release
           cluster_stack_name = stack.stack_name
         else
           break unless stack.stack_name.match(/#{env_hash}$/)
+
           stacks_to_delete.push(stack.stack_name)
           delete_stack(stack.stack_name)
         end
@@ -515,47 +514,45 @@ class Release
     cluster_stack_name = "ecs-cluster-#{env_hash}"
     if stack_exists?(cluster_stack_name)
       aggregator_enabled = get_stack_tags(cluster_stack_name).detect do |tag|
-        tag.key === "hostname_pattern_priority" and tag.value === "1"
+        tag.key === 'hostname_pattern_priority' and tag.value === '1'
       end.is_a?(Aws::CloudFormation::Types::Tag)
 
-      if aggregator_enabled
-        dns_to_staging(env_hash)
-      end
+      dns_to_staging(env_hash) if aggregator_enabled
     end
 
     # Se non ha finito di cancellare le altre non si puo' cancellare il cluster
-    output "Attendo 10 secondi per poter eliminare il cluster ECS"
+    output 'Attendo 10 secondi per poter eliminare il cluster ECS'
 
     while stacks_to_delete.length > 0
       sleep 13
       stacks_to_delete.each do |stack_name|
-        stacks_to_delete = stacks_to_delete - [stack_name] unless stack_exists?(stack_name)
+        stacks_to_delete -= [stack_name] unless stack_exists?(stack_name)
       end
-      output "Stack ancora attivi: #{stacks_to_delete.length.to_s}. Attendo altri 10 secondi per eliminare il cluster ECS"
+      output "Stack ancora attivi: #{stacks_to_delete.length}. Attendo altri 10 secondi per eliminare il cluster ECS"
     end
 
     delete_stack(cluster_stack_name) if stack_exists?(cluster_stack_name)
     delete_stack(@base_stack_name_alb + env_hash[3..8]) if stack_exists?(@base_stack_name_alb + env_hash[3..8])
     delete_stack(@base_stack_name_alb_ws + env_hash[3..8]) if stack_exists?(@base_stack_name_alb_ws + env_hash[3..8])
     `git checkout master && git push origin --delete ${DRONE_BRANCH}`
-    output "Cancello il record DNS utilizzato da Lighthouse"
-    delete_lighthouse_dns()
-    output "Finito!".green
+    output 'Cancello il record DNS utilizzato da Lighthouse'
+    delete_lighthouse_dns
+    output 'Finito!'.green
   end
 
   def qainit_write_output(file_message, output_message)
     `mkdir -p /etc/qainit-output`
-    qa_file_name = "/etc/qainit-output/url_qa"
+    qa_file_name = '/etc/qainit-output/url_qa'
     File.open(qa_file_name + '.txt', 'w') { |file| file.write(file_message) }
     output "#{output_message} #{qa_file_name}".green
   end
 
-  def update_drone_yml!()
+  def update_drone_yml!
     drone_yml = File.read('.drone.yml')
     @projects.each do |key, project|
       drone_yml = drone_yml.gsub(/#{key}@.+\n/, "#{key}@#{project['revision']}\n")
     end
-    File.open(".drone.yml", "w") do |f|
+    File.open('.drone.yml', 'w') do |f|
       f.write(drone_yml)
     end
   end
@@ -570,10 +567,9 @@ class Release
   end
 
   def get_alb_host(stack_name)
-    case
-    when stack_name.include?('alb-http-public')
+    if stack_name.include?('alb-http-public')
       logical_resource_id = 'EcsApplicationLoadBalancerPublic'
-    when stack_name.include?('alb-ws-public')
+    elsif stack_name.include?('alb-ws-public')
       logical_resource_id = 'EcsApplicationLoadBalancerPublic'
     end
     resp = describe_stack_resource(stack_name, logical_resource_id)
@@ -589,8 +585,8 @@ class Release
   def choose_branch_to_deploy(project_name, select_master = false)
     # chiamare api octokit per recuperare i branch/commit
     output "Recupero la lista dei branch del progetto #{project_name}..."
-    branches = @gh.branches("primait/#{project_name}", {per_page: 100})
-    master_branch = branches.select {|branch| branch[:name] == 'master'}[0]
+    branches = @gh.branches("primait/#{project_name}", { per_page: 100 })
+    master_branch = branches.select { |branch| branch[:name] == 'master' }[0]
 
     if select_master || branches.length == 1
       branch_name = 'master'
@@ -612,7 +608,7 @@ class Release
       end
     end
 
-    chosen_branch = branches.select {|branch| branch[:name] == branch_name}[0]
+    chosen_branch = branches.select { |branch| branch[:name] == branch_name }[0]
     name = branch_name
     revision = chosen_branch[:commit][:sha]
     { 'name' => name, 'revision' => revision[0..14], 'default_branch' => select_master }
@@ -627,7 +623,7 @@ class Release
     { 'name' => name, 'revision' => revision[0..14], 'committer' => committer_email }
   end
 
-  def get_stacks()
+  def get_stacks
     envs = {}
     stack_list = stack_list()
     stack_list.each do |stack|
@@ -636,10 +632,10 @@ class Release
         envs[env_hash] = stack.tags unless envs.has_key?(env_hash) || stack.tags.empty?
       end
     end
-    return stack_list, envs
+    [stack_list, envs]
   end
 
-  def get_clusters()
+  def get_clusters
     envs = {}
     cluster_list = cluster_list()
     cluster_list.each do |stack|
@@ -648,63 +644,65 @@ class Release
         envs[env_hash] = stack.tags unless envs.has_key?(env_hash) || stack.tags.empty?
       end
     end
-    return cluster_list, envs
+    [cluster_list, envs]
   end
 
-  def hostname_pattern_priority()
-    (Time.now.to_i.to_s[-4..-1].to_i + Random.rand(40000)).to_s
+  def hostname_pattern_priority
+    (Time.now.to_i.to_s[-4..-1].to_i + Random.rand(40_000)).to_s
   end
 
   def select_branches(project_names = nil)
-    output "Deploy feature menu"
+    output 'Deploy feature menu'
     if project_names.nil?
-      @projects.each{ |key, value| @projects[key] = choose_branch_to_deploy(key) }
+      @projects.each { |key, _value| @projects[key] = choose_branch_to_deploy(key) }
     else
       project_names.each do |project|
         @projects[project] = choose_branch_to_deploy(project)
       end
       @projects.each_key do |branch_project|
-        @projects[branch_project] = choose_branch_to_deploy(branch_project, true) unless project_names.include? branch_project
+        unless project_names.include? branch_project
+          @projects[branch_project] = choose_branch_to_deploy(branch_project, true)
+        end
       end
     end
   end
 end
 
 def help_content
-  <<-HELP
+  <<~HELP
 
-twig-feature
-===========
+    twig-feature
+    ===========
 
-Manage feature branches
+    Manage feature branches
 
-Synopsis
---------
+    Synopsis
+    --------
 
-  twig release start
-  twig release finish
-  twig release deploy
-  twig release aggregator
+      twig release start
+      twig release finish
+      twig release deploy
+      twig release aggregator
 
-Description
------------
+    Description
+    -----------
 
-  start                       creates a new feature branch
-  finish                      finishes the feature by merging to dev and master
-  qainit                      deploys a new environment with selected branches from every project
-  qainit $PROJECT_NAME        deploys a new environment allowing to selected a branch from the input project (everything else is master)
-  qainit shutdown             deletes a specific qa environment
+      start                       creates a new feature branch
+      finish                      finishes the feature by merging to dev and master
+      qainit                      deploys a new environment with selected branches from every project
+      qainit $PROJECT_NAME        deploys a new environment allowing to selected a branch from the input project (everything else is master)
+      qainit shutdown             deletes a specific qa environment
 
-Available only to devops (from artemide)
------------
-  deploy                      deploys the feature branch to a temporary AWS Elastic Beanstalk env
-  deploy stop                 destroys the AWS Elastic Beanstalk env
-  deploy update               updates a feature branch with current branches
-  deploy lock                 protects a qa environment from automatic deletion
-  aggregator enable/disable   directs comparator's staging environments to a qa/staging
+    Available only to devops (from artemide)
+    -----------
+      deploy                      deploys the feature branch to a temporary AWS Elastic Beanstalk env
+      deploy stop                 destroys the AWS Elastic Beanstalk env
+      deploy update               updates a feature branch with current branches
+      deploy lock                 protects a qa environment from automatic deletion
+      aggregator enable/disable   directs comparator's staging environments to a qa/staging
 
-Subcommand for Twig: <http://rondevera.github.io/twig/>
-Author: Andrea Usuelli <https://github.com/andreausu>
+    Subcommand for Twig: <http://rondevera.github.io/twig/>
+    Author: Andrea Usuelli <https://github.com/andreausu>
 
   HELP
 end
@@ -717,9 +715,7 @@ if args.include?('--help')
 end
 
 gem_update = true
-if args.include?('no-gem-update')
-  gem_update = false
-end
+gem_update = false if args.include?('no-gem-update')
 
 args.delete('no-gem-update')
 

data/lib/command.rb

@@ -64,10 +64,10 @@ module Command
 
   # executes command and returns properly colored output
   def execute_command(cmd)
-    output "Eseguo #{cmd}".yellow
+    output "Executing #{cmd}".yellow
     res = `#{cmd}`
     color = $CHILD_STATUS.exitstatus.zero? ? 'green' : 'red'
     output res.send color
-    stop_if (color == 'red'), "Errore durante la build dell'artifact".red
+    stop_if (color == 'red'), 'Error'.red
   end
 end

data/lib/prima_aws_client.rb

@@ -7,7 +7,6 @@ require 'aws-sdk-ecs'
 require 'aws-sdk-elasticloadbalancingv2'
 require 'aws-sdk-s3'
 require 'colorize'
-#
 module PrimaAwsClient
   def s3_client
     @s3 ||= Aws::S3::Client.new
@@ -48,6 +47,7 @@ module PrimaAwsClient
       end
       stacks += resp.stacks
       break unless resp.next_token
+
       next_token = resp.next_token
     end
     puts '.'.yellow; STDOUT.flush
@@ -70,6 +70,7 @@ module PrimaAwsClient
       end
       stacks += resp.stacks
       break unless resp.next_token
+
       next_token = resp.next_token
     end
     puts '.'.yellow; STDOUT.flush
@@ -92,6 +93,7 @@ module PrimaAwsClient
       end
       exports += resp.exports
       break unless resp.next_token
+
       next_token = resp.next_token
     end
     puts '.'.yellow; STDOUT.flush
@@ -108,9 +110,7 @@ module PrimaAwsClient
       on_failure: 'ROLLBACK'
     }
 
-    if role != nil then
-      cf_args.merge!(role_arn: role)
-    end
+    cf_args.merge!(role_arn: role) unless role.nil?
 
     begin
       cf_client.create_stack(cf_args)
@@ -119,7 +119,7 @@ module PrimaAwsClient
       sleep 15
       create_stack(stack_name, stack_body, parameters = [], tags = [])
     else
-      output "La creazione dello stack #{stack_name} è stata avviata".green
+      output "CloudFormation stack #{stack_name} creation started".green
     end
   end
 
@@ -132,9 +132,7 @@ module PrimaAwsClient
       capabilities: ['CAPABILITY_IAM']
     }
 
-    if role != nil then
-      cf_args.merge!(role_arn: role)
-    end
+    cf_args.merge!(role_arn: role) unless role.nil?
 
     begin
       cf_client.update_stack(cf_args)
@@ -145,7 +143,7 @@ module PrimaAwsClient
     rescue Aws::CloudFormation::Errors::ValidationError => e
       raise e
     else
-      output "L'update dello stack #{stack_name} è stato avviato".green
+      output "CloudFormation stack #{stack_name} update started".green
     end
   end
 
@@ -158,9 +156,7 @@ module PrimaAwsClient
       capabilities: ['CAPABILITY_IAM']
     }
 
-    if role != nil then
-      cf_args.merge!(role_arn: role)
-    end
+    cf_args.merge!(role_arn: role) unless role.nil?
 
     begin
       cf_client.update_stack(cf_args)
@@ -171,7 +167,7 @@ module PrimaAwsClient
     rescue Aws::CloudFormation::Errors::ValidationError => e
       raise e
     else
-      output "L'update dello stack #{stack_name} è stato avviato".green
+      output "CloudFormation stack #{stack_name} update started".green
     end
   end
 
@@ -184,9 +180,7 @@ module PrimaAwsClient
       capabilities: ['CAPABILITY_IAM']
     }
 
-    if role != nil then
-      cf_args.merge!(role_arn: role)
-    end
+    cf_args.merge!(role_arn: role) unless role.nil?
 
     begin
       cf_client.update_stack(cf_args)
@@ -197,64 +191,63 @@ module PrimaAwsClient
     rescue Aws::CloudFormation::Errors::ValidationError => e
       raise e
     else
-      output "L'update dello stack #{stack_name} è stato avviato".green
+      output "CloudFormation stack #{stack_name} update started".green
     end
   end
 
   def stack_exists?(stack_name)
-    begin
-      cf_client.describe_stacks(stack_name: stack_name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      stack_exists?(stack_name)
-    rescue Aws::CloudFormation::Errors::ValidationError => e
-      return false if e.message.include? 'does not exist'
-      raise e
-    else
-      true
-    end
+    cf_client.describe_stacks(stack_name: stack_name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    stack_exists?(stack_name)
+  rescue Aws::CloudFormation::Errors::ValidationError => e
+    return false if e.message.include? 'does not exist'
+
+    raise e
+  else
+    true
   end
 
   def delete_stack(stack_name)
-    begin
-      cf_client.delete_stack(stack_name: stack_name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      delete_stack(stack_name)
-    else
-      output "Stack #{stack_name} spenta con successo\n".green
-    end
+    cf_client.delete_stack(stack_name: stack_name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    delete_stack(stack_name)
+  else
+    output "Stack #{stack_name} shutdown succesfully\n".green
   end
 
-  def wait_for_stack_ready(stack_name, failed_statuses = ['CREATE_FAILED', 'ROLLBACK_IN_PROGRESS', 'ROLLBACK_FAILED', 'DELETE_IN_PROGRESS', 'DELETE_FAILED', 'DELETE_COMPLETE', 'UPDATE_ROLLBACK_FAILED', 'UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS'])
+  def wait_for_stack_ready(stack_name, failed_statuses = %w[CREATE_FAILED ROLLBACK_IN_PROGRESS ROLLBACK_FAILED DELETE_IN_PROGRESS DELETE_FAILED DELETE_COMPLETE UPDATE_ROLLBACK_FAILED UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS])
     ready = false
     sleep_seconds = 13
-    output "Attendo che lo stack #{stack_name} finisca di essere inizializzato...\n".yellow
-    while !ready
+    output "Waiting for stack #{stack_name}...\n".yellow
+    until ready
       ready = true if stack_ready?(stack_name, failed_statuses)
       seconds_elapsed = 0
       loop do
         break if seconds_elapsed >= sleep_seconds
+
         print '.'.yellow; STDOUT.flush
         sleep 1
         seconds_elapsed += 1
       end
     end
-    output "\nStack #{stack_name} pronto!\n".green
+    output "\nStack #{stack_name} ready!\n".green
   end
 
   def wait_for_stack_removal(stack_name)
     ready = false
     sleep_seconds = 13
     sleep 10
-    output "Attendo che lo stack #{stack_name} finisca di essere cancellato...\n".yellow
-    while !ready
+    output "Waiting for stack #{stack_name}...\n".yellow
+    until ready
       ready = true if stack_deleted?(stack_name)
       seconds_elapsed = 0
       loop do
         break if seconds_elapsed >= sleep_seconds
+
         print '.'.yellow; STDOUT.flush
         sleep 1
         seconds_elapsed += 1
@@ -264,55 +257,46 @@ module PrimaAwsClient
   end
 
   def get_stack_tags(name)
-    begin
-      resp = cf_client.describe_stacks(stack_name: name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      get_stack_tags(name)
-    else
-      resp.stacks[0].tags
-    end
+    resp = cf_client.describe_stacks(stack_name: name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    get_stack_tags(name)
+  else
+    resp.stacks[0].tags
   end
 
   def get_stack_parameters(name)
-    begin
-      resp = cf_client.describe_stacks(stack_name: name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      get_stack_parameters(name)
-    else
-      resp.stacks[0].parameters
-    end
+    resp = cf_client.describe_stacks(stack_name: name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    get_stack_parameters(name)
+  else
+    resp.stacks[0].parameters
   end
 
   def get_stack_outputs(name)
-    begin
-      resp = cf_client.describe_stacks(stack_name: name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      get_stack_outputs(name)
-    else
-      resp.stacks[0].outputs
-    end
+    resp = cf_client.describe_stacks(stack_name: name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    get_stack_outputs(name)
+  else
+    resp.stacks[0].outputs
   end
 
   def get_stack_template(name)
-    begin
-      resp = cf_client.get_template(stack_name: name)
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      get_stack_template(name)
-    else
-      resp.template_body
-    end
-
+    resp = cf_client.get_template(stack_name: name)
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    get_stack_template(name)
+  else
+    resp.template_body
   end
 
-  def stack_ready?(stack_name, failed_statuses = ['CREATE_FAILED', 'ROLLBACK_IN_PROGRESS', 'ROLLBACK_FAILED', 'DELETE_IN_PROGRESS', 'DELETE_FAILED', 'DELETE_COMPLETE', 'UPDATE_ROLLBACK_FAILED', 'UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS'])
+  def stack_ready?(stack_name, failed_statuses = %w[CREATE_FAILED ROLLBACK_IN_PROGRESS ROLLBACK_FAILED DELETE_IN_PROGRESS DELETE_FAILED DELETE_COMPLETE UPDATE_ROLLBACK_FAILED UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS])
     begin
       resp = cf_client.describe_stacks(
         stack_name: stack_name
@@ -323,10 +307,11 @@ module PrimaAwsClient
       return false
     end
     raise "The stack #{stack_name} errored out" if failed_statuses.include? stack_status
-    ['CREATE_COMPLETE', 'UPDATE_COMPLETE', 'UPDATE_ROLLBACK_COMPLETE', 'ROLLBACK_COMPLETE'].include? stack_status
+
+    %w[CREATE_COMPLETE UPDATE_COMPLETE UPDATE_ROLLBACK_COMPLETE ROLLBACK_COMPLETE].include? stack_status
   end
 
-  def stack_deleted?(stack_name, failed_statuses = ['ROLLBACK_IN_PROGRESS', 'ROLLBACK_FAILED', 'DELETE_FAILED', 'UPDATE_ROLLBACK_FAILED', 'UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS'])
+  def stack_deleted?(stack_name, failed_statuses = %w[ROLLBACK_IN_PROGRESS ROLLBACK_FAILED DELETE_FAILED UPDATE_ROLLBACK_FAILED UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS])
     begin
       resp = cf_client.describe_stacks(
         stack_name: stack_name
@@ -340,6 +325,7 @@ module PrimaAwsClient
       return true
     end
     raise "The stack #{stack_name} errored out" if failed_statuses.include? stack_status
+
     ['DELETE_COMPLETE'].include? stack_status
   end
 
@@ -352,38 +338,39 @@ module PrimaAwsClient
     !resp.contents.empty?
   end
 
-  def upload_artifact(source_path, destination_path, bucket_name_override=nil)
-    output "Upload dell'artifact in corso (#{(File.size(source_path).to_f / 2**20).round(2)} MiB)\n".yellow
+  def upload_artifact(source_path, destination_path, bucket_name_override = nil)
+    output "Uploading artifact (#{(File.size(source_path).to_f / 2**20).round(2)} MiB)\n".yellow
     s3 = Aws::S3::Resource.new
-    s3_bucket = if !bucket_name_override.nil? then bucket_name_override else @s3_bucket end
+    s3_bucket = !bucket_name_override.nil? ? bucket_name_override : @s3_bucket
     puts s3_bucket
     obj = s3.bucket(s3_bucket).object(destination_path)
     obj.upload_file(source_path)
 
-    output "#{s3_bucket}/#{destination_path} uploadato con successo!\n".green
+    output "#{s3_bucket}/#{destination_path} upload success!\n".green
   end
 
   def wait_for_artifact(bucket, path)
     ready = artifact_exists?(bucket, path)
     sleep_seconds = 13
-    output "Attendo che sia pronto l'artefatto #{path}...\n".yellow
+    output "Wating that artifact #{path} becomes ready...\n".yellow
     retries = 0
-    while !ready
+    until ready
       ready = true if artifact_exists?(bucket, path)
       seconds_elapsed = 0
       loop do
         break if seconds_elapsed >= sleep_seconds
+
         print '.'.yellow; STDOUT.flush
         sleep 1
         seconds_elapsed += 1
       end
       retries += 1
       if retries > 150
-        output "\n Timeout raggiunto aspettando #{path}\n".red
+        output "\n Artifact #{path} timed out\n".red
         exit
       end
     end
-    output "\nArtefatto #{path} creato!\n".green
+    output "\nArtifact #{path} created!\n".green
   end
 
   def list_import_stacks(export_name)
@@ -391,7 +378,7 @@ module PrimaAwsClient
     next_token = ''
     loop do
       print '.'.yellow; STDOUT.flush
-      options = next_token != '' ? { export_name: export_name, next_token: next_token } : {export_name: export_name}
+      options = next_token != '' ? { export_name: export_name, next_token: next_token } : { export_name: export_name }
       begin
         resp = cf_client.list_imports(options)
       rescue Aws::CloudFormation::Errors::Throttling => e
@@ -401,94 +388,81 @@ module PrimaAwsClient
       end
       stacks += resp.imports
       break unless resp.next_token
+
       next_token = resp.next_token
     end
     stacks
   end
 
   def describe_stack_resource(cluster_stack_name, logical_resource_id)
-    begin
-      resp = cf_client.describe_stack_resource({stack_name: cluster_stack_name, logical_resource_id: logical_resource_id})
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = describe_stack_resource(cluster_stack_name, logical_resource_id)
-    end
+    resp = cf_client.describe_stack_resource({ stack_name: cluster_stack_name, logical_resource_id: logical_resource_id })
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = describe_stack_resource(cluster_stack_name, logical_resource_id)
   end
 
   def describe_instances(instance_ids)
-    begin
-      resp = ec2_client.describe_instances({instance_ids: instance_ids})
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = describe_instances(instance_ids)
-    end
+    resp = ec2_client.describe_instances({ instance_ids: instance_ids })
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = describe_instances(instance_ids)
   end
 
   def describe_auto_scaling_groups(auto_scaling_group_names, max_records)
-    begin
-      resp = asg_client.describe_auto_scaling_groups({
-        auto_scaling_group_names: auto_scaling_group_names,
-        max_records: max_records
-      })
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = describe_auto_scaling_groups(auto_scaling_group_names, max_records)
-    end
+    resp = asg_client.describe_auto_scaling_groups({
+                                                     auto_scaling_group_names: auto_scaling_group_names,
+                                                     max_records: max_records
+                                                   })
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = describe_auto_scaling_groups(auto_scaling_group_names, max_records)
   end
 
   def describe_load_balancers(load_balancer_arns)
-    begin
-      resp = alb_client.describe_load_balancers({load_balancer_arns: load_balancer_arns})
-    rescue Aws::ElasticLoadBalancingV2::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = describe_load_balancers(load_balancer_arns)
-    end
+    resp = alb_client.describe_load_balancers({ load_balancer_arns: load_balancer_arns })
+  rescue Aws::ElasticLoadBalancingV2::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = describe_load_balancers(load_balancer_arns)
   end
 
   def update_ecs_service(cluster, service, deployment_configuration)
-    begin
-      resp = ecs_client.update_service(
-        cluster: cluster,
-        service: service,
-        deployment_configuration: deployment_configuration
-      )
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = update_ecs_service(cluster, service, deployment_configuration)
-    end
+    resp = ecs_client.update_service(
+      cluster: cluster,
+      service: service,
+      deployment_configuration: deployment_configuration
+    )
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = update_ecs_service(cluster, service, deployment_configuration)
   end
 
   def describe_ecs_tasks(cluster, tasks)
-    begin
-      resp = ecs_client.describe_tasks({
-        cluster: cluster,
-        tasks: tasks
-      })
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = describe_ecs_tasks(cluster, tasks)
-    end
+    resp = ecs_client.describe_tasks({
+                                       cluster: cluster,
+                                       tasks: tasks
+                                     })
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = describe_ecs_tasks(cluster, tasks)
   end
 
   def run_ecs_task(cluster, task_definition, overrides, count)
-    begin
-      resp = ecs_client.run_task({
-        cluster: cluster,
-        task_definition: task_definition,
-        overrides: overrides,
-        count: count
-      })
-    rescue Aws::CloudFormation::Errors::Throttling => e
-      output 'Throttling, retrying in 15 seconds'.red
-      sleep 15
-      resp = run_ecs_task(cluster, task_definition, overrides, count)
-    end
+    resp = ecs_client.run_task({
+                                 cluster: cluster,
+                                 task_definition: task_definition,
+                                 overrides: overrides,
+                                 count: count
+                               })
+  rescue Aws::CloudFormation::Errors::Throttling => e
+    output 'Throttling, retrying in 15 seconds'.red
+    sleep 15
+    resp = run_ecs_task(cluster, task_definition, overrides, count)
   end
 
   def get_autoscaling_capacity(asg_name)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: prima-twig
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.5
 platform: ruby
 authors:
 - Matteo Giachino
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-16 00:00:00.000000000 Z
+date: 2020-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-autoscaling