pricehubble 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdab94d0db6b8d52953fec4af77bc72a063eb384a08f8d0f9c94a2cbc495887a
-  data.tar.gz: 2e3e154a4a4fcbc49cbc1f17b3b738f2c808ff200a82377884eef7463499b9ec
+  metadata.gz: 9e4560c6511f4825274bd9f0c8f0d992afbba0146124ef0bd3190a245cb9b034
+  data.tar.gz: 809942c34cc2b1bb219f91d0dae42b56454d34df87ed04684693c2dda40bab28
 SHA512:
-  metadata.gz: de8cce6ca9891a70b60afdc7621c848c1d9cdce76a895276f5986df113cc5c0c5a4edd0ddabcc150f4ca1ff8e8d8f74947da5fa89008a8a84dcb67c8bb08e765
-  data.tar.gz: eb755dc661fa163d417f6be206561e9accf27a435e15fbbec128d30e26aa8c8fb475ae86a86d0fcb0425ff50047f2dcb1b6acc9ef2d4afdffea0934e98490fe5
+  metadata.gz: 3f2cc01cce2b6dd5966eb73a656d1c4dc914259a5c1b147bfbe2c6fb22408863382b89f2a18fa6f8392ec26355587b928aecfae5a1503eece017d2a673f60ea1
+  data.tar.gz: d3b0f23dbff8ca220ca69f1c54aa091b6839f53129d4b0afa06c71188e5723730fe30137a76ee4b85a3ec087c2956fa7f5dacb56e0ac741bada2040f4b1470f1

data/.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec
   - rubocop-rails
 
@@ -63,7 +63,7 @@ RSpec/NestedGroups:
   Max: 4
 
 # Disable regular Rails spec paths.
-RSpec/FilePath:
+Rails/FilePath:
   Enabled: false
 
 # Because we just implemented the ActiveRecord API.

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 * TODO: Replace this bullet point with an actual description of a change.
 
+### 1.6.1 (21 May 2025)
+
+* Corrected some RuboCop glitches ([#15](https://github.com/hausgold/pricehubble/pull/15))
+* Upgraded the rubocop dependencies ([#16](https://github.com/hausgold/pricehubble/pull/16))
+
 ### 1.6.0 (30 January 2025)
 
 * Added all versions up to Ruby 3.4 to the CI matrix ([#14](https://github.com/hausgold/pricehubble/pull/14))

data/Dockerfile

@@ -1,5 +1,5 @@
 FROM hausgold/ruby:2.7
-MAINTAINER Hermann Mayer <hermann.mayer@hausgold.de>
+LABEL org.opencontainers.image.authors="containers@hausgold.de"
 
 # Update system gem
 RUN gem update --system '3.4.22'

data/Gemfile

@@ -18,9 +18,9 @@ gem 'guard-rspec', '~> 4.7'
 gem 'rake', '~> 13.0'
 gem 'redcarpet', '~> 3.5'
 gem 'rspec', '~> 3.12'
-gem 'rubocop', '~> 1.28'
-gem 'rubocop-rails', '~> 2.14'
-gem 'rubocop-rspec', '~> 2.10'
+gem 'rubocop'
+gem 'rubocop-rails'
+gem 'rubocop-rspec'
 gem 'simplecov', '>= 0.22'
 gem 'terminal-table', '~> 3.0'
 gem 'timecop', '>= 0.9.6'

data/doc/assets/project.svg

@@ -1,68 +1,7 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg
-   xmlns:dc="http://purl.org/dc/elements/1.1/"
-   xmlns:cc="http://creativecommons.org/ns#"
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
-   xmlns:svg="http://www.w3.org/2000/svg"
-   xmlns="http://www.w3.org/2000/svg"
-   version="1.1"
-   id="Ebene_1"
-   x="0px"
-   y="0px"
-   viewBox="0 0 800 200"
-   xml:space="preserve"
-   width="800"
-   height="200"><metadata
-   id="metadata33"><rdf:RDF><cc:Work
-       rdf:about=""><dc:format>image/svg+xml</dc:format><dc:type
-         rdf:resource="http://purl.org/dc/dcmitype/StillImage" /><dc:title></dc:title></cc:Work></rdf:RDF></metadata><defs
-   id="defs31" />
-<style
-   type="text/css"
-   id="style2">
-    .st0{fill-rule:evenodd;clip-rule:evenodd;fill:#E73E11;}
-    .st1{fill-rule:evenodd;clip-rule:evenodd;fill:#0371B9;}
-    .st2{fill:#132E48;}
-    .st3{font-family:'OpenSans-Bold';}
-    .st4{font-size:29.5168px;}
-    .st5{fill-rule:evenodd;clip-rule:evenodd;fill:none;}
-    .st6{opacity:0.5;fill:#132E48;}
-    .st7{font-family:'OpenSans';}
-    .st8{font-size:12px;}
-</style>
-<g
-   transform="translate(0,1.53584)"
-   id="g828"><g
-   transform="translate(35.93985,35.66416)"
-   id="g8">
-    <path
-   style="clip-rule:evenodd;fill:#e73e11;fill-rule:evenodd"
-   id="path4"
-   d="m -0.1,124.4 c 0,0 33.7,-123.2 66.7,-123.2 12.8,0 26.9,21.9 38.8,47.2 -23.6,27.9 -66.6,59.7 -94,76 -7.1,0 -11.5,0 -11.5,0 z"
-   class="st0" />
-    <path
-   style="clip-rule:evenodd;fill:#0371b9;fill-rule:evenodd"
-   id="path6"
-   d="m 88.1,101.8 c 13.5,-10.4 18.4,-16.2 27.1,-25.4 10,25.7 16.7,48 16.7,48 0,0 -41.4,0 -78,0 14.6,-7.9 18.7,-10.7 34.2,-22.6 z"
-   class="st1" />
-</g><text
-   y="106.40316"
-   x="192.43155"
-   style="font-style:normal;font-variant:normal;font-weight:bold;font-stretch:normal;font-size:29.51733398px;font-family:'Open Sans', sans-serif;-inkscape-font-specification:'OpenSans-Bold, Bold';font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-feature-settings:normal;text-align:start;writing-mode:lr-tb;text-anchor:start;fill:#132e48"
-   id="text10"
-   class="st2 st3 st4">PriceHubble</text>
-<rect
-   style="clip-rule:evenodd;fill:none;fill-rule:evenodd"
-   id="rect12"
-   height="24"
-   width="314.5"
-   class="st5"
-   y="118.06416"
-   x="194.23985" /><text
-   y="127.22146"
-   x="194.21715"
-   style="font-size:12px;font-family:'Open Sans', sans-serif;opacity:0.5;fill:#132e48;-inkscape-font-specification:'Open Sans, sans-serif, Normal';font-weight:normal;font-style:normal;font-stretch:normal;font-variant:normal;text-anchor:start;text-align:start;writing-mode:lr;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-feature-settings:normal;"
-   id="text14"
-   class="st6 st7 st8">Ruby client for the PriceHubble REST API</text>
-</g>
-</svg>
+<svg id="hg-readme-banner-v2" viewBox="0 0 800 200" width="800" height="200" xmlns="http://www.w3.org/2000/svg"><defs><linearGradient id="a" x1="112.46" y1="309.13" x2="314.5" y2="309.13" gradientUnits="userSpaceOnUse" gradientTransform="translate(-33.985 -122.816)"><stop offset="0" stop-color="#1992f4" /><stop offset="1" stop-color="#2b8af6" /></linearGradient></defs><style>.st3{font-family:&apos;OpenSans-Bold&apos;}.st4{font-size:29.5168px}.st5{fill-rule:evenodd;clip-rule:evenodd;fill:none}.st7{font-family:&apos;OpenSans&apos;}.st8{font-size:12px}@media (prefers-color-scheme:dark){text{fill:#f0f6fc!important}}</style>
+<text y="107.939" x="192.432" style="font-family:'Open Sans', sans-serif;-inkscape-font-specification:'OpenSans-Bold, Bold';font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-feature-settings:normal;text-align:start" class="st3 st4" font-weight="700" font-size="29.517" font-family="'Open Sans',sans-serif" fill="#3f3e4b"
+>PriceHubble</text>
+<path class="st5" clip-rule="evenodd" fill="none" fill-rule="evenodd" d="M194.24 119.6h314.5v24h-314.5z"/>
+<text y="128.757" x="194.217" style="font-family:'Open Sans', sans-serif;-inkscape-font-specification:'Open Sans, sans-serif, Normal';font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-feature-settings:normal;text-align:start" class="st7 st8" font-weight="400" font-size="12" font-family="'Open Sans',sans-serif" opacity=".75" fill="#3f3e4b"
+>Ruby client for the PriceHubble REST API</text>
+<g transform="translate(33.985 122.816)"><path d="M129.427 32.4q-7-20.71-14.09-41.44c-.33-1-.52-1.18-1.34-.25-3.1 3.48-6.25 6.92-9.49 10.26a180.23 180.23 0 0 1-18.54 16.15 193.7 193.7 0 0 1-21.95 15.43c-2.53 1.47-5.08 2.91-7.62 4.36l.11.27h73.05c1 .1 1.4-.13 1-1.22-.4-1.09-.73-2.38-1.13-3.56z" fill="url(#a)" /><path d="M89.077-63.87c-3.57-5.58-7.42-10.95-12.62-15.17-3.93-3.19-8.28-5-13.42-3.32a23 23 0 0 0-8.76 5.6 66.77 66.77 0 0 0-10.34 13.09c-8 12.68-14.06 26.28-19.28 40.25-4.6 12.33-8.82 24.8-12.95 37.29-2.45 7.41-4.39 15-6.61 22.49-.26.88 0 1 .79 1h7.4c1.23 0 2.44.14 3.6-.68 9.17-6.45 18.51-12.67 27.55-19.31a396.21 396.21 0 0 0 37.36-31.3 245.79 245.79 0 0 0 20.74-22 1.6 1.6 0 0 0 .26-2 224.45 224.45 0 0 0-13.72-25.94z" fill="#f2686d" /></g></svg>

data/gemfiles/rails_6.1.gemfile

@@ -10,9 +10,9 @@ gem "guard-rspec", "~> 4.7"
 gem "rake", "~> 13.0"
 gem "redcarpet", "~> 3.5"
 gem "rspec", "~> 3.12"
-gem "rubocop", "~> 1.28"
-gem "rubocop-rails", "~> 2.14"
-gem "rubocop-rspec", "~> 2.10"
+gem "rubocop"
+gem "rubocop-rails"
+gem "rubocop-rspec"
 gem "simplecov", ">= 0.22"
 gem "terminal-table", "~> 3.0"
 gem "timecop", ">= 0.9.6"

data/gemfiles/rails_7.1.gemfile

@@ -10,9 +10,9 @@ gem "guard-rspec", "~> 4.7"
 gem "rake", "~> 13.0"
 gem "redcarpet", "~> 3.5"
 gem "rspec", "~> 3.12"
-gem "rubocop", "~> 1.28"
-gem "rubocop-rails", "~> 2.14"
-gem "rubocop-rspec", "~> 2.10"
+gem "rubocop"
+gem "rubocop-rails"
+gem "rubocop-rspec"
 gem "simplecov", ">= 0.22"
 gem "terminal-table", "~> 3.0"
 gem "timecop", ">= 0.9.6"

data/lib/price_hubble/client/base.rb

@@ -24,7 +24,7 @@ module PriceHubble
       #
       # @param con [Faraday::Connection] the connection object
       #
-      # rubocop:disable Metrics/MethodLength because of the middleware list
+      # rubocop:disable Metrics/MethodLength -- because of the middleware list
       def configure(con)
         con.use :instrumentation
 

data/lib/price_hubble/client/dossiers.rb

@@ -11,8 +11,8 @@ module PriceHubble
       # @return [PriceHubble::Dossier, nil] the PriceHubble dossier,
       #   or +nil+ on error
       #
-      # rubocop:disable Metrics/MethodLength because thats the bare minimum
-      #  handling is quite complex
+      # rubocop:disable Metrics/MethodLength -- because thats the bare minimum
+      #   handling is quite complex
       def create_dossier(entity, **args)
         res = connection.post do |req|
           req.path = '/api/v1/dossiers'
@@ -36,9 +36,9 @@ module PriceHubble
       # @param locale [String] the user frontend locale
       # @param args [Hash{Symbol => Mixed}] additional arguments
       #
-      # rubocop:disable Metrics/MethodLength because thats the bare minimum
-      # rubocop:disable Metrics/AbcSize because the decission
-      #  handling is quite complex
+      # rubocop:disable Metrics/MethodLength -- because thats the bare minimum
+      # rubocop:disable Metrics/AbcSize -- because the decission handling is
+      #   quite complex
       def share_dossier(entity, ttl:, locale:, **args)
         res = connection.post do |req|
           req.path = '/api/v1/dossiers/links'
@@ -65,8 +65,8 @@ module PriceHubble
       # @param entity [PriceHubble::Dossier] the entity to delete
       # @param args [Hash{Symbol => Mixed}] additional arguments
       #
-      # rubocop:disable Metrics/MethodLength because thats the bare minimumbecause the decission
-      #  handling is quite complex
+      # rubocop:disable Metrics/MethodLength -- because thats the bare
+      #   minimumbecause the decission handling is quite complex
       def delete_dossier(entity, **args)
         res = connection.delete do |req|
           req.path = "/api/v1/dossiers/#{entity.id}"

data/lib/price_hubble/client/utils/response.rb

@@ -5,7 +5,8 @@ module PriceHubble
     module Utils
       # Some helpers to work with responses in a general way.
       #
-      # rubocop:disable Metrics/BlockLength because of ActiveSupport::Concern
+      # rubocop:disable Metrics/BlockLength -- because of
+      #   ActiveSupport::Concern
       module Response
         extend ActiveSupport::Concern
 

data/lib/price_hubble/client/valuation.rb

@@ -11,8 +11,8 @@ module PriceHubble
       # @return [Array<PriceHubble::Valuation>, nil] the valuation results,
       #   or +nil+ on error
       #
-      # rubocop:disable Metrics/MethodLength because of the request handling
-      # rubocop:disable Metrics/AbcSize dito
+      # rubocop:disable Metrics/MethodLength -- because of the request handling
+      # rubocop:disable Metrics/AbcSize -- ditto
       def property_value(request, **args)
         data = request.attributes(sanitize: true)
         res = connection.post do |req|
@@ -42,9 +42,9 @@ module PriceHubble
       # @param request [PriceHubble::ValuationRequest] the original request
       # @return [Proc] the valuation mapping code
       #
-      # rubocop:disable Metrics/MethodLength because of the request
-      #   to response mapping
-      # rubocop:disable Metrics/AbcSize dito
+      # rubocop:disable Metrics/MethodLength -- because of the request to
+      #   response mapping
+      # rubocop:disable Metrics/AbcSize -- ditto
       def assign_valuations(data, request)
         lambda do
           # valuations[i][j] contains the valuation for property i on date j

data/lib/price_hubble/configuration_handling.rb

@@ -3,7 +3,7 @@
 module PriceHubble
   # The top-level configuration handling.
   #
-  # rubocop:disable Style/ClassVars because we split module code
+  # rubocop:disable Style/ClassVars -- because we split module code
   module ConfigurationHandling
     extend ActiveSupport::Concern
 

data/lib/price_hubble/core_ext/hash.rb

@@ -33,8 +33,8 @@ class Hash
   # @param object [Mixed] the object to compact
   # @return [Mixed] the compacted object
   #
-  # rubocop:disable Metrics/MethodLength because of the extra empty
-  #   hash compaction logic
+  # rubocop:disable Metrics/MethodLength -- because of the extra empty hash
+  #   compaction logic
   def deep_compact_in_object(object)
     case object
     when Hash

data/lib/price_hubble/entity/concern/associations.rb

@@ -38,8 +38,8 @@ module PriceHubble
         # @return [Array<RecursiveOpenStruct, Hash{Symbol => Mixed}>] the
         #   left over data
         #
-        # rubocop:disable Metrics/AbcSize because of the complex logic
-        # rubocop:disable Metrics/MethodLength because of the complex logic
+        # rubocop:disable Metrics/AbcSize -- because of the complex logic
+        # rubocop:disable Metrics/MethodLength -- because of the complex logic
         def map_has_one_association(attribute, opts, struct, hash)
           # Early exit when the source key is missing on the given data
           key = opts[:from]
@@ -77,12 +77,12 @@ module PriceHubble
         # @return [Array<RecursiveOpenStruct, Hash{Symbol => Mixed}>] the
         #   left over data
         #
-        # rubocop:disable Metrics/AbcSize because of the complex logic
-        # rubocop:disable Metrics/CyclomaticComplexity because of the
+        # rubocop:disable Metrics/AbcSize -- because of the complex logic
+        # rubocop:disable Metrics/CyclomaticComplexity -- because of the
         #   complex logic
-        # rubocop:disable Metrics/PerceivedComplexity because of the
-        #   complex logic
-        # rubocop:disable Metrics/MethodLength because of the complex logic
+        # rubocop:disable Metrics/PerceivedComplexity -- because of the complex
+        #   logic
+        # rubocop:disable Metrics/MethodLength -- because of the complex logic
         def map_has_many_association(attribute, opts, struct, hash)
           # Early exit when the source key is missing on the given data
           key = opts[:from]
@@ -120,8 +120,8 @@ module PriceHubble
         # rubocop:enable Metrics/MethodLength
       end
 
-      # rubocop:disable Naming/PredicateName because we follow
-      #   known naming conventions
+      # rubocop:disable Naming/PredicateName -- because we follow known naming
+      #   conventions
       class_methods do
         # Initialize the associations structures on an inherited class.
         #

data/lib/price_hubble/entity/concern/attributes/enum.rb

@@ -14,8 +14,8 @@ module PriceHubble
           # @param values [Array<String, Symbol>] the allowed values
           # @param _args [Hash{Symbol => Mixed}] additional options
           #
-          # rubocop:disable Metrics/MethodLength because of the inline
-          #   meta method definitions
+          # rubocop:disable Metrics/MethodLength -- because of the inline meta
+          #   method definitions
           def typed_attr_enum(name, values:, **_args)
             values = values.map(&:to_sym)
             const_values = "ATTR_#{name.to_s.upcase}"

data/lib/price_hubble/entity/concern/attributes.rb

@@ -25,8 +25,8 @@ module PriceHubble
         # @param sanitize [Boolean] whenever to sanitize the data for transport
         # @return [Hash{String => Mixed}] the attribute data
         #
-        # rubocop:disable Metrics/MethodLength because of the
-        #   key/value sanitization handling
+        # rubocop:disable Metrics/MethodLength -- because of the key/value
+        #   sanitization handling
         def attributes(sanitize: false)
           attribute_names.each_with_object({}) do |key, memo|
             reader = key
@@ -74,7 +74,8 @@ module PriceHubble
         # @param sanitize [Boolean] whenever to sanitize the data for transport
         # @return [Mixed] the attribute(s) data
         #
-        # rubocop:disable Metrics/MethodLength because thats the pure minimum
+        # rubocop:disable Metrics/MethodLength -- because thats the pure
+        #   minimum
         def resolve_attributes(obj, sanitize: false)
           if obj.respond_to? :attributes
             obj = if obj.method(:attributes).arity == 1

data/lib/price_hubble/identity.rb

@@ -3,7 +3,7 @@
 module PriceHubble
   # Handles all the identity retrival high-level logic.
   #
-  # rubocop:disable Style/ClassVars because we split module code
+  # rubocop:disable Style/ClassVars -- because we split module code
   module Identity
     extend ActiveSupport::Concern
 

data/lib/price_hubble/utils/bangers.rb

@@ -15,7 +15,7 @@ module PriceHubble
         # @raise [NoMethodError] when a source method is not defined
         # @raise [ArgumentError] when a source method does not accept arguments
         #
-        # rubocop:disable Metrics/MethodLength because the method template
+        # rubocop:disable Metrics/MethodLength -- because the method template
         #   is better inlined
         def bangers(*methods)
           methods.each do |meth|

data/lib/price_hubble/version.rb

@@ -3,7 +3,7 @@
 # The gem version details.
 module PriceHubble
   # The version of the +price-hubble+ gem
-  VERSION = '1.6.0'
+  VERSION = '1.6.1'
 
   class << self
     # Returns the version of gem as a string.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pricehubble
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Hermann Mayer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2025-01-30 00:00:00.000000000 Z
+date: 2025-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel