pricehubble 1.3.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a07bc69bd21da2ef882a604b4fe9004058e498b55e054d570028bbf68f7c62cc
-  data.tar.gz: 47aa8a135d82dfadcff96647cfcbed8d676edcab4afa2b4c95c080d8ee11bac7
+  metadata.gz: 9721bb7bde0466664e06c6669668eb4bfe18afbcd922b3e9780cbccf7fab38c4
+  data.tar.gz: 96cbc3748db0776ad37c56d0cae090d4c7f181ba5357dc94fdcc05cd138f7fd1
 SHA512:
-  metadata.gz: f470b76681cdb721ea601c90ff82e09fec7dec6d6788a784e818060520cbd356fb4c2719cc193e592e13e48a50c373aad6b3994e23779d9ecd6dacd86127a16c
-  data.tar.gz: 7d4a5c14802732b4564287c6f535a0bfa857b44e4a8e5020084b900aed62197eb5a07d111de2c74e13a2e35f9f32101a3530a15ac810351fc60d6fa1cc8a4f94
+  metadata.gz: ed6ada92ef2cb5a3ff5a1d715fe1aad5bc68adc9482cf5b383b6497d253552f02c42b908c48e326337886227dc616dcd3210a59e70da3591d5bbb18242a7174c
+  data.tar.gz: 17461520b2a3631e0706da2c6b5355ee5fe6c9f0d2228eee4497f6ac068780431f9c5da0585f1862227c4cd86e6b562f19a7e4a1bbcd3a4d9db9c14d878e23c1

data/.github/workflows/test.yml

@@ -18,8 +18,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.7']
-        rails: ['5.2', '6.1', '7.1']
+        ruby: ['2.7', '3.0']
+        rails: ['6.1', '7.1']
     env:
       BUNDLE_GEMFILE: 'gemfiles/rails_${{ matrix.rails }}.gemfile'
     steps:

data/.rubocop.yml

@@ -13,7 +13,7 @@ AllCops:
   SuggestExtensions: false
   DisplayCopNames: true
   TargetRubyVersion: 2.7
-  TargetRailsVersion: 5.2
+  TargetRailsVersion: 6.1
   Exclude:
     - bin/**/*
     - vendor/**/*

data/Appraisals

@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 
-appraise 'rails-5.2' do
-  gem 'activemodel', '~> 5.2.0'
-  gem 'activesupport', '~> 5.2.0'
-end
-
 appraise 'rails-6.1' do
   gem 'activemodel', '~> 6.1.0'
   gem 'activesupport', '~> 6.1.0'

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 * TODO: Replace this bullet point with an actual description of a change.
 
+### 1.5.0 (12 January 2025)
+
+* Switched to Zeitwerk as autoloader (#12)
+
+### 1.4.0 (3 January 2025)
+
+* Raised minimum supported Ruby/Rails version to 2.7/6.1 (#11)
+
 ### 1.3.0 (4 October 2024)
 
 * Upgraded the `recursive-open-struct` gem to `~> 2.0` (#10)

data/lib/price_hubble/{entity/base_entity.rb → base_entity.rb}

@@ -13,11 +13,11 @@ module PriceHubble
       include PriceHubble::Utils::Bangers
     end
 
-    include PriceHubble::EntityConcern::Callbacks
-    include PriceHubble::EntityConcern::Attributes
-    include PriceHubble::EntityConcern::Associations
-    include PriceHubble::EntityConcern::Client
-    include PriceHubble::EntityConcern::Persistence
+    include Concern::Callbacks
+    include Concern::Attributes
+    include Concern::Associations
+    include Concern::Client
+    include Concern::Persistence
 
     # We collect all unknown attributes instead of raising while creating a new
     # instance. The unknown attributes are wrapped inside a

data/lib/price_hubble/entity/concern/associations.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     # Allow simple association mappings like ActiveRecord supports (eg.
     # +has_one+, +has_many+).
     module Associations

data/lib/price_hubble/entity/concern/attributes/date_array.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     module Attributes
       # A separated date array typed attribute helper.
       module DateArray

data/lib/price_hubble/entity/concern/attributes/enum.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     module Attributes
       # A separated enum typed attribute helper.
       module Enum

data/lib/price_hubble/entity/concern/attributes/range.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     module Attributes
       # A separated range typed attribute helper.
       module Range

data/lib/price_hubble/entity/concern/attributes/string_inquirer.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     module Attributes
       # A separated string inquirer typed attribute helper.
       module StringInquirer

data/lib/price_hubble/entity/concern/attributes.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     # An ActiveRecord-like attribute management feature, with the exception
     # that the attributes are not generated through a schema file, but are
     # defined inline the entity class.

data/lib/price_hubble/entity/concern/callbacks.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     # Define all the base callbacks of a common entity.
     module Callbacks
       extend ActiveSupport::Concern

data/lib/price_hubble/entity/concern/client.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     # Allow entities to define their low level HTTP client to use.
     module Client
       extend ActiveSupport::Concern

data/lib/price_hubble/entity/concern/persistence.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module PriceHubble
-  module EntityConcern
+  module Concern
     # Map some of the ActiveRecord::Persistence API methods for an entity
     # instance for good compatibility. See: http://bit.ly/2W1rjfF and
     # http://bit.ly/2ARRFYB

data/lib/price_hubble/utils/bangers.rb

@@ -22,17 +22,14 @@ module PriceHubble
             raise NoMethodError, "#{self}##{meth} does not exit" \
               unless instance_methods(false).include? meth
 
-            raise ArgumentError, "#{self}##{meth} does not accept arguments" \
-              if instance_method(meth).arity.zero?
+            if instance_method(meth).arity.zero?
+              raise ArgumentError,
+                    "#{self}##{meth} does not accept arguments"
+            end
 
             class_eval <<-RUBY, __FILE__, __LINE__ + 1
-              def #{meth}!(*args)
-                if args.last.is_a? Hash
-                  args.last.merge!(bang: true)
-                else
-                  args.push({ bang: true })
-                end
-                #{meth}(*args)
+              def #{meth}!(*args, **kwargs, &block)
+                #{meth}(*args, **kwargs, bang: true, &block)
               end
             RUBY
           end

data/lib/price_hubble/version.rb

@@ -3,7 +3,7 @@
 # The gem version details.
 module PriceHubble
   # The version of the +price-hubble+ gem
-  VERSION = '1.3.0'
+  VERSION = '1.5.0'
 
   class << self
     # Returns the version of gem as a string.

data/lib/price_hubble.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'zeitwerk'
 require 'active_support'
 require 'active_support/concern'
 require 'active_support/configurable'
@@ -14,100 +15,44 @@ require 'recursive-open-struct'
 require 'faraday'
 require 'faraday_middleware'
 
-# Load polyfills if needed
-require 'price_hubble/core_ext/hash'
-
 # The top level namespace for the PriceHubble gem.
 module PriceHubble
-  # Top level elements
-  autoload :Configuration, 'price_hubble/configuration'
-  autoload :ConfigurationHandling, 'price_hubble/configuration_handling'
-  autoload :Client, 'price_hubble/client'
-  autoload :Identity, 'price_hubble/identity'
-  autoload :Instrumentation, 'price_hubble/instrumentation'
-
-  # Entities
-  autoload :BaseEntity, 'price_hubble/entity/base_entity'
-  autoload :Authentication, 'price_hubble/entity/authentication'
-  autoload :Valuation, 'price_hubble/entity/valuation'
-  autoload :ValuationScores, 'price_hubble/entity/valuation_scores'
-  autoload :ValuationRequest, 'price_hubble/entity/valuation_request'
-  autoload :Property, 'price_hubble/entity/property'
-  autoload :PropertyConditions, 'price_hubble/entity/property_conditions'
-  autoload :PropertyQualities, 'price_hubble/entity/property_qualities'
-  autoload :PropertyType, 'price_hubble/entity/property_type'
-  autoload :Location, 'price_hubble/entity/location'
-  autoload :Address, 'price_hubble/entity/address'
-  autoload :Coordinates, 'price_hubble/entity/coordinates'
-  autoload :Dossier, 'price_hubble/entity/dossier'
-
-  # Some general purpose utilities
-  module Utils
-    autoload :Decision, 'price_hubble/utils/decision'
-    autoload :Bangers, 'price_hubble/utils/bangers'
-  end
-
-  # Instrumentation
-  module Instrumentation
-    autoload :LogSubscriber, 'price_hubble/instrumentation/log_subscriber'
-  end
-
-  # Dedicated application HTTP (low level) client
-  module Client
-    # All our utilities used for the low level client
-    module Utils
-      autoload :Request, 'price_hubble/client/utils/request'
-      autoload :Response, 'price_hubble/client/utils/response'
-    end
+  # Configure the relative gem code base location
+  root_path = Pathname.new("#{__dir__}/price_hubble")
 
-    # Faraday request middlewares
-    module Request
-      autoload :DataSanitization,
-               'price_hubble/client/request/data_sanitization'
-      autoload :DefaultHeaders, 'price_hubble/client/request/default_headers'
-    end
+  # Setup a Zeitwerk autoloader instance and configure it
+  loader = Zeitwerk::Loader.for_gem
 
-    # Faraday response middlewares
-    module Response
-      autoload :DataSanitization,
-               'price_hubble/client/response/data_sanitization'
-      autoload :RecursiveOpenStruct,
-               'price_hubble/client/response/recursive_open_struct'
-    end
+  # Do not auto load some parts of the gem
+  loader.ignore("#{__dir__}/pricehubble*")
+  loader.ignore(root_path.join('core_ext'))
+  loader.ignore(root_path.join('initializers*'))
+  loader.ignore(root_path.join('railtie.rb'))
 
-    autoload :Base, 'price_hubble/client/base'
-    autoload :Authentication, 'price_hubble/client/authentication'
-    autoload :Valuation, 'price_hubble/client/valuation'
-    autoload :Dossiers, 'price_hubble/client/dossiers'
-  end
+  # Entity definitions, based on core functionalities,
+  # all entities are directly located at the namespace root,
+  # together with their shared concerns
+  loader.push_dir(root_path.join('entity'), namespace: PriceHubble)
 
-  # Separated features of an entity instance
-  module EntityConcern
-    autoload :Callbacks, 'price_hubble/entity/concern/callbacks'
-    autoload :Attributes, 'price_hubble/entity/concern/attributes'
-    autoload :Associations, 'price_hubble/entity/concern/associations'
-    autoload :Client, 'price_hubble/entity/concern/client'
-    autoload :Persistence, 'price_hubble/entity/concern/persistence'
-
-    # Some custom typed attribute helpers
-    module Attributes
-      base = 'price_hubble/entity/concern/attributes'
-      autoload :DateArray, "#{base}/date_array"
-      autoload :Enum, "#{base}/enum"
-      autoload :Range, "#{base}/range"
-      autoload :StringInquirer, "#{base}/string_inquirer"
-    end
-  end
+  # Finish the auto loader configuration
+  loader.setup
 
   # Load standalone code
   require 'price_hubble/version'
-  require 'price_hubble/errors'
-  require 'price_hubble/faraday'
   require 'price_hubble/railtie' if defined? Rails
 
+  # Load all core extension of the gem
+  Dir[root_path.join('core_ext/**/*.rb')].sort.each { |path| require path }
+
+  # Load all initializers of the gem
+  Dir[root_path.join('initializers/**/*.rb')].sort.each { |path| require path }
+
   # Include top-level features
   include PriceHubble::ConfigurationHandling
   include PriceHubble::Client
   include PriceHubble::Identity
   include PriceHubble::Instrumentation
+
+  # Make sure to eager load all constants
+  loader.eager_load
 end

data/pricehubble.gemspec

@@ -33,9 +33,10 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.7'
 
-  spec.add_dependency 'activemodel', '>= 5.2'
-  spec.add_dependency 'activesupport', '>= 5.2'
+  spec.add_dependency 'activemodel', '>= 6.1'
+  spec.add_dependency 'activesupport', '>= 6.1'
   spec.add_dependency 'faraday', '~> 1.0'
   spec.add_dependency 'faraday_middleware', '~> 1.0'
   spec.add_dependency 'recursive-open-struct', '~> 2.0'
+  spec.add_dependency 'zeitwerk', '~> 2.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pricehubble
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Hermann Mayer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-10-04 00:00:00.000000000 Z
+date: 2025-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: zeitwerk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.6'
 description: Ruby client for the PriceHubble REST API
 email:
 - hermann.mayer92@gmail.com
@@ -120,10 +134,10 @@ files:
 - doc/examples/property_valuations_errors.rb
 - doc/examples/simple_property_valuations.rb
 - docker-compose.yml
-- gemfiles/rails_5.2.gemfile
 - gemfiles/rails_6.1.gemfile
 - gemfiles/rails_7.1.gemfile
 - lib/price_hubble.rb
+- lib/price_hubble/base_entity.rb
 - lib/price_hubble/client.rb
 - lib/price_hubble/client/authentication.rb
 - lib/price_hubble/client/base.rb
@@ -140,7 +154,6 @@ files:
 - lib/price_hubble/core_ext/hash.rb
 - lib/price_hubble/entity/address.rb
 - lib/price_hubble/entity/authentication.rb
-- lib/price_hubble/entity/base_entity.rb
 - lib/price_hubble/entity/concern/associations.rb
 - lib/price_hubble/entity/concern/attributes.rb
 - lib/price_hubble/entity/concern/attributes/date_array.rb
@@ -160,9 +173,9 @@ files:
 - lib/price_hubble/entity/valuation.rb
 - lib/price_hubble/entity/valuation_request.rb
 - lib/price_hubble/entity/valuation_scores.rb
-- lib/price_hubble/errors.rb
-- lib/price_hubble/faraday.rb
 - lib/price_hubble/identity.rb
+- lib/price_hubble/initializers/errors.rb
+- lib/price_hubble/initializers/faraday.rb
 - lib/price_hubble/instrumentation.rb
 - lib/price_hubble/instrumentation/log_subscriber.rb
 - lib/price_hubble/railtie.rb

data/gemfiles/rails_5.2.gemfile

@@ -1,26 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal", "~> 2.4"
-gem "bundler", "~> 2.3"
-gem "countless", "~> 1.1"
-gem "factory_bot", "~> 6.2", "< 6.4.5"
-gem "guard-rspec", "~> 4.7"
-gem "rake", "~> 13.0"
-gem "redcarpet", "~> 3.5"
-gem "rspec", "~> 3.12"
-gem "rubocop", "~> 1.28"
-gem "rubocop-rails", "~> 2.14"
-gem "rubocop-rspec", "~> 2.10"
-gem "simplecov", ">= 0.22"
-gem "terminal-table", "~> 3.0"
-gem "timecop", ">= 0.9.6"
-gem "vcr", "~> 6.0"
-gem "webmock", "~> 3.18"
-gem "yard", ">= 0.9.28"
-gem "yard-activesupport-concern", ">= 0.0.1"
-gem "activemodel", "~> 5.2.0"
-gem "activesupport", "~> 5.2.0"
-
-gemspec path: "../"