pricehubble 0.4.2 → 1.1.0

data/gemfiles/rails_5.2.gemfile

@@ -1,11 +1,8 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-gem 'activemodel', '~> 5.2.2'
-gem 'activesupport', '~> 5.2.2'
-gem 'railties', '~> 5.2.2'
+gem "activemodel", "~> 5.2.0"
+gem "activesupport", "~> 5.2.0"
 
-gemspec path: '../'
+gemspec path: "../"

data/lib/pricehubble/client/dossiers.rb

@@ -65,8 +65,7 @@ module PriceHubble
       # @param entity [PriceHubble::Dossier] the entity to delete
       # @param args [Hash{Symbol => Mixed}] additional arguments
       #
-      # rubocop:disable Metrics/MethodLength because thats the bare minimum
-      # rubocop:disable Metrics/AbcSize because the decission
+      # rubocop:disable Metrics/MethodLength because thats the bare minimumbecause the decission
       #  handling is quite complex
       def delete_dossier(entity, **args)
         res = connection.delete do |req|
@@ -82,9 +81,8 @@ module PriceHubble
           successful?(res)
         end
       end
-      # rubocop:enable Metrics/MethodLength
-      # rubocop:enable Metrics/AbcSize
 
+      # rubocop:enable Metrics/MethodLength
       # Update a dossier entity.
       #
       # TODO: Implement this.

data/lib/pricehubble/client/request/data_sanitization.rb

@@ -18,7 +18,7 @@ module PriceHubble
           # Perform the data compaction and the hash key transformation,
           # when the body is available and a hash
           env[:body] = body.deep_compact.deep_camelize_keys \
-            if body&.is_a?(Hash)
+            if body.is_a?(Hash)
 
           @app.call(env)
         end

data/lib/pricehubble/client/utils/request.rb

@@ -8,15 +8,15 @@ module PriceHubble
       module Request
         extend ActiveSupport::Concern
 
-        included do
-          # A common HTTP content type to symbol
-          # mapping for correct header settings.
-          CONTENT_TYPE = {
-            json: 'application/json',
-            multipart: 'multipart/form-data',
-            url_encoded: 'application/x-www-form-urlencoded'
-          }.freeze
+        # A common HTTP content type to symbol
+        # mapping for correct header settings.
+        CONTENT_TYPE = {
+          json: 'application/json',
+          multipart: 'multipart/form-data',
+          url_encoded: 'application/x-www-form-urlencoded'
+        }.freeze
 
+        included do
           # Use the configured identity to authenticate the given request.
           #
           # @param req [Faraday::Request] the request to manipulate

data/lib/pricehubble/client/valuation.rb

@@ -12,8 +12,9 @@ module PriceHubble
       #   or +nil+ on error
       #
       # rubocop:disable Metrics/MethodLength because of the request handling
+      # rubocop:disable Metrics/AbcSize dito
       def property_value(request, **args)
-        data = request.attributes(true)
+        data = request.attributes(sanitize: true)
         res = connection.post do |req|
           req.path = '/api/v1/valuation/property_value'
           req.body = data
@@ -27,6 +28,7 @@ module PriceHubble
         end
       end
       # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
 
       # Map and assign the valuation response to our local
       # +PriceHubble::Valuation+ representation. While taking care of the
@@ -42,6 +44,7 @@ module PriceHubble
       #
       # rubocop:disable Metrics/MethodLength because of the request
       #   to response mapping
+      # rubocop:disable Metrics/AbcSize dito
       def assign_valuations(data, request)
         lambda do
           # valuations[i][j] contains the valuation for property i on date j
@@ -60,6 +63,7 @@ module PriceHubble
         end
       end
       # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
 
       # Generate bang method variants
       bangers :property_value

data/lib/pricehubble/core_ext/hash.rb

@@ -38,8 +38,8 @@ class Hash
   def deep_compact_in_object(object)
     case object
     when Hash
-      object = object.compact.each_with_object({}) do |(key, value), result|
-        result[key] = deep_compact_in_object(value)
+      object = object.compact.transform_values do |value|
+        deep_compact_in_object(value)
       end
       object.empty? ? nil : object.compact
     when Array

data/lib/pricehubble/entity/base_entity.rb

@@ -55,6 +55,7 @@ module PriceHubble
       #
       # @param child_class [Class] the child class which inherits us
       def inherited(child_class)
+        super
         match = ->(sym) { sym.to_s.start_with? 'inherited_setup_' }
         trigger = ->(sym) { send(sym, child_class) }
         methods.select(&match).each(&trigger)

data/lib/pricehubble/entity/concern/associations.rb

@@ -45,8 +45,8 @@ module PriceHubble
           key = opts[:from]
 
           # Initialize an object on the association, even without data
-          if opts[:initialize] && send(attribute).nil?
-            hash[key] = {} unless hash.key? key
+          if opts[:initialize] && send(attribute).nil? && !(hash.key? key)
+            hash[key] = {}
           end
 
           return [struct, hash] unless hash.key? key
@@ -92,8 +92,8 @@ module PriceHubble
           key = opts[:fallback_from] if opts[:fallback_from] && !hash.key?(key)
 
           # Initialize an empty array on the association
-          if opts[:initialize] && send(attribute).nil?
-            hash[key] = [] unless hash.key? key
+          if opts[:initialize] && send(attribute).nil? && !(hash.key? key)
+            hash[key] = []
           end
 
           return [struct, hash] unless hash.key? key
@@ -156,6 +156,7 @@ module PriceHubble
           associations[entity] = opts
           # Generate getters and setters
           attr_accessor entity
+
           # Add the entity to the tracked attributes if it should be persisted
           tracked_attr entity if opts[:persist]
         end
@@ -187,6 +188,7 @@ module PriceHubble
           associations[entity] = opts
           # Generate getters and setters
           attr_accessor entity
+
           # Add the entity to the tracked attributes if it should be persisted
           tracked_attr entity if opts[:persist]
         end

data/lib/pricehubble/entity/concern/attributes.rb

@@ -27,7 +27,7 @@ module PriceHubble
         #
         # rubocop:disable Metrics/MethodLength because of the
         #   key/value sanitization handling
-        def attributes(sanitize = false)
+        def attributes(sanitize: false)
           attribute_names.each_with_object({}) do |key, memo|
             reader = key
 
@@ -43,8 +43,8 @@ module PriceHubble
             memo[key.to_s] = result
           end
         end
-        # rubocop:enable Metrics/MethodLength
 
+        # rubocop:enable Metrics/MethodLength
         # A wrapper for the +ActiveModel#assign_attributes+ method with support
         # for unmapped attributes. These attributes are put into the
         # +_unmapped+ struct and all the known attributes are assigned like
@@ -73,20 +73,26 @@ module PriceHubble
         # @param obj [Mixed] the object to resolve its attributes
         # @param sanitize [Boolean] whenever to sanitize the data for transport
         # @return [Mixed] the attribute(s) data
-        def resolve_attributes(obj, sanitize = false)
+        #
+        # rubocop:disable Metrics/MethodLength because thats the pure minimum
+        def resolve_attributes(obj, sanitize: false)
           if obj.respond_to? :attributes
             obj = if obj.method(:attributes).arity == 1
-                    obj.attributes(sanitize)
+                    obj.attributes(sanitize: sanitize)
                   else
                     obj.attributes
                   end
           end
 
-          obj = obj.map { |elem| resolve_attributes(elem, sanitize) } \
-            if obj.is_a? Array
+          if obj.is_a? Array
+            obj = obj.map do |elem|
+              resolve_attributes(elem, sanitize: sanitize)
+            end
+          end
 
           obj
         end
+        # rubocop:enable Metrics/MethodLength
 
         # Explicitly convert the given struct to an +RecursiveOpenStruct+ and a
         # deep symbolized key copy for further usage.
@@ -144,6 +150,7 @@ module PriceHubble
           self.attribute_names += args
           # Define getters/setters
           attr_reader(*args)
+
           args.each do |arg|
             class_eval <<-RUBY, __FILE__, __LINE__ + 1
               def #{arg}=(value)

data/lib/pricehubble/entity/valuation_request.rb

@@ -43,7 +43,7 @@ module PriceHubble
     #
     # @return [Array<Hash{String => Mixed}>] the sanitized properties
     def sanitize_attr_properties
-      properties.map { |prop| { property: prop.attributes(true) } }
+      properties.map { |prop| { property: prop.attributes(sanitize: true) } }
     end
 
     # Perform the property valuation request.

data/lib/pricehubble/identity.rb

@@ -6,6 +6,7 @@ module PriceHubble
   # rubocop:disable Style/ClassVars because we split module code
   module Identity
     extend ActiveSupport::Concern
+
     class_methods do
       # Reset the current identity.
       def reset_identity!

data/lib/pricehubble/utils/decision.rb

@@ -49,7 +49,7 @@ module PriceHubble
         def initialize(on_error: :fail)
           @on_error = on_error
           @bang_proc = -> { StandardError.new }
-          @fail_proc = @good_proc = -> { nil }
+          @fail_proc = @good_proc = -> {}
         end
 
         # Register a new error (bang) way. Requires a block.

data/lib/pricehubble/version.rb

@@ -1,6 +1,23 @@
 # frozen_string_literal: true
 
+# The gem version details.
 module PriceHubble
   # The version of the +price-hubble+ gem
-  VERSION = '0.4.2'
+  VERSION = '1.1.0'
+
+  class << self
+    # Returns the version of gem as a string.
+    #
+    # @return [String] the gem version as string
+    def version
+      VERSION
+    end
+
+    # Returns the version of the gem as a +Gem::Version+.
+    #
+    # @return [Gem::Version] the gem version as object
+    def gem_version
+      Gem::Version.new VERSION
+    end
+  end
 end

data/lib/pricehubble.rb

@@ -13,7 +13,6 @@ require 'active_model'
 require 'recursive-open-struct'
 require 'faraday'
 require 'faraday_middleware'
-require 'pp'
 
 # Load polyfills if needed
 require 'pricehubble/core_ext/hash'

data/pricehubble.gemspec

@@ -5,45 +5,56 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'pricehubble/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'pricehubble'
-  spec.version       = PriceHubble::VERSION
-  spec.authors       = ['Hermann Mayer']
-  spec.email         = ['hermann.mayer92@gmail.com']
+  spec.name = 'pricehubble'
+  spec.version = PriceHubble::VERSION
+  spec.authors = ['Hermann Mayer']
+  spec.email = ['hermann.mayer92@gmail.com']
 
-  spec.summary       = 'Ruby client for the PriceHubble REST API'
-  spec.description   = 'Ruby client for the PriceHubble REST API'
-  spec.homepage      = 'https://github.com/hausgold/pricehubble'
+  spec.license = 'MIT'
+  spec.summary = 'Ruby client for the PriceHubble REST API'
+  spec.description = 'Ruby client for the PriceHubble REST API'
 
-  spec.required_ruby_version = '~> 2.5'
+  base_uri = "https://github.com/hausgold/#{spec.name}"
+  spec.metadata = {
+    'homepage_uri' => base_uri,
+    'source_code_uri' => base_uri,
+    'changelog_uri' => "#{base_uri}/blob/master/CHANGELOG.md",
+    'bug_tracker_uri' => "#{base_uri}/issues",
+    'documentation_uri' => "https://www.rubydoc.info/gems/#{spec.name}"
+  }
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'activemodel', '>= 5.2.0'
-  spec.add_runtime_dependency 'activesupport', '>= 5.2.0'
+  spec.required_ruby_version = '>= 2.5'
+
+  spec.add_runtime_dependency 'activemodel', '>= 5.2'
+  spec.add_runtime_dependency 'activesupport', '>= 5.2'
   spec.add_runtime_dependency 'faraday', '~> 1.0'
   spec.add_runtime_dependency 'faraday_middleware', '~> 1.0'
   spec.add_runtime_dependency 'recursive-open-struct', '~> 1.1'
 
-  spec.add_development_dependency 'appraisal'
-  spec.add_development_dependency 'bundler', '>= 1.16', '< 3'
-  spec.add_development_dependency 'factory_bot', '~> 4.11'
-  spec.add_development_dependency 'railties', '>= 4.2.0', '< 6.1'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rdoc', '~> 6.1'
-  spec.add_development_dependency 'redcarpet', '~> 3.4'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.63.1'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.31'
-  spec.add_development_dependency 'simplecov', '< 0.18'
-  spec.add_development_dependency 'terminal-table', '~> 1.8'
-  spec.add_development_dependency 'timecop', '~> 0.9.1'
-  spec.add_development_dependency 'vcr', '~> 3.0'
-  spec.add_development_dependency 'webmock', '~> 3.5'
-  spec.add_development_dependency 'yard', '~> 0.9.18'
-  spec.add_development_dependency 'yard-activesupport-concern', '~> 0.0.1'
+  spec.add_development_dependency 'appraisal', '~> 2.4'
+  spec.add_development_dependency 'bundler', '~> 2.3'
+  spec.add_development_dependency 'countless', '~> 1.1'
+  spec.add_development_dependency 'factory_bot', '~> 6.2'
+  spec.add_development_dependency 'guard-rspec', '~> 4.7'
+  spec.add_development_dependency 'rake', '~> 13.0'
+  spec.add_development_dependency 'redcarpet', '~> 3.5'
+  spec.add_development_dependency 'rspec', '~> 3.12'
+  spec.add_development_dependency 'rubocop', '~> 1.28'
+  spec.add_development_dependency 'rubocop-rails', '~> 2.14'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.10'
+  spec.add_development_dependency 'simplecov', '>= 0.22'
+  spec.add_development_dependency 'terminal-table', '~> 3.0'
+  spec.add_development_dependency 'timecop', '>= 0.9.6'
+  spec.add_development_dependency 'vcr', '~> 6.0'
+  spec.add_development_dependency 'webmock', '~> 3.18'
+  spec.add_development_dependency 'yard', '>= 0.9.28'
+  spec.add_development_dependency 'yard-activesupport-concern', '>= 0.0.1'
 end