pricehubble 0.4.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1c2e582e583c4400274fdd33ec9b4150ce4910a8bd6b8aeec4cbf029378bc89
-  data.tar.gz: 2edaa056bc36349f835250e4a55414022b55a0773c0d215c35c706bd023cd925
+  metadata.gz: 3f1ed8db96f0efa1edf1011116a4269e35a075b9b162b13d68a4e6c08d81d9cb
+  data.tar.gz: 00b1e03b3c0f76e577c2fdea0108c03d9743a6bfe73c00d71b4183e2f9b0aa05
 SHA512:
-  metadata.gz: 8ac3db724b8f3f60e1a760b36f248772b601824ea63cd24bcfedcefe6ba31128bfaf8d0956280335775c5bf5a5faae652cb6348b11c700f2aff1c91a0179c37e
-  data.tar.gz: 566857d2fb6ce6163b55cbc2d3d3c46ecedd20e46565bde0aedb205902c7aca01c99f689d60fb38afce263a7f87c47cdca00dba928d426b64a11c6241234d937
+  metadata.gz: 8822ad28938b426cd42242cbeebacf6c4697eb17187343c3478e415a9ade67add42c13d0c01bd378efaab3f0252d6e7916e7ce9a48055b5bb9060553467bffb3
+  data.tar.gz: 0fcc8813a696d6c64e9dc8ba70676ee129621189bee80da841c3d02b96f6587fa99a4d72bf312dc300fa484798d801c46152543d7136c9a7880dfd34baeae6bc

data/.github/workflows/documentation.yml

@@ -0,0 +1,39 @@
+name: Build Documentation
+on:
+  repository_dispatch:
+    types: [documentation]
+
+concurrency:
+  group: 'docs'
+
+jobs:
+  docs:
+    name: Build gem documentation
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install the correct Ruby version
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.5
+          bundler-cache: true
+          rubygems: '3.3.26'
+
+      - name: Prepare the virtual environment
+        uses: hausgold/actions/ci@master
+        with:
+          clone_token: '${{ secrets.CLONE_TOKEN }}'
+          settings: '${{ github.repository }}'
+          target: ci/gem-test
+
+      - name: Build gem documentation
+        run: make docs
+
+      - name: Upload the code coverage report
+        run: coverage
+
+      - name: Add this job to the commit status
+        run: commit-status '${{ job.status }}'
+        if: always()

data/.github/workflows/test.yml

@@ -0,0 +1,63 @@
+name: Test
+on:
+  push:
+    branches:
+      - '**'
+  schedule:
+    - cron: '0 0 * * MON'
+
+concurrency:
+  group: '${{ github.ref }}'
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: 'Test the gem (Ruby ${{ matrix.ruby }}, Rails ${{ matrix.rails }})'
+    runs-on: ubuntu-22.04
+    timeout-minutes: 5
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['2.5', '2.7']
+        rails: ['5.2']
+    env:
+      BUNDLE_GEMFILE: 'gemfiles/rails_${{ matrix.rails }}.gemfile'
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install the correct Ruby version
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+          rubygems: '3.3.26'
+
+      - name: Prepare the virtual environment
+        uses: hausgold/actions/ci@master
+        with:
+          clone_token: '${{ secrets.CLONE_TOKEN }}'
+          settings: '${{ github.repository }}'
+          target: ci/gem-test
+
+      - name: Run the gem tests
+        run: make test
+
+      - name: Upload the code coverage report
+        run: coverage
+
+  trigger-docs:
+    name: Trigger the documentation upload
+    runs-on: ubuntu-22.04
+    timeout-minutes: 2
+    needs: test
+    if: github.ref == 'refs/heads/master'
+    steps:
+      - name: Prepare the virtual environment
+        uses: hausgold/actions/ci@master
+        with:
+          clone_token: '${{ secrets.CLONE_TOKEN }}'
+          settings: '${{ github.repository }}'
+          target: ci/noop
+
+      - name: Trigger the documentation upload
+        run: workflow documentation

data/.rspec

@@ -1,3 +1,3 @@
+--backtrace
+--force-color
 --format documentation
---color
---require spec_helper

data/.rubocop.yml

@@ -1,19 +1,24 @@
-require: rubocop-rspec
+require:
+  - rubocop-rspec
+  - rubocop-rails
 
 Rails:
   Enabled: true
 
-Documentation:
+Style/Documentation:
   Enabled: true
 
 AllCops:
+  NewCops: enable
+  SuggestExtensions: false
   DisplayCopNames: true
   TargetRubyVersion: 2.5
+  TargetRailsVersion: 5.2
   Exclude:
     - bin/**/*
     - vendor/**/*
     - build/**/*
-    - gemfiles/vendor/**/*
+    - gemfiles/**/*
 
 Metrics/BlockLength:
   Exclude:
@@ -27,6 +32,10 @@ Metrics/BlockLength:
     - lib/pricehubble/client/request/**/*.rb
     - lib/pricehubble/client/response/**/*.rb
 
+# MFA is not yet enabled for our gems yet.
+Gemspec/RequireMFA:
+  Enabled: false
+
 # Document all the things.
 Style/DocumentationMethod:
   Enabled: true
@@ -63,5 +72,20 @@ Lint/ShadowingOuterLocalVariable:
 
 # We stay at 80 characters per line.
 # See: https://rubystyle.guide/#max-line-length
-Metrics/LineLength:
+Layout/LineLength:
   Max: 80
+
+# We use memoized helpers all over the place to construct inputs and output
+# which can be customized at nested contexts easily.
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+# That are false-positives because we implement similar working
+# helpers for associations like +.has_one+.
+Rails/ReflectionClassName:
+  Enabled: false
+
+# A very nice feature, but it does not work for non-method code parts atow.
+# So just disabling it for now.
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false

data/.simplecov

@@ -1,3 +1,15 @@
+# frozen_string_literal: true
+
+require 'simplecov-html'
+require 'simplecov_json_formatter'
+
+SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new(
+  [
+    SimpleCov::Formatter::HTMLFormatter,
+    SimpleCov::Formatter::JSONFormatter
+  ]
+)
+
 SimpleCov.start 'test_frameworks' do
   add_filter '/vendor/bundle/'
 end

data/Appraisals

@@ -1,13 +1,6 @@
 # frozen_string_literal: true
 
 appraise 'rails-5.2' do
-  gem 'activemodel', '~> 5.2.2'
-  gem 'activesupport', '~> 5.2.2'
-  gem 'railties', '~> 5.2.2'
-end
-
-appraise 'rails-6.0' do
-  gem 'activemodel', '~> 6.0.0'
-  gem 'activesupport', '~> 6.0.0'
-  gem 'railties', '~> 6.0.0'
+  gem 'activemodel', '~> 5.2.0'
+  gem 'activesupport', '~> 5.2.0'
 end

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+### 1.0.0
+
+* Bundler >= 2.3 is from now on required as minimal version (#5)
+* Dropped support for Ruby < 2.5 (#5)
+* Dropped support for Rails < 5.2 (#5)
+* Updated all development/runtime gems to their latest
+  Ruby 2.5 compatible version (#5)
+* [Breaking Change] The `sanitize` argument of the
+  `PriceHubble::BaseEntity#attributes(sanitize = false)` method has changed to
+  a keyword argument `PriceHubble::BaseEntity#attributes(sanitize: false)` (#5)
+
+### 0.4.2
+
+* Migrated to Github Actions
+* Migrated to our own coverage reporting
+* Added the code statistics to the test process
+
 ### 0.4.1
 
 * Corrected the GNU Make release target

data/Dockerfile

@@ -2,7 +2,7 @@ FROM hausgold/ruby:2.5
 MAINTAINER Hermann Mayer <hermann.mayer@hausgold.de>
 
 # Update system gem
-RUN gem update --system
+RUN gem update --system '3.3.26'
 
 # Install system packages and the latest bundler
 RUN apt-get update -yqqq && \
@@ -11,8 +11,7 @@ RUN apt-get update -yqqq && \
     ca-certificates \
     bash-completion inotify-tools && \
   echo 'en_US.UTF-8 UTF-8' >> /etc/locale.gen && /usr/sbin/locale-gen && \
-  gem install bundler -v '~> 2.0' --no-document --no-prerelease && \
-  gem install bundler -v '~> 1.0' --no-document --no-prerelease
+  gem install bundler -v '~> 2.3.0' --no-document --no-prerelease
 
 # Add new web user
 RUN mkdir /app && \

data/Guardfile

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+(directories %w[lib spec]).select do |d|
+  if Dir.exist?(d)
+    d
+  else
+    UI.warning("Directory #{d} does not exist")
+  end
+end
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# NOTE: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  watch('spec/spec_helper.rb') { 'spec' }
+  watch(%r{^lib/pricehubble.rb}) { 'spec' }
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/pricehubble/([^\\]+)\.rb$}) do |m|
+    "spec/pricehubble/#{m[1]}_spec.rb"
+  end
+  watch(%r{^lib/pricehubble/([^\\]+)/(.*)\.rb$}) do |m|
+    "spec/#{m[1]}/#{m[2]}_spec.rb"
+  end
+end

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 HAUSGOLD | talocasa GmbH
+Copyright (c) 2023 HAUSGOLD | talocasa GmbH
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Makefile

@@ -9,6 +9,7 @@ SHELL := bash
 # Environment switches
 MAKE_ENV ?= docker
 COMPOSE_RUN_SHELL_FLAGS ?= --rm
+BASH_RUN_SHELL_FLAGS ?=
 
 # Directories
 VENDOR_DIR ?= vendor/bundle
@@ -26,13 +27,14 @@ RM ?= rm
 XARGS ?= xargs
 
 # Container binaries
-BUNDLE ?= bundle
 APPRAISAL ?= appraisal
+BUNDLE ?= bundle
 GEM ?= gem
+GUARD ?= guard
 RAKE ?= rake
-YARD ?= yard
-RAKE ?= rake
+RSPEC ?= rspec
 RUBOCOP ?= rubocop
+YARD ?= yard
 
 # Files
 GEMFILES ?= $(subst _,-,$(patsubst $(GEMFILES_DIR)/%.gemfile,%,\
@@ -46,7 +48,8 @@ define run-shell
 	$(COMPOSE) run $(COMPOSE_RUN_SHELL_FLAGS) \
 		-e LANG=en_US.UTF-8 -e LANGUAGE=en_US.UTF-8 -e LC_ALL=en_US.UTF-8 \
 		-e HOME=/home/web -e BUNDLE_APP_CONFIG=/app/.bundle \
-		-u `$(ID) -u` test bash -c 'sleep 0.1; echo; $(1)'
+		-u `$(ID) -u` test \
+		bash $(BASH_RUN_SHELL_FLAGS) -c 'sleep 0.1; echo; $(1)'
 endef
 else ifeq ($(MAKE_ENV),baremetal)
 define run-shell
@@ -63,6 +66,7 @@ all:
 	#
 	# test               Run the whole test suite
 	# test-style         Test the code styles
+	# watch              Watch for code changes and rerun the test suite
 	#
 	# docs               Generate the Ruby documentation of the library
 	# stats              Print the code statistics (library and test suite)
@@ -72,27 +76,37 @@ all:
 	# shell              Run an interactive shell on the container
 	# shell-irb          Run an interactive IRB shell on the container
 
+.interactive:
+	@$(eval BASH_RUN_SHELL_FLAGS = --login)
+
 install:
 	# Install the dependencies
 	@$(MKDIR) -p $(VENDOR_DIR)
 	@$(call run-shell,$(BUNDLE) check || $(BUNDLE) install --path $(VENDOR_DIR))
-	@$(call run-shell,GEM_HOME=vendor/bundle/ruby/$${RUBY_MAJOR}.0 \
-		$(GEM) install bundler -v "~> 1.0")
 	@$(call run-shell,$(BUNDLE) exec $(APPRAISAL) install)
 
-update: install
+update:
 	# Install the dependencies
 	@$(MKDIR) -p $(VENDOR_DIR)
+	@$(call run-shell,$(BUNDLE) update)
 	@$(call run-shell,$(BUNDLE) exec $(APPRAISAL) update)
 
-test: #install
+watch: install .interactive
+	# Watch for code changes and rerun the test suite
+	@$(call run-shell,$(BUNDLE) exec $(GUARD))
+
+test: \
+	test-specs \
+	test-style
+
+test-specs:
 	# Run the whole test suite
-	@$(call run-shell,$(BUNDLE) exec $(RAKE))
+	@$(call run-shell,$(BUNDLE) exec $(RAKE) stats spec)
 
 $(TEST_GEMFILES): GEMFILE=$(@:test-%=%)
 $(TEST_GEMFILES):
 	# Run the whole test suite ($(GEMFILE))
-	@$(call run-shell,$(BUNDLE) exec $(APPRAISAL) $(GEMFILE) $(RAKE))
+	@$(call run-shell,$(BUNDLE) exec $(APPRAISAL) $(GEMFILE) $(RSPEC))
 
 test-style: \
 	test-style-ruby
@@ -107,8 +121,8 @@ clean:
 	@$(RM) -rf $(VENDOR_DIR)/Gemfile.lock
 	@$(RM) -rf $(GEMFILES_DIR)/vendor
 	@$(RM) -rf $(GEMFILES_DIR)/*.lock
-	@$(RM) -rf pkg
-	@$(RM) -rf coverage
+	@$(RM) -rf .bundle .yardoc coverage pkg Gemfile.lock doc/api \
+		.rspec_status
 
 clean-containers:
 	# Clean running containers
@@ -119,31 +133,31 @@ endif
 clean-images:
 	# Clean build images
 ifeq ($(MAKE_ENV),docker)
-	@-$(DOCKER) images | $(GREP) pricehubble \
+	@-$(DOCKER) images | $(GREP) $(shell basename "`pwd`") \
 		| $(AWK) '{ print $$3 }' \
 		| $(XARGS) -rn1 $(DOCKER) rmi -f
 endif
 
 distclean: clean clean-containers clean-images
 
-shell: install
+shell:
 	# Run an interactive shell on the container
 	@$(call run-shell,$(BASH) -i)
 
-shell-irb: install
+shell-irb:
 	# Run an interactive IRB shell on the container
 	@$(call run-shell,bin/console)
 
-docs: install
+docs:
 	# Build the API documentation
 	@$(call run-shell,$(BUNDLE) exec $(YARD) -q && \
 		$(BUNDLE) exec $(YARD) stats --list-undoc --compact)
 
-notes: install
+notes:
 	# Print the code statistics (library and test suite)
 	@$(call run-shell,$(BUNDLE) exec $(RAKE) notes)
 
-stats: install
+stats:
 	# Print all the notes from the code
 	@$(call run-shell,$(BUNDLE) exec $(RAKE) stats)
 

data/README.md

@@ -1,10 +1,10 @@
 ![PriceHubble](doc/assets/project.svg)
 
-[![Build Status](https://travis-ci.com/hausgold/pricehubble.svg?token=4XcyqxxmkyBSSV3wWRt7&branch=master)](https://travis-ci.com/hausgold/pricehubble)
+[![Continuous Integration](https://github.com/hausgold/pricehubble/actions/workflows/test.yml/badge.svg?branch=master)](https://github.com/hausgold/pricehubble/actions/workflows/test.yml)
 [![Gem Version](https://badge.fury.io/rb/pricehubble.svg)](https://badge.fury.io/rb/pricehubble)
-[![Maintainability](https://api.codeclimate.com/v1/badges/cd15f59fc84566e4b200/maintainability)](https://codeclimate.com/repos/5da572bd60163201b800c255/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/cd15f59fc84566e4b200/test_coverage)](https://codeclimate.com/repos/5da572bd60163201b800c255/test_coverage)
-[![API docs](https://img.shields.io/badge/docs-API-blue.svg)](https://www.rubydoc.info/gems/pricehubble)
+[![Test Coverage](https://automate-api.hausgold.de/v1/coverage_reports/pricehubble/coverage.svg)](https://knowledge.hausgold.de/coverage)
+[![Test Ratio](https://automate-api.hausgold.de/v1/coverage_reports/pricehubble/ratio.svg)](https://knowledge.hausgold.de/coverage)
+[![API docs](https://automate-api.hausgold.de/v1/coverage_reports/pricehubble/documentation.svg)](https://www.rubydoc.info/gems/pricehubble)
 
 This project is dedicated to build a client/API wrapper around the
 [PriceHubble](https://pricehubble.com) REST API. It follows strictly the

data/Rakefile

@@ -2,79 +2,30 @@
 
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
-require 'rails/code_statistics'
-require 'pp'
+require 'countless/rake_tasks'
 
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
 
-# Load some railties tasks
-load 'rails/tasks/statistics.rake'
-load 'rails/tasks/annotations.rake'
-
-# Clear the default statistics directory constant
-#
-# rubocop:disable Style/MutableConstant because we define it
-Object.send(:remove_const, :STATS_DIRECTORIES)
-::STATS_DIRECTORIES = []
-# rubocop:enable Style/MutableConstant
-
-# Monkey patch the Rails +CodeStatistics+ class to support configurable
-# patterns per path. This is reuqired to support top-level only file matches.
-class CodeStatistics
-  DEFAULT_PATTERN = /^(?!\.).*?\.(rb|js|coffee|rake)$/.freeze
-
-  # Pass the possible +pattern+ argument down to the
-  # +calculate_directory_statistics+ method call.
-  def calculate_statistics
-    Hash[@pairs.map do |pair|
-      [pair.first, calculate_directory_statistics(*pair[1..-1])]
-    end]
-  end
-
-  # Match the pattern against the individual file name and the relative file
-  # path. This allows top-level only matches.
-  def calculate_directory_statistics(directory, pattern = DEFAULT_PATTERN)
-    stats = CodeStatisticsCalculator.new
-
-    Dir.foreach(directory) do |file_name|
-      path = "#{directory}/#{file_name}"
-
-      if File.directory?(path) && (/^\./ !~ file_name)
-        stats.add(calculate_directory_statistics(path, pattern))
-      elsif file_name =~ pattern || path =~ pattern
-        stats.add_by_file_path(path)
-      end
-    end
-
-    stats
-  end
-end
-
 # Configure all code statistics directories
-vendors = [
-  [:unshift, 'Clients', 'lib/pricehubble/client'],
-  [:unshift, 'Entities', 'lib/pricehubble/entity'],
-  [:unshift, 'Utilities', 'lib/pricehubble/utils'],
-  [:unshift, 'Top-levels', 'lib', %r{lib(/pricehubble)?/[^/]+\.rb$}],
-
-  [:unshift, 'Clients specs', 'spec/client'],
-  [:unshift, 'Entities specs', 'spec/entity'],
-  [:unshift, 'Utilities specs', 'spec/utils'],
-  [:unshift, 'Top-levels specs', 'spec',
-   %r{spec/pricehubble(_spec\.rb|/[^/]+\.rb$)}]
-].reverse
-
-vendors.each do |method, type, dir, pattern|
-  ::STATS_DIRECTORIES.send(method, [type, dir, pattern].compact)
-  ::CodeStatistics::TEST_TYPES << type if type.include? 'specs'
-end
-
-# Setup annotations
-ENV['SOURCE_ANNOTATION_DIRECTORIES'] = 'spec,doc'
-
-desc 'Enumerate all annotations'
-task :notes do
-  SourceAnnotationExtractor.enumerate '@?OPTIMIZE|@?FIXME|@?TODO', tag: true
+Countless.configure do |config|
+  config.stats_base_directories = [
+    { name: 'Top-levels', dir: 'lib',
+      pattern: %r{/lib(/pricehubble)?/[^/]+\.rb$} },
+    { name: 'Top-levels specs', test: true, dir: 'spec',
+      pattern: %r{/spec(/pricehubble)?/[^/]+_spec\.rb$} },
+    { name: 'Clients', pattern: 'lib/pricehubble/client/**/*.rb' },
+    { name: 'Clients specs', test: true,
+      pattern: 'spec/client/**/*_spec.rb' },
+    { name: 'Entities', pattern: 'lib/pricehubble/entity/**/*.rb' },
+    { name: 'Entities specs', test: true,
+      pattern: 'spec/entity/**/*_spec.rb' },
+    { name: 'Utilities', pattern: 'lib/pricehubble/utils/**/*.rb' },
+    { name: 'Utilities specs', test: true,
+      pattern: 'spec/utils/**/*_spec.rb' },
+    { name: 'Instrumentation',
+      pattern: 'lib/pricehubble/instrumentation/**/*.rb' },
+    { name: 'Core Extensions', pattern: 'lib/pricehubble/core_ext/**/*.rb' }
+  ]
 end

data/gemfiles/rails_5.2.gemfile

@@ -1,11 +1,8 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-gem 'activemodel', '~> 5.2.2'
-gem 'activesupport', '~> 5.2.2'
-gem 'railties', '~> 5.2.2'
+gem "activemodel", "~> 5.2.0"
+gem "activesupport", "~> 5.2.0"
 
-gemspec path: '../'
+gemspec path: "../"

data/lib/pricehubble/client/dossiers.rb

@@ -65,8 +65,7 @@ module PriceHubble
       # @param entity [PriceHubble::Dossier] the entity to delete
       # @param args [Hash{Symbol => Mixed}] additional arguments
       #
-      # rubocop:disable Metrics/MethodLength because thats the bare minimum
-      # rubocop:disable Metrics/AbcSize because the decission
+      # rubocop:disable Metrics/MethodLength because thats the bare minimumbecause the decission
       #  handling is quite complex
       def delete_dossier(entity, **args)
         res = connection.delete do |req|
@@ -82,9 +81,8 @@ module PriceHubble
           successful?(res)
         end
       end
-      # rubocop:enable Metrics/MethodLength
-      # rubocop:enable Metrics/AbcSize
 
+      # rubocop:enable Metrics/MethodLength
       # Update a dossier entity.
       #
       # TODO: Implement this.

data/lib/pricehubble/client/request/data_sanitization.rb

@@ -18,7 +18,7 @@ module PriceHubble
           # Perform the data compaction and the hash key transformation,
           # when the body is available and a hash
           env[:body] = body.deep_compact.deep_camelize_keys \
-            if body&.is_a?(Hash)
+            if body.is_a?(Hash)
 
           @app.call(env)
         end

data/lib/pricehubble/client/utils/request.rb

@@ -8,15 +8,15 @@ module PriceHubble
       module Request
         extend ActiveSupport::Concern
 
-        included do
-          # A common HTTP content type to symbol
-          # mapping for correct header settings.
-          CONTENT_TYPE = {
-            json: 'application/json',
-            multipart: 'multipart/form-data',
-            url_encoded: 'application/x-www-form-urlencoded'
-          }.freeze
+        # A common HTTP content type to symbol
+        # mapping for correct header settings.
+        CONTENT_TYPE = {
+          json: 'application/json',
+          multipart: 'multipart/form-data',
+          url_encoded: 'application/x-www-form-urlencoded'
+        }.freeze
 
+        included do
           # Use the configured identity to authenticate the given request.
           #
           # @param req [Faraday::Request] the request to manipulate

data/lib/pricehubble/client/valuation.rb

@@ -12,8 +12,9 @@ module PriceHubble
       #   or +nil+ on error
       #
       # rubocop:disable Metrics/MethodLength because of the request handling
+      # rubocop:disable Metrics/AbcSize dito
       def property_value(request, **args)
-        data = request.attributes(true)
+        data = request.attributes(sanitize: true)
         res = connection.post do |req|
           req.path = '/api/v1/valuation/property_value'
           req.body = data
@@ -27,6 +28,7 @@ module PriceHubble
         end
       end
       # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
 
       # Map and assign the valuation response to our local
       # +PriceHubble::Valuation+ representation. While taking care of the
@@ -42,6 +44,7 @@ module PriceHubble
       #
       # rubocop:disable Metrics/MethodLength because of the request
       #   to response mapping
+      # rubocop:disable Metrics/AbcSize dito
       def assign_valuations(data, request)
         lambda do
           # valuations[i][j] contains the valuation for property i on date j
@@ -60,6 +63,7 @@ module PriceHubble
         end
       end
       # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/AbcSize
 
       # Generate bang method variants
       bangers :property_value