previews 0.0.3 → 0.0.4

data/.travis.yml

@@ -0,0 +1,6 @@
+script: 'bundle exec rake'
+rvm:
+  - 1.9.2
+  - 1.9.3
+  - 1.8.7
+  - ruby-head

data/Gemfile.lock

@@ -0,0 +1,23 @@
+PATH
+  remote: .
+  specs:
+    previews (0.0.3)
+      hirb (~> 0.6.0)
+      json (~> 1.6.3)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    hirb (0.6.0)
+    json (1.6.3)
+    rake (0.9.2.2)
+    rdoc (3.12)
+      json (~> 1.4)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  previews!
+  rake (~> 0.9.2)
+  rdoc

data/Rakefile

@@ -1,8 +1,6 @@
 require 'bundler'
 require 'rake/clean'
 require 'rake/testtask'
-require 'cucumber'
-require 'cucumber/rake/task'
 gem 'rdoc' # we need the installed RDoc gem, not the system one
 require 'rdoc/task'
 
@@ -14,18 +12,12 @@ Rake::TestTask.new do |t|
   t.pattern = 'test/tc_*.rb'
 end
 
-CUKE_RESULTS = 'results.html'
-CLEAN << CUKE_RESULTS
-Cucumber::Rake::Task.new(:features) do |t|
-  t.cucumber_opts = "features --format html -o #{CUKE_RESULTS} --format progress -x"
-  t.fork = false
-end
 
 Rake::RDocTask.new do |rd|
-  
+
   rd.main = "README.rdoc"
-  
+
   rd.rdoc_files.include("README.rdoc","lib/**/*.rb","bin/**/*")
 end
 
-task :default => [:test,:features]
+task :default => [:test]

data/lib/previews/array.rb

@@ -15,8 +15,8 @@ class Array
   # By default reviews sorted by usefulness. We can reverse it to sort by ascending
   # For others fields we sorting by comparing each element of Array
   def sort_with!(field, direction)
-    self          if 'usefulness' == field && 'desc' == direction
-    self.reverse! if 'usefulness' == field && 'asc'  == direction
+    return self          if 'usefulness' == field && 'desc' == direction
+    return self.reverse! if 'usefulness' == field && 'asc'  == direction
     if 'asc' == direction
       self.sort! { |review1, review2| review1[field] <=> review2[field]}
     elsif 'desc' == direction

data/lib/previews/version.rb

@@ -1,3 +1,3 @@
 module Previews
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/previews.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+require 'rubygems'
 require 'json'
 require 'net/http'
 require 'previews/version'

data/previews.gemspec

@@ -19,9 +19,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_development_dependency('rdoc')
-  s.add_development_dependency('aruba')
   s.add_development_dependency('rake','~> 0.9.2')
-  s.add_dependency('methadone')
   s.add_dependency('hirb', '~> 0.6.0')
   s.add_dependency('json', '~> 1.6.3')
 end

data/test/tc_array.rb

@@ -0,0 +1,90 @@
+require 'tc_helper'
+
+class TestArray < Test::Unit::TestCase
+  def setup
+    @reviews = [{"origin"=>"ubuntu",
+      "rating"=>5,
+      "hide"=>false,
+      "app_name"=>"VLC media player",
+      "language"=>"en",
+      "reviewer_username"=>"p8KFRbG",
+      "usefulness_total"=>3,
+      "usefulness_favorable"=>2,
+      "review_text"=>"I have one on my Windows 7. And now on Ubuntu",
+      "date_deleted"=>nil,
+      "summary"=>"Great player!!",
+      "version"=>"1.1.12-2~oneiric1",
+      "id"=>27925,
+      "date_created"=>"2011-11-01 00:39:57",
+      "reviewer_displayname"=>"Ruden Estolonio",
+      "package_name"=>"vlc",
+      "distroseries"=>"oneiric"},
+      {"origin"=>"ubuntu",
+      "rating"=>3,
+      "hide"=>false,
+      "app_name"=>"VLC media player",
+      "language"=>"en",
+      "reviewer_username"=>"javanmardy",
+      "usefulness_total"=>2,
+      "usefulness_favorable"=>1,
+      "review_text"=>"Useful but it ant show subtitles on another language",
+      "date_deleted"=>nil,
+      "summary"=>"Could be better",
+      "version"=>"1.1.12-2~oneiric1",
+      "id"=>28416,
+      "date_created"=>"2011-11-04 05:35:45",
+      "reviewer_displayname"=>"Behrouz",
+      "package_name"=>"vlc",
+      "distroseries"=>"oneiric"}]
+  end
+
+  def test_replace_rating_with
+    @reviews.replace_rating_with('+','-')
+    assert_equal '+++++', @reviews[0]['rating']
+    assert_equal '+++--', @reviews[1]['rating']
+  end
+
+  def test_parse_date_time
+    @reviews.parse_date_time
+    assert_equal '2011-11-01T00:39:57+00:00', @reviews[0]['date_created'].to_s
+    assert_equal '2011-11-04T05:35:45+00:00', @reviews[1]['date_created'].to_s
+  end
+
+  def test_sort_with_usefulness_desc
+    initial_reviews = @reviews
+    @reviews.sort_with!('usefulness', 'desc')
+    assert_equal initial_reviews, @reviews
+  end
+
+  def test_sort_with_usefulness_asc
+    @reviews.sort_with!('usefulness', 'asc')
+    assert_equal 28416, @reviews[0]['id']
+    assert_equal 27925, @reviews[1]['id']
+  end
+
+  def test_sort_with_date_created_desc
+    @reviews.parse_date_time
+    @reviews.sort_with!('date_created', 'desc')
+    assert_equal 28416, @reviews[0]['id']
+    assert_equal 27925, @reviews[1]['id']
+  end
+
+  def test_sort_with_date_created_asc
+    @reviews.parse_date_time
+    @reviews.sort_with!('date_created', 'asc')
+    assert_equal 27925, @reviews[0]['id']
+    assert_equal 28416, @reviews[1]['id']
+  end
+
+  def test_sort_with_rating_asc
+    @reviews.sort_with!('rating', 'asc')
+    assert_equal 28416, @reviews[0]['id']
+    assert_equal 27925, @reviews[1]['id']
+  end
+
+  def test_sort_with_rating_desc
+    @reviews.sort_with!('rating', 'desc')
+    assert_equal 27925, @reviews[0]['id']
+    assert_equal 28416, @reviews[1]['id']
+  end
+end

data/test/tc_helper.rb

@@ -0,0 +1,4 @@
+require 'test/unit'
+require 'previews'
+$LOAD_PATH << File.dirname(__FILE__)
+$LOAD_PATH << File.join(File.dirname(__FILE__), *%w[.. lib])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: previews
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-12-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &19746740 !ruby/object:Gem::Requirement
+  requirement: &10000620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,21 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *19746740
-- !ruby/object:Gem::Dependency
-  name: aruba
-  requirement: &19746320 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: *19746320
+  version_requirements: *10000620
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &19745800 !ruby/object:Gem::Requirement
+  requirement: &10000120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,21 +32,10 @@ dependencies:
         version: 0.9.2
   type: :development
   prerelease: false
-  version_requirements: *19745800
-- !ruby/object:Gem::Dependency
-  name: methadone
-  requirement: &19745380 !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: *19745380
+  version_requirements: *10000120
 - !ruby/object:Gem::Dependency
   name: hirb
-  requirement: &19744840 !ruby/object:Gem::Requirement
+  requirement: &9999620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +43,10 @@ dependencies:
         version: 0.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *19744840
+  version_requirements: *9999620
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &19744340 !ruby/object:Gem::Requirement
+  requirement: &9999160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,7 +54,7 @@ dependencies:
         version: 1.6.3
   type: :runtime
   prerelease: false
-  version_requirements: *19744340
+  version_requirements: *9999160
 description: previews lets you read user reviews of linux packages from your console.
 email:
 - divout@gmail.com
@@ -86,20 +64,20 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
+- Gemfile.lock
 - MIT-LICENSE
 - README.md
 - Rakefile
 - bin/previews
-- features/previews.feature
-- features/step_definitions/previews_steps.rb
-- features/support/env.rb
 - lib/previews.rb
 - lib/previews/array.rb
 - lib/previews/hirb_vertical_table.rb
 - lib/previews/version.rb
 - previews.gemspec
-- test/tc_something.rb
+- test/tc_array.rb
+- test/tc_helper.rb
 homepage: ''
 licenses: []
 post_install_message: 

data/features/previews.feature

@@ -1,11 +0,0 @@
-Feature: My bootstrapped app kinda works
-  In order to get going on coding my awesome app
-  I want to have aruba and cucumber setup
-  So I don't have to do it myself
-
-  Scenario: App just runs
-    When I get help for "previews"
-    Then the exit status should be 0
-    And the banner should be present
-    And the banner should document that this app takes no options
-    And the banner should document that this app takes no arguments

data/features/step_definitions/previews_steps.rb

@@ -1 +0,0 @@
-# Put your step defintions here

data/features/support/env.rb

@@ -1,9 +0,0 @@
-require 'aruba/cucumber'
-require 'methadone/cucumber'
-
-ENV['PATH'] = "#{File.expand_path(File.dirname(__FILE__) + '/../../bin')}#{File::PATH_SEPARATOR}#{ENV['PATH']}"
-
-Before do
-  # Using "announce" causes massive warnings on 1.9.2
-  @puts = true
-end

data/test/tc_something.rb

@@ -1,7 +0,0 @@
-require 'test/unit'
-
-class TestSomething < Test::Unit::TestCase
-  def test_truth
-    assert true
-  end
-end