pretty_proxy 4.0.5 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c16832f5f4322e0c4336890282344a1077fe37e5
-  data.tar.gz: 453bdbd7bac88f01759735e08bb0b81e00b31299
+  metadata.gz: a4be42b0d496b149d2697367b6357dc69704dabd
+  data.tar.gz: b822e0d942bf5feec3e8a82bbecf8735ba01e069
 SHA512:
-  metadata.gz: 0729ece1abf3037bbab19a7a179c5e052abc5cdf98662c2911f3b8760681664a62401554362e89bff3ea4cdc8c60dba5ae9ceaa6010ff056b96f5d5ddd7a7ef2
-  data.tar.gz: 2726adc0e771f52f39ab891bc09e1ff0b97a7337b5412f8eb965ae6e2e6b0b40b6322cb70a0c4a496d0ec98f41744abbec6e662ba9bdfdd082c7fa7999d235d1
+  metadata.gz: 2b18c943cc12069dd3fed37aeaadaf0b3482bd9b876ad3e5e4e4f66fe28f7271408968b7e161804b9843cc13f37837ad2e5e62c0d702b29aa067587b7cf1de9f
+  data.tar.gz: de5a5dc56cf624c4be0a66d337f91546ebac270239ec1995364280abd6457b4a5b68f360ac34e2959523a54db9c5419285ad384aa4ce4c7e0639f88a4ab9aac7

data/lib/pretty_proxy.rb

@@ -86,6 +86,7 @@ class PrettyProxy < Rack::Proxy
   @proxy_path = nil
   @original_domain = nil
   @original_paths = nil
+  attr_accessor :ignore_html_errors
 
   # Create a new PrettyProxy instance or raise a ConfigError. Clone the arguments.
   # @param proxy_path [String] Start and end with slashes, represent the
@@ -96,14 +97,19 @@ class PrettyProxy < Rack::Proxy
   #   to where the proxy map.
   # @param original_paths [String, #each] The path (or the paths) to be mapped
   #   right inside the proxy_path (has to begin with slash).
+  # @param ignore_html_errors [TrueClass, FalseClass] If the argument of this
+  #   parameter is true the #proxify_html try to ignore some exceptions that can
+  #   be caused by an malformed (X)HTML and continue. Don't silence
+  #   #{sugared_,}rewrite_response. Experimental.
   # @note See the specs {file:../spec/pretty_proxy_spec.rb} for examples and
   #   complete definition of invalid args.
   # @return [PrettyProxy] a new instance
   # @raise PrettyProxy::ConfigError
-  def initialize(proxy_path, original_domain, original_paths)
+  def initialize(proxy_path, original_domain, original_paths, ignore_html_errors = false)
     Utils.validate_proxy_path(proxy_path)
     Utils.validate_original_domain_and_paths(original_domain, original_paths)
 
+    @ignore_html_errors = ignore_html_errors
     @proxy_path = proxy_path.clone
     @original_domain = Addressable::URI.parse(original_domain.clone)
     @original_paths = Set.new 
@@ -225,9 +231,17 @@ class PrettyProxy < Rack::Proxy
 
     # the href isn't a obrigatory attribute of an anchor element
     parsed_html.css('a[href]').each do | hyperlink |
-      absolute_hyperlink = Addressable::URI.parse(base_url)
-                                           .join(hyperlink['href']).to_s
-      hyperlink['href'] = proxify_hyperlink(absolute_hyperlink, proxy_url)
+      begin
+        absolute_hyperlink = Addressable::URI.parse(base_url)
+                                             .join(hyperlink['href']).to_s
+        hyperlink['href'] = proxify_hyperlink(absolute_hyperlink, proxy_url)
+      rescue => e
+        # Here we catch any exception derived from StandardError and do nothing
+        # with it. This is a little risky, but the link in the href can be
+        # wrong in many ways and yet be accepted by nokogiri. So to not
+        # complexify the code we simply ignore when we can't proxify a link.
+        raise e unless @ignore_html_errors
+      end
     end
 
     unless base_tag

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pretty_proxy
 version: !ruby/object:Gem::Version
-  version: 4.0.5
+  version: 4.1.0
 platform: ruby
 authors:
 - Henrique Becker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-23 00:00:00.000000000 Z
+date: 2013-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri