pretender 0.0.3 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 912488b31e2aedf08cf4370da9cd18f5d9b444e8
+  data.tar.gz: 0277513a5ebf12372667de4503cb6fd1a36c4a13
+SHA512:
+  metadata.gz: 563a6e9b4a66732ae8830f2250481029f9a738841efafa457b658952fc1740616dd6a9835534e26d3ba4781083db1881b4c7c40b5a57748557c9923ab5cdcc61
+  data.tar.gz: 8524dae4aef68116d865d8134972b1862e4967a2a0426ef2efdaee71fd2f3e98a098fc9e9aee1029a7fba248966ae0d00356cb57b80ff2c2b86621d3a1922470

data/README.md

@@ -11,13 +11,13 @@ As an admin, there are times you want to see exactly what another user sees or t
 Pretender is also flexible and lightweight - less than 40 lines of code :-)
 
 Pretender works with Rails 2.3+ and almost any authentication system.
-(devise, authlogic, sorcery, and many more - it's agnostic)
+(devise, authlogic, sorcery, and many more - it’s agnostic)
 
 [Battle-tested at Instacart](https://www.instacart.com)
 
 ## Get started
 
-Add this line to your application's Gemfile:
+Add this line to your application’s Gemfile:
 
 ```ruby
 # Gemfile
@@ -57,13 +57,13 @@ current_user
 
 **Note:** the name of this method is configurable (details at the end)
 
-Now we need to setup a way to login as another user.  **Pretender makes no assumptions about how you want to do this**.  I like to add this to my admin dashboard.
+Now we need to set up a way to login as another user.  **Pretender makes no assumptions about how you want to do this**.  I like to add this to my admin dashboard.
 
 ### Sample Implementation
 
 ```ruby
 class Admin::UsersController < ApplicationController
-  before_filter :require_admin, :except => [:stop_impersonating]
+  before_filter :require_admin
 
   def impersonate
     user = User.find(params[:id])
@@ -71,40 +71,26 @@ class Admin::UsersController < ApplicationController
     redirect_to root_path
   end
 
-  # do not require admin for this method if access control
-  # is performed on the current_user instead of true_user
   def stop_impersonating
     stop_impersonating_user
-    redirect_to admin_path
+    redirect_to root_path
   end
-end
-```
 
-### Very Important!
-
-Be sure to call `stop_impersonating_user` before the current user logs out.
-
-```ruby
-class SessionsController < ActionController::Base
-  def logout
-    # it's safe to call this regardless of whether the user is being impersonated
-    stop_impersonating_user
-    # now, log out the user
-    # ...
-  end
 end
 ```
 
-You may want to make it obvious to an admin when he / she is logged in as another user.  I like to add this to the application layout.
+### Show Admins
+
+You may want to make it obvious to an admin when he / she is signed in as another user.  I like to add this to the application layout.
 
-### Haml / Slim
+#### Haml / Slim
 
 ```haml
-- # app/views/layouts/application.haml
+- # app/views/layouts/application.html.haml
 - if current_user != true_user
   .alert
-    You (#{true_user.name}) are logged in as #{current_user.name}
-    = link_to "Back to admin", stop_impersonating_user_path
+    You (#{true_user.name}) are signed in as #{current_user.name}
+    = link_to "Back to admin", stop_impersonating_path
 ```
 
 ### Audits
@@ -117,7 +103,7 @@ Audited.current_user_method = :true_user
 
 ### Configuration
 
-Pretender is super flexible.  You can change the names of methods and even impersonate multiple roles at the same time.  Here's the default configuration.
+Pretender is super flexible.  You can change the names of methods and even impersonate multiple roles at the same time.  Here’s the default configuration.
 
 ```ruby
 # app/controllers/application_controller.rb
@@ -145,4 +131,13 @@ stop_impersonating_account
 
 Also, authenticated_account is overridden with `EnterpriseAccount.where(:id => id).first`
 
-### That's all folks!
+## Contributing
+
+Everyone is encouraged to help improve this project. Here are a few ways you can help:
+
+- [Report bugs](https://github.com/ankane/pretender/issues)
+- Fix bugs and [submit pull requests](https://github.com/ankane/pretender/pulls)
+- Write, clarify, or fix documentation
+- Suggest or add new features
+
+That’s all folks!

data/lib/pretender.rb

@@ -10,7 +10,13 @@ module Pretender
     impersonated_var = :"@impersonated_#{scope}"
 
     # define methods
-    alias_method true_method, impersonated_method
+    if respond_to?(impersonated_method)
+      alias_method true_method, impersonated_method
+    else
+      define_method true_method do
+        ActionController::Base.instance_method(impersonated_method).bind(self).call
+      end
+    end
     helper_method true_method
 
     define_method impersonated_method do
@@ -18,7 +24,7 @@ module Pretender
         # only fetch impersonation if user is logged in and impersonation_id exists
         true_resource = send(true_method)
         if session[session_key] and !true_resource
-          raise "Security warning: Be sure to call stop_impersonating_#{scope} before logging out"
+          session[session_key] = nil
         end
         value = (session[session_key] && impersonate_with.call(session[session_key])) || true_resource
         instance_variable_set(impersonated_var, value) if value

data/lib/pretender/version.rb

@@ -1,3 +1,3 @@
 module Pretender
-  VERSION = "0.0.3"
+  VERSION = "0.1.0"
 end

metadata

@@ -1,46 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: pretender
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-10 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple, powerful user impersonation for Rails
@@ -50,7 +45,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -61,33 +56,26 @@ files:
 homepage: http://ankane.github.com/pretender/
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1172062548524424326
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1172062548524424326
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Easy to switch back and forth between roles, minimal code changes, and plays
   nicely with auditing tools
 test_files: []