prerender_rails 0.0.4 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5013e7eaea9bbf3be69499894144a70bf904911
-  data.tar.gz: a25e41c1f16f935222447687ff1e85f49e357f34
+  metadata.gz: 6ae62eb11cd28b731ae1fcbe0c737748e6efb9ab
+  data.tar.gz: 1f5227b5f8aebdb0d6af3dfd13571d456b6a6175
 SHA512:
-  metadata.gz: 4e4005a4509b94bda2ec6783f7b0a2ba5bc6c3203257cb5cb57cbda056c5c52a92f6e0758fcc252eb8fbf0fab5016a2725d0aa29bccafd2518f4ded7954a72bd
-  data.tar.gz: 85ce4274d97f7148160fdba543e7c8c3784d47e48f7c2183d9d040e4b08593158802d8d6c2d5fd2b31b64b1773bf5a41b04c4842d44761e70459c4ed5c04bd5c
+  metadata.gz: 21aa10c6a922512f53d23d08acc7bd5f288926a14e880f49552f65a363c6ed2d2075acb64f67e3434a48dc79b9bf96056d6ed69fe3bee7368b3cd73c4a8021f8
+  data.tar.gz: 5e5ff5959804c54bca5f483862b10641b57eaea17ccbd360b5e41f0da4d4f5ab75a9b05e2d78c053c56b6ab3a3e5de8537cb6eef75a799421192c917cbebbae7

data/Gemfile

@@ -1,4 +1,5 @@
-source 'https://rubygems.org'
+# source 'https://rubygems.org'
+source 'https://s3.amazonaws.com/production.s3.rubygems.org/'
 
 # Specify your gem's dependencies in prerender_rails.gemspec
 gemspec

data/README.md

@@ -3,7 +3,9 @@ Prerender Rails [![Build Status](https://travis-ci.org/collectiveip/prerender_ra
 
 Are you using backbone, angular, emberjs, etc, but you're unsure about the SEO implications?
 
-Use this gem to install rails middleware that prerenders a javascript-rendered page and returns the HTML to the search engine crawler for SEO.
+Use this gem to install rails middleware that prerenders a javascript-rendered page using an external service and returns the HTML to the search engine crawler for SEO.
+
+`Note:` Make sure you have more than one webserver thread/process running because the prerender service will make a request to your server to render the HTML.
 
 Add this line to your application's Gemfile:
 

data/lib/prerender_rails.rb

@@ -49,13 +49,13 @@ module Rack
       request = Rack::Request.new(env)
 
       #if it is not a bot...dont prerender
-      return false if !@crawler_user_agents.include?(user_agent.downcase)
+      return false if @crawler_user_agents.all? { |crawler_user_agent| !user_agent.downcase.include?(crawler_user_agent.downcase) }
 
       #if it is a bot and is requesting a resource...dont prerender
       return false if @extensions_to_ignore.any? { |extension| request.path.include? extension }
 
       #if it is a bot and not requesting a resource and is not whitelisted...dont prerender
-      return false if @options[:whitelist].is_a?(Array) && @options[:whitelist].all? { |whitelisted| !!Regexp.new(whitelisted).match(request.path) }
+      return false if @options[:whitelist].is_a?(Array) && @options[:whitelist].all? { |whitelisted| !Regexp.new(whitelisted).match(request.path) }
 
       #if it is a bot and not requesting a resource and is not blacklisted(url or referer)...dont prerender
       if @options[:blacklist].is_a?(Array) && @options[:blacklist].any? { |blacklisted|

data/prerender_rails.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "prerender_rails"
-  spec.version       = "0.0.4"
+  spec.version       = "0.0.6"
   spec.authors       = ["Todd Hooper"]
   spec.email         = ["todd@collectiveip.com"]
   spec.description   = %q{Rails middleware to prerender your javascript heavy pages on the fly by a phantomjs service}

data/test/lib/prerender_rails.rb

@@ -44,13 +44,13 @@ describe Rack::Prerender do
 
   it "should continue to app routes if the url is not part of the regex specific whitelist" do
     request = Rack::MockRequest.env_for "/saved/search/blah", "HTTP_USER_AGENT" => bot
-    response = Rack::Prerender.new(@app, whitelist: ['/search', '/help']).call(request)
+    response = Rack::Prerender.new(@app, whitelist: ['^/search', '/help']).call(request)
 
     assert_equal response[2], ""
   end
 
   it "should return a prerendered response if the url is part of the whitelist" do
-    request = Rack::MockRequest.env_for "/search/things?query=blah", "HTTP_USER_AGENT" => bot
+    request = Rack::MockRequest.env_for "/search/things/123/page", "HTTP_USER_AGENT" => bot
     stub_request(:get, @prerender.build_api_url(request)).to_return(:body => "<html></html>")
     response = Rack::Prerender.new(@app, whitelist: ['/search', '/help']).call(request)
 
@@ -58,22 +58,22 @@ describe Rack::Prerender do
   end
 
   it "should return a prerendered response if the url is part of the regex specific whitelist" do
-    request = Rack::MockRequest.env_for "/search/things?query=blah", "HTTP_USER_AGENT" => bot
+    request = Rack::MockRequest.env_for "/search/things/123/page", "HTTP_USER_AGENT" => bot
     stub_request(:get, @prerender.build_api_url(request)).to_return(:body => "<html></html>")
-    response = Rack::Prerender.new(@app, whitelist: ['^/search.*query', '/help']).call(request)
+    response = Rack::Prerender.new(@app, whitelist: ['^/search.*page', '/help']).call(request)
 
     assert_equal response[2].body, ["<html></html>"]
   end
 
   it "should continue to app routes if the url is part of the blacklist" do
-    request = Rack::MockRequest.env_for "/search/things?query=blah", "HTTP_USER_AGENT" => bot
+    request = Rack::MockRequest.env_for "/search/things/123/page", "HTTP_USER_AGENT" => bot
     response = Rack::Prerender.new(@app, blacklist: ['/search', '/help']).call(request)
 
     assert_equal response[2], ""
   end
 
   it "should continue to app routes if the url is part of the regex specific blacklist" do
-    request = Rack::MockRequest.env_for "/search/things?query=blah", "HTTP_USER_AGENT" => bot
+    request = Rack::MockRequest.env_for "/search/things/123/page", "HTTP_USER_AGENT" => bot
     response = Rack::Prerender.new(@app, blacklist: ['^/search', '/help']).call(request)
 
     assert_equal response[2], ""

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prerender_rails
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.6
 platform: ruby
 authors:
 - Todd Hooper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-29 00:00:00.000000000 Z
+date: 2013-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -104,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.5
 signing_key: 
 specification_version: 4
 summary: Prerender your backbone/angular/javascript rendered application on the fly