RubyGems - premailer - Versions diffs - 1.7.1 → 1.7.3 - Mend

premailer 1.7.1 → 1.7.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (38) hide show

data/.gitignore +7 -0
data/Gemfile +3 -0
data/LICENSE.rdoc +11 -0
data/README.rdoc +20 -0
data/bin/premailer +3 -95
data/lib/premailer.rb +5 -3
data/lib/premailer/adapter/hpricot.rb +21 -11
data/lib/premailer/adapter/nokogiri.rb +18 -17
data/lib/premailer/executor.rb +96 -0
data/lib/premailer/html_to_plain_text.rb +26 -6
data/lib/premailer/premailer.rb +62 -32
data/local-premailer +9 -0
data/premailer.gemspec +22 -0
data/rakefile.rb +69 -0
data/test/files/base.html +142 -0
data/test/files/chars.html +6 -0
data/test/files/contact_bg.png +0 -0
data/test/files/dialect.png +0 -0
data/test/files/dots_end.png +0 -0
data/test/files/dots_h.gif +0 -0
data/test/files/html4.html +12 -0
data/test/files/import.css +13 -0
data/test/files/inc/2009-placeholder.png +0 -0
data/test/files/iso-8859-2.html +1 -0
data/test/files/iso-8859-5.html +8 -0
data/test/files/no_css.html +11 -0
data/test/files/noimport.css +13 -0
data/test/files/styles.css +106 -0
data/test/files/xhtml.html +11 -0
data/test/future_tests.rb +50 -0
data/test/helper.rb +7 -0
data/test/test_adapter.rb +29 -0
data/test/test_html_to_plain_text.rb +149 -0
data/test/test_links.rb +141 -0
data/test/test_misc.rb +233 -0
data/test/test_premailer.rb +257 -0
data/test/test_warnings.rb +97 -0
metadata +109 -13

data/test/test_misc.rb ADDED

@@ -0,0 +1,233 @@
+# encoding: UTF-8
+require File.expand_path(File.dirname(__FILE__)) + '/helper'
+# Random tests for specific issues.
+#
+# The test suite will be cleaned up at some point soon.
+class TestMisc < Test::Unit::TestCase
+  # in response to http://github.com/alexdunae/premailer/issues#issue/4
+  #
+  # NB: 2010-11-16 -- after reverting to Hpricot this test can no longer pass.
+  # It's too much of an edge case to get any dev time.
+  def test_parsing_extra_quotes
+    io = StringIO.new('<p></p>
+    <h3 "id="WAR"><a name="WAR"></a>Writes and Resources</h3>
+    <table></table>')
+    premailer = Premailer.new(io, :adapter => :nokogiri)
+    assert_match /<h3>[\s]*<a name="WAR">[\s]*<\/a>[\s]*Writes and Resources[\s]*<\/h3>/i, premailer.to_inline_css
+  end
+  def test_styles_in_the_body
+    html = <<END_HTML
+    <html>
+    <body>
+    <style type="text/css"> p { color: red; } </style>
+		<p>Test</p>
+		</body>
+		</html>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+		premailer.to_inline_css
+	  assert_match /color\: red/i,  premailer.processed_doc.at('p')['style']
+  end
+  def test_commented_out_styles_in_the_body
+    html = <<END_HTML
+    <html>
+    <body>
+    <style type="text/css"> <!-- p { color: red; } --> </style>
+		<p>Test</p>
+		</body>
+		</html>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+		premailer.to_inline_css
+	  assert_match /color\: red/i,  premailer.processed_doc.at('p')['style']
+  end
+  def test_not_applying_styles_to_the_head
+    html = <<END_HTML
+    <html>
+    <head>
+    <title>Title</title>
+    <style type="text/css"> * { color: red; } </style>
+    </head>
+    <body>
+		<p><a>Test</a></p>
+		</body>
+		</html>
+END_HTML
+    [:nokogiri, :hpricot].each do |adapter|
+  		premailer = Premailer.new(html, :with_html_string => true, :adapter => adapter)
+  		premailer.to_inline_css
+  	  h = premailer.processed_doc.at('head')
+  	  assert_nil h['style']
+  	  t = premailer.processed_doc.at('title')
+  	  assert_nil t['style']
+    end
+  end
+  def test_multiple_identical_ids
+    html = <<-END_HTML
+    <html>
+    <head>
+    <style type="text/css"> #the_id { color: red; } </style>
+    </head>
+    <body>
+		<p id="the_id">Test</p>
+		<p id="the_id">Test</p>
+		</body>
+		</html>
+    END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+		premailer.to_inline_css
+    premailer.processed_doc.search('p').each do |el|
+      assert_match /red/i, el['style']
+    end
+  end
+  def test_preserving_styles
+    html = <<END_HTML
+    <html>
+    <head>
+    <link rel="stylesheet" href="#"/>
+    <style type="text/css"> a:hover { color: red; } </style>
+    </head>
+    <body>
+		<p><a>Test</a></p>
+		</body>
+		</html>
+END_HTML
+    [:nokogiri, :hpricot].each do |adapter|
+  		premailer = Premailer.new(html, :with_html_string => true, :preserve_styles => true,  :adapter => adapter)
+  		premailer.to_inline_css
+  	  assert_equal 1, premailer.processed_doc.search('head link').length
+  	  assert_equal 1, premailer.processed_doc.search('head style').length
+  		premailer = Premailer.new(html, :with_html_string => true, :preserve_styles => false, :adapter => adapter)
+  		premailer.to_inline_css
+  	  assert_nil premailer.processed_doc.at('head link')
+      # should be preserved as unmergeable
+  	  assert_match /red !important/i, premailer.processed_doc.at('body style').inner_html
+  	end
+  end
+  def test_unmergable_rules
+    html = <<END_HTML
+    <html> <head> <style type="text/css"> a { color:blue; } a:hover { color: red; } </style> </head>
+		<p><a>Test</a></p>
+		</body> </html>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true, :verbose => true)
+		premailer.to_inline_css
+	  assert_match /a\:hover[\s]*\{[\s]*color\:[\s]*red[\s]*!important;[\s]*\}/i, premailer.processed_doc.at('body style').inner_html
+  end
+  def test_unmergable_rules_with_no_body
+    html = <<END_HTML
+    <html>
+    <style type="text/css"> a:hover { color: red; } </style>
+		<p><a>Test</a></p>
+		</html>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+    assert_nothing_raised do
+		  premailer.to_inline_css
+	  end
+	  assert_match /red !important/i, premailer.processed_doc.at('style').inner_html
+  end
+  # in response to https://github.com/alexdunae/premailer/issues#issue/7
+  def test_ignoring_link_pseudo_selectors
+    html = <<END_HTML
+    <html>
+    <style type="text/css"> td a:link.top_links { color: red; } </style>
+    <body>
+		<td><a class="top_links">Test</a></td>
+		</body>
+		</html>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+    assert_nothing_raised do
+		  premailer.to_inline_css
+	  end
+	  assert_match /color: red/, premailer.processed_doc.at('a').attributes['style'].to_s
+  end
+  # in response to https://github.com/alexdunae/premailer/issues#issue/7
+  def test_parsing_bad_markup_around_tables
+    html = <<END_HTML
+    <html>
+    <style type="text/css">
+      .style3 { font-size: xx-large; }
+      .style5 { background-color: #000080; }
+    </style>
+		<tr>
+						<td valign="top" class="style3">
+						<!-- MSCellType="ContentHead" -->
+						<strong>PROMOCION CURSOS PRESENCIALES</strong></td>
+						<strong>
+						<td valign="top" style="height: 125px" class="style5">
+						<!-- MSCellType="DecArea" -->
+						<img alt="" src="../../images/CertisegGold.GIF" width="608" height="87" /></td>
+		</tr>
+END_HTML
+		premailer = Premailer.new(html, :with_html_string => true)
+		premailer.to_inline_css
+	  assert_match /font-size: xx-large/, premailer.processed_doc.search('.style3').first.attributes['style'].to_s
+	  assert_match /background-color: #000080/, premailer.processed_doc.search('.style5').first.attributes['style'].to_s
+  end
+  # in response to https://github.com/alexdunae/premailer/issues/56
+  def test_inline_important
+    html = <<END_HTML
+    <html>
+    <style type="text/css">
+      p { color: red !important; }
+    </style>
+    <body>
+      <p style='color: green !important;'>test</p></div>
+    </body>
+    </html>
+END_HTML
+    premailer = Premailer.new(html, :with_html_string => true, :adapter => :nokogiri)
+  	premailer.to_inline_css
+    assert_equal 'color: green !important;', premailer.processed_doc.search('p').first.attributes['style'].to_s
+  end
+  # in response to https://github.com/alexdunae/premailer/issues/28
+  def test_handling_shorthand_auto_properties
+    html = <<END_HTML
+    <html>
+    <style type="text/css">
+      #page { margin: 0; margin-left: auto; margin-right: auto; }
+      p { border: 1px solid black; border-right: none; }
+    </style>
+    <body>
+      <div id='page'><p>test</p></div>
+    </body>
+    </html>
+END_HTML
+    premailer = Premailer.new(html, :with_html_string => true)
+  	premailer.to_inline_css
+    assert_match /margin: 0 auto;/, premailer.processed_doc.search('#page').first.attributes['style'].to_s
+    assert_match /border-style: solid none solid solid;/, premailer.processed_doc.search('p').first.attributes['style'].to_s
+  end
+end

data/test/test_premailer.rb ADDED

@@ -0,0 +1,257 @@
+# encoding: UTF-8
+require File.expand_path(File.dirname(__FILE__)) + '/helper'
+class TestPremailer < Test::Unit::TestCase
+  include WEBrick
+  def setup
+    # from http://nullref.se/blog/2006/5/17/testing-with-webrick
+    @uri_base = "http://localhost:12000"
+    www_root = File.expand_path(File.dirname(__FILE__)) + '/files/'
+    @server_thread = Thread.new do
+      s = WEBrick::HTTPServer.new(:Port => 12000, :DocumentRoot => www_root, :Logger => Log.new(nil, BasicLog::ERROR), :AccessLog => [])
+      port = s.config[:Port]
+      begin
+        s.start
+      ensure
+        s.shutdown
+      end
+    end
+  end
+  def test_special_characters_nokogiri
+    html = 	'<p>cédille c&eacute; & garçon gar&#231;on à &agrave; &nbsp; &amp; &copy;</p>'
+    premailer = Premailer.new(html, :with_html_string => true, :adapter => :nokogiri)
+  	premailer.to_inline_css
+    assert_equal 'c&eacute;dille c&eacute; &amp; gar&ccedil;on gar&ccedil;on &agrave; &agrave; &nbsp; &amp; &copy;', premailer.processed_doc.at('p').inner_html
+  end
+  def test_special_characters_nokogiri_remote
+    remote_setup('chars.html', :adapter => :nokogiri)
+  	@premailer.to_inline_css
+    assert_equal 'c&eacute;dille c&eacute; &amp; gar&ccedil;on gar&ccedil;on &agrave; &agrave; &nbsp; &amp; &copy;', @premailer.processed_doc.at('p').inner_html
+  end
+  #def test_cyrillic_nokogiri_remote
+  #  if RUBY_VERSION =~ /1.9/
+  #    remote_setup('iso-8859-5.html', :adapter => :nokogiri) #, :encoding => 'iso-8859-5')
+  #  	@premailer.to_inline_css
+  #    assert_equal Encoding.find('ISO-8859-5'), @premailer.processed_doc.at('p').inner_html.encoding
+  #  end
+  #end
+  # TODO: this passes when run from rake but not when run from:
+  #  ruby -Itest test/test_premailer.rb -n test_special_characters_hpricot
+  def test_special_characters_hpricot
+    html = 	'<p>cédille c&eacute; & garçon gar&#231;on à &agrave; &nbsp; &amp;</p>'
+    premailer = Premailer.new(html, :with_html_string => true, :adapter => :hpricot)
+  	premailer.to_inline_css
+    assert_equal 'c&eacute;dille c&eacute; &amp; gar&ccedil;on gar&ccedil;on &agrave; &agrave; &nbsp; &amp;', premailer.processed_doc.at('p').inner_html
+  end
+  def test_detecting_html
+    [:nokogiri, :hpricot].each do |adapter|
+      remote_setup('base.html', :adapter => adapter)
+      assert !@premailer.is_xhtml?
+    end
+  end
+  def test_detecting_xhtml
+    [:nokogiri, :hpricot].each do |adapter|
+      remote_setup('xhtml.html', :adapter => adapter)
+      assert @premailer.is_xhtml?
+    end
+  end
+  def test_self_closing_xhtml_tags
+    [:nokogiri, :hpricot].each do |adapter|
+      remote_setup('xhtml.html', :adapter => adapter)
+      assert_match /<br[\s]*\/>/, @premailer.to_s
+      assert_match /<br[\s]*\/>/, @premailer.to_inline_css
+    end
+  end
+  def test_non_self_closing_html_tags
+    [:nokogiri, :hpricot].each do |adapter|
+      remote_setup('html4.html', :adapter => adapter)
+      assert_match /<br>/, @premailer.to_s
+      assert_match /<br>/, @premailer.to_inline_css
+    end
+  end
+  def test_mailtos_with_query_strings
+    html = <<END_HTML
+    <html>
+		<a href="mailto:info@example.com?subject=Programmübersicht&amp;body=Lorem ipsum dolor sit amet.">Test</a>
+		</html>
+END_HTML
+    qs = 'testing=123'
+    [:nokogiri, :hpricot].each do |adapter|
+		  premailer = Premailer.new(html, :with_html_string => true, :link_query_string => qs, :adapter => adapter)
+		  premailer.to_inline_css
+	    assert_no_match /testing=123/, premailer.processed_doc.search('a').first.attributes['href'].to_s
+	  end
+  end
+  def test_escaping_strings
+    local_setup
+    str = %q{url("/images/test.png");}
+    assert_equal("url(\'/images/test.png\');", Premailer.escape_string(str))
+  end
+  def test_importing_local_css
+    [:nokogiri, :hpricot].each do |adapter|
+      local_setup('base.html', :adapter => adapter)
+      # noimport.css (print stylesheet) sets body { background } to red
+      assert_no_match /red/, @doc.at('body').attributes['style'].to_s
+      # import.css sets .hide to { display: none }
+      assert_match /display: none/, @doc.at('#hide01').attributes['style'].to_s
+    end
+  end
+  def test_importing_remote_css
+    [:nokogiri, :hpricot].each do |adapter|
+      remote_setup('base.html', :adapter => adapter)
+      # noimport.css (print stylesheet) sets body { background } to red
+      assert_no_match /red/, @doc.at('body')['style']
+      # import.css sets .hide to { display: none }
+      assert_match /display: none/, @doc.at('#hide01')['style']
+    end
+  end
+  def test_importing_css_as_string
+    files_base = File.expand_path(File.dirname(__FILE__)) + '/files/'
+    css_string = IO.read(File.join(files_base, 'import.css'))
+    [:nokogiri, :hpricot].each do |adapter|
+      premailer = Premailer.new(File.join(files_base, 'no_css.html'), {:css_string => css_string, :adapter => adapter})
+      premailer.to_inline_css
+      @doc = premailer.processed_doc
+      # import.css sets .hide to { display: none }
+      assert_match /display: none/, @doc.at('#hide01')['style']
+    end
+  end
+  def test_local_remote_check
+    assert Premailer.local_data?( StringIO.new('a') )
+    assert Premailer.local_data?( '/path/' )
+    assert !Premailer.local_data?( 'http://example.com/path/' )
+    # the old way is deprecated but should still work
+    premailer = Premailer.new( StringIO.new('a') )
+    assert premailer.local_uri?( '/path/' )
+  end
+  def test_initialize_can_accept_io_object
+    [:nokogiri, :hpricot].each do |adapter|
+      io = StringIO.new('hi mom')
+      premailer = Premailer.new(io, :adapter => adapter)
+      assert_match /hi mom/, premailer.to_inline_css
+    end
+  end
+  def test_initialize_can_accept_html_string
+    [:nokogiri, :hpricot].each do |adapter|
+      premailer = Premailer.new('<p>test</p>', :with_html_string => true, :adapter => adapter)
+      assert_match /test/, premailer.to_inline_css
+    end
+  end
+  def test_remove_ids
+    html = <<END_HTML
+    <html> <head> <style type="text/css"> #remove { color:blue; } </style> </head>
+    <body>
+		<p id="remove"><a href="#keep">Test</a></p>
+		<p id="keep">Test</p>
+		</body> </html>
+END_HTML
+    [:nokogiri, :hpricot].each do |adapter|
+  		pm = Premailer.new(html, :with_html_string => true, :remove_ids => true, :adapter => adapter)
+      pm.to_inline_css
+      doc = pm.processed_doc
+  	  assert_nil doc.at('#remove')
+  	  assert_nil doc.at('#keep')
+  	  hashed_id = doc.at('a')['href'][1..-1]
+  	  assert_not_nil doc.at("\##{hashed_id}")
+  	end
+  end
+  def test_carriage_returns_as_entities
+    html = <<-html
+    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+    <html>
+    <body>\n\r<p>test</p>\n\r<p>test</p>
+    </body></html>
+    html
+    [:nokogiri, :hpricot].each do |adapter|
+      pm = Premailer.new(html, :with_html_string => true, :adapter => adapter)
+      assert_match /\r/, pm.to_inline_css
+    end
+  end
+  def test_advanced_selectors
+    remote_setup('base.html', :adapter => :nokogiri)
+    assert_match /italic/, @doc.at('h2 + h3')['style']
+    assert_match /italic/, @doc.at('p[attr~=quote]')['style']
+    assert_match /italic/, @doc.at('ul li:first-of-type')['style']
+    remote_setup('base.html', :adapter => :hpricot)
+    assert_match /italic/, @doc.at('p[@attr~="quote"]')['style']
+    assert_match /italic/, @doc.at('ul li:first-of-type')['style']
+  end
+  def test_premailer_related_attributes
+    html = <<END_HTML
+    <html> <head> <style>table { -premailer-width: 500; } td { -premailer-height: 20}; </style>
+    <body>
+		<table> <tr> <td> Test </td> </tr> </table>
+		</body> </html>
+END_HTML
+    [:nokogiri, :hpricot].each do |adapter|
+  		pm = Premailer.new(html, :with_html_string => true, :adapter => adapter)
+      pm.to_inline_css
+      doc = pm.processed_doc
+  	  assert_equal '500', doc.at('table')['width']
+  	  assert_equal '20', doc.at('td')['height']
+  	end
+  end
+protected
+  def local_setup(f = 'base.html', opts = {})
+    base_file = File.expand_path(File.dirname(__FILE__)) + '/files/' + f
+    premailer = Premailer.new(base_file, opts)
+    premailer.to_inline_css
+    @doc = premailer.processed_doc
+  end
+  def remote_setup(f = 'base.html', opts = {})
+    # increment the port number for testing multiple adapters
+    @premailer = Premailer.new(@uri_base + "/#{f}", opts)
+    @premailer.to_inline_css
+    @doc = @premailer.processed_doc
+  end
+  def teardown
+    if @server_thread
+      @server_thread.kill
+      @server_thread.join(5)
+      @server_thread = nil
+    end
+  end
+end