preferences 0.4.1 → 0.4.2

data/CHANGELOG.rdoc

@@ -1,5 +1,9 @@
 == master
 
+== 0.4.2 / 2010-04-17
+
+* Fix #preferences lookup not typecasting values
+
 == 0.4.1 / 2010-03-07
 
 * Add support for per-group default preferences

data/README.rdoc

@@ -6,7 +6,7 @@
 
 API
 
-* http://api.pluginaweek.org/preferences
+* http://rdoc.info/projects/pluginaweek/preferences
 
 Bugs
 

data/Rakefile

@@ -6,7 +6,7 @@ require 'rake/gempackagetask'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'preferences'
-  s.version           = '0.4.1'
+  s.version           = '0.4.2'
   s.platform          = Gem::Platform::RUBY
   s.summary           = 'Adds support for easily creating custom preferences for ActiveRecord models'
   s.description       = s.summary
@@ -66,23 +66,8 @@ Rake::GemPackageTask.new(spec) do |p|
   p.gem_spec = spec
 end
 
-desc 'Publish the beta gem.'
-task :pgem => [:package] do
-  require 'rake/contrib/sshpublisher'
-  Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{spec.name}-#{spec.version}.gem").upload
-end
-
-desc 'Publish the API documentation.'
-task :pdoc => [:rdoc] do
-  require 'rake/contrib/sshpublisher'
-  Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{spec.name}", 'rdoc').upload
-end
-
-desc 'Publish the API docs and gem'
-task :publish => [:pgem, :pdoc, :release]
-
 desc 'Publish the release files to RubyForge.'
-task :release => [:gem, :package] do
+task :release => :package do
   require 'rake/gemcutter'
   
   Rake::Gemcutter::Tasks.new(spec)

data/lib/preferences.rb

@@ -317,7 +317,10 @@ module Preferences
         end
       end
       
-      preferences.dup
+      preferences.inject({}) do |typed_preferences, (name, value)|
+        typed_preferences[name] = value.nil? ? value : preference_definitions[name].type_cast(value)
+        typed_preferences
+      end
     end
     
     # Queries whether or not a value is present for the given preference.

data/test/functional/preferences_test.rb

@@ -968,6 +968,11 @@ class PreferencesLookupTest < ModelPreferenceTest
     assert_equal e = {'notifications' => false, 'language' => 'English'}, @user.preferences
   end
   
+  def test_should_typecast_unsaved_changes
+    @user.write_preference(:notifications, 'true')
+    assert_equal e = {'notifications' => true, 'language' => 'English'}, @user.preferences
+  end
+  
   def test_should_cache_results
     assert_queries(1) { @user.preferences }
     assert_queries(0) { @user.preferences }
@@ -1019,6 +1024,11 @@ class PreferencesGroupLookupTest < ModelPreferenceTest
     assert_equal e = {'notifications' => false, 'language' => 'Spanish'}, @user.preferences(:chat)
   end
   
+  def test_should_typecast_unsaved_changes
+    @user.write_preference(:notifications, 'true', :chat)
+    assert_equal e = {'notifications' => true, 'language' => 'English'}, @user.preferences
+  end
+  
   def test_should_cache_results
     assert_queries(1) { @user.preferences(:chat) }
     assert_queries(0) { @user.preferences(:chat) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: preferences
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-07 00:00:00 -05:00
+date: 2010-04-17 00:00:00 -04:00
 default_executable: 
 dependencies: []