preferences 0.0.1 → 0.1.0

data/test/functional/preferences_test.rb

@@ -2,6 +2,8 @@ require "#{File.dirname(__FILE__)}/../test_helper"
 
 class PreferencesTest < Test::Unit::TestCase
   def setup
+    User.preference :notifications, :boolean
+    
     @user = User.new
   end
   
@@ -30,9 +32,17 @@ class PreferencesTest < Test::Unit::TestCase
     assert User.respond_to?(:preference_definitions)
   end
   
+  def test_should_create_default_preferences_values
+    assert User.respond_to?(:default_preference_values)
+  end
+  
   def test_should_include_new_definitions_in_preference_definitions
-    definition = User.preference :notifications
-    assert_equal definition, User.preference_definitions['notifications']
+    assert_not_nil User.preference_definitions['notifications']
+  end
+  
+  def teardown
+    User.preference_definitions.delete('notifications')
+    User.default_preference_values.delete('notifications')
   end
 end
 
@@ -60,6 +70,18 @@ class UserByDefaultTest < Test::Unit::TestCase
   def test_should_have_a_preferred_language
     assert_equal 'English', @user.preferred_language
   end
+  
+  def test_should_have_only_default_preference_values
+    expected = {
+      'hot_salsa' => nil,
+      'dark_chocolate' => true,
+      'color' => nil,
+      'car' => nil,
+      'language' => 'English'
+    }
+    
+    assert_equal expected, @user.preference_values
+  end
 end
 
 class UserTest < Test::Unit::TestCase
@@ -175,6 +197,18 @@ class UserWithPreferencesTest < Test::Unit::TestCase
     assert_equal 1, @user.preferences.size
   end
   
+  def test_should_include_custom_and_default_preferences_in_preference_values
+    expected = {
+      'hot_salsa' => nil,
+      'dark_chocolate' => true,
+      'color' => nil,
+      'car' => nil,
+      'language' => 'Latin'
+    }
+    
+    assert_equal expected, @user.preference_values
+  end
+  
   def test_should_not_remove_preference_if_set_to_default
     @user.preferred_language = 'English'
     @user.save!
@@ -215,12 +249,70 @@ class UserWithPreferencesTest < Test::Unit::TestCase
   end
 end
 
-class UserWithPreferencesForOtherModelsTest < Test::Unit::TestCase
+class UserWithPreferencesForBasicGroupsTest < Test::Unit::TestCase
+  def setup
+    @user = create_user
+    @user.preferred_color = 'red', 'cars'
+    @user.save!
+  end
+  
+  def test_should_have_preferences
+    assert_equal 1, @user.preferences.size
+  end
+  
+  def test_should_have_preference_values_for_group
+    expected = {
+      'hot_salsa' => nil,
+      'dark_chocolate' => true,
+      'color' => nil,
+      'car' => nil,
+      'language' => 'English',
+      'cars' => {
+        'hot_salsa' => nil,
+        'dark_chocolate' => true,
+        'color' => 'red',
+        'car' => nil,
+        'language' => 'English'
+      }
+    }
+    
+    assert_equal expected, @user.preference_values
+  end
+  
+  def test_should_not_have_preference_without_group
+    assert_nil @user.preferred_color
+  end
+  
+  def test_should_have_preference_with_group
+    assert_equal 'red', @user.preferred_color('cars')
+  end
+  
+  def test_should_modify_existing_preferences_when_saved
+    @user.preferred_color = 'blue', 'cars'
+    assert @user.save
+    
+    @user.reload
+    assert_equal 'blue', @user.preferred_color('cars')
+    assert_equal 1, @user.preferences.size
+  end
+  
+  def test_should_be_able_to_differentiate_between_groups
+    @user.preferred_color = 'blue', 'boats'
+    assert @user.save
+    
+    @user.reload
+    assert_equal 'red', @user.preferred_color('cars')
+    assert_equal 'blue', @user.preferred_color('boats')
+    assert_equal 2, @user.preferences.size
+  end
+end
+
+class UserWithPreferencesForActiveRecordGroupsTest < Test::Unit::TestCase
   def setup
     @car = create_car
     
     @user = create_user
-    @user.preferred_color = 'red', {:for => @car}
+    @user.preferred_color = 'red', @car
     @user.save!
   end
   
@@ -228,32 +320,51 @@ class UserWithPreferencesForOtherModelsTest < Test::Unit::TestCase
     assert_equal 1, @user.preferences.size
   end
   
-  def test_should_not_have_preference_without_preferenced_record
+  def test_should_have_preference_values_for_group
+    expected = {
+      'hot_salsa' => nil,
+      'dark_chocolate' => true,
+      'color' => nil,
+      'car' => nil,
+      'language' => 'English',
+      @car => {
+        'hot_salsa' => nil,
+        'dark_chocolate' => true,
+        'color' => 'red',
+        'car' => nil,
+        'language' => 'English'
+      }
+    }
+    
+    assert_equal expected, @user.preference_values
+  end
+  
+  def test_should_not_have_preference_without_group
     assert_nil @user.preferred_color
   end
   
-  def test_should_have_preference_with_preferenced_record
-    assert_equal 'red', @user.preferred_color(:for => @car)
+  def test_should_have_preference_with_group
+    assert_equal 'red', @user.preferred_color(@car)
   end
   
   def test_should_modify_existing_preferences_when_saved
-    @user.preferred_color = 'blue', {:for => @car}
+    @user.preferred_color = 'blue', @car
     assert @user.save
     
     @user.reload
-    assert_equal 'blue', @user.preferred_color(:for => @car)
+    assert_equal 'blue', @user.preferred_color(@car)
     assert_equal 1, @user.preferences.size
   end
   
-  def test_should_be_able_to_differentiate_between_preferenced_records
+  def test_should_be_able_to_differentiate_between_groups
     @different_car = create_car
     
-    @user.preferred_color = 'blue', {:for => @different_car}
+    @user.preferred_color = 'blue', @different_car
     assert @user.save
     
     @user.reload
-    assert_equal 'red', @user.preferred_color(:for => @car)
-    assert_equal 'blue', @user.preferred_color(:for => @different_car)
+    assert_equal 'red', @user.preferred_color(@car)
+    assert_equal 'blue', @user.preferred_color(@different_car)
     assert_equal 2, @user.preferences.size
   end
 end

data/test/test_helper.rb

@@ -4,7 +4,7 @@ require 'rubygems'
 require 'plugin_test_helper'
 
 # Run the migrations
-ActiveRecord::Migrator.migrate("#{RAILS_ROOT}/db/migrate")
+ActiveRecord::Migrator.migrate("#{Rails.root}/db/migrate")
 
 # Mixin the factory helper
 require File.expand_path("#{File.dirname(__FILE__)}/factory")

data/test/unit/preference_test.rb

@@ -17,12 +17,12 @@ class PreferenceByDefaultTest < Test::Unit::TestCase
     assert @preference.owner_type.blank?
   end
   
-  def test_should_not_have_a_preferenced_association
-    assert_nil @preference.preferenced_id
+  def test_should_not_have_a_group_association
+    assert_nil @preference.group_id
   end
   
-  def test_should_not_have_a_preferenced_type
-    assert @preference.preferenced_type.nil?
+  def test_should_not_have_a_group_type
+    assert @preference.group_type.nil?
   end
   
   def test_should_not_have_a_value
@@ -58,28 +58,53 @@ class PreferenceTest < Test::Unit::TestCase
     assert_equal 1, Array(preference.errors.on(:owner_type)).size
   end
   
-  def test_should_not_require_a_preferenced_id
-    preference = new_preference(:preferenced => nil)
+  def test_should_not_require_a_group_id
+    preference = new_preference(:group => nil)
     assert preference.valid?
   end
   
-  def test_should_require_a_preferenced_id_if_specified
-    preference = new_preference(:preferenced => nil)
-    preference.preferenced_type = 'Car'
-    assert !preference.valid?
-    assert_equal 1, Array(preference.errors.on(:preferenced_id)).size
+  def test_should_not_require_a_group_id_if_type_specified
+    preference = new_preference(:group => nil)
+    preference.group_type = 'Car'
+    assert preference.valid?
   end
   
-  def test_should_not_require_a_preferenced_type
-    preference = new_preference(:preferenced => nil)
+  def test_should_not_require_a_group_type
+    preference = new_preference(:group => nil)
     assert preference.valid?
   end
   
-  def test_should_require_a_preferenced_type_if_specified
-    preference = new_preference(:preferenced => nil)
-    preference.preferenced_id = 1
+  def test_should_require_a_group_type_if_id_specified
+    preference = new_preference(:group => nil)
+    preference.group_id = 1
     assert !preference.valid?
-    assert_equal 1, Array(preference.errors.on(:preferenced_type)).size
+    assert_equal 1, Array(preference.errors.on(:group_type)).size
+  end
+end
+
+class PreferenceAsAClassTest < Test::Unit::TestCase
+  def test_should_be_able_to_split_nil_groups
+    group_id, group_type = Preference.split_group(nil)
+    assert_nil group_id
+    assert_nil group_type
+  end
+  
+  def test_should_be_able_to_split_non_active_record_groups
+    group_id, group_type = Preference.split_group('car')
+    assert_nil group_id
+    assert_equal 'car', group_type
+    
+    group_id, group_type = Preference.split_group(10)
+    assert_nil group_id
+    assert_equal 10, group_type
+  end
+  
+  def test_should_be_able_to_split_active_record_groups
+    car = create_car
+    
+    group_id, group_type = Preference.split_group(car)
+    assert_equal 1, group_id
+    assert_equal 'Car', group_type
   end
 end
 
@@ -102,18 +127,34 @@ class PreferenceAfterBeingCreatedTest < Test::Unit::TestCase
     assert_not_nil @preference.value
   end
   
-  def test_should_not_have_a_preferenced_association
-    assert_nil @preference.preferenced
+  def test_should_not_have_a_group_association
+    assert_nil @preference.group
+  end
+  
+  def teardown
+    User.preference_definitions.delete('notifications')
+    User.default_preference_values.delete('notifications')
+  end
+end
+
+class PreferenceWithBasicGroupTest < Test::Unit::TestCase
+  def setup
+    @preference = create_preference(:group_type => 'car')
+  end
+  
+  def test_should_have_a_group_association
+    assert_equal 'car', @preference.group
   end
 end
 
-class PreferenceWithPreferencedAssociationTest < Test::Unit::TestCase
+class PreferenceWithActiveRecordGroupTest < Test::Unit::TestCase
   def setup
-    @preference = create_preference(:preferenced => create_car)
+    @car = create_car
+    @preference = create_preference(:group => @car)
   end
   
-  def test_should_have_a_preferenced_association
-    assert_not_nil @preference.preferenced
+  def test_should_have_a_group_association
+    assert_equal @car, @preference.group
   end
 end
 
@@ -142,4 +183,9 @@ class PreferenceWithBooleanAttributeTest < Test::Unit::TestCase
     preference.value = true
     assert_equal true, preference.value
   end
+  
+  def teardown
+    User.preference_definitions.delete('notifications')
+    User.default_preference_values.delete('notifications')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: preferences
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire: preferences
 bindir: bin
 cert_chain: []
 
-date: 2008-05-10 00:00:00 -04:00
+date: 2008-06-19 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
@@ -27,24 +27,24 @@ files:
 - lib/preferences
 - lib/preferences/preference_definition.rb
 - lib/preferences.rb
-- test/factory.rb
 - test/app_root
-- test/app_root/log
-- test/app_root/log/in_memory.log
+- test/app_root/app
+- test/app_root/app/models
+- test/app_root/app/models/car.rb
+- test/app_root/app/models/user.rb
+- test/app_root/config
+- test/app_root/config/environment.rb
 - test/app_root/db
 - test/app_root/db/migrate
+- test/app_root/db/migrate/001_create_users.rb
 - test/app_root/db/migrate/003_migrate_preferences_to_version_1.rb
 - test/app_root/db/migrate/002_create_cars.rb
-- test/app_root/db/migrate/001_create_users.rb
-- test/app_root/config
-- test/app_root/config/environment.rb
-- test/app_root/app
-- test/app_root/app/models
-- test/app_root/app/models/user.rb
-- test/app_root/app/models/car.rb
+- test/app_root/log
+- test/app_root/log/in_memory.log
 - test/functional
 - test/functional/preferences_test.rb
 - test/test_helper.rb
+- test/factory.rb
 - test/unit
 - test/unit/preference_test.rb
 - test/unit/preference_definition_test.rb
@@ -75,7 +75,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.1.0
+rubygems_version: 1.1.1
 signing_key: 
 specification_version: 2
 summary: Adds support for easily creating custom preferences for models