prefab-cloud-ruby 0.23.4 → 0.23.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74e19eed1d40cad8e3ea9b99a8755c90864a97b4a00e08d2df6a9fe5226f5ad0
-  data.tar.gz: 4ad94565a39139d01795007077128d8f997c05e6a8b785e019ca8b66308df5c5
+  metadata.gz: 7132292d4137fdc797fa0bd721fc2a4389ed5fda5452be8e6403fe11ca1be9a4
+  data.tar.gz: b23a18e42a3d033f4d5f8ab565df09b30bdcfffa97c0ec9a528811fd2f1bbb22
 SHA512:
-  metadata.gz: 7a10679fe049175ebaf01f12194f91bea1a98ce226bf0e0f3e87aea3ab299c888fb7cebfe67b942e77dc46367c9b05cc5acaf995870e1d6ee1f2b8aa744f2fa3
-  data.tar.gz: c6e506da285ae5f7913f81891e7f32a1b5365f1071bc90323f317aa2523fddb0bd41c2d8a53decf2afec000e234d535713e198f3ac8b4c98259c7904f03ce7ad
+  metadata.gz: 4ba972c390518d261dd8d5c29411bb786445b37023f6e333c9d5e57923819ba3d00dcd085de747df48d763704fdb795ed955f53f15436f33596059091aeee2b3
+  data.tar.gz: d5c38d28c9b87229255127556be2e8b815cc442b159d074bee09d997c438cdece7ab6df9e037cd1eb2e7057aaef08355ec7729b926a93b6eea44e83808c1d2d0

data/VERSION

@@ -1 +1 @@
-0.23.4
+0.23.6

data/lib/prefab/config_client.rb

@@ -68,7 +68,12 @@ module Prefab
     def get(key, default = Prefab::Client::NO_DEFAULT_PROVIDED, properties = {}, lookup_key = nil)
       value = _get(key, lookup_key, properties)
 
-      value ? Prefab::ConfigValueUnwrapper.unwrap(value, key, properties) : handle_default(key, default)
+      if value
+        lookup = lookup_key == Prefab::Client::NO_DEFAULT_PROVIDED ? nil : lookup_key
+        Prefab::ConfigValueUnwrapper.unwrap(value, key, properties.merge(Prefab::CriteriaEvaluator::LOOKUP_KEY => lookup))
+      else
+        handle_default(key, default)
+      end
     end
 
     private

data/lib/prefab/criteria_evaluator.rb

@@ -87,7 +87,9 @@ module Prefab
 
       case criterion_value_or_values
       when Google::Protobuf::RepeatedField
-        criterion_value_or_values.include?(value_from_properties)
+        # we to_s the value from properties for comparison because the
+        # criterion_value_or_values is a list of strings
+        criterion_value_or_values.include?(value_from_properties.to_s)
       else
         criterion_value_or_values == value_from_properties
       end

data/prefab-cloud-ruby.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: prefab-cloud-ruby 0.23.4 ruby lib
+# stub: prefab-cloud-ruby 0.23.6 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "prefab-cloud-ruby".freeze
-  s.version = "0.23.4"
+  s.version = "0.23.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeff Dwyer".freeze]
-  s.date = "2023-04-12"
+  s.date = "2023-04-17"
   s.description = "Feature Flags, Live Config, and Dynamic Log Levels as a service".freeze
   s.email = "jdwyer@prefab.cloud".freeze
   s.extra_rdoc_files = [

data/test/test_criteria_evaluator.rb

@@ -505,6 +505,43 @@ class TestCriteriaEvaluator < Minitest::Test
     assert_equal DEFAULT_VALUE, evaluator.evaluate({ email: 'example@gmail.com', admin: true, deleted: true }).string
   end
 
+  def test_stringifying_property_values_and_names
+    config = Prefab::Config.new(
+      key: KEY,
+      rows: [
+        DEFAULT_ROW,
+        Prefab::ConfigRow.new(
+          project_env_id: PROJECT_ENV_ID,
+          values: [
+            Prefab::ConditionalValue.new(
+              criteria: [
+                Prefab::Criterion.new(
+                  operator: Prefab::Criterion::CriterionOperator::PROP_IS_ONE_OF,
+                  value_to_match: string_list(%w[1 true hello]),
+                  property_name: 'team_name'
+                )
+              ],
+              value: Prefab::ConfigValue.new(string: DESIRED_VALUE)
+            )
+          ]
+        )
+      ]
+    )
+
+    evaluator = Prefab::CriteriaEvaluator.new(config, project_env_id: PROJECT_ENV_ID, resolver: nil,
+                                                      base_client: nil)
+
+    assert_equal DEFAULT_VALUE, evaluator.evaluate({}).string
+    assert_equal DEFAULT_VALUE, evaluator.evaluate({ team_name: 'prefab.cloud' }).string
+
+    [1, true, :hello].each do |value|
+      [:team_name, 'team_name'].each do |property_name|
+        assert_equal DESIRED_VALUE, evaluator.evaluate({ property_name => value }).string
+        assert_equal DESIRED_VALUE, evaluator.evaluate({ property_name => value.to_s }).string
+      end
+    end
+  end
+
   private
 
   def string_list(values)

data/test/test_logger.rb

@@ -387,6 +387,21 @@ class TestLogger < Minitest::Test
     end
   end
 
+  def test_logging_with_a_block
+    prefab, io = captured_logger
+    message = 'MY MESSAGE'
+
+    prefab.log.error do
+      message
+    end
+
+    prefab.log.info do
+      raise 'THIS WILL NEVER BE EVALUATED'
+    end
+
+    assert_logged io, 'ERROR', 'test.test_logger.test_logging_with_a_block', ' ' + message
+  end
+
   private
 
   def assert_logged(logged_io, level, path, message)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prefab-cloud-ruby
 version: !ruby/object:Gem::Version
-  version: 0.23.4
+  version: 0.23.6
 platform: ruby
 authors:
 - Jeff Dwyer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-12 00:00:00.000000000 Z
+date: 2023-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby