prefab-cloud-ruby 0.19.0 → 0.21.0

data/lib/prefab_pb.rb

@@ -17,12 +17,22 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
         optional :bytes, :bytes, 3
         optional :double, :double, 4
         optional :bool, :bool, 5
-        optional :feature_flag, :message, 6, "prefab.FeatureFlag"
+        optional :weighted_values, :message, 6, "prefab.WeightedValues"
         optional :limit_definition, :message, 7, "prefab.LimitDefinition"
-        optional :segment, :message, 8, "prefab.Segment"
         optional :log_level, :enum, 9, "prefab.LogLevel"
+        optional :string_list, :message, 10, "prefab.StringList"
       end
     end
+    add_message "prefab.StringList" do
+      repeated :values, :string, 1
+    end
+    add_message "prefab.WeightedValue" do
+      optional :weight, :int32, 1
+      optional :value, :message, 2, "prefab.ConfigValue"
+    end
+    add_message "prefab.WeightedValues" do
+      repeated :weighted_values, :message, 1, "prefab.WeightedValue"
+    end
     add_message "prefab.Configs" do
       repeated :configs, :message, 1, "prefab.Config"
       optional :config_service_pointer, :message, 2, "prefab.ConfigServicePointer"
@@ -31,14 +41,24 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
       optional :id, :int64, 1
       optional :project_id, :int64, 2
       optional :key, :string, 3
-      optional :changed_by, :string, 4
+      optional :changed_by, :message, 4, "prefab.ChangedBy"
       repeated :rows, :message, 5, "prefab.ConfigRow"
-      repeated :variants, :message, 6, "prefab.FeatureFlagVariant"
+      repeated :allowable_values, :message, 6, "prefab.ConfigValue"
+      optional :config_type, :enum, 7, "prefab.ConfigType"
+      proto3_optional :draftId, :int64, 8
+    end
+    add_message "prefab.ChangedBy" do
+      optional :user_id, :int64, 1
+      optional :email, :string, 2
     end
     add_message "prefab.ConfigRow" do
-      optional :project_env_id, :int64, 1
-      optional :namespace, :string, 2
-      optional :value, :message, 3, "prefab.ConfigValue"
+      proto3_optional :project_env_id, :int64, 1
+      repeated :values, :message, 2, "prefab.ConditionalValue"
+      map :properties, :string, :message, 3, "prefab.ConfigValue"
+    end
+    add_message "prefab.ConditionalValue" do
+      repeated :criteria, :message, 1, "prefab.Criterion"
+      optional :value, :message, 2, "prefab.ConfigValue"
     end
     add_message "prefab.LimitResponse" do
       optional :passed, :bool, 1
@@ -75,20 +95,12 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
       value :MINIMUM, 1
       value :MAXIMUM, 2
     end
-    add_message "prefab.FeatureFlagVariant" do
-      proto3_optional :int, :int64, 1
-      proto3_optional :string, :string, 2
-      proto3_optional :double, :double, 3
-      proto3_optional :bool, :bool, 4
-      optional :name, :string, 5
-      optional :description, :string, 6
-    end
-    add_message "prefab.Criteria" do
-      optional :property, :string, 1
-      optional :operator, :enum, 2, "prefab.Criteria.CriteriaOperator"
-      repeated :values, :string, 3
+    add_message "prefab.Criterion" do
+      optional :property_name, :string, 1
+      optional :operator, :enum, 2, "prefab.Criterion.CriterionOperator"
+      optional :value_to_match, :message, 3, "prefab.ConfigValue"
     end
-    add_enum "prefab.Criteria.CriteriaOperator" do
+    add_enum "prefab.Criterion.CriterionOperator" do
       value :NOT_SET, 0
       value :LOOKUP_KEY_IN, 1
       value :LOOKUP_KEY_NOT_IN, 2
@@ -99,22 +111,7 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
       value :PROP_IS_NOT_ONE_OF, 7
       value :PROP_ENDS_WITH_ONE_OF, 8
       value :PROP_DOES_NOT_END_WITH_ONE_OF, 9
-    end
-    add_message "prefab.Rule" do
-      optional :criteria, :message, 1, "prefab.Criteria"
-      repeated :variant_weights, :message, 2, "prefab.VariantWeight"
-    end
-    add_message "prefab.Segment" do
-      repeated :criterion, :message, 1, "prefab.Criteria"
-    end
-    add_message "prefab.VariantWeight" do
-      optional :weight, :int32, 1
-      optional :variant_idx, :int32, 2
-    end
-    add_message "prefab.FeatureFlag" do
-      optional :active, :bool, 1
-      optional :inactive_variant_idx, :int32, 2
-      repeated :rules, :message, 5, "prefab.Rule"
+      value :HIERARCHICAL_MATCH, 10
     end
     add_message "prefab.Identity" do
       proto3_optional :lookup, :string, 1
@@ -184,6 +181,14 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
       optional :sequence_name, :string, 3
       optional :size, :int64, 4
     end
+    add_enum "prefab.ConfigType" do
+      value :NOT_SET_CONFIG_TYPE, 0
+      value :CONFIG, 1
+      value :FEATURE_FLAG, 2
+      value :LOG_LEVEL, 3
+      value :SEGMENT, 4
+      value :LIMIT_DEFINITION, 5
+    end
     add_enum "prefab.LogLevel" do
       value :NOT_SET_LOG_LEVEL, 0
       value :TRACE, 1
@@ -205,20 +210,20 @@ end
 module Prefab
   ConfigServicePointer = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConfigServicePointer").msgclass
   ConfigValue = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConfigValue").msgclass
+  StringList = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.StringList").msgclass
+  WeightedValue = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.WeightedValue").msgclass
+  WeightedValues = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.WeightedValues").msgclass
   Configs = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Configs").msgclass
   Config = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Config").msgclass
+  ChangedBy = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ChangedBy").msgclass
   ConfigRow = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConfigRow").msgclass
+  ConditionalValue = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConditionalValue").msgclass
   LimitResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.LimitResponse").msgclass
   LimitResponse::LimitPolicyNames = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.LimitResponse.LimitPolicyNames").enummodule
   LimitRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.LimitRequest").msgclass
   LimitRequest::LimitCombiner = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.LimitRequest.LimitCombiner").enummodule
-  FeatureFlagVariant = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.FeatureFlagVariant").msgclass
-  Criteria = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Criteria").msgclass
-  Criteria::CriteriaOperator = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Criteria.CriteriaOperator").enummodule
-  Rule = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Rule").msgclass
-  Segment = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Segment").msgclass
-  VariantWeight = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.VariantWeight").msgclass
-  FeatureFlag = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.FeatureFlag").msgclass
+  Criterion = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Criterion").msgclass
+  Criterion::CriterionOperator = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Criterion.CriterionOperator").enummodule
   Identity = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.Identity").msgclass
   ClientConfigValue = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ClientConfigValue").msgclass
   ConfigEvaluations = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConfigEvaluations").msgclass
@@ -231,6 +236,7 @@ module Prefab
   CreationResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.CreationResponse").msgclass
   IdBlock = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.IdBlock").msgclass
   IdBlockRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.IdBlockRequest").msgclass
+  ConfigType = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.ConfigType").enummodule
   LogLevel = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.LogLevel").enummodule
   OnFailure = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.OnFailure").enummodule
 end

data/lib/prefab_services_pb.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # Source: prefab.proto for package 'prefab'
 

data/prefab-cloud-ruby.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: prefab-cloud-ruby 0.19.0 ruby lib
+# stub: prefab-cloud-ruby 0.21.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "prefab-cloud-ruby".freeze
-  s.version = "0.19.0"
+  s.version = "0.21.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeff Dwyer".freeze]
-  s.date = "2022-11-19"
+  s.date = "2023-02-27"
   s.description = "RateLimits & Config as a service".freeze
   s.email = "jdwyer@prefab.cloud".freeze
   s.extra_rdoc_files = [
@@ -20,7 +20,9 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".envrc",
+    ".envrc.sample",
     ".github/workflows/ruby.yml",
+    ".gitmodules",
     ".tool-versions",
     "CODEOWNERS",
     "Gemfile",
@@ -35,15 +37,17 @@ Gem::Specification.new do |s|
     "lib/prefab/cancellable_interceptor.rb",
     "lib/prefab/client.rb",
     "lib/prefab/config_client.rb",
-    "lib/prefab/config_helper.rb",
     "lib/prefab/config_loader.rb",
     "lib/prefab/config_resolver.rb",
+    "lib/prefab/config_value_unwrapper.rb",
+    "lib/prefab/criteria_evaluator.rb",
     "lib/prefab/error.rb",
     "lib/prefab/errors/initialization_timeout_error.rb",
     "lib/prefab/errors/invalid_api_key_error.rb",
     "lib/prefab/errors/missing_default_error.rb",
     "lib/prefab/feature_flag_client.rb",
     "lib/prefab/internal_logger.rb",
+    "lib/prefab/local_config_parser.rb",
     "lib/prefab/logger_client.rb",
     "lib/prefab/murmer3.rb",
     "lib/prefab/noop_cache.rb",
@@ -51,20 +55,27 @@ Gem::Specification.new do |s|
     "lib/prefab/options.rb",
     "lib/prefab/ratelimit_client.rb",
     "lib/prefab/sse_logger.rb",
+    "lib/prefab/weighted_value_resolver.rb",
+    "lib/prefab/yaml_config_parser.rb",
     "lib/prefab_pb.rb",
     "lib/prefab_services_pb.rb",
     "prefab-cloud-ruby.gemspec",
-    "run_test_harness_server.sh",
     "test/.prefab.default.config.yaml",
     "test/.prefab.unit_tests.config.yaml",
-    "test/harness_server.rb",
+    "test/integration_test.rb",
+    "test/integration_test_helpers.rb",
     "test/test_client.rb",
     "test/test_config_client.rb",
     "test/test_config_loader.rb",
     "test/test_config_resolver.rb",
+    "test/test_config_value_unwrapper.rb",
+    "test/test_criteria_evaluator.rb",
     "test/test_feature_flag_client.rb",
     "test/test_helper.rb",
-    "test/test_logger.rb"
+    "test/test_integration.rb",
+    "test/test_local_config_parser.rb",
+    "test/test_logger.rb",
+    "test/test_weighted_value_resolver.rb"
   ]
   s.homepage = "http://github.com/prefab-cloud/prefab-cloud-ruby".freeze
   s.licenses = ["MIT".freeze]
@@ -78,31 +89,29 @@ Gem::Specification.new do |s|
   if s.respond_to? :add_runtime_dependency then
     s.add_runtime_dependency(%q<concurrent-ruby>.freeze, ["~> 1.0", ">= 1.0.5"])
     s.add_runtime_dependency(%q<faraday>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<ld-eventsource>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<grpc>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<google-protobuf>.freeze, [">= 0"])
     s.add_runtime_dependency(%q<googleapis-common-protos-types>.freeze, [">= 0"])
+    s.add_runtime_dependency(%q<google-protobuf>.freeze, [">= 0"])
+    s.add_runtime_dependency(%q<grpc>.freeze, [">= 0"])
+    s.add_runtime_dependency(%q<ld-eventsource>.freeze, [">= 0"])
     s.add_development_dependency(%q<benchmark-ips>.freeze, [">= 0"])
-    s.add_development_dependency(%q<grpc-tools>.freeze, [">= 0"])
-    s.add_development_dependency(%q<rdoc>.freeze, [">= 0"])
     s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_development_dependency(%q<grpc-tools>.freeze, [">= 0"])
     s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.4.9"])
+    s.add_development_dependency(%q<rdoc>.freeze, [">= 0"])
     s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_development_dependency(%q<thin>.freeze, [">= 0"])
   else
     s.add_dependency(%q<concurrent-ruby>.freeze, ["~> 1.0", ">= 1.0.5"])
     s.add_dependency(%q<faraday>.freeze, [">= 0"])
-    s.add_dependency(%q<ld-eventsource>.freeze, [">= 0"])
-    s.add_dependency(%q<grpc>.freeze, [">= 0"])
-    s.add_dependency(%q<google-protobuf>.freeze, [">= 0"])
     s.add_dependency(%q<googleapis-common-protos-types>.freeze, [">= 0"])
+    s.add_dependency(%q<google-protobuf>.freeze, [">= 0"])
+    s.add_dependency(%q<grpc>.freeze, [">= 0"])
+    s.add_dependency(%q<ld-eventsource>.freeze, [">= 0"])
     s.add_dependency(%q<benchmark-ips>.freeze, [">= 0"])
-    s.add_dependency(%q<grpc-tools>.freeze, [">= 0"])
-    s.add_dependency(%q<rdoc>.freeze, [">= 0"])
     s.add_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_dependency(%q<grpc-tools>.freeze, [">= 0"])
     s.add_dependency(%q<juwelier>.freeze, ["~> 2.4.9"])
+    s.add_dependency(%q<rdoc>.freeze, [">= 0"])
     s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_dependency(%q<thin>.freeze, [">= 0"])
   end
 end
 

data/test/.prefab.unit_tests.config.yaml

@@ -9,8 +9,9 @@ sample: test sample value
 enabled_flag: true
 disabled_flag: false
 flag_with_a_value: { "feature_flag": "true", value: "all-features" }
-in_lookup_key: { "feature_flag": "true", value: true, criteria: { operator: LOOKUP_KEY_IN, values: [ "abc123", "xyz987" ] } }
-just_my_domain: { "feature_flag": "true", value: "new-version", criteria: { operator: PROP_IS_ONE_OF, property: "domain", values: [ "prefab.cloud", "example.com" ] } }
+in_lookup_key: { "feature_flag": "true", value: true, criterion: { operator: LOOKUP_KEY_IN, values: [ "abc123", "xyz987" ] } }
+just_my_domain: { "feature_flag": "true", value: "new-version", criterion: { operator: PROP_IS_ONE_OF, property: "domain", values: [ "prefab.cloud", "example.com" ] } }
+
 nested:
   values:
     _: top level

data/test/integration_test.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+class IntegrationTest
+  attr_reader :func
+  attr_reader :input
+  attr_reader :expected
+  attr_reader :test_client
+
+  def initialize(test_data)
+    @client_overrides = parse_client_overrides(test_data['client_overrides'])
+    @func = parse_function(test_data['function'])
+    @input = parse_input(test_data['input'])
+    @expected = parse_expected(test_data['expected'])
+    test_client = :"#{test_data['client']}"
+    @test_client = base_client.send(test_client)
+  end
+
+  def test_type
+    if @expected[:status] == 'raise'
+      :raise
+    elsif @expected[:value].nil?
+      :nil
+    elsif @func == :feature_is_on_for?
+      :feature_flag
+    else
+      :simple_equality
+    end
+  end
+
+  private
+
+  def parse_client_overrides(overrides)
+    Hash[
+      (overrides || {}).map do |(k, v)|
+        [k.to_sym, v]
+      end
+    ]
+  end
+
+  def parse_function(function)
+    case function
+    when 'get_or_raise' then :get
+    when 'enabled' then :feature_is_on_for?
+    else :"#{function}"
+    end
+  end
+
+  def parse_input(input)
+    if input['key']
+      parse_config_input(input)
+    elsif input['flag']
+      parse_ff_input(input)
+    end
+  end
+
+  def parse_config_input(input)
+    if !input['default'].nil?
+      [input['key'], input['default']]
+    else
+      [input['key']]
+    end
+  end
+
+  def parse_ff_input(input)
+    [input['flag'], input['lookup_key'], input['properties'] || {}]
+  end
+
+  def parse_expected(expected)
+    {
+      status: expected['status'],
+      error: parse_error_type(expected['error']),
+      message: expected['message'],
+      value: expected['value']
+    }
+  end
+
+  def parse_error_type(error_type)
+    case error_type
+    when 'missing_default' then Prefab::Errors::MissingDefaultError
+    end
+  end
+
+  def base_client
+    @_base_client ||= Prefab::Client.new(base_client_options)
+  end
+
+  def base_client_options
+    @_options ||= Prefab::Options.new(**{
+      prefab_config_override_dir: 'none',
+      prefab_config_classpath_dir: 'test',
+      prefab_envs: ['unit_tests'],
+      prefab_datasources: Prefab::Options::DATASOURCES::ALL,
+      api_key: ENV['PREFAB_INTEGRATION_TEST_API_KEY'],
+      prefab_api_url: 'https://api.staging-prefab.cloud',
+      prefab_grpc_url: 'grpc.staging-prefab.cloud:443'
+    }.merge(@client_overrides))
+  end
+end

data/test/integration_test_helpers.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module IntegrationTestHelpers
+  SUBMODULE_PATH = 'test/prefab-cloud-integration-test-data'
+  RAISE_IF_NO_TESTS_FOUND = ENV['PREFAB_INTEGRATION_TEST_RAISE'] == 'true'
+
+  def self.find_integration_tests
+    version = find_integration_test_version
+
+    files = find_versioned_test_files(version)
+
+    if files.none?
+      message = "No integration tests found for version: #{version}"
+      raise message if RAISE_IF_NO_TESTS_FOUND
+
+      puts message
+
+    end
+
+    files
+  end
+
+  def self.find_integration_test_version
+    File.read(File.join(SUBMODULE_PATH, 'version')).strip
+  rescue StandardError => e
+    puts "No version found for integration tests: #{e.message}"
+  end
+
+  def self.find_versioned_test_files(version)
+    if version.nil?
+      []
+    else
+      Dir[File.join(SUBMODULE_PATH, "tests/#{version}/**/*")]
+        .select { |file| file =~ /\.ya?ml$/ }
+    end
+  end
+end

data/test/test_client.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class TestClient < Minitest::Test
@@ -7,25 +8,25 @@ class TestClient < Minitest::Test
   end
 
   def test_get
-    assert_equal "test sample value", @client.get("sample")
-    assert_equal 123, @client.get("sample_int")
+    assert_equal 'test sample value', @client.get('sample')
+    assert_equal 123, @client.get('sample_int')
   end
 
   def test_get_with_default
     # A `false` value is not replaced with the default
-    assert_equal false, @client.get("false_value", "red")
+    assert_equal false, @client.get('false_value', 'red')
 
     # A falsy value is not replaced with the default
-    assert_equal 0, @client.get("zero_value", "red")
+    assert_equal 0, @client.get('zero_value', 'red')
 
     # A missing value returns the default
-    assert_equal "buckets", @client.get("missing_value", "buckets")
+    assert_equal 'buckets', @client.get('missing_value', 'buckets')
   end
 
   def test_get_with_missing_default
     # it raises by default
     err = assert_raises(Prefab::Errors::MissingDefaultError) do
-      assert_nil @client.get("missing_value")
+      assert_nil @client.get('missing_value')
     end
 
     assert_match(/No value found for key/, err.message)
@@ -33,51 +34,51 @@ class TestClient < Minitest::Test
 
     # you can opt-in to return `nil` instead
     client = new_client(on_no_default: Prefab::Options::ON_NO_DEFAULT::RETURN_NIL)
-    assert_nil client.get("missing_value")
+    assert_nil client.get('missing_value')
   end
 
   def test_enabled
-    assert_equal false, @client.enabled?("does_not_exist")
-    assert_equal true, @client.enabled?("enabled_flag")
-    assert_equal false, @client.enabled?("disabled_flag")
-    assert_equal false, @client.enabled?("flag_with_a_value")
+    assert_equal false, @client.enabled?('does_not_exist')
+    assert_equal true, @client.enabled?('enabled_flag')
+    assert_equal false, @client.enabled?('disabled_flag')
+    assert_equal false, @client.enabled?('flag_with_a_value')
   end
 
   def test_ff_enabled_with_lookup_key
-    assert_equal false, @client.enabled?("in_lookup_key", "jimmy")
-    assert_equal true, @client.enabled?("in_lookup_key", "abc123")
-    assert_equal true, @client.enabled?("in_lookup_key", "xyz987")
+    assert_equal false, @client.enabled?('in_lookup_key', 'jimmy')
+    assert_equal true, @client.enabled?('in_lookup_key', 'abc123')
+    assert_equal true, @client.enabled?('in_lookup_key', 'xyz987')
   end
 
   def test_ff_get_with_lookup_key
-    assert_nil @client.get("in_lookup_key", "jimmy")
-    assert_equal "DEFAULT", @client.get("in_lookup_key", "jimmy", {}, "DEFAULT")
+    assert_nil @client.get('in_lookup_key', 'jimmy')
+    assert_equal 'DEFAULT', @client.get('in_lookup_key', 'jimmy', {}, 'DEFAULT')
 
-    assert_equal true, @client.get("in_lookup_key", "abc123")
-    assert_equal true, @client.get("in_lookup_key", "xyz987")
+    assert_equal true, @client.get('in_lookup_key', 'abc123')
+    assert_equal true, @client.get('in_lookup_key', 'xyz987')
   end
 
   def test_ff_enabled_with_attributes
-    assert_equal false, @client.enabled?("just_my_domain", "abc123", { domain: "gmail.com" })
-    assert_equal false, @client.enabled?("just_my_domain", "abc123", { domain: "prefab.cloud" })
-    assert_equal false, @client.enabled?("just_my_domain", "abc123", { domain: "example.com" })
+    assert_equal false, @client.enabled?('just_my_domain', 'abc123', { domain: 'gmail.com' })
+    assert_equal false, @client.enabled?('just_my_domain', 'abc123', { domain: 'prefab.cloud' })
+    assert_equal false, @client.enabled?('just_my_domain', 'abc123', { domain: 'example.com' })
   end
 
   def test_ff_get_with_attributes
-    assert_nil @client.get("just_my_domain", "abc123", { domain: "gmail.com" })
-    assert_equal "DEFAULT", @client.get("just_my_domain", "abc123", { domain: "gmail.com" }, "DEFAULT")
+    assert_nil @client.get('just_my_domain', 'abc123', { domain: 'gmail.com' })
+    assert_equal 'DEFAULT', @client.get('just_my_domain', 'abc123', { domain: 'gmail.com' }, 'DEFAULT')
 
-    assert_equal "new-version", @client.get("just_my_domain", "abc123", { domain: "prefab.cloud" })
-    assert_equal "new-version", @client.get("just_my_domain", "abc123", { domain: "example.com" })
+    assert_equal 'new-version', @client.get('just_my_domain', 'abc123', { domain: 'prefab.cloud' })
+    assert_equal 'new-version', @client.get('just_my_domain', 'abc123', { domain: 'example.com' })
   end
 
   def test_getting_feature_flag_value
-    assert_equal false, @client.enabled?("flag_with_a_value")
-    assert_equal "all-features", @client.get("flag_with_a_value")
+    assert_equal false, @client.enabled?('flag_with_a_value')
+    assert_equal 'all-features', @client.get('flag_with_a_value')
   end
 
   def test_ssl_certs
-    certs = @client.send(:ssl_certs).split("-----BEGIN CERTIFICATE-----")
+    certs = @client.send(:ssl_certs).split('-----BEGIN CERTIFICATE-----')
 
     # This is a smoke test to make sure multiple certs are loaded
     assert certs.length > 1
@@ -87,9 +88,9 @@ class TestClient < Minitest::Test
 
   def new_client(overrides = {})
     options = Prefab::Options.new(**{
-      prefab_config_override_dir: "none",
-      prefab_config_classpath_dir: "test",
-      prefab_envs: ["unit_tests"],
+      prefab_config_override_dir: 'none',
+      prefab_config_classpath_dir: 'test',
+      prefab_envs: ['unit_tests'],
       prefab_datasources: Prefab::Options::DATASOURCES::LOCAL_ONLY
     }.merge(overrides))
 

data/test/test_config_client.rb

@@ -1,12 +1,13 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class TestConfigClient < Minitest::Test
   def setup
     options = Prefab::Options.new(
-      prefab_config_override_dir: "none",
-      prefab_config_classpath_dir: "test",
-      prefab_envs: "unit_tests",
+      prefab_config_override_dir: 'none',
+      prefab_config_classpath_dir: 'test',
+      prefab_envs: 'unit_tests',
       prefab_datasources: Prefab::Options::DATASOURCES::LOCAL_ONLY
     )
 
@@ -14,59 +15,59 @@ class TestConfigClient < Minitest::Test
   end
 
   def test_load
-    assert_equal "test sample value", @config_client.get("sample")
-    assert_equal 123, @config_client.get("sample_int")
-    assert_equal 12.12, @config_client.get("sample_double")
-    assert_equal true, @config_client.get("sample_bool")
-    assert_equal :ERROR, @config_client.get("log-level.app")
+    assert_equal 'test sample value', @config_client.get('sample')
+    assert_equal 123, @config_client.get('sample_int')
+    assert_equal 12.12, @config_client.get('sample_double')
+    assert_equal true, @config_client.get('sample_bool')
+    assert_equal :ERROR, @config_client.get('log-level.app')
   end
 
   def test_initialization_timeout_error
     options = Prefab::Options.new(
-      api_key: "123-ENV-KEY-SDK",
+      api_key: '123-ENV-KEY-SDK',
       initialization_timeout_sec: 0.01,
       logdev: StringIO.new
     )
 
     err = assert_raises(Prefab::Errors::InitializationTimeoutError) do
-      Prefab::Client.new(options).config_client.get("anything")
+      Prefab::Client.new(options).config_client.get('anything')
     end
 
     assert_match(/couldn't initialize in 0.01 second timeout/, err.message)
   end
 
   def test_prefab_envs_is_forgiving
-    assert_equal ["my_env"], Prefab::Options.new(
-      prefab_envs: "my_env",
+    assert_equal ['my_env'], Prefab::Options.new(
+      prefab_envs: 'my_env'
     ).prefab_envs
 
-    assert_equal ["my_env", "a_second_env"], Prefab::Options.new(
-      prefab_envs: ["my_env", "a_second_env"],
+    assert_equal %w[my_env a_second_env], Prefab::Options.new(
+      prefab_envs: %w[my_env a_second_env]
     ).prefab_envs
   end
 
   def test_prefab_envs_env_var
-    ENV["PREFAB_ENVS"] = "one,two"
-    assert_equal ["one", "two"], Prefab::Options.new().prefab_envs
+    ENV['PREFAB_ENVS'] = 'one,two'
+    assert_equal %w[one two], Prefab::Options.new.prefab_envs
   end
 
   def test_invalid_api_key_error
     options = Prefab::Options.new(
-      api_key: "",
+      api_key: ''
     )
 
     err = assert_raises(Prefab::Errors::InvalidApiKeyError) do
-      Prefab::Client.new(options).config_client.get("anything")
+      Prefab::Client.new(options).config_client.get('anything')
     end
 
     assert_match(/No API key/, err.message)
 
     options = Prefab::Options.new(
-      api_key: "invalid",
+      api_key: 'invalid'
     )
 
     err = assert_raises(Prefab::Errors::InvalidApiKeyError) do
-      Prefab::Client.new(options).config_client.get("anything")
+      Prefab::Client.new(options).config_client.get('anything')
     end
 
     assert_match(/format is invalid/, err.message)