prefab-cloud-ruby 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56f869e526c34a5e949e257b7d3bad480e9bfc35a32c228c00edf27bd1ffd0e1
-  data.tar.gz: 34e5775b22b085295618be7f9c411923d3b643e16032ee70c7dc6340fed6009b
+  metadata.gz: 82381e4b656d675f4b98ee11601cde1920637e52eb5b039814247500207b9fa5
+  data.tar.gz: 4ff8914774523e745d512d506cc42f20e71a657fd8191d82e7e6ba1878bf04c9
 SHA512:
-  metadata.gz: d5ce5a0a3c1dc3d0d8e258da5da8cd9f12975d8232c0775a39a205cbfb464074bf0fda9c7467d5bdbc4d04a4020d48aa68a816eaf1714ea5c3863a299178b2ac
-  data.tar.gz: 5123db89a4947143ceff5e29f30cd655870193c6ec8afaa7eca9f2fb85d61c1da2eae18a1fd31fbd3ae5c580a4e438c93c330ecb54fffdaf05b94259b6dc96ec
+  metadata.gz: aac3fc04c779900ca92a6a859430a2fe7776bee90afba632456ff45e3bacb428dda61314d3cbf5a5b04ce61672e4591afb7ae0248b77352b381f52dcbbfb6f24
+  data.tar.gz: 5e2008ec802e2f32154bffb34804673187feb618a60edf2aba19666851787e14111e3d6e0fbeeebe8e3192cac56a32f3010b4d46ef507c3d16359886973ee90c

data/Gemfile

@@ -8,6 +8,7 @@ gem 'google-protobuf', :platforms => :ruby
 gem 'googleapis-common-protos-types', :platforms => :ruby
 
 group :development do
+  gem 'benchmark-ips'
   gem 'grpc-tools', :platforms => :ruby
   gem "rdoc", "~> 3.12"
   gem "bundler"

data/Gemfile.lock

@@ -3,6 +3,7 @@ GEM
   specs:
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
+    benchmark-ips (2.10.0)
     builder (3.2.4)
     concurrent-ruby (1.1.10)
     daemons (1.4.1)
@@ -109,6 +110,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  benchmark-ips
   bundler
   concurrent-ruby (~> 1.0, >= 1.0.5)
   faraday

data/VERSION

@@ -1 +1 @@
-0.15.0
+0.16.0

data/lib/prefab/feature_flag_client.rb

@@ -121,33 +121,40 @@ module Prefab
       int_value / MAX_32_FLOAT
     end
 
-    # def criteria_match?(rule, lookup_key, attributes)
-    #
-    # end
     def criteria_match?(criteria, lookup_key, attributes)
-      if criteria.operator == :ALWAYS_TRUE
-        return true
-      elsif criteria.operator == :LOOKUP_KEY_IN
-        return criteria.values.include?(lookup_key)
-      elsif criteria.operator == :LOOKUP_KEY_NOT_IN
-        return !criteria.values.include?(lookup_key)
-      elsif criteria.operator == :IN_SEG
-        return segment_matches(criteria.values, lookup_key, attributes).any?
-      elsif criteria.operator == :NOT_IN_SEG
-        return segment_matches(criteria.values, lookup_key, attributes).none?
-      elsif criteria.operator == :PROP_IS_ONE_OF
-        return criteria.values.include?(attributes[criteria.property]) || criteria.values.include?(attributes[criteria.property.to_sym])
-      elsif criteria.operator == :PROP_IS_NOT_ONE_OF
-        return !(criteria.values.include?(attributes[criteria.property]) || criteria.values.include?(attributes[criteria.property.to_sym]))
+      case criteria.operator
+      when :ALWAYS_TRUE
+        true
+      when :LOOKUP_KEY_IN
+        criteria.values.include?(lookup_key)
+      when :LOOKUP_KEY_NOT_IN
+        !criteria.values.include?(lookup_key)
+      when :IN_SEG
+        segment_matches?(criteria.values, lookup_key, attributes)
+      when :NOT_IN_SEG
+        !segment_matches?(criteria.values, lookup_key, attributes)
+      when :PROP_IS_ONE_OF
+        criteria.values.include?(attribute_value(attributes, criteria.property))
+      when :PROP_IS_NOT_ONE_OF
+        !criteria.values.include?(attribute_value(attributes, criteria.property))
+      when :PROP_ENDS_WITH_ONE_OF
+        criteria.values.any? { |value| attribute_value(attributes, criteria.property)&.end_with?(value) }
+      when :PROP_DOES_NOT_END_WITH_ONE_OF
+        criteria.values.none? { |value| attribute_value(attributes, criteria.property)&.end_with?(value) }
+      else
+        @base_client.log.info("Unknown Operator: #{criteria.operator}")
+        false
       end
-      @base_client.log.info("Unknown Operator")
-      false
     end
 
-    # evaluate each segment key and return whether each one matches
+    def attribute_value(attributes, property)
+      attributes[property] || attributes[property.to_sym]
+    end
+
+    # evaluate each segment key and return whether any match
     # there should be an associated segment available as a standard config obj
-    def segment_matches(segment_keys, lookup_key, attributes)
-      segment_keys.map do |segment_key|
+    def segment_matches?(segment_keys, lookup_key, attributes)
+      segment_keys.any? do |segment_key|
         segment = @base_client.config_client.get(segment_key)
         if segment.nil?
           @base_client.log.info("Missing Segment")
@@ -160,9 +167,9 @@ module Prefab
 
     # does a given segment match?
     def segment_match?(segment, lookup_key, attributes)
-      segment.criterion.map do |criteria|
+      segment.criterion.any? do |criteria|
         criteria_match?(criteria, lookup_key, attributes)
-      end.any?
+      end
     end
   end
 end

data/prefab-cloud-ruby.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: prefab-cloud-ruby 0.15.0 ruby lib
+# stub: prefab-cloud-ruby 0.16.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "prefab-cloud-ruby".freeze
-  s.version = "0.15.0"
+  s.version = "0.16.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeff Dwyer".freeze]
-  s.date = "2022-08-28"
+  s.date = "2022-09-01"
   s.description = "RateLimits & Config as a service".freeze
   s.email = "jdwyer@prefab.cloud".freeze
   s.extra_rdoc_files = [
@@ -81,6 +81,7 @@ Gem::Specification.new do |s|
     s.add_runtime_dependency(%q<grpc>.freeze, [">= 0"])
     s.add_runtime_dependency(%q<google-protobuf>.freeze, [">= 0"])
     s.add_runtime_dependency(%q<googleapis-common-protos-types>.freeze, [">= 0"])
+    s.add_development_dependency(%q<benchmark-ips>.freeze, [">= 0"])
     s.add_development_dependency(%q<grpc-tools>.freeze, [">= 0"])
     s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
     s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
@@ -94,6 +95,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<grpc>.freeze, [">= 0"])
     s.add_dependency(%q<google-protobuf>.freeze, [">= 0"])
     s.add_dependency(%q<googleapis-common-protos-types>.freeze, [">= 0"])
+    s.add_dependency(%q<benchmark-ips>.freeze, [">= 0"])
     s.add_dependency(%q<grpc-tools>.freeze, [">= 0"])
     s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
     s.add_dependency(%q<bundler>.freeze, [">= 0"])

data/test/test_feature_flag_client.rb

@@ -299,6 +299,66 @@ class TestFeatureFlagClient < Minitest::Test
 
   end
 
+  def test_prop_ends_with_one_of
+    feature = "FlagName"
+
+    variants = [
+      Prefab::FeatureFlagVariant.new(bool: false),
+      Prefab::FeatureFlagVariant.new(bool: true)
+    ]
+    flag = Prefab::FeatureFlag.new(
+      active: true,
+      inactive_variant_idx: 1,
+      rules: [
+        Prefab::Rule.new(
+          criteria: Prefab::Criteria.new(operator: Prefab::Criteria::CriteriaOperator::PROP_ENDS_WITH_ONE_OF,
+                                         property: "email",
+                                         values: ["@example.com"]),
+          variant_weights: [
+            Prefab::VariantWeight.new(weight: 100, variant_idx: 2)
+          ]
+        )
+      ]
+    )
+
+    assert_equal false, evaluate(feature, "user:0", {}, flag, variants)
+    assert_equal true, evaluate(feature, "user:0", {email: "test@example.com"}, flag, variants)
+    assert_equal true, evaluate(feature, "user:0", {"email" => "test@example.com"}, flag, variants)
+  end
+
+  def test_prop_does_not_end_with_one_of
+    feature = "FlagName"
+
+    variants = [
+      Prefab::FeatureFlagVariant.new(bool: false),
+      Prefab::FeatureFlagVariant.new(bool: true)
+    ]
+    flag = Prefab::FeatureFlag.new(
+      active: true,
+      inactive_variant_idx: 1,
+      rules: [
+        Prefab::Rule.new(
+          criteria: Prefab::Criteria.new(operator: Prefab::Criteria::CriteriaOperator::PROP_DOES_NOT_END_WITH_ONE_OF,
+                                         property: "email",
+                                         values: ["@example.com"]),
+          variant_weights: [
+            Prefab::VariantWeight.new(weight: 100, variant_idx: 2)
+          ]
+        ),
+        Prefab::Rule.new(
+          criteria: Prefab::Criteria.new(operator: Prefab::Criteria::CriteriaOperator::ALWAYS_TRUE),
+          variant_weights: [
+            Prefab::VariantWeight.new(weight: 100, variant_idx: 1)
+          ]
+        )
+      ],
+    )
+
+    assert_equal true, evaluate(feature, "user:0", {}, flag, variants)
+    assert_equal false, evaluate(feature, "user:0", {email: "test@example.com"}, flag, variants)
+    assert_equal false, evaluate(feature, "user:0", {"email" => "test@example.com"}, flag, variants)
+  end
+
   def evaluate(feature_name, lookup_key, attributes, flag, variants)
     variant = @client.get_variant(feature_name, lookup_key, attributes, flag, variants)
     @client.value_of_variant(variant)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prefab-cloud-ruby
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Jeff Dwyer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-28 00:00:00.000000000 Z
+date: 2022-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -100,6 +100,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: grpc-tools
   requirement: !ruby/object:Gem::Requirement