prefab-cloud-ruby 0.11.0 → 0.12.0

data/test/test_feature_flag_client.rb

@@ -75,32 +75,6 @@ class TestFeatureFlagClient < Minitest::Test
                  @client.evaluate(feature, "hashes low", [], flag, variants)
   end
 
-  def test_user_targets
-
-    feature = "FlagName"
-    variants = [
-      Prefab::FeatureFlagVariant.new(string: "inactive"),
-      Prefab::FeatureFlagVariant.new(string: "user target"),
-      Prefab::FeatureFlagVariant.new(string: "default"),
-    ]
-    flag = Prefab::FeatureFlag.new(
-      active: true,
-      inactive_variant_idx: 1,
-      user_targets: [
-        variant_idx: 2,
-        identifiers: ["user:1", "user:3"]
-      ],
-      rules: default_ff_rule(3)
-    )
-
-    assert_equal "user target",
-                 @client.evaluate(feature, "user:1", [], flag, variants)
-    assert_equal "default",
-                 @client.evaluate(feature, "user:2", [], flag, variants)
-    assert_equal "user target",
-                 @client.evaluate(feature, "user:3", [], flag, variants)
-  end
-
   def test_inclusion_rule
     feature = "FlagName"
     variants = [
@@ -174,34 +148,46 @@ class TestFeatureFlagClient < Minitest::Test
     )
 
     assert_equal "default",
-                 @client.evaluate(feature, "user:1", {email: "not@example.com"}, flag, variants)
+                 @client.evaluate(feature, "user:1", { email: "not@example.com" }, flag, variants)
     assert_equal "default",
                  @client.evaluate(feature, "user:2", {}, flag, variants)
     assert_equal "rule target",
-                 @client.evaluate(feature, "user:2", {email: "b@example.com"}, flag, variants)
+                 @client.evaluate(feature, "user:2", { email: "b@example.com" }, flag, variants)
     assert_equal "rule target",
-                 @client.evaluate(feature, "user:2", {"email" => "b@example.com"}, flag, variants)
+                 @client.evaluate(feature, "user:2", { "email" => "b@example.com" }, flag, variants)
 
   end
 
   def test_segment_match?
     segment = Prefab::Segment.new(
-      name: "Beta Group",
-      includes: ["user:1", "user:5"],
-      excludes: ["user:1", "user:2"]
+      criterion: [
+        Prefab::Criteria.new(
+          operator: "PROP_IS_ONE_OF",
+          values: ["a@example.com", "b@example.com"],
+          property: "email"
+        ),
+        Prefab::Criteria.new(
+          operator: "LOOKUP_KEY_IN",
+          values: ["user:2"]
+        )
+      ]
     )
     assert_equal false, @client.segment_match?(segment, "user:0", {})
-    assert_equal false, @client.segment_match?(segment, "user:1", {})
-    assert_equal false, @client.segment_match?(segment, "user:2", {})
-    assert_equal true, @client.segment_match?(segment, "user:5", {})
+    assert_equal true, @client.segment_match?(segment, "user:2", {})
+    assert_equal false, @client.segment_match?(segment, "user:1", { email: "no@example.com" })
+    assert_equal true, @client.segment_match?(segment, "user:1", { email: "a@example.com" })
   end
 
   def test_segments
     segment_key = "prefab-segment-beta-group"
     @mock_base_client.config_client.mock_this_config(segment_key,
                                                      Prefab::Segment.new(
-                                                       name: "Beta Group",
-                                                       includes: ["user:1"]
+                                                       criterion: [
+                                                         Prefab::Criteria.new(
+                                                           operator: Prefab::Criteria::CriteriaOperator::LOOKUP_KEY_IN,
+                                                           values: ["user:1"]
+                                                         )
+                                                       ]
                                                      )
     )
 
@@ -247,17 +233,23 @@ class TestFeatureFlagClient < Minitest::Test
     segment_key_one = "prefab-segment-segment-1"
     @mock_base_client.config_client.mock_this_config(segment_key_one,
                                                      Prefab::Segment.new(
-                                                       name: "Segment-1",
-                                                       includes: ["user:1", "user:2"],
-                                                       excludes: ["user:3"]
+                                                       criterion: [
+                                                         Prefab::Criteria.new(
+                                                           operator: Prefab::Criteria::CriteriaOperator::LOOKUP_KEY_IN,
+                                                           values: ["user:1", "user:2"]
+                                                         )
+                                                       ]
                                                      )
     )
     segment_key_two = "prefab-segment-segment-2"
     @mock_base_client.config_client.mock_this_config(segment_key_two,
                                                      Prefab::Segment.new(
-                                                       name: "Segment-2",
-                                                       includes: ["user:3", "user:4"],
-                                                       excludes: ["user:2"]
+                                                       criterion: [
+                                                         Prefab::Criteria.new(
+                                                           operator: Prefab::Criteria::CriteriaOperator::LOOKUP_KEY_IN,
+                                                           values: ["user:3", "user:4"]
+                                                         )
+                                                       ]
                                                      )
     )
 
@@ -288,7 +280,8 @@ class TestFeatureFlagClient < Minitest::Test
                                       variant_idx: 3)
           ]
         )
-      ]
+
+      ],
     )
 
     assert_equal "rule target",

data/test/test_helper.rb

@@ -5,12 +5,12 @@ class MockBaseClient
   STAGING_ENV_ID = 1
   PRODUCTION_ENV_ID = 2
   TEST_ENV_ID = 3
-  attr_reader :namespace, :logger, :config_client
-
-  def initialize(namespace: "")
+  attr_reader :namespace, :logger, :config_client, :options
 
+  def initialize(options = Prefab::Options.new)
+    @options = options
     @namespace = namespace
-    @logger = Logger.new($stdout)
+    @logger = Prefab::LoggerClient.new($stdout)
     @config_client = MockConfigClient.new
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prefab-cloud-ruby
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Jeff Dwyer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-05 00:00:00.000000000 Z
+date: 2022-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -225,10 +225,13 @@ files:
 - lib/prefab/config_loader.rb
 - lib/prefab/config_resolver.rb
 - lib/prefab/feature_flag_client.rb
+- lib/prefab/internal_logger.rb
 - lib/prefab/logger_client.rb
 - lib/prefab/murmer3.rb
 - lib/prefab/noop_cache.rb
 - lib/prefab/noop_stats.rb
+- lib/prefab/options.rb
+- lib/prefab/prefab.rb
 - lib/prefab/ratelimit_client.rb
 - lib/prefab_pb.rb
 - lib/prefab_services_pb.rb
@@ -236,6 +239,7 @@ files:
 - run_test_harness_server.sh
 - test/.prefab.test.config.yaml
 - test/harness_server.rb
+- test/test_config_client.rb
 - test/test_config_loader.rb
 - test/test_config_resolver.rb
 - test/test_feature_flag_client.rb