prefab-cloud-ruby 0.0.14 → 0.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 70b7e6905adede604544ce942c02d4b77c8e368b
-  data.tar.gz: 9b5091d9df705f1c8dd01ab7bc218ac0bcdada04
+  metadata.gz: b73b4ea9cec303d84c4e8cd05458a8373cfcb0b7
+  data.tar.gz: 243c8d3dda441efd9b3f5741c6b52355a2256665
 SHA512:
-  metadata.gz: 75fb25229c3523976b4048c4bbc220705486062620c8f51951ff41cb80c0b575cb4bbab1cf792366c108c553b94a00a0f89b594e328d725eeb7a58bce8990865
-  data.tar.gz: a8cc43a7a3e102bd4bfe131f93e3ff0eb0a389cc3e8ba10357d426aefd5608ebcee9269cc6ca228ae059ee0b8ec590e09fa7a68cb5f383c176254563df4e0817
+  metadata.gz: a2375b7451fcd3623a14dd74cdaf568521baa5e554b15f67d1675570a89783f5212938d6f5e2dc44afa4544709cda070d4b59c72dd7124a3f881f3d8ef34f02e
+  data.tar.gz: b1032ec6c8953b2c0896367bd1276315271ba75c68b3f57134b082d35f8b2b972bf36e76546cf34bad48286eadba4cff4d32b2d774403cc550f6d26841a3ef6a

data/Gemfile

@@ -1,10 +1,10 @@
 source "https://rubygems.org"
 
-gem 'grpc', '~> 1.8.3'
+gem 'grpc', '~> 1.10.0'
 gem 'concurrent-ruby', '~> 1.0', '>= 1.0.5'
 
 group :development do
-  gem 'grpc-tools', '~> 1.8.3'
+  gem 'grpc-tools', '~> 1.10.0'
   gem "shoulda", ">= 0"
   gem "rdoc", "~> 3.12"
   gem "bundler", "~> 1.0"

data/Gemfile.lock

@@ -22,7 +22,7 @@ GEM
       faraday (~> 0.8)
       hashie (~> 3.5, >= 3.5.2)
       oauth2 (~> 1.0)
-    google-protobuf (3.5.1)
+    google-protobuf (3.5.1.2)
     googleapis-common-protos-types (1.0.1)
       google-protobuf (~> 3.0)
     googleauth (0.6.2)
@@ -33,11 +33,11 @@ GEM
       multi_json (~> 1.11)
       os (~> 0.9)
       signet (~> 0.7)
-    grpc (1.8.3)
+    grpc (1.10.0)
       google-protobuf (~> 3.1)
       googleapis-common-protos-types (~> 1.0.0)
       googleauth (>= 0.5.1, < 0.7)
-    grpc-tools (1.8.3)
+    grpc-tools (1.10.0)
     hashie (3.5.6)
     highline (1.7.10)
     i18n (0.9.1)
@@ -105,8 +105,8 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 1.0)
   concurrent-ruby (~> 1.0, >= 1.0.5)
-  grpc (~> 1.8.3)
-  grpc-tools (~> 1.8.3)
+  grpc (~> 1.10.0)
+  grpc-tools (~> 1.10.0)
   juwelier (~> 2.1.0)
   rdoc (~> 3.12)
   shoulda

data/VERSION

@@ -1 +1 @@
-0.0.14
+0.0.15

data/lib/prefab/client.rb

@@ -36,14 +36,8 @@ module Prefab
                       GRPC::Core::Channel.new('api.prefab.cloud:8443', nil, @creds)
     end
 
-    def reset_channel!
-      @_channel = nil
-    end
-
     def config_client(timeout: 5.0)
       @config_client ||= Prefab::ConfigClient.new(self, timeout)
-      @config_client.init
-      @config_client
     end
 
     def ratelimit_client(timeout: 5.0)
@@ -55,7 +49,7 @@ module Prefab
     end
 
     def log(base_logger = @logger)
-      @logger_client || Prefab::LoggerClient.new(self, base_logger)
+      @logger_client ||= Prefab::LoggerClient.new(base_logger)
     end
 
     def log_internal(level, msg)
@@ -70,7 +64,7 @@ module Prefab
 
       begin
         attempts += 1
-        return stub_for(service).send(method, *params)
+        return stub_for(service, opts[:timeout]).send(method, *params)
       rescue => exception
 
         log_internal :warn, exception
@@ -95,11 +89,12 @@ module Prefab
       reset_channel!
     end
 
-    def stub_for(service)
-      @stubs[service] ||= service::Stub.new(nil,
-                                            nil,
-                                            channel_override: channel,
-                                            interceptors: [@interceptor])
+    def stub_for(service, timeout)
+      @stubs["#{service}_#{timeout}"] ||= service::Stub.new(nil,
+                                                            nil,
+                                                            timeout: timeout,
+                                                            channel_override: channel,
+                                                            interceptors: [@interceptor])
     end
 
     def ssl_certs

data/lib/prefab/config_client.rb

@@ -1,29 +1,31 @@
 module Prefab
   class ConfigClient
     RECONNECT_WAIT = 5
-    CHECKPOINT_FREQ_SEC = 10
-    SUSPENDERS_FREQ_SEC = 60
+    CHECKPOINT_LOCK = 20
+    DEFAULT_CHECKPOINT_FREQ_SEC = 10
+    DEFAULT_MAX_CHECKPOINT_AGE_SEC = 60
 
     def initialize(base_client, timeout)
       @base_client = base_client
       @timeout = timeout
-      @initialized = false
-    end
-
-    def init
-      if !@initialized
-        @initialized = true
-        @config_loader = Prefab::ConfigLoader.new(@base_client)
-        @config_resolver = Prefab::ConfigResolver.new(@base_client, @config_loader)
-        start_at_id = load_checkpoint
-        start_api_connection_thread(start_at_id)
-        start_checkpointing_thread
-        start_suspenders_thread
-      end
+      @initialization_lock = Concurrent::ReadWriteLock.new
+
+      @checkpoint_max_age_secs = (ENV["PREFAB_CHECKPOINT_MAX_AGE_SEC"] || DEFAULT_MAX_CHECKPOINT_AGE_SEC)
+      @checkpoint_max_age = @checkpoint_max_age_secs * 1000 * 10000
+      @checkpoint_freq_secs = (ENV["PREFAB_DEFAULT_CHECKPOINT_FREQ_SEC"] || DEFAULT_CHECKPOINT_FREQ_SEC)
+
+      @config_loader = Prefab::ConfigLoader.new(@base_client)
+      @config_resolver = Prefab::ConfigResolver.new(@base_client, @config_loader)
+
+      @initialization_lock.acquire_write_lock
+
+      start_checkpointing_thread
     end
 
     def get(prop)
-      @config_resolver.get(prop) if @config_resolver
+      @initialization_lock.with_read_lock do
+        @config_resolver.get(prop)
+      end
     end
 
     def upsert(key, config_value, namespace = nil, previous_key = nil)
@@ -33,7 +35,7 @@ module Prefab
       upsert_req = Prefab::UpsertRequest.new(config_delta: config_delta)
       upsert_req.previous_key = previous_key if previous_key&.present?
 
-      @base_client.request Prefab::ConfigService, :upsert, req_options: {timeout: @timeout}, params: upsert_req
+      @base_client.request Prefab::ConfigService, :upsert, req_options: { timeout: @timeout }, params: upsert_req
 
       @config_loader.set(config_delta)
       @config_loader.rm(previous_key) if previous_key&.present?
@@ -41,7 +43,7 @@ module Prefab
     end
 
     def reset
-      @base_client.reset_channel!
+      @base_client.reset!
       @_stub = nil
     end
 
@@ -63,30 +65,35 @@ module Prefab
                                                interceptors: [@base_client.interceptor])
     end
 
-    def cache_key
-      "prefab:config:checkpoint"
-    end
-
     # Bootstrap out of the cache
     # returns the high-watermark of what was in the cache
     def load_checkpoint
-      checkpoint = @base_client.shared_cache.read(cache_key)
-      start_at_id = 0
+      checkpoint = @base_client.shared_cache.read(checkpoint_cache_key)
 
       if checkpoint
         deltas = Prefab::ConfigDeltas.decode(checkpoint)
         deltas.deltas.each do |delta|
-          @base_client.log_internal :debug, "checkpoint set #{delta.key} #{delta.value.int} #{delta.value.string} #{delta.id} "
           @config_loader.set(delta)
-          start_at_id = [delta.id, start_at_id].max
         end
-        @base_client.log_internal :info, "Found checkpoint with highwater id #{start_at_id}"
+        @base_client.log_internal :info, "Found checkpoint with highwater id #{@config_loader.highwater_mark}"
         @config_resolver.update
+        finish_init!
       else
         @base_client.log_internal :info, "No checkpoint"
       end
+    end
 
-      start_at_id
+    # Save off the config to a local cache as a backup
+    #
+    def save_checkpoint
+      begin
+        deltas = @config_resolver.export_api_deltas
+        @base_client.log_internal :debug, "Save Checkpoint #{@config_loader.highwater_mark} Thread #{Thread.current.object_id}"
+        @base_client.shared_cache.write(checkpoint_cache_key, Prefab::ConfigDeltas.encode(deltas))
+        @base_client.shared_cache.write(checkpoint_highwater_cache_key, @config_loader.highwater_mark)
+      rescue StandardError => exn
+        @base_client.log_internal :info, "Issue Saving Checkpoint #{exn.message}"
+      end
     end
 
     # A thread that saves current state to the cache, "checkpointing" it
@@ -94,14 +101,13 @@ module Prefab
       Thread.new do
         loop do
           begin
+            checkpoint_if_needed
+
             started_at = Time.now
-            delta = CHECKPOINT_FREQ_SEC - (Time.now - started_at)
+            delta = @checkpoint_freq_secs - (Time.now - started_at)
             if delta > 0
               sleep(delta)
             end
-            deltas = @config_resolver.export_api_deltas
-            @base_client.log_internal :debug, "Save Checkpoint #{deltas.deltas.map {|d| d.id}.max} Thread #{Thread.current.object_id}"
-            @base_client.shared_cache.write(cache_key, Prefab::ConfigDeltas.encode(deltas))
           rescue StandardError => exn
             @base_client.log_internal :info, "Issue Checkpointing #{exn.message}"
           end
@@ -109,12 +115,74 @@ module Prefab
       end
     end
 
+    # check what our shared highwater mark is
+    # if it is higher than our own highwater mark, we must have missed something, so load the checkpoint
+    # if it is lower than our own highwater mark, save a checkpoint
+    # if everything is up to date, but the shared highwater mark is old, coordinate amongst other processes to have
+    #    one process "double check" by restarting the API thread
+    def checkpoint_if_needed
+      shared_highwater_mark = get_shared_highwater_mark
+      @base_client.log_internal :debug, "Checkpoint_if_needed apx ahead/behind #{(@config_loader.highwater_mark - shared_highwater_mark) / (1000 * 10000)}"
+
+      if shared_highwater_mark > @config_loader.highwater_mark
+        @base_client.log_internal :debug, "We were behind, loading checkpoint"
+        load_checkpoint
+      elsif shared_highwater_mark < @config_loader.highwater_mark
+        @base_client.log_internal :debug, "Saving off checkpoint"
+        save_checkpoint
+      elsif shared_highwater_is_old?
+        if get_shared_lock?
+          @base_client.log_internal :debug, "Shared highwater mark > PREFAB_CHECKPOINT_MAX_AGE #{@checkpoint_max_age_secs}. We have been chosen to run suspenders"
+          reset_api_connection
+        else
+          @base_client.log_internal :debug, "Shared highwater mark > PREFAB_CHECKPOINT_MAX_AGE #{@checkpoint_max_age_secs}. Other process is running suspenders"
+        end
+      end
+    end
+
+    def current_time_as_id
+      Time.now.to_f * 1000 * 10000
+    end
+
+    def shared_highwater_is_old?
+      age = current_time_as_id - get_shared_highwater_mark
+      @base_client.log_internal :debug, "shared_highwater_is_old? apx #{age / (1000 * 10000)}" if age > @checkpoint_max_age
+      age > @checkpoint_max_age_secs
+    end
+
+    def get_shared_highwater_mark
+      (@base_client.shared_cache.read(checkpoint_highwater_cache_key) || 0).to_i
+    end
+
+    def get_shared_lock?
+      in_progess = @base_client.shared_cache.read(checkpoint_update_in_progress_cache_key)
+      if in_progess.nil?
+        @base_client.shared_cache.write(checkpoint_update_in_progress_cache_key, "true", { expires_in: CHECKPOINT_LOCK })
+        true
+      else
+        false
+      end
+    end
+
+    def reset_api_connection
+      @api_connection_thread&.exit
+      start_api_connection_thread(@config_loader.highwater_mark)
+    end
+
+    def finish_init!
+      if @initialization_lock.write_locked?
+        @initialization_lock.release_write_lock
+        @base_client.log.set_config_client(self)
+      end
+    end
+
     # Setup a streaming connection to the API
     # Save new config values into the loader
     def start_api_connection_thread(start_at_id)
       config_req = Prefab::ConfigServicePointer.new(account_id: @base_client.account_id,
                                                     start_at_id: start_at_id)
-      Thread.new do
+      @base_client.log_internal :debug, "start api connection thread #{start_at_id}"
+      @api_connection_thread = Thread.new do
         while true do
           begin
             resp = stub.get_config(config_req)
@@ -123,6 +191,7 @@ module Prefab
                 @config_loader.set(delta)
               end
               @config_resolver.update
+              finish_init!
             end
           rescue => e
             @base_client.log_internal :info, ("config client encountered #{e.message} pausing #{RECONNECT_WAIT}")
@@ -133,38 +202,16 @@ module Prefab
       end
     end
 
-    # Streaming connections don't guarantee all items have been seen
-    #
-    def start_suspenders_thread
-      start_at_suspenders = 0
-
-      Thread.new do
-        loop do
-          begin
-            started_at = Time.now
-            config_req = Prefab::ConfigServicePointer.new(account_id: @base_client.account_id,
-                                                          start_at_id: start_at_suspenders)
-
-            resp = @base_client.request Prefab::ConfigService, :get_config, req_options: {timeout: @timeout}, params: config_req
+    def checkpoint_cache_key
+      "prefab:config:checkpoint"
+    end
 
-            resp.each do |r|
-              r.deltas.each do |delta|
-                @config_loader.set(delta)
-                start_at_suspenders = [start_at_suspenders, delta.id].max
-              end
-            end
-          rescue GRPC::DeadlineExceeded
-            # Ignore. This is a streaming endpoint, but we only need a single response
-          rescue => e
-            @base_client.log_internal :info, "Suspenders encountered an issue #{e.message}"
-          end
+    def checkpoint_update_in_progress_cache_key
+      "prefab:config:checkpoint:updating"
+    end
 
-          delta = SUSPENDERS_FREQ_SEC - (Time.now - started_at)
-          if delta > 0
-            sleep(delta)
-          end
-        end
-      end
+    def checkpoint_highwater_cache_key
+      "prefab:config:checkpoint:highwater"
     end
   end
 end

data/lib/prefab/config_loader.rb

@@ -1,8 +1,11 @@
 require 'yaml'
 module Prefab
   class ConfigLoader
+    attr_reader :highwater_mark
+
     def initialize(base_client)
       @base_client = base_client
+      @highwater_mark = 0
       @classpath_config = load_classpath_config
       @local_overrides = load_local_overrides
       @api_config = Concurrent::Map.new
@@ -23,6 +26,7 @@ module Prefab
       else
         @api_config[delta.key] = delta
       end
+      @highwater_mark = [delta.id, @highwater_mark].max
     end
 
     def rm(key)
@@ -62,10 +66,10 @@ module Prefab
 
     def load(filename)
       if File.exist? filename
-        @base_client.log_internal :warn, "Load #{filename}"
+        @base_client.log_internal :info, "Load #{filename}"
         YAML.load_file(filename)
       else
-        @base_client.log_internal :warn, "No file #{filename}"
+        @base_client.log_internal :info, "No file #{filename}"
         {}
       end
     end

data/lib/prefab/config_resolver.rb

@@ -6,7 +6,6 @@ module Prefab
       @local_store = {}
       @namespace = base_client.namespace
       @config_loader = config_loader
-      @logger = base_client.log
       make_local
     end
 

data/lib/prefab/logger_client.rb

@@ -4,9 +4,9 @@ module Prefab
     SEP = ".".freeze
     BASE = "log_level".freeze
 
-    def initialize(base_client, base_logger)
-      @base_client = base_client
+    def initialize(base_logger)
       @base_logger = base_logger
+      @config_client = BootstrappingConfigClient.new
     end
 
     def debug msg
@@ -29,6 +29,30 @@ module Prefab
       pf_log_internal level, msg, "", loc
     end
 
+    def level= lvl
+      #noop
+    end
+
+    def formatter
+      @formatter ||= ActiveSupport::Logger::SimpleFormatter.new
+    end
+
+    def level
+      :debug
+    end
+
+    def debug?
+      true
+    end
+
+    def info?
+      true
+    end
+
+    def set_config_client(config_client)
+      @config_client = config_client
+    end
+
     private
 
     def pf_log(level, msg, loc)
@@ -43,10 +67,10 @@ module Prefab
       path = "#{path.gsub("/", SEP).gsub(".rb", "")}#{SEP}#{base_label}"
       path.slice! SEP
 
-      closest_log_level_match = @base_client.config_client.get(BASE) || :warn
+      closest_log_level_match = @config_client.get(BASE) || :warn
       path.split(SEP).inject([BASE]) do |memo, n|
         memo << n
-        val = @base_client.config_client.get memo.join(SEP)
+        val = @config_client.get(memo.join(SEP))
         unless val.nil?
           closest_log_level_match = val
         end
@@ -71,5 +95,13 @@ module Prefab
       end
     end
   end
+
+  # StubConfigClient to be used while config client initializes
+  # since it may log
+  class BootstrappingConfigClient
+    def get(key)
+      ENV["PREFAB_LOG_CLIENT_BOOTSTRAP_LOG_LEVEL"] || :info
+    end
+  end
 end
 

data/lib/prefab/noop_cache.rb

@@ -9,5 +9,8 @@ module Prefab
 
     def read(name)
     end
+
+    def delete(name)
+    end
   end
 end

data/lib/prefab/ratelimit_client.rb

@@ -39,6 +39,18 @@ module Prefab
       handle_error(e, on_error, groups)
     end
 
+    def upsert(group, policy_name, limit, burst: nil)
+      burst = limit if burst.nil?
+      limit_defintion = Prefab::LimitDefinition.new(
+        account_id: @base_client.account_id,
+        group: group,
+        policy_name: Object.const_get("Prefab::LimitResponse::LimitPolicyNames::#{policy_name}"),
+        limit: limit,
+        burst: burst
+      )
+      @base_client.request Prefab::RateLimitService, :upsert_limit_definition, params: limit_defintion
+    end
+
     private
 
     def handle_error(e, on_error, groups)
@@ -47,10 +59,10 @@ module Prefab
       message = "ratelimit for #{groups} error: #{e.message}"
       case on_error
       when :log_and_pass
-        @base_client.logger.warn(message)
+        @base_client.log.warn(message)
         Prefab::LimitResponse.new(passed: true, amount: 0)
       when :log_and_hit
-        @base_client.logger.warn(message)
+        @base_client.log.warn(message)
         Prefab::LimitResponse.new(passed: false, amount: 0)
       when :throw
         raise e

data/lib/prefab_pb.rb

@@ -109,6 +109,9 @@ Google::Protobuf::DescriptorPool.generated_pool.build do
     optional :batch_template, :string, 6
     optional :batch_separator, :string, 7
   end
+  add_message "prefab.BasicResponse" do
+    optional :message, :string, 1
+  end
   add_enum "prefab.OnFailure" do
     value :NOT_SET, 0
     value :LOG_AND_PASS, 1
@@ -134,5 +137,6 @@ module Prefab
   FeatureFlags = Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.FeatureFlags").msgclass
   BufferedRequest = Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.BufferedRequest").msgclass
   BatchRequest = Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.BatchRequest").msgclass
+  BasicResponse = Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.BasicResponse").msgclass
   OnFailure = Google::Protobuf::DescriptorPool.generated_pool.lookup("prefab.OnFailure").enummodule
 end

data/lib/prefab_services_pb.rb

@@ -15,6 +15,7 @@ module Prefab
       self.service_name = 'prefab.RateLimitService'
 
       rpc :LimitCheck, LimitRequest, LimitResponse
+      rpc :UpsertLimitDefinition, LimitDefinition, BasicResponse
     end
 
     Stub = Service.rpc_stub_class

data/prefab-cloud-ruby.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: prefab-cloud-ruby 0.0.14 ruby lib
+# stub: prefab-cloud-ruby 0.0.15 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "prefab-cloud-ruby".freeze
-  s.version = "0.0.14"
+  s.version = "0.0.15"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jeff Dwyer".freeze]
-  s.date = "2018-02-20"
+  s.date = "2018-03-08"
   s.description = "RateLimits & Config as a service".freeze
   s.email = "jdwyer@prefab.cloud".freeze
   s.extra_rdoc_files = [
@@ -55,18 +55,18 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<grpc>.freeze, ["~> 1.8.3"])
+      s.add_runtime_dependency(%q<grpc>.freeze, ["~> 1.10.0"])
       s.add_runtime_dependency(%q<concurrent-ruby>.freeze, [">= 1.0.5", "~> 1.0"])
-      s.add_development_dependency(%q<grpc-tools>.freeze, ["~> 1.8.3"])
+      s.add_development_dependency(%q<grpc-tools>.freeze, ["~> 1.10.0"])
       s.add_development_dependency(%q<shoulda>.freeze, [">= 0"])
       s.add_development_dependency(%q<rdoc>.freeze, ["~> 3.12"])
       s.add_development_dependency(%q<bundler>.freeze, ["~> 1.0"])
       s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.1.0"])
       s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
     else
-      s.add_dependency(%q<grpc>.freeze, ["~> 1.8.3"])
+      s.add_dependency(%q<grpc>.freeze, ["~> 1.10.0"])
       s.add_dependency(%q<concurrent-ruby>.freeze, [">= 1.0.5", "~> 1.0"])
-      s.add_dependency(%q<grpc-tools>.freeze, ["~> 1.8.3"])
+      s.add_dependency(%q<grpc-tools>.freeze, ["~> 1.10.0"])
       s.add_dependency(%q<shoulda>.freeze, [">= 0"])
       s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
       s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])
@@ -74,9 +74,9 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<simplecov>.freeze, [">= 0"])
     end
   else
-    s.add_dependency(%q<grpc>.freeze, ["~> 1.8.3"])
+    s.add_dependency(%q<grpc>.freeze, ["~> 1.10.0"])
     s.add_dependency(%q<concurrent-ruby>.freeze, [">= 1.0.5", "~> 1.0"])
-    s.add_dependency(%q<grpc-tools>.freeze, ["~> 1.8.3"])
+    s.add_dependency(%q<grpc-tools>.freeze, ["~> 1.10.0"])
     s.add_dependency(%q<shoulda>.freeze, [">= 0"])
     s.add_dependency(%q<rdoc>.freeze, ["~> 3.12"])
     s.add_dependency(%q<bundler>.freeze, ["~> 1.0"])

data/test/test_config_loader.rb

@@ -14,13 +14,22 @@ class TestConfigLoader < Minitest::Test
     should_be :double, 12.12, "sample_double"
   end
 
+  def test_highwater
+    assert_equal 0, @loader.highwater_mark
+    @loader.set(Prefab::ConfigDelta.new(id: 1, key: "sample_int", value: Prefab::ConfigValue.new(int: 456)))
+    assert_equal 1, @loader.highwater_mark
+
+    @loader.set(Prefab::ConfigDelta.new(id: 5, key: "sample_int", value: Prefab::ConfigValue.new(int: 456)))
+    assert_equal 5, @loader.highwater_mark
+    @loader.set(Prefab::ConfigDelta.new(id: 2, key: "sample_int", value: Prefab::ConfigValue.new(int: 456)))
+    assert_equal 5, @loader.highwater_mark
+  end
 
   def test_api_precedence
     should_be :int, 123, "sample_int"
 
     @loader.set(Prefab::ConfigDelta.new(key: "sample_int", value: Prefab::ConfigValue.new(int: 456)))
     should_be :int, 456, "sample_int"
-
   end
 
   def test_api_deltas

data/test/test_helper.rb

@@ -12,10 +12,12 @@ class MockBaseClient
   def account_id
     1
   end
+
+  def log_internal level, message
+  end
 end
 
 class MockConfigLoader
   def calc_config
-
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: prefab-cloud-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Jeff Dwyer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-20 00:00:00.000000000 Z
+date: 2018-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: grpc
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.3
+        version: 1.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.3
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -50,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.3
+        version: 1.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.3
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement