preek 1.4.3 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0381b8f7518b3ec3a5007118bc49aebb0c1ad448
-  data.tar.gz: 4908aa1896f8b21d66eb98682256a7bec1ba575a
+  metadata.gz: c585c8febf862238a426fd347775911454140bbb
+  data.tar.gz: e1ec29fbab5d972d84a4abf5731cd815cd1d2e83
 SHA512:
-  metadata.gz: 3e4f7564855597775457f785c52f4613249501bf6c8044c50353f147cffe27fbd9105e60c93a57385436b65d8680cb86dcbff846ab7a87c3d8563174742842f4
-  data.tar.gz: 2ea27c77c1937cc9a55a38e2dfce367a4e4f73f8fe1bccf33b8a3aaac947c5b97b63b1f6125307783a97e4adbcb4720b4da23a35530ad5cb26f8f21dfe982803
+  metadata.gz: fa32eff70b87f0f4ebfa3ff282ed72399d15192fb537b403163c75f284f3486f4001a82d5631f40f33c8581068a6a91823bf8723ec101742fe928170007a4ed2
+  data.tar.gz: 52f8ef1a293c65142a1d834e499a581d91f505f1dc9d81c56c5895f33b5183c93a431ed51ae807b49014b21c2e842164935c1cb8ff523b5499e695b590768883

data/.travis.yml

@@ -2,6 +2,7 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.0
   - jruby-19mode
 branches:
   only:

data/lib/preek/examiner.rb

@@ -13,9 +13,11 @@ module Preek
 
     def perform
       examine_and_report
-      report_totals if totals_to_report?
-      @output.print_line
-      report_non_existing if non_existing_files?
+      @output.separated do
+        report_success if report_success?
+        report_total_smells unless success?
+        report_non_existing if non_existing_files?
+      end
     end
 
   private
@@ -34,19 +36,24 @@ module Preek
       end
     end
 
-    def totals_to_report?
-      return false if @reporter.verbose? || @sources.count == 0
+    def success?
       @total_smells == 0
     end
 
-    def report_totals
-      @output.print_line
+    def report_success?
+      !@reporter.verbose? && @sources.count > 0 && success?
+    end
+
+    def report_success
       @output.green :success, %(No smells detected)
     end
 
+    def report_total_smells
+      @output.red :total, @total_smells
+    end
+
     def report_non_existing
       @output.red :error, %{No such file(s) - #{non_existing_files.join(', ')}.\n}
-      @output.print_line
     end
 
     def existing_files

data/lib/preek/output.rb

@@ -9,6 +9,8 @@ module Preek
       say "\n\t#{'-'*60}\n\n"
     end
 
+    alias :separator :print_line
+
     def blue(*args)
       status *args, :blue
     end
@@ -20,6 +22,12 @@ module Preek
     def red(*args)
       status *args, :red
     end
+
+    def separated(&block)
+      print_line
+      yield
+      print_line
+    end
   end
 
   class CompactOutput < Output
@@ -32,5 +40,6 @@ module Preek
     def print_line
       say "\n-\n\n"
     end
+    alias :separator :print_line
   end
 end

data/lib/preek/version.rb

@@ -1,3 +1,3 @@
 module Preek
-  VERSION = "1.4.3"
+  VERSION = "1.5.0"
 end

data/preek.gemspec

@@ -4,8 +4,8 @@ require File.expand_path('../lib/preek/version', __FILE__)
 Gem::Specification.new do |gem|
   gem.authors       = ["Jon Neverland"]
   gem.email         = ["jonwestin@gmail.com"]
-  gem.description   = %q{Gives a nice, colorful output to Reek. Based on Thor.}
-  gem.summary       = %q{It might reek but its pretty}
+  gem.description   = %q{Preek prints Ruby code smells in color, using Reek. }
+  gem.summary       = %q{Code smells in color}
   gem.homepage      = "https://github.com/joenas/preek"
   gem.license       = 'MIT'
 

data/spec/cli_spec.rb

@@ -68,7 +68,7 @@ describe Preek::CLI do
         Then{output.should_not include(args[0])}
       end
 
-      context "when given file has no smells" do
+      context "when given file has no smells and the other does not exist" do
         Given(:args){ [test_file('non_smelly'), 'i/am/not/a_file'] }
         Then{output.should include("No smells")}
         Then{output.should_not include(args[0])}
@@ -86,6 +86,10 @@ describe Preek::CLI do
         Given(:args){ [test_file('two_smelly_classes')] }
         Then{output.should include('SecondSmelly')}
         Then{output.should include('UncommunicativeMethodName')}
+
+        describe 'total count' do
+          Then{output.should match(/total.*1/)}
+        end
       end
 
       context "when given two smelly files" do
@@ -93,6 +97,10 @@ describe Preek::CLI do
         Then{output.should include('UncommunicativeMethodName', 'TooManyStatements')}
         Then{output.should include(args[0], args[1])}
         Then{output.should include("#loong_method", "#x")}
+
+        describe 'total count' do
+          Then{output.should match(/total.*2/)}
+        end
       end
 
       context "when given one file without smells and another with smells" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: preek
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.5.0
 platform: ruby
 authors:
 - Jon Neverland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-29 00:00:00.000000000 Z
+date: 2014-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -108,7 +108,7 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Gives a nice, colorful output to Reek. Based on Thor.
+description: 'Preek prints Ruby code smells in color, using Reek. '
 email:
 - jonwestin@gmail.com
 executables:
@@ -165,10 +165,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
-summary: It might reek but its pretty
+summary: Code smells in color
 test_files:
 - spec/capture_helper.rb
 - spec/cli_spec.rb