preek 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c107d59e998f9ab44c16a25c170e29a28e63e40d
-  data.tar.gz: 2a1f2fa67d7700bf8b6a900a3ae91543155e8ca5
+  metadata.gz: 23aaf624b23cc383b727443a4638f9d8974465ff
+  data.tar.gz: ba4e3c93bd89f810a2ff58b8d76373fc39153f19
 SHA512:
-  metadata.gz: b383dcbd667dc3937f38311ac46134c3d713da67e3b1e020a350ed5271a5e82549aa111e9eb7f0859467492758b86d930bcb6580a5620461a89ef2cc3b991ab2
-  data.tar.gz: c3466db14aa8375fdd5a0622ee5c969e1451c7950cccb77e00def184bf70c7ca2fca99cae5c79d00018da66016806fda56d4dd553aa827336616e34022aecd8e
+  metadata.gz: f8e069e0498d2879120117dca4c13a4679981bef8757a0fe6293705a0c43d69971b64c3c0d7b30717e628601f8f00962b8b586fd9101c346646056732a9fa2ad
+  data.tar.gz: 331ad8be448eb115fc52bc5ef25f719af4a4f71ac4bc670fcd1d75c7e5b022015e6d7339353fa312ee20c7caac37f075ebd14728ffc1755ed7b5dcf8cb8e0b88

data/bin/preek

@@ -1,13 +1,14 @@
 #!/usr/bin/env ruby
 require "preek"
 
-unless ARGV.empty?
-  preek = Preek::Preek.new
-  if preek.respond_to? ARGV[0]
-    preek.send ARGV.shift.to_sym, ARGV
-  else
-    preek.parse ARGV
-  end
-else
-  Preek::Preek.start
-end
+# unless ARGV.empty?
+#   preek = Preek::Preek.new
+#   if preek.respond_to? ARGV[0]
+#     preek.send ARGV.shift.to_sym, ARGV
+#   else
+#     preek.parse ARGV
+#   end
+# else
+#   Preek::Preek.start
+# end
+Preek::Preek.start

data/lib/preek.rb

@@ -14,17 +14,23 @@ module Preek
       say VERSION
     end
 
-    desc 'FILE', 'Pretty format Reek output'
-    def parse(args)
+    desc 'smell FILE(S)|DIR', 'Pretty format Reek output'
+    method_option :irresponsible,
+                  type: :boolean,
+                  aliases: '-i',
+                  desc: 'include IrresponsibleModule smell in output.'
+    def smell(*args)
+      args ||= @args
+      @includes = options.keys.map {|key| _aliases[key.to_sym] }
       files, @not_files = args.partition { |file| File.exists? file }
-      report_smells_for files unless files.empty?
+      report_smells_for(files, excludes) unless files.empty?
       report_not_files
     end
 
   private
-    def report_smells_for files
+    def report_smells_for(files, includes)
       sources = Reek::Source::SourceLocator.new(files).all_sources
-      smelly_files = SmellCollector.new(sources).smelly_files
+      smelly_files = SmellCollector.new(sources, excludes).smelly_files
       @reporter = SmellReporter.new(smelly_files)
       @reporter.print_smells
     end
@@ -32,5 +38,19 @@ module Preek
     def report_not_files
       say_status :error, "No such file(s) - #{@not_files*", "}.", :red unless @not_files.empty?
     end
+
+    def _aliases
+      {
+        irresponsible: 'IrresponsibleModule'
+      }
+    end
+
+    def excludes
+      (exclude_list - @includes)#.map(&:to_s).map(&:capitalize)
+    end
+
+    def exclude_list
+      %w(IrresponsibleModule)
+    end
   end
 end

data/lib/preek/smell_collector.rb

@@ -3,8 +3,9 @@ module Preek
   require 'preek/smell_file'
   # This is a 'Collector'
   class SmellCollector
-    def initialize sources
+    def initialize(sources, excludes)
       @sources = sources
+      @excludes = excludes
       @files = examine_sources
     end
 
@@ -16,7 +17,7 @@ module Preek
     def examine_sources
       @sources.map do |source|
         smells = Reek::Examiner.new(source).smells
-        SmellFile.new smells unless smells.empty?
+        SmellFile.new(smells, @excludes) unless smells.empty?
       end
     end
   end

data/lib/preek/smell_file.rb

@@ -2,13 +2,14 @@ module Preek
   require 'preek/klass_collector'
   # A smelly file
   class SmellFile
-    def initialize(smells)
+    def initialize(smells, excludes)
       @smells = smells
+      @excludes = excludes
       @klass_collector = KlassCollector.new
+      add_smells_to_klass
     end
 
     def klasses
-      add_smells_to_klass
       @klass_collector.get_klasses
     end
 
@@ -19,6 +20,7 @@ module Preek
   private
     def add_smells_to_klass
       @smells.each do |smell|
+        next if @excludes.include? smell.smell_class
         @klass_collector.find(smell.klass).add_smell smell
       end
     end

data/lib/preek/smell_reporter.rb

@@ -7,6 +7,7 @@ module Preek
     end
 
     def print_smells
+      @smelly_files.delete_if {|smell_file| smell_file.klasses.empty? }
       return say_status 'success!', 'No smells detected.' if @smelly_files.empty?
       print_line
       @smelly_files.each do |smell|

data/lib/preek/version.rb

@@ -1,3 +1,3 @@
 module Preek
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/preek_spec.rb

@@ -14,7 +14,8 @@ describe Preek::Preek do
   end
 
   describe "#parse" do
-    let(:output) { capture(:stdout) { subject.parse(args) } }
+    let(:output) { capture(:stdout) { subject.parse(*args) } }
+    let(:args) { ['i/am/not/a_file'] }
 
     context "with non-existing file in ARGS" do
       let(:args) { ['i/am/not/a_file'] }
@@ -35,16 +36,40 @@ describe Preek::Preek do
 
     context "when given file has Irresponsible smell" do
       let(:args){ [test_file('irresponsible')] }
+      it "output contains 'success! No smells'" do
+        output.should include("No smells")
+      end
+    end
+
+    context "when given file has Irresponsible smell with --irresponsible options" do
+      let(:args){ [test_file('irresponsible')] }
+
+      before :each do
+        subject.options =  {irresponsible: true}
+      end
+
       it "output contains 'Irresponsible'" do
         output.should include("Irresponsible")
       end
-      it "outputs the name of the file" do
-        output.should include(args[0])
-      end
+
     end
 
     context "when given a file with two smelly classes" do
       let(:args){ [test_file('two_smelly_classes')] }
+      it "output contains one classnames" do
+        output.should include('SecondSmelly')
+      end
+      it "output contains one smell" do
+        output.should include('UncommunicativeMethodName')
+      end
+    end
+
+    context "when given a file with two smelly classes with --irresponsible options" do
+      let(:args){ [test_file('two_smelly_classes')] }
+      before :each do
+        subject.options =  {irresponsible: true}
+      end
+
       it "output contains both classnames" do
         output.should include('FirstSmelly', 'SecondSmelly')
       end
@@ -53,15 +78,20 @@ describe Preek::Preek do
       end
     end
 
-    context "when given a file with two different smells" do
+    context "when given a file with two different smells with --irresponsible options" do
       let(:args){ [test_file('irresponsible_and_lazy')] }
       it "output contains both smells" do
+        subject.options =  {irresponsible: true}
         output.should include('IrresponsibleModule', 'UncommunicativeMethodName')
       end
     end
 
     context "when given two smelly files" do
       let(:args){ [test_file('too_many_statements'), test_file('two_smelly_classes')] }
+      before :each do
+        subject.options =  {irresponsible: true}
+      end
+
       it "output contains all smells" do
         output.should include('IrresponsibleModule', 'UncommunicativeMethodName', 'TooManyStatements')
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: preek
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Jon Neverland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-17 00:00:00.000000000 Z
+date: 2013-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor