preek 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZjczMTRhYmZjYTA0ODE2M2Y3NjFhNWFlMzRhNDQ1N2E1OTRkZWI1Mw==
-  data.tar.gz: !binary |-
-    YjFmYmZhMGU3NDA5N2M1ZjdlNWVmYmI1ZDU1YzI4YmE0YTQxYWM2Yg==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    NzZmN2JiOTg0ODI2N2Q0MzM0MzM4MTg2Y2Q2Y2IwNjViZWY1NzJhMDM2MjVj
-    ODA4MzYzYzJiMDE1MjI0MzU2YzVlMjdiZDBhNGZmNTRjYzUyNzI5YTE4NWI0
-    ODY4OTczMTNiZTJmOTUzYjc5NGRiZWQ3Njg0OThiNTkzYTgzMWM=
-  data.tar.gz: !binary |-
-    NTVjODc4NDAwYjM2Yjc5M2IyM2QwNTliOTAyMzJjNzZmMmFmMDMwZGIxODhi
-    OGE5MGU4MTliZGI2ZDVjMmU3YzUxOWY3NmVmYTRmNGViYTczYmNkOThmMWI3
-    ZWMyN2Q1YWE1MTI0Y2ExMDMxNTAwMDhjNTY3YTk4NzQ0ZTBlOWU=
+SHA1:
+  metadata.gz: a8559dbf44087b95a487aa6cd703eab355856553
+  data.tar.gz: 20d5406a15c573adfaa73cb51d9cdfdf082334e6
+SHA512:
+  metadata.gz: fb9f6342f78100d39b6f944d0c97066a3ec204acc2279010443b318bfa0c852d79a529a2174f00082cec13d5fa5d83c730e9f8041e6e9e023c43f175614b3b3e
+  data.tar.gz: a568c93c4d40d2fc03043dbc65b6e11190a8d9cf33909d8c39d27589d8b198a20224236c7139f4b9b0d666d0c25917840fd8db7277f85b32056e30f488e7fa3a

data/.travis.yml

@@ -5,4 +5,5 @@ rvm:
   - 2.0.0
 branches:
   only:
-    - master
+    - master
+script: rspec spec

data/Guardfile

@@ -6,4 +6,3 @@ guard 'rspec' do
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
 end
-

data/README.md

@@ -1,23 +1,39 @@
 [![Code Climate](https://codeclimate.com/github/joenas/preek.png)](https://codeclimate.com/github/joenas/preek)
+[![Build Status](https://travis-ci.org/joenas/preek.png)](https://travis-ci.org/joenas/preek)
+[![Dependency Status](https://gemnasium.com/joenas/preek.png)](https://gemnasium.com/joenas/preek)
+[![Coverage Status](https://coveralls.io/repos/joenas/preek/badge.png?branch=master)](https://coveralls.io/r/joenas/preek?branch=master)
+
 
 # Preek
 
 For a pretty colorful output of [Reek](https://github.com/troessner/reek), which is an awesome gem!
+This is just something I came up with while learning [Thor](https://github.com/wycats/thor).
+As an exercise I also worked on getting Reek and Pelusa to stop whining when running them on the code.
 
 ## Installation
 
 Install it yourself as:
 
     $ git clone git@github.com:joenas/preek.git
-    
+
     $ cd preek
 
     $ rake install
 
+or
+
+    $ gem install preek
+
+
 ## Usage
 
     $ preek . or file
 
+At the moment it only supports files, not stuff like this:
+
+    $ echo "def x() true end" | reek
+
+
 ## Contributing
 
 1. Fork it

data/lib/preek/smell_reporter.rb

@@ -34,7 +34,6 @@ module Preek
       say "\n\t#{'-'*60}\n\n"
     end
 
-  
     def padding; 0; end
 
     def format_path file

data/lib/preek/smell_warning.rb

@@ -10,7 +10,7 @@ module Reek
     end
 
     def smell_string
-      "#{smell_method} #{@smell['message']} (#{@smell['subclass']}) at lines #{@location['lines']*','}"
+      "#{smell_method} #{@smell['message']} (#{@smell['subclass']}) at lines #{Array(@location['lines'])*','}"
     end
   end
 end

data/lib/preek/version.rb

@@ -1,3 +1,3 @@
 module Preek
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/preek.gemspec

@@ -4,7 +4,7 @@ require File.expand_path('../lib/preek/version', __FILE__)
 Gem::Specification.new do |gem|
   gem.authors       = ["Jon Neverland"]
   gem.email         = ["jonwestin@gmail.com"]
-  gem.description   = %q{Gives the nice output to the reek}
+  gem.description   = %q{Gives a nice, colorful output to Reek. Based on Thor.}
   gem.summary       = %q{It might reek but its pretty}
   gem.homepage      = "https://github.com/joenas/preek"
 
@@ -15,12 +15,11 @@ Gem::Specification.new do |gem|
   gem.name          = "preek"
   gem.require_paths = ["lib"]
   gem.version       = Preek::VERSION
-  gem.add_runtime_dependency "thor"
-  gem.add_runtime_dependency "reek"
-  gem.add_runtime_dependency "rake"
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "rspec"
-  gem.add_development_dependency "guard"
-  gem.add_development_dependency "guard-rspec"
-  gem.add_development_dependency "simplecov"
+  gem.add_runtime_dependency "thor", ">=0.16"
+  gem.add_runtime_dependency "reek", ">=1.3"
+  gem.add_development_dependency "rspec", ">=2.13"
+  gem.add_development_dependency "guard", ">=1.6"
+  gem.add_development_dependency "guard-pushover"
+  gem.add_development_dependency "guard-rspec", ">=2.4"
+  gem.add_development_dependency 'coveralls'
 end

data/spec/preek_spec.rb

@@ -74,5 +74,15 @@ describe Preek::Preek do
         output.should include("#loong_method", "#x")
       end
     end
+
+    context "when given file has NilCheck smell" do
+      let(:args){ [test_file('nil_check')] }
+      it "output contains 'NilCheck'" do
+        output.should include("NilCheck")
+      end
+      it "outputs the name of the file" do
+        output.should include(args[0])
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
-require 'simplecov'
-SimpleCov.start
+require 'coveralls'
+Coveralls.wear!
 
 $:.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 require 'stringio'

data/spec/test_files/nil_check.rb

@@ -0,0 +1,12 @@
+#This class a nil check
+class NilCheck
+  def initialize(number)
+    @number = number
+  end
+
+  def nil_check
+    @number.times do |number|
+      next if number.nil?
+    end
+  end
+end

metadata

@@ -1,128 +1,114 @@
 --- !ruby/object:Gem::Specification
 name: preek
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jon Neverland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-28 00:00:00.000000000 Z
+date: 2013-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.16'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.13'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
-  name: guard
+  name: guard-pushover
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.4'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Gives the nice output to the reek
+description: Gives a nice, colorful output to Reek. Based on Thor.
 email:
 - jonwestin@gmail.com
 executables:
@@ -140,7 +126,6 @@ files:
 - Rakefile
 - bin/preek
 - lib/preek.rb
-- lib/preek/cli.rb
 - lib/preek/klass_collector.rb
 - lib/preek/smell_collector.rb
 - lib/preek/smell_file.rb
@@ -153,6 +138,7 @@ files:
 - spec/spec_helper.rb
 - spec/test_files/irresponsible.rb
 - spec/test_files/irresponsible_and_lazy.rb
+- spec/test_files/nil_check.rb
 - spec/test_files/non_smelly.rb
 - spec/test_files/too_many_statements.rb
 - spec/test_files/two_smelly_classes.rb
@@ -165,17 +151,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: It might reek but its pretty
@@ -184,6 +170,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/test_files/irresponsible.rb
 - spec/test_files/irresponsible_and_lazy.rb
+- spec/test_files/nil_check.rb
 - spec/test_files/non_smelly.rb
 - spec/test_files/too_many_statements.rb
 - spec/test_files/two_smelly_classes.rb

data/lib/preek/cli.rb

@@ -1,24 +0,0 @@
-require 'preek'
-module Preek
-  class Cli
-    def initialize(args)
-      @args = args
-    end
-
-    def execute
-      Preek.start []
-    end
-  end
-end
-
-      
-# unless ARGV.empty?
-#   preek = Preek::Preek.new
-#   if preek.respond_to? ARGV[0]
-#     preek.send ARGV.shift.to_sym, ARGV
-#   else
-#     preek.parse ARGV
-#   end
-# else
-#   Preek::Preek.start
-# end