prebake 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19a1c62dd2df6b16ab27629bda27ea6d6c18ae200c6e5874e1de7a17a642b643
-  data.tar.gz: ddcba7e497fa98ce7955fb0c78804a64945f5a8d64b6fa017d56b23a32f624fe
+  metadata.gz: 3a9faf240c276429e13f29b8ac1b96042dbe56fbcb22718a1fe8e5a3d87b3647
+  data.tar.gz: '09075fab2ca5e7e79d1f1dc7c37cb0ab2fe7dba2d95de0526343817ac23ee76a'
 SHA512:
-  metadata.gz: d5e9a824142b4bb5734a917ed9b52fc2ec75286fee31bd41129f0b7aeadffd4e918ff368a64a64e0262b365823e448d505f7a9e5af1d69380ba78c2cc816c74a
-  data.tar.gz: 33687eb0a1d9ddf94b2b1773b2a9548783c93280c8731a1cc6c56bc598543ec339fdaebf336986b1f4727ef759795ea2dae048907b73fc5d715b4921c800fb2c
+  metadata.gz: e57e53e423306d08e03dd50d8c31646785ca5b9ded9d252a63a343c33607e4653394e0289d3c575599b4424b69fb5d5bad306bac2c2a7678868aa66729cebdd9
+  data.tar.gz: ee212634e00c97d3b3e084be9f2cfffd7158819a006b965b61bcca3719544d50b5fb34f5e18fa2906c8fb0e65dc50fa7bb383e4c671ead2513876975c2f2b6cc

data/lib/prebake/backends/base.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "fileutils"
 require_relative "../logger"
 
 module Prebake
@@ -16,6 +17,9 @@ module Prebake
       def fetch_with_checksum(cache_key)
         path = fetch(cache_key)
         [path, path && fetch_checksum(cache_key)]
+      rescue StandardError
+        FileUtils.rm_f(path) if path
+        raise
       end
 
       def push(gem_path, cache_key, checksum)

data/lib/prebake/backends/http.rb

@@ -2,6 +2,7 @@
 
 require "uri"
 require "securerandom"
+require "fileutils"
 require_relative "base"
 require_relative "http_client"
 require_relative "../logger"
@@ -32,16 +33,19 @@ module Prebake
         return [nil, nil] unless path
 
         [path, checksum || fetch_checksum(cache_key)]
+      rescue StandardError
+        FileUtils.rm_f(path) if path
+        raise
       end
 
+      # nil means the server has no checksum file. Anything else that goes wrong
+      # raises, so a lookup that merely failed never gets a good cached gem deleted.
       def fetch_checksum(cache_key)
         response = http_request(:get, checksum_uri(cache_key))
-        return nil unless response.is_a?(Net::HTTPSuccess)
+        return response.body.strip if response.is_a?(Net::HTTPSuccess)
+        return nil if response.is_a?(Net::HTTPNotFound)
 
-        response.body.strip
-      rescue StandardError => e
-        Logger.debug "Checksum fetch failed for #{cache_key}: #{e.message}"
-        nil
+        raise Error, "Checksum fetch for #{cache_key} returned #{response.code}"
       end
 
       def push(gem_path, cache_key, checksum)

data/lib/prebake/backends/s3.rb

@@ -31,8 +31,7 @@ module Prebake
       def fetch_checksum(cache_key)
         response = client.get_object(bucket: @bucket, key: checksum_key(cache_key))
         response.body.read.strip
-      rescue StandardError => e
-        Logger.debug "S3 checksum fetch failed for #{cache_key}: #{e.message}"
+      rescue Aws::S3::Errors::NoSuchKey
         nil
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: prebake
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Thejus Paul