preadly-bulbasaur 0.6.1 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40b514207389a8d48e89d57e1368bdf5c05db0dd
-  data.tar.gz: 8ec55684674c1587f0a6ecf7a1d851a182683977
+  metadata.gz: 0dc0a73c1850ae685cf72ca24ef60eb89f72b28e
+  data.tar.gz: 82073826c2a3eae44106a25afdc82c16cf6ec853
 SHA512:
-  metadata.gz: 27980ae974932ced7c96047c3f4811df95d54fea82d481776b43f933a2979f3ed736fa2aab25fa378632a7040f762019677688a9ef3bce0c93e9d8d1d2eceab0
-  data.tar.gz: 64a1c0ccfd39f8bfe3d68bda43a28d8518741cfbc5107fbcc5060ad79e6fc8d45be734384b1dff7c041fa6317d1f8e8497c0964ac987cbbdc5064f434042dbca
+  metadata.gz: eb0a1cf64c3eb6f738b37e9ee54814c544fe69447053145ae6a8320ade4221dd7ac3b535cff41ae881c9eb662f3b200ad7b157a6750d975251eb2d529b679196
+  data.tar.gz: a75600ad921fad3dd30e56c5fa0e47ce2efba244a5c49b8d12523c1696fa42da23d9f6328ad96eff88e43dfe746a1a762f66b202d8e1c0a83d59c01e76da3da0

data/lib/bulbasaur/removals/remove_attributes.rb

@@ -0,0 +1,14 @@
+module Bulbasaur
+  class RemoveAttributes
+    def initialize(html, banned_attrs)
+      @html = html
+      @banned_attrs = banned_attrs
+    end
+
+    def call
+      parsed_html = Nokogiri::HTML::DocumentFragment.parse @html
+      @banned_attrs.each { |attr| parsed_html.xpath(".//@#{attr}").remove }
+      parsed_html.to_s
+    end
+  end
+end

data/lib/bulbasaur/removals/remove_tags.rb

@@ -0,0 +1,14 @@
+module Bulbasaur
+  class RemoveTags
+    def initialize(html, banned_tags)
+      @html = html
+      @banned_tags = banned_tags
+    end
+
+    def call
+      parsed_html = Nokogiri::HTML::DocumentFragment.parse @html
+      @banned_tags.each { |tag| parsed_html.css(tag).remove }
+      parsed_html.to_s
+    end
+  end
+end

data/lib/bulbasaur/utils/normalize_image_sources.rb

@@ -0,0 +1,32 @@
+module Bulbasaur
+  class NormalizeImageSources
+    def initialize(html, target_attrs)
+      @html = html
+      @target_attrs = target_attrs
+    end
+
+    def call
+      parsed_html = Nokogiri::HTML::DocumentFragment.parse @html
+      parsed_html.css('img').each do |element|
+        check_for_attrs element
+      end
+      parsed_html.to_s
+    end
+
+    private
+
+    def check_for_attrs(element)
+      @target_attrs.each do |attr|
+        if element.xpath "@#{attr}"
+          adjust element, "@#{attr}"
+          break
+        end
+      end
+    end
+
+    def adjust(element, attr)
+      element.set_attribute 'src', element.xpath(attr).text
+      element.xpath(attr).remove
+    end
+  end
+end

data/lib/bulbasaur/version.rb

@@ -2,8 +2,8 @@ module Bulbasaur
 
   module Version
     MAJOR = 0
-    MINOR = 6
-    PATCH = 1
+    MINOR = 7
+    PATCH = 0
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
   

data/lib/bulbasaur.rb

@@ -4,8 +4,11 @@ require "bulbasaur/extracts/extract_images_from_vimeo"
 require "bulbasaur/extracts/extract_images_from_html"
 require "bulbasaur/extracts/extract_images_from_all_resources"
 require "bulbasaur/extracts/extract_text_from_html.rb"
+require "bulbasaur/removals/remove_tags"
+require "bulbasaur/removals/remove_attributes"
 require "bulbasaur/replaces/replace_by_tag_image"
 require "bulbasaur/utils/normalize_url"
+require "bulbasaur/utils/normalize_image_sources"
 require "bulbasaur/version"
 
 

data/spec/bulbasaur/removals/remove_attributes_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+RSpec.describe Bulbasaur::RemoveAttributes do
+  subject { described_class.new(html, banned_attrs).call }
+
+  describe '#call' do
+    let(:html) do
+      %[
+        <style>
+          div { color: green; width: 1024px; }
+        </style>
+        <div style="height: 100px; width: 100px;"></div>
+        <form>
+          <input type="text">
+        </form>
+        <p style="font-size: x-large">hello!</p>
+      ]
+    end
+
+    context 'when there are no banned attributes' do
+      let(:banned_attrs) { [] }
+
+      it 'returns the HTML code as it was before' do
+        expect(subject).to eq html
+      end
+    end
+
+    context 'when there are banned attributes' do
+      let(:banned_attrs) { %w(style) }
+
+      it 'returns the HTML code without the banned attributes' do
+        expect(subject.strip.gsub(/\n/, '').squeeze ' ').to eq %[
+          <style>
+            div { color: green; width: 1024px; }
+          </style>
+          <div></div>
+          <form>
+            <input type="text">
+          </form>
+          <p>hello!</p>
+        ].strip.gsub(/\n/, '').squeeze ' '
+      end
+    end
+  end
+end

data/spec/bulbasaur/removals/remove_tags_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+RSpec.describe Bulbasaur::RemoveTags do
+  subject { described_class.new(html, banned_tags).call }
+
+  describe '#call' do
+    let(:html) do
+      %[
+        <style>
+          div { color: green; width: 1024px; }
+        </style>
+        <div style="height: 100px; width: 100px;"></div>
+        <form>
+          <input type="text">
+        </form>
+        <p>hello!</p>
+      ]
+    end
+
+    context 'when there are no banned tags' do
+      let(:banned_tags) { [] }
+
+      it 'returns the HTML code as it was before' do
+        expect(subject).to eq html
+      end
+    end
+
+    context 'when there are banned tags' do
+      let(:banned_tags) { %w(form style) }
+
+      it 'returns the HTML code without the banned tags' do
+        expect(subject.strip.gsub(/\n/, '').squeeze ' ').to eq %[
+          <div style="height: 100px; width: 100px;"></div>
+          <p>hello!</p>
+        ].strip.gsub(/\n/, '').squeeze ' '
+      end
+    end
+  end
+end

data/spec/bulbasaur/utils/normalize_image_sources_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+RSpec.describe Bulbasaur::NormalizeImageSources do
+  subject { described_class.new(html, target_attrs).call }
+
+  describe '#call' do
+    let(:html) { '<img src="http://somewhere.to/get/a-pixel.gif" data-lazy-src="http://somewhere.to/get/the-real-image.jpg" alt="Image" width="800" height="1200">' }
+
+    context 'when there are no target attributes' do
+      let(:target_attrs) { [] }
+
+      it 'returns the HTML code as it was before' do
+        expect(subject).to eq html
+      end
+    end
+
+    context 'when there are target attributes' do
+      let(:target_attrs) { %w(data-lazy-src) }
+
+      it 'returns the HTML code with the image tags adjusted' do
+        expect(subject).to eq '<img src="http://somewhere.to/get/the-real-image.jpg" alt="Image" width="800" height="1200">'
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: preadly-bulbasaur
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Magno Costa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-06 00:00:00.000000000 Z
+date: 2015-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -95,7 +95,10 @@ files:
 - lib/bulbasaur/extracts/extract_images_from_vimeo.rb
 - lib/bulbasaur/extracts/extract_images_from_youtube.rb
 - lib/bulbasaur/extracts/extract_text_from_html.rb
+- lib/bulbasaur/removals/remove_attributes.rb
+- lib/bulbasaur/removals/remove_tags.rb
 - lib/bulbasaur/replaces/replace_by_tag_image.rb
+- lib/bulbasaur/utils/normalize_image_sources.rb
 - lib/bulbasaur/utils/normalize_url.rb
 - lib/bulbasaur/version.rb
 - spec/bulbasaur/extracts/extract_images_from_all_resources_spec.rb
@@ -103,7 +106,10 @@ files:
 - spec/bulbasaur/extracts/extract_images_from_vimeo_spec.rb
 - spec/bulbasaur/extracts/extract_images_from_youtube_spec.rb
 - spec/bulbasaur/extracts/extract_inner_text_from_html_spec.rb
+- spec/bulbasaur/removals/remove_attributes_spec.rb
+- spec/bulbasaur/removals/remove_tags_spec.rb
 - spec/bulbasaur/replaces/replace_by_tag_image_spec.rb
+- spec/bulbasaur/utils/normalize_image_sources_spec.rb
 - spec/bulbasaur/utils/normalize_url_spec.rb
 - spec/bulbasaur_spec.rb
 - spec/spec_helper.rb
@@ -136,7 +142,10 @@ test_files:
 - spec/bulbasaur/extracts/extract_images_from_vimeo_spec.rb
 - spec/bulbasaur/extracts/extract_images_from_youtube_spec.rb
 - spec/bulbasaur/extracts/extract_inner_text_from_html_spec.rb
+- spec/bulbasaur/removals/remove_attributes_spec.rb
+- spec/bulbasaur/removals/remove_tags_spec.rb
 - spec/bulbasaur/replaces/replace_by_tag_image_spec.rb
+- spec/bulbasaur/utils/normalize_image_sources_spec.rb
 - spec/bulbasaur/utils/normalize_url_spec.rb
 - spec/bulbasaur_spec.rb
 - spec/spec_helper.rb