preadly-bulbasaur 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2279477cdf112255d8e1fc39cfed178ecb592aa8
-  data.tar.gz: 74718795d096dffe94e27a5cf20798de4516adb5
+  metadata.gz: e2ce49896cc75739b7b348c8562bd27b782ae050
+  data.tar.gz: 8e085b9b873fe13483f5885bf4c5a26d7f4171b8
 SHA512:
-  metadata.gz: 3ab87a531d9fb0fdb6c51c4e17c8afe3dee513b03dafd14ee68094c563649ba7cb4ba8ab097bcf3b1c2be18108a222af59321e785e7b36903e2d6e4cbdc8459d
-  data.tar.gz: c646b121b54cde24f7f381e5b4c4e0fb0845f93ce1b62e323ad39bdf790e0729355dc567326cb9e0f2d24a7618a894ea67c4e2400b80d575257ebb8ea5c2e521
+  metadata.gz: 36409b5eda6f8928b710698fbb7787fa387f59276f08a724e448a333e8b259096efd30cff1b8632b0e77401a3194c7b7f2a42c2b3fd64a44e20c649b3dc1be1a
+  data.tar.gz: bedb92be982705d050f8ea472410a34af96f4df36a528d370a593cf6087246717a4f2bc3e08f2eac34473cd71d0433d7920482d42a96bd639630dcbef75940ea

data/bulbasaur.gemspec

@@ -18,6 +18,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake", "~> 10.4"
   spec.add_development_dependency "rspec", "~> 3.3"
+  spec.add_development_dependency "webmock"
+
 
   spec.add_dependency "nokogiri", "~> 1.6"
 end

data/lib/bulbasaur/extracts/extract_images_from_youtube.rb

@@ -1,7 +1,7 @@
 module Bulbasaur
 
   class ExtractImagesFromYoutube
-  
+
     EXTRACT_URL_PATTERN = /www\.youtube(?:-nocookie)?\.com\/(?:v|embed)\/[a-zA-Z0-9-]+/i
     EXTRACT_VID_PATTERN = /(?<=v|embed)\/(?<vid>[a-zA-Z0-9-]+)/i
 
@@ -13,7 +13,7 @@ module Bulbasaur
       images = Array.new
       @html.scan(EXTRACT_URL_PATTERN).each do |video|
         vid = get_vid(video)
-        images << { url: image_url(vid), url_fallback: image_url_fallback(vid) }
+        images << { url: image_url(vid) }
       end
       images
     end
@@ -25,9 +25,20 @@ module Bulbasaur
     end
 
     def image_url(vid)
+      image = image_url_max_resolution(vid)
+      response = Net::HTTP.get_response(URI(image))
+      case response
+      when Net::HTTPSuccess then
+        return image_url_max_resolution(vid)
+      else
+        return image_url_fallback(vid)
+      end
+    end
+
+    def image_url_max_resolution(vid)
       "http://img.youtube.com/vi/#{vid}/maxresdefault.jpg"
     end
-    
+
     def image_url_fallback(vid)
       "http://img.youtube.com/vi/#{vid}/0.jpg"
     end

data/lib/bulbasaur/version.rb

@@ -2,7 +2,7 @@ module Bulbasaur
 
   module Version
     MAJOR = 0
-    MINOR = 3
+    MINOR = 4
     PATCH = 0
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end

data/spec/bulbasaur/extracts/extract_images_from_all_resources_spec.rb

@@ -5,6 +5,10 @@ RSpec.describe Bulbasaur::ExtractImagesFromAllResources do
   subject do
     described_class.new(html).call
   end
+  
+  before do
+    stub_request(:get, /\.youtube\.com/).to_return(status: 200)
+  end
 
   describe "#call" do
     

data/spec/bulbasaur/extracts/extract_images_from_youtube_spec.rb

@@ -6,6 +6,10 @@ RSpec.describe Bulbasaur::ExtractImagesFromYoutube do
     described_class.new(html).call
   end
 
+  before do
+    stub_request(:get, /\.youtube\.com/).to_return(status: 200)
+  end
+
   describe "#call" do
     
     context "When there is not youtube images" do
@@ -32,10 +36,6 @@ RSpec.describe Bulbasaur::ExtractImagesFromYoutube do
       it "Does return youtube url" do
         expect(subject.first[:url]).to eq "http://img.youtube.com/vi/123idfake321/maxresdefault.jpg"
       end
-      
-      it "Does return youtube url fallback" do
-        expect(subject.first[:url_fallback]).to eq "http://img.youtube.com/vi/123idfake321/0.jpg"
-      end
     end
 
     context "When has on youtube video with path 'v'" do
@@ -51,10 +51,6 @@ RSpec.describe Bulbasaur::ExtractImagesFromYoutube do
       it "Does return youtube url" do
         expect(subject.first[:url]).to eq "http://img.youtube.com/vi/video-1/maxresdefault.jpg"
       end
-      
-      it "Does return youtube url fallback" do
-        expect(subject.first[:url_fallback]).to eq "http://img.youtube.com/vi/video-1/0.jpg"
-      end
     end
 
     context "When has on youtube video with domais no-cookies" do
@@ -70,9 +66,20 @@ RSpec.describe Bulbasaur::ExtractImagesFromYoutube do
       it "Does return youtube url" do
         expect(subject.first[:url]).to eq "http://img.youtube.com/vi/video-6/maxresdefault.jpg"
       end
-      
-      it "Does return youtube url fallback" do
-        expect(subject.first[:url_fallback]).to eq "http://img.youtube.com/vi/video-6/0.jpg"
+    end
+
+    context "When image max resolution not exists" do
+
+      let(:html) do
+          %Q(<iframe width="560" height="315" src="https://www.youtube-nocookie.com/v/video-fail-6" frameborder="0" allowfullscreen></iframe>)
+      end
+
+      before do
+        stub_request(:get, "http://img.youtube.com/vi/video-fail-6/maxresdefault.jpg").to_return(status: 404)
+      end
+
+      it "Does return image fallback url" do
+        expect(subject.first[:url]).to eq "http://img.youtube.com/vi/video-fail-6/0.jpg"
       end
     end
     
@@ -106,17 +113,6 @@ RSpec.describe Bulbasaur::ExtractImagesFromYoutube do
           "http://img.youtube.com/vi/video-4/maxresdefault.jpg", 
           "http://img.youtube.com/vi/video-6/maxresdefault.jpg")
       end
-      
-      it "Does return youtube urls fallback" do
-        expect(subject.map{ |video| video[:url_fallback] }).to include(
-          "http://img.youtube.com/vi/video0/0.jpg",  
-          "http://img.youtube.com/vi/video1/0.jpg",  
-          "http://img.youtube.com/vi/video2/0.jpg", 
-          "http://img.youtube.com/vi/video3/0.jpg", 
-          "http://img.youtube.com/vi/video-4/0.jpg", 
-          "http://img.youtube.com/vi/video-4/0.jpg", 
-          "http://img.youtube.com/vi/video-6/0.jpg")
-      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -7,8 +7,12 @@ require "bundler/setup"
 Bundler.setup
 
 require "bulbasaur"
-require "simplecov"
+require "webmock/rspec"
 
 RSpec.configure do |config|
 
+  config.after(:suite) do
+    WebMock.disable_net_connect!(:allow => 'codeclimate.com')
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: preadly-bulbasaur
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Magno Costa
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement