pre-commit 0.38.1 → 0.39.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a9bfb25f2d369ac0724a9836d0c90a763ffb5c4d066d651852dad9afe5d6dd3
-  data.tar.gz: 2a9545037374a38f0e91801620a857ca62f1052cd9c36eb0f944ab149ea4a8fd
+  metadata.gz: 5849a98ebb481bb8f21d491ce6de8f41bb27187ba650bef608e88ce4c6f6b4da
+  data.tar.gz: c3c4d54f01f80b104189fef18de43e2e217b7cb759e41b5ecca933f7ed4ef793
 SHA512:
-  metadata.gz: f5da744009fb8a0784c81060b8c2a0368e509fcc6a600baeb474b707683edeed285d1aa3294e0673ca4eb92c1abd788aed6d7d4ec0c6ce03b2e8a0136a45a283
-  data.tar.gz: e5316ef693fad9b4583233027bad25999112cb3eb7c089cdab77e67c8aebabf32dc124d3651d1c5b8e42ae44ae94de4f1060b4f42d8ea3ab57dc71fd7b3980f4
+  metadata.gz: 377c16ed45e5339853dae530f14faf2b467ca8f932e9e44bdd645b1a52491e81aa4de0476bbfd92c4143ae5007828352e986a036ce8df6a15b4a43e685397803
+  data.tar.gz: 2f56fcc858842ec520f04ee19f9b830eee3b9c85d39dc9276fc0f3023de1057d8d15adb1f5d29b44f7a30d126fd3208664f87aa2ec1b70161e9f5d1698d9601d

data/lib/plugins/pre_commit/checks/migration.rb

@@ -3,13 +3,9 @@ require 'pre-commit/checks/plugin'
 module PreCommit
   module Checks
     class Migration < Plugin
-      VERSION_PATTERN = /(\d{14})/
+      VERSION_PATTERN = /(\d{4}_?\d{2}_?\d{2}_?\d{6})/
 
-      self::VersionedFile = Struct.new(:file, :version) do
-        def to_s
-          "<#{self.class.name} file=\"#{file}\" version=\"#{version}\">"
-        end
-      end
+      VersionedFile = Struct.new(:file, :version)
 
       def self.aliases
         [:migrations]
@@ -25,7 +21,9 @@ module PreCommit
           "You're trying to change the schema without adding a migration file"
         elsif migration_files.any? && schema_files.any?
           migration_versions = migration_files.map(&:version)
-          missing_versions = migration_versions - schema_files.map(&:version)
+          schema_versions = schema_files.map(&:version)
+          missing_versions = migration_versions - schema_versions
+
           if missing_versions.any?
             "You did not add the schema versions for "\
             "#{migration_versions.join(', ')} to #{schema_files.map(&:file).join(' or ')}"
@@ -52,7 +50,8 @@ module PreCommit
 
         files.each_with_object([]) do |f, result|
           File.read(f).scan(VERSION_PATTERN) do |i|
-            result << VersionedFile.new(f, i.first)
+            version = i.first.gsub(/_/, "")
+            result << VersionedFile.new(f, version)
           end
         end
       end

data/lib/pre-commit/checks/js.rb

@@ -6,7 +6,7 @@ module PreCommit
       def call(staged_files)
         require 'execjs'
       rescue RuntimeError, LoadError => e
-        $stderr.puts "Could not load execjs: #{e}"
+        $stderr.puts "Could not load execjs: #{e}. You need to manually install execjs to use JavaScript plugins for security reasons."
       else
         staged_files = files_filter(staged_files)
         return if staged_files.empty?

data/lib/pre-commit/configuration.rb

@@ -46,7 +46,7 @@ module PreCommit
       @providers.update( plugin_name, "#{type}_remove", :+, checks )
       true
     rescue PreCommit::PluginNotFound => e
-      warn e
+      warn e.message
       false
     end
 

data/templates/gem/test/plugins/pre_commit/checks/PLUGIN_NAME_test.rb

@@ -11,13 +11,13 @@ describe PreCommit::Checks::<%= name.capitalize %> do
   let(:check){ PreCommit::Checks::<%= name.capitalize %>.new(nil, nil, []) }
 
   it "does nothing" do
-    check.send(:run_check, "rake").must_equal(nil)
+    check.send(:run_check, "rake").must_be_nil
   end
 
   it "checks files" do
     Dir.chdir(test_files) do
       # TODO: create example files in test/files
-      check.send(:run_check, ".keep").must_equal(nil)
+      check.send(:run_check, ".keep").must_be_nil
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.38.1
+  version: 0.39.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-06 00:00:00.000000000 Z
+date: 2018-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pluginator
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: minitest-reporters
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement