pre-commit 0.38.1 → 0.39.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (6) hide show
  1. checksums.yaml +4 -4
  2. data/lib/plugins/pre_commit/checks/migration.rb +7 -8
  3. data/lib/pre-commit/checks/js.rb +1 -1
  4. data/lib/pre-commit/configuration.rb +1 -1
  5. data/templates/gem/test/plugins/pre_commit/checks/PLUGIN_NAME_test.rb +2 -2
  6. metadata +6 -6
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 0a9bfb25f2d369ac0724a9836d0c90a763ffb5c4d066d651852dad9afe5d6dd3
4
- data.tar.gz: 2a9545037374a38f0e91801620a857ca62f1052cd9c36eb0f944ab149ea4a8fd
3
+ metadata.gz: 5849a98ebb481bb8f21d491ce6de8f41bb27187ba650bef608e88ce4c6f6b4da
4
+ data.tar.gz: c3c4d54f01f80b104189fef18de43e2e217b7cb759e41b5ecca933f7ed4ef793
5
5
  SHA512:
6
- metadata.gz: f5da744009fb8a0784c81060b8c2a0368e509fcc6a600baeb474b707683edeed285d1aa3294e0673ca4eb92c1abd788aed6d7d4ec0c6ce03b2e8a0136a45a283
7
- data.tar.gz: e5316ef693fad9b4583233027bad25999112cb3eb7c089cdab77e67c8aebabf32dc124d3651d1c5b8e42ae44ae94de4f1060b4f42d8ea3ab57dc71fd7b3980f4
6
+ metadata.gz: 377c16ed45e5339853dae530f14faf2b467ca8f932e9e44bdd645b1a52491e81aa4de0476bbfd92c4143ae5007828352e986a036ce8df6a15b4a43e685397803
7
+ data.tar.gz: 2f56fcc858842ec520f04ee19f9b830eee3b9c85d39dc9276fc0f3023de1057d8d15adb1f5d29b44f7a30d126fd3208664f87aa2ec1b70161e9f5d1698d9601d
data/lib/plugins/pre_commit/checks/migration.rb CHANGED
@@ -3,13 +3,9 @@ require 'pre-commit/checks/plugin'
3
3
  module PreCommit
4
4
  module Checks
5
5
  class Migration < Plugin
6
- VERSION_PATTERN = /(\d{14})/
6
+ VERSION_PATTERN = /(\d{4}_?\d{2}_?\d{2}_?\d{6})/
7
7
 
8
- self::VersionedFile = Struct.new(:file, :version) do
9
- def to_s
10
- "<#{self.class.name} file=\"#{file}\" version=\"#{version}\">"
11
- end
12
- end
8
+ VersionedFile = Struct.new(:file, :version)
13
9
 
14
10
  def self.aliases
15
11
  [:migrations]
@@ -25,7 +21,9 @@ module PreCommit
25
21
  "You're trying to change the schema without adding a migration file"
26
22
  elsif migration_files.any? && schema_files.any?
27
23
  migration_versions = migration_files.map(&:version)
28
- missing_versions = migration_versions - schema_files.map(&:version)
24
+ schema_versions = schema_files.map(&:version)
25
+ missing_versions = migration_versions - schema_versions
26
+
29
27
  if missing_versions.any?
30
28
  "You did not add the schema versions for "\
31
29
  "#{migration_versions.join(', ')} to #{schema_files.map(&:file).join(' or ')}"
@@ -52,7 +50,8 @@ module PreCommit
52
50
 
53
51
  files.each_with_object([]) do |f, result|
54
52
  File.read(f).scan(VERSION_PATTERN) do |i|
55
- result << VersionedFile.new(f, i.first)
53
+ version = i.first.gsub(/_/, "")
54
+ result << VersionedFile.new(f, version)
56
55
  end
57
56
  end
58
57
  end
data/lib/pre-commit/checks/js.rb CHANGED
@@ -6,7 +6,7 @@ module PreCommit
6
6
  def call(staged_files)
7
7
  require 'execjs'
8
8
  rescue RuntimeError, LoadError => e
9
- $stderr.puts "Could not load execjs: #{e}"
9
+ $stderr.puts "Could not load execjs: #{e}. You need to manually install execjs to use JavaScript plugins for security reasons."
10
10
  else
11
11
  staged_files = files_filter(staged_files)
12
12
  return if staged_files.empty?
data/lib/pre-commit/configuration.rb CHANGED
@@ -46,7 +46,7 @@ module PreCommit
46
46
  @providers.update( plugin_name, "#{type}_remove", :+, checks )
47
47
  true
48
48
  rescue PreCommit::PluginNotFound => e
49
- warn e
49
+ warn e.message
50
50
  false
51
51
  end
52
52
 
data/templates/gem/test/plugins/pre_commit/checks/PLUGIN_NAME_test.rb CHANGED
@@ -11,13 +11,13 @@ describe PreCommit::Checks::<%= name.capitalize %> do
11
11
  let(:check){ PreCommit::Checks::<%= name.capitalize %>.new(nil, nil, []) }
12
12
 
13
13
  it "does nothing" do
14
- check.send(:run_check, "rake").must_equal(nil)
14
+ check.send(:run_check, "rake").must_be_nil
15
15
  end
16
16
 
17
17
  it "checks files" do
18
18
  Dir.chdir(test_files) do
19
19
  # TODO: create example files in test/files
20
- check.send(:run_check, ".keep").must_equal(nil)
20
+ check.send(:run_check, ".keep").must_be_nil
21
21
  end
22
22
  end
23
23
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: pre-commit
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.38.1
4
+ version: 0.39.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Shajith Chacko, Josh Lubaway
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2018-04-06 00:00:00.000000000 Z
11
+ date: 2018-10-22 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: pluginator
@@ -44,28 +44,28 @@ dependencies:
44
44
  requirements:
45
45
  - - "~>"
46
46
  - !ruby/object:Gem::Version
47
- version: '4.0'
47
+ version: '5.0'
48
48
  type: :development
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - "~>"
53
53
  - !ruby/object:Gem::Version
54
- version: '4.0'
54
+ version: '5.0'
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: minitest-reporters
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
59
  - - "~>"
60
60
  - !ruby/object:Gem::Version
61
- version: '0'
61
+ version: '1.0'
62
62
  type: :development
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
66
  - - "~>"
67
67
  - !ruby/object:Gem::Version
68
- version: '0'
68
+ version: '1.0'
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: rake
71
71
  requirement: !ruby/object:Gem::Requirement