pre-commit 0.7.0 → 0.8.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 4d9c371797ba41d4ea7f982f02afb3ea83509b6c
+  data.tar.gz: 3db78877071110d7c8a6594144d6a581ff05f4b9
+SHA512:
+  metadata.gz: ef060f68886d56abe7fb9ead2edfa62f287cb3a84fa76c83a26748fdde3f726a83124401274fbd7a2bb3a89c755ae5efc3a40158de8cd0e19d895deb59bd0e08
+  data.tar.gz: 5e182f1fd7511e7bddd86704c40220f6f2c83b69108213b3f1052bd123d984cfd2850bfb963828ba36765c9b3cfab665501d709f229f21a7656431f1c70fe62d

data/README.md

@@ -1,5 +1,8 @@
 A better pre-commit hook for git.
 
+[![Current version](https://badge.fury.io/rb/pre-commit.png)][1] 
+[![Build status](https://secure.travis-ci.org/jish/pre-commit.png?branch=master)][2]
+
 ## Installation
 
 Install the gem
@@ -20,19 +23,21 @@ These are the available checks:
 * white_space
 * console_log
 * debugger
+* pry
 * tabs
 * jshint
 * js\_lint\_all (Runs JSLint on all staged JS files)
 * js\_lint\_new (Runs JSLint on all new staged JS files)
 * closure\_syntax\_check
 * php (Runs php -l on all staged files)
+* rspec_focus (Will check if you are about to check in a :focus in a spec file)
 * ruby_symbol_hashrockets (1.9 syntax. BAD :foo => "bar". GOOD foo: "bar")
 * local (executes `config/pre-commit.rb` with list of changed files)
-* merge conflict (Will check if you are about to check in a merge conflict)
+* merge_conflict (Will check if you are about to check in a merge conflict)
 * migrations (Will make sure you check in the proper files after creating a Rails migration)
 * ci (Will run the `pre_commit:ci` rake task and pass or fail accordingly)
 
-To configure which checks you would like to run, simply set the `pre-commit.checks` git configuration setting. 
+To configure which checks you would like to run, simply set the `pre-commit.checks` git configuration setting.
 
 To enable `white_space` and `tab` checks:
 
@@ -46,4 +51,7 @@ To enable `white_space`, `console_log` and `debugger` checks:
 
 Note: If no checks are configured, a default set of checks is run:
 
-    white_space, console_log, debugger, tabs, jshint, migrations, merge_conflict, local
+    white_space, console_log, debugger, pry, tabs, jshint, migrations, merge_conflict, local
+
+[1]: https://rubygems.org/gems/pre-commit
+[2]: https://travis-ci.org/jish/pre-commit

data/lib/pre-commit/checks.rb

@@ -10,6 +10,8 @@ require 'pre-commit/checks/jshint_check'
 require 'pre-commit/checks/migration_check'
 require 'pre-commit/checks/ci_check'
 require 'pre-commit/checks/php_check'
+require 'pre-commit/checks/pry_check'
+require 'pre-commit/checks/rspec_focus_check'
 require 'pre-commit/checks/ruby_symbol_hashrockets'
 
 module PreCommit
@@ -35,6 +37,7 @@ module PreCommit
     :js_lint_new             => JslintCheck.new(:new),
     :jshint                  => JshintCheck.new,
     :debugger                => DebuggerCheck,
+    :pry                     => PryCheck,
     :local                   => LocalCheck,
     :tabs                    => Tabs,
     :closure_syntax_check    => ClosureSyntaxCheck,
@@ -42,6 +45,7 @@ module PreCommit
     :migrations              => MigrationCheck.new,
     :ci                      => CiCheck.new,
     :php                     => PhpCheck.new,
+    :rspec_focus             => RSpecFocusCheck,
     :ruby_symbol_hashrockets => RubySymbolHashrockets
   }
 
@@ -60,7 +64,7 @@ module PreCommit
     checks_to_run = `git config pre-commit.checks`.chomp.split(/,\s*/).map(&:to_sym)
 
     if checks_to_run.empty?
-      Checks.values_at(:white_space, :console_log, :debugger, :tabs, :jshint,
+      Checks.values_at(:white_space, :console_log, :debugger, :pry, :tabs, :jshint,
         :migrations, :merge_conflict, :local)
     else
       Checks.values_at(*checks_to_run)

data/lib/pre-commit/checks/pry_check.rb

@@ -0,0 +1,47 @@
+module PreCommit
+  class PryCheck
+
+    attr_accessor :staged_files, :error_message, :grep_command
+
+    def self.call(quiet=false)
+      dirs = ['app/', 'lib/', 'script/', 'vendor/', 'test/'].reject {|d| !File.exists?(d)}
+      check = new
+      check.staged_files = Utils.staged_files(*dirs)
+
+      result = check.run
+      if !quiet && !result
+        $stderr.puts check.error_message
+        $stderr.puts
+        check.print_dash_n_reminder
+      end
+      result
+    end
+
+    def run
+      return true if staged_files.empty?
+
+      if detected_bad_code?
+        @error_message = "pre-commit: binding.pry statement(s) found:\n"
+        @error_message += instances_of_pry_violations
+        false
+      else
+        true
+      end
+    end
+
+    def detected_bad_code?
+      !system("git diff --cached -S binding.pry --quiet --exit-code")
+    end
+
+    def instances_of_pry_violations
+      cmd = grep_command || "git grep"
+      `#{cmd} -nH "binding\.pry" #{staged_files}`
+    end
+
+    def print_dash_n_reminder
+      $stderr.puts 'You can bypass this check using `git commit -n`'
+      $stderr.puts
+    end
+
+  end
+end

data/lib/pre-commit/checks/rspec_focus_check.rb

@@ -0,0 +1,54 @@
+module PreCommit
+  class RSpecFocusCheck
+
+    attr_accessor :staged_files, :error_message, :grep_command, :spec_files
+
+    def self.call(quiet=false)
+      dirs = ['spec/'].reject {|d| !File.exists?(d)}
+      check = new
+      check.staged_files = Utils.staged_files(*dirs)
+
+      result = check.run
+      if !quiet && !result
+        $stderr.puts check.error_message
+        $stderr.puts
+        check.print_dash_n_reminder
+      end
+      result
+    end
+
+    def run
+      return true if staged_files.empty?
+
+      if detected_bad_code?
+        @error_message = "pre-commit: :focus in spec(s) found:\n"
+        @error_message += instances_of_rspec_focus_violations
+        false
+      else
+        true
+      end
+    end
+
+    def detected_bad_code?
+      spec_files = staged_files.split(' ').select do |file|
+        file =~ /_spec\.rb$/
+      end
+
+      return false if spec_files.empty?
+
+      diff = `git diff --cached -G:focus #{spec_files.join(" ")}`
+      !!(diff =~ /[\W\s]:focus[\W\s]/)
+    end
+
+    def instances_of_rspec_focus_violations
+      cmd = grep_command || "git grep"
+      `#{cmd} -nHw ':focus' #{staged_files}`
+    end
+
+    def print_dash_n_reminder
+      $stderr.puts 'You can bypass this check using `git commit -n`'
+      $stderr.puts
+    end
+
+  end
+end

data/lib/pre-commit/checks/ruby_symbol_hashrockets.rb

@@ -5,7 +5,7 @@ module PreCommit
 
     attr_accessor :staged_files, :error_message
 
-    HASHROCKET_PATTERN = ':(?:\$|@|@@|[_A-Za-z])?\w*[=!?]?\s*=>\s*'
+    HASHROCKET_PATTERN = '[^:](:{1}(?:\$|@|@@|[_A-Za-z])?\w*[=!?]?\s*=>\s*)'
 
     def self.call
       check = new

data/templates/pre-commit-hook

@@ -9,7 +9,7 @@ else
 end
 cmd << " -r pre-commit"
 
-if !system("#{cmd} -e '' 2>&1")
+if !system("#{cmd} -e ';' 2>&1")
   $stderr.puts "pre-commit: WARNING: Skipping checks because the pre-commit gem is not installed. (Did you change your Ruby version?)"
   exit(0)
 end

metadata

@@ -1,30 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.7.0
-  prerelease: 
+  version: 0.8.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-14 00:00:00.000000000 Z
+date: 2013-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execjs
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: A git pre-commit hook written in ruby with a few more tricks up its sleeve
@@ -46,6 +43,8 @@ files:
 - lib/pre-commit/checks/merge_conflict.rb
 - lib/pre-commit/checks/migration_check.rb
 - lib/pre-commit/checks/php_check.rb
+- lib/pre-commit/checks/pry_check.rb
+- lib/pre-commit/checks/rspec_focus_check.rb
 - lib/pre-commit/checks/ruby_symbol_hashrockets.rb
 - lib/pre-commit/checks/tabs.rb
 - lib/pre-commit/checks.rb
@@ -65,6 +64,7 @@ files:
 - bin/pre-commit
 homepage: http://github.com/jish/pre-commit
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
 - --main
@@ -72,20 +72,18 @@ rdoc_options:
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.0
 signing_key: 
 specification_version: 3
 summary: A slightly better git pre-commit hook