pre-commit 0.5.0 → 0.6.0

data/lib/pre-commit/checks.rb

@@ -27,18 +27,19 @@ class PreCommit
   }
 
   Checks = {
-    :white_space          => WhiteSpace,
-    :console_log          => ConsoleLog,
-    :js_lint_all          => JslintCheck.new(:all),
-    :js_lint_new          => JslintCheck.new(:new),
-    :jshint               => JshintCheck.new,
-    :debugger             => DebuggerCheck,
-    :tabs                 => Tabs,
-    :closure_syntax_check => ClosureSyntaxCheck,
-    :merge_conflict       => MergeConflict,
-    :migrations           => MigrationCheck.new,
-    :ci                   => CiCheck.new,
-    :php                  => PhpCheck.new
+    :white_space             => WhiteSpace,
+    :console_log             => ConsoleLog,
+    :js_lint_all             => JslintCheck.new(:all),
+    :js_lint_new             => JslintCheck.new(:new),
+    :jshint                  => JshintCheck.new,
+    :debugger                => DebuggerCheck,
+    :tabs                    => Tabs,
+    :closure_syntax_check    => ClosureSyntaxCheck,
+    :merge_conflict          => MergeConflict,
+    :migrations              => MigrationCheck.new,
+    :ci                      => CiCheck.new,
+    :php                     => PhpCheck.new,
+    :ruby_symbol_hashrockets => RubySymbolHashrockets
   }
 
   # Can not delete this method with out a deprecation strategy.

data/lib/pre-commit/checks/ruby_symbol_hashrockets.rb

@@ -0,0 +1,49 @@
+class RubySymbolHashrockets
+  attr_accessor :staged_files, :error_message
+
+  HASHROCKET_PATTERN = ':(?:\$|@|@@|[_A-Za-z])?\w*[=!?]?\s*=>\s*'
+
+  def self.call
+    check = new
+    check.staged_files = Utils.staged_files('*')
+    result = check.run
+
+    if !result
+      $stderr.puts check.error_message
+      $stderr.puts
+      $stderr.puts 'pre-commit: You can bypass this check using `git commit -n`'
+      $stderr.puts
+    end
+
+    result
+  end
+
+  def run
+    # There is nothing to check
+    return true if staged_files.empty?
+
+    if detected_bad_code?
+      @error_message = "pre-commit: detected :symbol => value hashrocket:\n"
+      @error_message += violations[:lines]
+
+      @passed = false
+    else
+      @passed = true
+    end
+
+    @passed
+  end
+
+  def detected_bad_code?
+    violations[:success]
+  end
+
+  def violations
+    @violations ||= begin
+      lines = `#{Utils.grep} '#{HASHROCKET_PATTERN}' #{staged_files}`
+      success = $?.exitstatus == 0
+
+      { :lines => lines, :success => success}
+    end
+  end
+end

data/lib/pre-commit/checks/tabs.rb

@@ -40,19 +40,10 @@ class Tabs
   LEADING_TAB_PATTERN = '^ *\t'
 
   def detected_bad_code?
-    system("#{grep} -q '#{LEADING_TAB_PATTERN}' #{staged_files}")
+    system("#{Utils.grep} -q '#{LEADING_TAB_PATTERN}' #{staged_files}")
   end
 
   def violations
-    `#{grep} '#{LEADING_TAB_PATTERN}' #{staged_files}`
-  end
-
-  def grep
-    grep_version = `grep --version | head -n 1 | sed -e 's/^[^0-9.]*\([0-9.]*\)$/\1/'`
-    if grep_version =~ /FreeBSD/
-      "grep -EnIH"
-    else
-      "grep -PnIH"
-    end
+    `#{Utils.grep} '#{LEADING_TAB_PATTERN}' #{staged_files}`
   end
 end

data/lib/pre-commit/utils.rb

@@ -16,4 +16,13 @@ class Utils
     dirs.reject { |dir| !File.exist?(dir) }
   end
 
+  def self.grep
+    grep_version = `grep --version | head -n 1 | sed -e 's/^[^0-9.]*\([0-9.]*\)$/\1/'`
+    if grep_version =~ /FreeBSD/
+      "grep -EnIH"
+    else
+      "grep -PnIH"
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-08 00:00:00.000000000 Z
+date: 2012-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execjs
@@ -45,6 +45,7 @@ files:
 - lib/pre-commit/checks/merge_conflict.rb
 - lib/pre-commit/checks/migration_check.rb
 - lib/pre-commit/checks/php_check.rb
+- lib/pre-commit/checks/ruby_symbol_hashrockets.rb
 - lib/pre-commit/checks/tabs.rb
 - lib/pre-commit/checks.rb
 - lib/pre-commit/cli.rb