pre-commit 0.36.0 → 0.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ac175b7e57416744f8dd4f44288c14dd7df0e4e8
-  data.tar.gz: 0c7b2d185164ab133d07c3fb23fdee40a955a831
+  metadata.gz: 042b09e17f23f621e1faa6ea9932694fa6263e0a
+  data.tar.gz: 16934f896ce3e9e328bd883eae9408d396102be7
 SHA512:
-  metadata.gz: 850f5a706f5cc3261b700d87fcf43c8af49dc87e58821dba225852db48491947c00b9fb8b3a836b8927651e0fe89b556792476b6b65f90e53d9e7c0a07491e1e
-  data.tar.gz: de95b110f459871aeaeb3cf19ffa4e9e6fd220670e76e2c3bb75a61cf45574c9ed759e053d2260938812374273c4bc2fa3df2d09a6cd5ba7ca3566fbeebc3619
+  metadata.gz: b5802aa631fc983865d924f5b20e42a8431a0d685b414924315a61e698aa397ee858d7c581550d58a2efcc16b16675c09cad35c813a90e19d49d5f3a9dd9f26a
+  data.tar.gz: 7306cab5fd90c76570e10e80f4906fb02b207df6e6d09296be5a4b372cee7962409bbbc900b7de981e8159c459abca53bfd0e1eff2a1ece9e60a05bb77e9c79b

data/lib/pre-commit/utils/staged_files.rb

@@ -1,10 +1,23 @@
-require "pre-commit/configuration/top_level"
+# frozen-string-literal: true
+
+require 'pre-commit/configuration/top_level'
 
 module PreCommit
   module Utils
     module StagedFiles
       include PreCommit::Configuration::TopLevel
 
+      BINARIES = [
+        ".dmg", ".gz", ".img", ".iso", ".rar", ".tar", ".xz", ".zip"
+      ].freeze
+      IMAGES = [".gif", ".ico", ".jpeg", ".jpg", ".pdf", ".png"].freeze
+      IGNORED_EXTENSIONS = BINARIES + IMAGES
+
+      SOURCE_FILES = [
+        ".coffee", ".css", ".erb", ".feature", ".html", ".js", ".json",
+        ".liquid", ".md", ".rb", ".sass", ".scss", ".slim", ".yml"
+      ].freeze
+
       def set_staged_files(*args)
         case args[0].to_s
         when "all" then staged_files_all
@@ -30,6 +43,31 @@ module PreCommit
         @staged_files = filter_files(staged_from_git_all)
       end
 
+      # Definitely include this file in the checks.
+      def source_file?(filename)
+        SOURCE_FILES.include?(File.extname(filename))
+      end
+
+      # Try to bail out quickly based on filename.
+      #
+      # If the extension is `.jpg` this is likely not a source code file.
+      # So let's not waste time checking to see if it's "binary" (as best we
+      # can guess) and let's not run any checks on it.
+      def ignore_extension?(filename)
+        IGNORED_EXTENSIONS.include?(File.extname(filename))
+      end
+
+      # Make a best guess to determine if this is a binary file.
+      # This is not an exact science ;)
+      def appears_binary?(filename)
+        size = File.size(filename)
+        size > 1_000_000 || (size > 20 && binary?(filename))
+      end
+
+      def repo_ignored?(filename)
+        repo_ignores.any? { |ignore| File.fnmatch?(ignore, filename) }
+      end
+
     private
       # from https://github.com/djberg96/ptools/blob/master/lib/ptools.rb#L90
       def binary?(file)
@@ -41,14 +79,17 @@ module PreCommit
       end
 
       def filter_files(files)
-        files.reject do |file|
-          !File.exist?(file) ||
+        first_pass = files.reject do |file|
+          repo_ignored?(file) ||
+          ignore_extension?(file) ||
           File.directory?(file) ||
-          (
-            size = File.size(file)
-            size > 1_000_000 || (size > 20 && binary?(file))
-          ) ||
-          repo_ignores.any? { |ignore| File.fnmatch?(ignore, file) }
+          !File.exists?(file)
+        end
+
+        # If it's a source file, definitely check it.
+        # Otherwise, attempt to guess if the file is binary or not.
+        first_pass.select do |file|
+          source_file?(file) || !appears_binary?(file)
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pre-commit
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.37.0
 platform: ruby
 authors:
 - Shajith Chacko, Josh Lubaway
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-05 00:00:00.000000000 Z
+date: 2017-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pluginator
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: benchmark-ips
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement