praxis 2.0.pre.34 → 2.0.pre.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 907548a79ff385c164356d493d6ed808933534a37037d55fd3ffa446317c2e16
-  data.tar.gz: a1bc7931b86f65d6091a5ec835cc1b7ea7dafa21ac13a5cf8a0fcafdfd00ba3f
+  metadata.gz: 44bb802f0b2f4372668de58fa4026c7b89ceaf6b24e59021efe0ac66add311c1
+  data.tar.gz: ce0ad5cdaa52001ec451467e865e8fc3c53102984a2aec3256393a51683b668d
 SHA512:
-  metadata.gz: df103d23ba77341af3586865c294e4681ab4d3d8dcb89f5b78dc2f29c56e4edc84b755195e35965a0193635b9726cbfcfe96e1d13ee26597b10bd7fdc13011f4
-  data.tar.gz: 927034f7434cd8a9e3f710d151d5fd04b92db0939d116c4951888c2c8837e8029db723e3c1aadd40efdb9930f05aada870c0c1291a07c126630c3d4c1784bcb4
+  metadata.gz: 8ba98db39d88023a2cf4b2573e83a87a018fa8e3c5959d757ca798f1b7d268b817cf8f2166ba3c04c1a60fc08804c025d31fb231ef2abea074bdadeccb74b6d0
+  data.tar.gz: 496473875489e1276471c09e5307c75502318153ab5de9d4debe0f0261e78fe3036bde69681323fd44431b5b849cd57c95213b697eef4804defa6596e4022bf0

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## next
 
+## 2.0.pre.35
+- Fix reported nullability property in OpenAPI generation. Looking at null: true | false isn't enough. The system needs to look at the default null behavior from Attributor, to properly ascertain if the exclusion of a 'null' option means nullable or not. This PR fixes this.
+
 ## 2.0.pre.34
 - Allow filtering, ordering and pagination to freely use any attributes (potentially deep ones) when no block for the definition is provided. When continuing to define the allowed fields from within the block, those would still be enforced.
 - Added the ability to easily control the hiding/displayability of MediaType attributes in responses.

data/lib/praxis/blueprint.rb

@@ -374,6 +374,8 @@ module Praxis
 
     # Delegates the json-schema methods to the underlying attribute/member_type
     def self.as_json_schema(**args)
+      # TODO: Aren't we loosing the attribute options if we just call the type?? (e.g. description, etc)
+      # Also, we might want to add a 'title' for MTs, to be the class name (without prefixing) ...
       @attribute.type.as_json_schema(args)
     end
 

data/lib/praxis/docs/open_api/schema_object.rb

@@ -37,7 +37,10 @@ module Praxis
           end
           # Tag on OpenAPI specific requirements that aren't already added in the underlying JSON schema model
           # Nullable: (it seems we need to ensure there is a null option to the enum, if there is one)
-          base_options[:nullable] = !base_options.delete(:null).nil? if base_options.key?(:null)
+          if base_options.key?(:null)
+            base_options[:nullable] = Attributor::Attribute::nullable_attribute?(base_options)
+            base_options.delete(:null)
+          end
 
           # We will dump schemas for mediatypes by simply creating a reference to the components' section
           if type < Attributor::Container && !(type < Praxis::Types::MultipartArray)

data/lib/praxis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Praxis
-  VERSION = '2.0.pre.34'
+  VERSION = '2.0.pre.35'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: praxis
 version: !ruby/object:Gem::Version
-  version: 2.0.pre.34
+  version: 2.0.pre.35
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-14 00:00:00.000000000 Z
+date: 2023-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport