praxis 2.0.pre.29 → 2.0.pre.30

data/spec/praxis/mapper/selector_generator_spec.rb

@@ -9,134 +9,471 @@ describe Praxis::Mapper::SelectorGenerator do
   context '#add' do
     let(:resource) { SimpleResource }
     shared_examples 'a proper selector' do
-      it { expect(generator.add(resource, fields).selectors.dump).to be_deep_equal selectors }
+      it do
+        dumped = generator.add(resource, fields).selectors.dump
+        # puts JSON.pretty_generate(dumped)
+        expect(dumped).to be_deep_equal selectors
+      end
     end
 
-    context 'basic combos' do
-      context 'direct column fields' do
-        let(:fields) { { id: true, foobar: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[id foobar]
-          }
-        end
-        it_behaves_like 'a proper selector'
+    shared_examples 'a proper fields selector' do
+      it do
+        result = generator.add(resource, fields).selectors
+        dumped = result.dump(mode: :fields)
+        # puts JSON.pretty_generate(dumped)
+        expect(dumped).to be_deep_equal selectors
       end
+    end
 
-      context 'aliased column fields' do
-        let(:fields) { { id: true, name: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[id simple_name]
-          }
+    context 'selecting columns and tracks' do
+      context '#add' do
+        let(:resource) { SimpleResource }
+        shared_examples 'a proper selector' do
+          it { expect(generator.add(resource, fields).selectors.dump).to be_deep_equal selectors }
         end
-        it_behaves_like 'a proper selector'
-      end
-
-      context 'pure associations without recursion' do
-        let(:fields) { { other_model: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id], # FK of the other_model association
-            tracks: {
-              other_model: {
-                columns: [:id], # joining key for the association
-                model: OtherModel
+        context 'basic combos' do
+          context 'direct column fields' do
+            let(:fields) { { id: true, foobar: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[id foobar]
               }
-            }
-          }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'aliased column fields' do
+            let(:fields) { { id: true, name: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[id simple_name]
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'pure associations without recursion' do
+            let(:fields) { { other_model: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id], # FK of the other_model association
+                tracks: {
+                  other_model: {
+                    columns: [:id], # joining key for the association
+                    model: OtherModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'aliased associations without recursion' do
+            let(:fields) { { other_resource: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id], # FK of the other_model association
+                tracks: {
+                  other_model: {
+                    columns: [:id], # joining key for the association
+                    model: OtherModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'aliased associations without recursion (that map to columns and other associations)' do
+            let(:fields) { { aliased_method: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[column1 other_model_id], # other_model_id => because of the association
+                tracks: {
+                  other_model: {
+                    columns: [:id], # joining key for the association
+                    model: OtherModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'redefined associations that add some extra columns (would need both the underlying association AND the columns in place)' do
+            let(:fields) { { parent: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[parent_id added_column],
+                tracks: {
+                  parent: {
+                    columns: [:id],
+                    model: ParentModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'a simple property that requires all fields' do
+            let(:fields) { { everything: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:*]
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'a simple property that requires itself' do
+            let(:fields) { { circular_dep: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[circular_dep column1] # allows to "expand" the dependency into itself + others
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'a simple property without dependencies' do
+            let(:fields) { { no_deps: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
         end
-        it_behaves_like 'a proper selector'
-      end
-
-      context 'aliased associations without recursion' do
-        let(:fields) { { other_resource: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id], # FK of the other_model association
-            tracks: {
-              other_model: {
-                columns: [:id], # joining key for the association
-                model: OtherModel
+        context 'nested tracking' do
+          context 'pure associations follow the nested fields' do
+            let(:fields) do
+              {
+                other_model: {
+                  id: true
+                }
               }
-            }
-          }
+            end
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id],
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    columns: [:id]
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'Aliased resources disregard any nested fields...' do
+            let(:fields) do
+              {
+                other_resource: {
+                  id: true
+                }
+              }
+            end
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id],
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    columns: [:id]
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'merging multiple tracks with the same name within a node' do
+            let(:fields) do
+              { # Both everything_from_parent and parent will track the underlying 'parent' assoc
+                # ...and the final respective fields and tracks will need to be merged together.
+                # columns will be merged by just *, and tracks will merge true with simple children
+                everything_from_parent: true,
+                parent: {
+                  simple_children: true
+                }
+              }
+            end
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[parent_id added_column],
+                tracks: {
+                  parent: {
+                    model: ParentModel,
+                    columns: [:*],
+                    tracks: {
+                      simple_children: {
+                        model: SimpleModel,
+                        columns: [:parent_id]
+                      }
+                    }
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'Aliased underlying associations follows any nested fields...' do
+            let(:fields) do
+              {
+                parent_id: true,
+                aliased_association: {
+                  display_name: true
+                }
+              }
+            end
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[other_model_id parent_id],
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    columns: %i[id name]
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'Deep aliased underlying associations also follows any nested fields at the end of the chain...' do
+            let(:fields) do
+              {
+                parent_id: true,
+                deep_aliased_association: {
+                  name: true
+                }
+              }
+            end
+            # TODO: Legitimate failure!! there is a name in the parent column track...which shouldn't be there
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: %i[parent_id],
+                tracks: {
+                  parent: {
+                    model: ParentModel,
+                    columns: %i[id],
+                    tracks: {
+                      simple_children: {
+                        model: SimpleModel,
+                        columns: %i[parent_id simple_name]
+                      }
+                    }
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'Using self for the underlying association: follows any nested fields skipping the association name and still applies dependencies' do
+            let(:fields) do
+              {
+                parent_id: true,
+                sub_struct: {
+                  display_name: true
+                }
+              }
+            end
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                # Parent_id is because we asked for it at the top
+                # display_name because we asked for it under sub_struct, but it is marked as :self
+                # alway_necessary_attribute because it is a dependency of sub_struct
+                columns: %i[parent_id display_name]
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
         end
-        it_behaves_like 'a proper selector'
-      end
-      context 'aliased associations without recursion (that map to columns and other associations)' do
-        let(:fields) { { aliased_method: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[column1 other_model_id], # other_model_id => because of the association
-            tracks: {
-              other_model: {
-                columns: [:id], # joining key for the association
-                model: OtherModel
+        context 'string associations' do
+          context 'that specify a direct existing colum in the target dependency' do
+            let(:fields) { { direct_other_name: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id],
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    columns: %i[id name]
+                  }
+                }
               }
-            }
-          }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'that specify an aliased property in the target dependency' do
+            let(:fields) { { aliased_other_name: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id],
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    columns: %i[id name]
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+
+          context 'for a property that requires all fields from an association' do
+            let(:fields) { { everything_from_parent: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:parent_id],
+                tracks: {
+                  parent: {
+                    model: ParentModel,
+                    columns: [:*]
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
         end
-        it_behaves_like 'a proper selector'
-      end
 
-      context 'redefined associations that add some extra columns (would need both the underlying association AND the columns in place)' do
-        let(:fields) { { parent: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[parent_id added_column],
-            tracks: {
-              parent: {
-                columns: [:id],
-                model: ParentModel
+        context 'required extra select fields due to associations' do
+          context 'many_to_one' do
+            let(:fields) { { other_model: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:other_model_id], # FK of the other_model association
+                tracks: {
+                  other_model: {
+                    columns: [:id],
+                    model: OtherModel
+                  }
+                }
               }
-            }
-          }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'one_to_many' do
+            let(:resource) { ParentResource }
+            let(:fields) { { simple_children: true } }
+            let(:selectors) do
+              {
+                model: ParentModel,
+                columns: [:id], # No FKs in the source model for one_to_many
+                tracks: {
+                  simple_children: {
+                    columns: [:parent_id],
+                    model: SimpleModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+          context 'many_to_many' do
+            let(:resource) { OtherResource }
+            let(:fields) { { simple_models: true } }
+            let(:selectors) do
+              {
+                model: OtherModel,
+                columns: [:id], # join key in the source model for many_to_many (where the middle table points to)
+                tracks: {
+                  simple_models: {
+                    columns: [:id], # join key in the target model for many_to_many (where the middle table points to)
+                    model: SimpleModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
+
+          context 'that are several attriutes deep' do
+            let(:fields) { { deep_nested_deps: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                columns: [:parent_id],
+                tracks: {
+                  parent: {
+                    model: ParentModel,
+                    columns: [:id], # No FKs in the source model for one_to_many
+                    tracks: {
+                      simple_children: {
+                        columns: %i[parent_id other_model_id],
+                        model: SimpleModel,
+                        tracks: {
+                          other_model: {
+                            model: OtherModel,
+                            columns: %i[id parent_id],
+                            tracks: {
+                              parent: {
+                                model: ParentModel,
+                                columns: %i[id simple_name other_attribute]
+                              }
+                            }
+                          }
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper selector'
+          end
         end
-        it_behaves_like 'a proper selector'
       end
+    end
 
-      context 'a simple property that requires all fields' do
-        let(:fields) { { everything: true } }
-        let(:selectors) do
+    context 'selecting fields and subfields' do
+      context 'with nil dependencies' do
+        let(:fields) do
           {
-            model: SimpleModel,
-            columns: [:*]
+            nil_deps: true
           }
         end
-        it_behaves_like 'a proper selector'
-      end
-
-      context 'a simple property that requires itself' do
-        let(:fields) { { circular_dep: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: %i[circular_dep column1] # allows to "expand" the dependency into itself + others
+            fields: {
+              nil_deps: {
+                deps: %i[nil_deps]
+              }
+            }
           }
         end
-        it_behaves_like 'a proper selector'
+        it_behaves_like 'a proper fields selector'
       end
-
-      context 'a simple property without dependencies' do
+      context 'with empty array dependencies' do
         let(:fields) { { no_deps: true } }
         let(:selectors) do
           {
-            model: SimpleModel
+            model: SimpleModel,
+            fields: {
+              no_deps: {
+                deps: %i[no_deps]
+              }
+            }
           }
         end
-        it_behaves_like 'a proper selector'
+        it_behaves_like 'a proper fields selector'
       end
-    end
-
-    context 'nested tracking' do
-      context 'pure associations follow the nested fields' do
+      context 'following nested fields from pure implicit association properties (not defined and no deps)' do
+        # For implicit properties that aren't defined, but that have a name that matches an association
+        # we want to make it work like an as: association, therefore subfield following will work.
         let(:fields) do
           {
             other_model: {
@@ -147,276 +484,622 @@ describe Praxis::Mapper::SelectorGenerator do
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:other_model_id],
+            fields: {
+              other_model: {
+                references: 'Linked to resource: OtherResource'
+              }
+            },
             tracks: {
               other_model: {
                 model: OtherModel,
-                columns: [:id]
+                fields: {
+                  id: {
+                    deps: %i[id]
+                  }
+                }
               }
             }
           }
         end
-        it_behaves_like 'a proper selector'
+        it_behaves_like 'a proper fields selector'
       end
-
-      context 'Aliased resources disregard any nested fields...' do
-        let(:fields) do
-          {
-            other_resource: {
-              id: true
+      context 'implicit (not defined) properties that are direct associations can follow fields' do
+        context 'using a direct association name' do
+          let(:fields) do
+            {
+              other_model: true
             }
-          }
-        end
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id],
-            tracks: {
-              other_model: {
-                model: OtherModel,
-                columns: [:id]
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                other_model: {
+                  references: 'Linked to resource: OtherResource' # because other_model is implicit, without deps
+                }
+              },
+              tracks: {
+                other_model: {
+                  model: OtherModel,
+                  fields: {
+                    id: { deps: %i[id] }
+                  }
+                }
               }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
       end
+      context 'properties with dependencies' do
+        context 'simple direct column name' do
+          let(:fields) do
+            {
+              simple_name: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                simple_name: {
+                  deps: %i[simple_name]
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
+        end
+        context 'needing to resolve dependencies recursively' do
+          let(:fields) do
+            {
+              name: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                name: {
+                  deps: %i[name nested_name simple_name]
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
+        end
 
-      context 'merging multiple tracks with the same name within a node' do
-        let(:fields) do
-          { # Both everything_from_parent and parent will track the underlying 'parent' assoc
-            # ...and the final respective fields and tracks will need to be merged together.
-            # columns will be merged by just *, and tracks will merge true with simple children
-            everything_from_parent: true,
-            parent: {
-              simple_children: true
+        context 'a simple property that requires all fields' do
+          let(:fields) { { everything: true } }
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                everything: {
+                  deps: %i[everything]
+                }
+              }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[parent_id added_column],
-            tracks: {
-              parent: {
-                model: ParentModel,
-                columns: [:*],
-                tracks: {
-                  simple_children: {
-                    model: SimpleModel,
-                    columns: [:parent_id]
+        context 'self referential' do
+          let(:fields) do
+            {
+              circular_dep: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                circular_dep: {
+                  deps: %i[circular_dep column1]
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
+        end
+        context 'combining dependencies with other properties and associacions (stops at the property)' do
+          # There won't be any references or anything as it is a property with dependencies...so we just
+          # unroll them, and discard any nested fields (in this case there aren't any though)
+          let(:fields) do
+            {
+              aliased_method: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                aliased_method: {
+                  deps: %i[aliased_method other_model column1]
+                }
+              },
+              tracks: {
+                other_model: {
+                  model: OtherModel,
+                  fields: {
+                    id: { deps: %i[id] }
                   }
                 }
               }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
-      end
-      context 'Aliased underlying associations follows any nested fields...' do
-        let(:fields) do
-          {
-            parent_id: true,
-            aliased_association: {
-              display_name: true
+        context 'following nested fields from a property that has dependencies (does not work, same result as above)' do
+          # This means we will track up to the property name (nothing under that will be reflected in fields, even references)
+          let(:fields) do
+            {
+              aliased_method: {
+                display_name: true
+              }
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                aliased_method: {
+                  deps: %i[aliased_method other_model column1]
+                }
+              },
+              tracks: {
+                other_model: {
+                  model: OtherModel,
+                  fields: {
+                    id: {
+                      deps: %i[id] # There is no further tracking of display name here...since it is not an as: property
+                    }
+                  }
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[other_model_id parent_id simple_name],
-            tracks: {
-              other_model: {
-                model: OtherModel,
-                columns: %i[id name]
+        context 'a true substructure object' do
+          # once we hit true_struct, we know it is not a property group, so we'll bring ALL the inner dependencies
+          # even if the fields required are only a subset of it
+          let(:fields) do
+            {
+              true_struct: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                true_struct: {
+                  deps: %i[true_struct name nested_name simple_name sub_id inner_sub_id id]
+                }
               }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
+        end
+        context 'string associations' do
+          context 'that specify a direct existing colum in the target dependency' do
+            let(:fields) { { direct_other_name: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                fields: {
+                  direct_other_name: {
+                    deps: %i[direct_other_name]
+                  }
+                },
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    fields: {
+                      id: {
+                        deps: %i[id]
+                      },
+                      name: {
+                        deps: %i[name]
+                      }
+                    }
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper fields selector'
+          end
+          context 'that specify an aliased property in the target dependency' do
+            let(:fields) { { aliased_other_name: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                fields: {
+                  aliased_other_name: {
+                    deps: %i[aliased_other_name]
+                  }
+                },
+                tracks: {
+                  other_model: {
+                    model: OtherModel,
+                    fields: {
+                      id: {
+                        deps: %i[id]
+                      },
+                      display_name: {
+                        deps: %i[display_name name]
+                      }
+                    }
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper fields selector'
+          end
+          context 'for a property that requires all fields from an association' do
+            let(:fields) { { everything_from_parent: true } }
+            let(:selectors) do
+              {
+                model: SimpleModel,
+                fields: {
+                  everything_from_parent: {
+                    deps: %i[everything_from_parent]
+                  }
+                },
+                tracks: {
+                  parent: {
+                    model: ParentModel
+                  }
+                }
+              }
+            end
+            it_behaves_like 'a proper fields selector'
+          end
         end
-        it_behaves_like 'a proper selector'
       end
-      context 'Deep aliased underlying associations also follows any nested fields at the end of the chain...' do
-        let(:fields) do
-          {
-            parent_id: true,
-            deep_aliased_association: {
-              name: true
+      context 'entire forwarding (i.e., association_name: true) associations (as: aliases)' do
+        context 'using a forwarding association name with 1 level deep' do
+          let(:fields) do
+            {
+              aliased_association: true
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                aliased_association: {
+                  deps: [:aliased_association],
+                  references: 'Linked to resource: OtherResource'
+                }
+              },
+              tracks: {
+                other_model: {
+                  model: OtherModel,
+                  fields: {
+                    id: {
+                      deps: %i[id]
+                    }
+                  }
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: %i[parent_id simple_name], # No added_column, as it does not follow the dotted reference as properties, just associations
-            tracks: {
-              parent: {
-                model: ParentModel,
-                columns: %i[id],
-                tracks: {
-                  simple_children: {
-                    model: SimpleModel,
-                    columns: %i[parent_id simple_name]
+
+        context 'using a forwarding association name with 2 levels deep' do
+          let(:fields) do
+            {
+              deep_aliased_association: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                deep_aliased_association: {
+                  deps: [:deep_aliased_association],
+                  references: 'Linked to resource: SimpleResource'
+                }
+              },
+              tracks: {
+                parent: {
+                  model: ParentModel,
+                  fields: {
+                    id: {
+                      deps: %i[id]
+                    }
+                  },
+                  tracks: {
+                    simple_children: {
+                      model: SimpleModel,
+                      fields: {
+                        parent_id: {
+                          deps: %i[parent_id]
+                        }
+                      }
+                    }
                   }
                 }
               }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
+        end
+        context 'using a self forwarding association ' do
+          let(:fields) do
+            {
+              sub_struct: true
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                sub_struct: {
+                  deps: %i[sub_struct]
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
       end
-      context 'Using self for the underlying association: follows any nested fields skipping the association name and still applies dependencies' do
-        let(:fields) do
-          {
-            parent_id: true,
-            sub_struct: {
-              display_name: true
+      context 'forwarding associations (as: aliases) but specifying sub-fields' do
+        context 'using a self forwarding association name with 2 levels deep' do
+          let(:fields) do
+            {
+              sub_struct: {
+                name: true
+              }
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                sub_struct: {
+                  deps: %i[sub_struct],
+                  fields: {
+                    name: {
+                      deps: %i[name nested_name simple_name]
+                    }
+                  }
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            # Parent_id is because we asked for it at the top
-            # display_name because we asked for it under sub_struct, but it is marked as :self
-            # alway_necessary_attribute because it is a dependency of sub_struct
-            columns: %i[parent_id display_name alway_necessary_attribute]
-          }
+        context 'using a self forwarding association name with multiple levels which include deep forwarding associations' do
+          let(:fields) do
+            {
+              sub_struct: {
+                name: true,
+                deep_aliased_association: true
+              }
+            }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                sub_struct: {
+                  deps: %i[sub_struct],
+                  fields: {
+                    name: {
+                      deps: %i[name nested_name simple_name]
+                    },
+                    deep_aliased_association: {
+                      deps: %i[deep_aliased_association],
+                      references: 'Linked to resource: SimpleResource'
+                    }
+                  }
+                }
+              },
+              tracks: {
+                parent: {
+                  model: ParentModel,
+                  fields: {
+                    id: {
+                      deps: %i[id]
+                    }
+                  },
+                  tracks: {
+                    simple_children: {
+                      model: SimpleModel,
+                      fields: {
+                        parent_id: {
+                          deps: %i[parent_id]
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
       end
-    end
-
-    context 'string associations' do
-      context 'that specify a direct existing colum in the target dependency' do
-        let(:fields) { { direct_other_name: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id],
-            tracks: {
-              other_model: {
-                model: OtherModel,
-                columns: %i[id name]
+      context 'property groups' do
+        context 'a property group substructure object, but asking only 1 of the subfields' do
+          let(:resource) { Resources::Book }
+          let(:fields) do
+            {
+              grouped: {
+                # id: true,
+                name: true
+                # moar_tags
               }
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: ::ActiveBook,
+              fields: {
+                grouped: {
+                  deps: %i[grouped],
+                  fields: {
+                    name: {
+                      deps: %i[grouped_name name nested_name simple_name]
+                    }
+                  }
+                  # NO id or group_id or tags of any sort should be traversed and appear, as we didn't ask for them
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
-      end
 
-      context 'that specify an aliased property in the target dependency' do
-        let(:fields) { { aliased_other_name: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id],
-            tracks: {
-              other_model: {
-                model: OtherModel,
-                columns: %i[id name]
+        context 'a property group substructure object, but asking only a subset of fields, going deep in an association' do
+          let(:resource) { Resources::Book }
+          let(:fields) do
+            {
+              grouped: {
+                id: true,
+                # name: true,
+                moar_tags: {
+                  # name: true,
+                  label: true
+                }
               }
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: ::ActiveBook,
+              fields: {
+                grouped: {
+                  deps: %i[grouped],
+                  fields: {
+                    id: {
+                      deps: %i[grouped_id id]
+                    },
+                    moar_tags: {
+                      deps: %i[grouped_moar_tags],
+                      references: 'Linked to resource: Resources::Tag'
+                    }
+                  }
+                  # NO name of any other name related things
+                }
+              },
+              tracks: {
+                tags: {
+                  model: ActiveTag,
+                  fields: {
+                    id: {
+                      deps: %i[id]
+                    },
+                    label: {
+                      deps: %i[label]
+                    }
+                  }
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
       end
-
-      context 'for a property that requires all fields from an association' do
-        let(:fields) { { everything_from_parent: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:parent_id],
-            tracks: {
-              parent: {
-                model: ParentModel,
-                columns: [:*]
+      context 'true structs' do
+        context 'with any named subattributes' do
+          # once we hit true_struct, we know it is not a property group, so we'll bring ALL the inner dependencies
+          # even if the fields required are only a subset of it
+          let(:fields) do
+            {
+              true_struct: {
+                sub_id: {
+                  sub_sub_id: true
+                }
               }
             }
-          }
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                true_struct: {
+                  deps: %i[true_struct name nested_name simple_name sub_id inner_sub_id id]
+                }
+              }
+            }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
-      end
-    end
 
-    context 'required extra select fields due to associations' do
-      context 'many_to_one' do
-        let(:fields) { { other_model: true } }
-        let(:selectors) do
-          {
-            model: SimpleModel,
-            columns: [:other_model_id], # FK of the other_model association
-            tracks: {
-              other_model: {
-                columns: [:id],
-                model: OtherModel
+        context 'a true substructure object with property names prefixed like a property group (is still treated as a struct loading it all)' do
+          let(:fields) do
+            {
+              agroup: {
+                id: true
               }
             }
-          }
-        end
-        it_behaves_like 'a proper selector'
-      end
-      context 'one_to_many' do
-        let(:resource) { ParentResource }
-        let(:fields) { { simple_children: true } }
-        let(:selectors) do
-          {
-            model: ParentModel,
-            columns: [:id], # No FKs in the source model for one_to_many
-            tracks: {
-              simple_children: {
-                columns: [:parent_id],
-                model: SimpleModel
+          end
+          let(:selectors) do
+            {
+              model: SimpleModel,
+              fields: {
+                agroup: {
+                  deps: %i[agroup agroup_id id agroup_name name nested_name simple_name]
+                }
               }
             }
-          }
+          end
+          it_behaves_like 'a proper fields selector'
         end
-        it_behaves_like 'a proper selector'
       end
-      context 'many_to_many' do
-        let(:resource) { OtherResource }
-        let(:fields) { { simple_models: true } }
-        let(:selectors) do
+    end
+
+    context 'Traversal of field deps experiments' do
+      context 'using a self forwarding association name with multiple levels which include deep forwarding associations' do
+        let(:fields) do
           {
-            model: OtherModel,
-            columns: [:id], # join key in the source model for many_to_many (where the middle table points to)
-            tracks: {
-              simple_models: {
-                columns: [:id], # join key in the target model for many_to_many (where the middle table points to)
-                model: SimpleModel
+            sub_struct: {
+              name: true,
+              deep_aliased_association: {
+                nested_name: true
               }
             }
           }
         end
-        it_behaves_like 'a proper selector'
-      end
-
-      context 'that are several attriutes deep' do
-        let(:fields) { { deep_nested_deps: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:parent_id],
+            fields: {
+              sub_struct: {
+                deps: %i[sub_struct],
+                fields: {
+                  name: {
+                    deps: %i[name nested_name simple_name]
+                  },
+                  deep_aliased_association: {
+                    deps: %i[deep_aliased_association],
+                    references: 'Linked to resource: SimpleResource'
+                  }
+                }
+              }
+            },
             tracks: {
               parent: {
                 model: ParentModel,
-                columns: [:id], # No FKs in the source model for one_to_many
+                fields: {
+                  id: {
+                    deps: %i[id]
+                  }
+                },
                 tracks: {
                   simple_children: {
-                    columns: %i[parent_id other_model_id],
                     model: SimpleModel,
-                    tracks: {
-                      other_model: {
-                        model: OtherModel,
-                        columns: %i[id parent_id],
-                        tracks: {
-                          parent: {
-                            model: ParentModel,
-                            columns: %i[id simple_name other_attribute]
-                          }
-                        }
+                    fields: {
+                      parent_id: {
+                        deps: %i[parent_id]
+                      },
+                      nested_name: {
+                        deps: %i[nested_name simple_name]
                       }
+
                     }
                   }
                 }
@@ -424,7 +1107,7 @@ describe Praxis::Mapper::SelectorGenerator do
             }
           }
         end
-        it_behaves_like 'a proper selector'
+        it_behaves_like 'a proper fields selector'
       end
     end
   end