praxis 2.0.pre.26 → 2.0.pre.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcecd5fd9fb69d436e75297f383ffeaa63373caf8ddfbefdb7361230c981ffc8
-  data.tar.gz: a5e00599183864a2fec4a3f197accaa8c8724fdd40400d91917a460bbd72f8aa
+  metadata.gz: 71228b4dd69f45eb28f8fec8782eef94fc24bdf6bb164a707d19cfade5091ac7
+  data.tar.gz: 33e2fce254db25935827d67ccc394aa7b54039212e97eaa7aae89d9006e4d5fd
 SHA512:
-  metadata.gz: cf23dd0e2cd395df1a956216987023b1427e50268a964a770d2b1649206a115ae345a91adefaf067d612c64f04b312f1e508e1dc8f56dfa1157a395c038ac31f
-  data.tar.gz: fd01611ba7921490e8fdfee9073ab83fab85130e4428271e1d0f448cde5afd844da6a2a930bbff206f6b9832589bc425d5fc15231eb44a7c47842942305e4b40
+  metadata.gz: 4f1bb58917fe5070e9433acdc2c2b1cbc0341eb832331f399a08bc2138fc5080397326ec2755f7e9452ec4774e931842699c4a4fa9455e0ef1231a6532f2b2d9
+  data.tar.gz: 346dbe116bab1da666e6e38b5d8a7f3863c0dcd2c97736a762fc107eaf77d879b6e9f52e5569e5ee4e4e56207b14c87b21a0cd4e4e10a2f33a34177720c682e7

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## next
 
+## 2.0.pre.26
+  * Introduce a new `as:` option for resource's `property`, to indicate that the underlying association method it is connected to, has a different name.
+    * This also will create a delegation function for the property name, that instead of calling the underlying association on the record, and wrapping the result with a resource instance, it will simply call the aliased method name (which is likely gonna hit the autogenerated code for that properyty, unless we have overriden it)
+    * With this change, the selector generator (i.e., the thing that looks at the incoming `fields` parameters and calculates which select and includes are necessary to query all the data we need), will be able to understand this aliasing cases, and properly pass along, and continue expanding any nested fields that are under the property name (before this, and further inner fields would be not included as soon as we hit a property that didn't have that direct association underneath).
+
 ## 2.0.pre.26
   * Make POST action forwarding more robust against technically malformed GET requests with no body but passing `Content-Type`. This could cause issues when using the `enable_large_params_proxy_action` DSL.
 

data/lib/praxis/mapper/resource.rb

@@ -60,8 +60,10 @@ module Praxis
         end
       end
 
-      def self.property(name, dependencies: nil, through: nil)
-        properties[name] = { dependencies: dependencies, through: through }
+      # The `as:` can be used for properties that correspond to an underlying association of a different name. With this the selector generator, is able to not only add
+      # any extra dependencies needed for the property, but it also follow and pass any incoming nested fields when necessary (as opposed to only add dependencies and discard nested fields)
+      def self.property(name, dependencies: nil, through: nil, as: name) # rubocop:disable Naming/MethodParameterName
+        properties[name] = { dependencies: dependencies, through: through, as: as }
       end
 
       def self.batch_computed(attribute, with_instance_method: true, &block)
@@ -119,11 +121,27 @@ module Praxis
       def self.define_model_accessors
         return if model.nil?
 
+        define_aliased_methods
+
         model._praxis_associations.each do |k, v|
           define_model_association_accessor(k, v) unless instance_methods.include? k
         end
       end
 
+      def self.define_aliased_methods
+        with_different_alias_name = properties.reject { |name, opts| name == opts[:as] }
+        with_different_alias_name.each do |prop_name, opts|
+          next if instance_methods.include? prop_name
+
+          # Straight call to another association method (that we will generate automatically in our association accessors)
+          module_eval <<-RUBY, __FILE__, __LINE__ + 1
+            def #{prop_name}
+              #{opts[:as]}
+            end
+          RUBY
+        end
+      end
+
       def self.hookup_callbacks
         return unless ancestors.include?(Praxis::Mapper::Resources::Callbacks)
 

data/lib/praxis/mapper/selector_generator.rb

@@ -66,8 +66,10 @@ module Praxis
       def add_property(name, fields)
         dependencies = resource.properties[name][:dependencies]
         # Always add the underlying association if we're overriding the name...
-        praxis_compat_model = resource.model&.respond_to?(:_praxis_associations)
-        add_association(name, fields) if praxis_compat_model && resource.model._praxis_associations.key?(name)
+        if (praxis_compat_model = resource.model&.respond_to?(:_praxis_associations))
+          aliased_as = resource.properties[name][:as]
+          add_association(aliased_as, fields) if resource.model._praxis_associations[aliased_as]
+        end
         dependencies&.each do |dependency|
           # To detect recursion, let's allow mapping depending fields to the same name of the property
           # but properly detecting if it's a real association...in which case we've already added it above

data/lib/praxis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Praxis
-  VERSION = '2.0.pre.26'
+  VERSION = '2.0.pre.27'
 end

data/spec/praxis/mapper/resource_spec.rb

@@ -5,6 +5,8 @@ require 'spec_helper'
 describe Praxis::Mapper::Resource do
   let(:parent_record) { ParentModel.new(id: 100, name: 'george sr') }
   let(:parent_records) { [ParentModel.new(id: 101, name: 'georgia'), ParentModel.new(id: 102, name: 'georgina')] }
+  let(:other_model) { OtherModel.new(name: 'other george') }
+
   let(:record) { SimpleModel.new(id: 103, name: 'george xvi') }
   let(:model) { SimpleModel }
 
@@ -16,15 +18,19 @@ describe Praxis::Mapper::Resource do
       subject(:properties) { resource.properties }
 
       it 'includes directly-set properties' do
-        expect(properties[:other_resource]).to eq(dependencies: [:other_model], through: nil)
+        expect(properties[:other_resource]).to eq(dependencies: [:other_model], through: nil, as: :other_resource)
+      end
+
+      it 'includes aliases as well if different from name' do
+        expect(properties[:aliased_association]).to eq(dependencies: [:name], through: nil, as: :other_model)
       end
 
       it 'inherits from a superclass' do
-        expect(properties[:href]).to eq(dependencies: [:id], through: nil)
+        expect(properties[:href]).to eq(dependencies: [:id], through: nil, as: :href)
       end
 
       it 'properly overrides a property from the parent' do
-        expect(properties[:name]).to eq(dependencies: [:simple_name], through: nil)
+        expect(properties[:name]).to eq(dependencies: [:simple_name], through: nil, as: :name)
       end
     end
   end
@@ -106,6 +112,19 @@ describe Praxis::Mapper::Resource do
         expect(parents.collect(&:record)).to match_array(parent_records)
       end
     end
+
+    context 'for aliased properties' do
+      before { expect(record).to receive(:other_model).and_return(other_model) }
+      it 'skips creation of aliased method if the resource already has it defined' do
+        expect(subject.overriden_aliased_association).to be_kind_of(OtherModel) # Our override return a bare model
+        expect(subject.method(:overriden_aliased_association).source_location).to_not include(%r{/mapper/resource.rb$}) # Not created by us
+      end
+
+      it 'creates the aliased method name, instead of the property name' do
+        expect(subject.aliased_association).to be_kind_of(OtherResource) # Calling the other generated method also wraps it
+        expect(subject.method(:aliased_association).source_location).to include(%r{/mapper/resource.rb$}) # created by us
+      end
+    end
   end
 
   context 'resource_delegate' do

data/spec/praxis/mapper/selector_generator_spec.rb

@@ -213,6 +213,29 @@ describe Praxis::Mapper::SelectorGenerator do
         end
         it_behaves_like 'a proper selector'
       end
+      context 'Aliased underlying associations follows any nested fields...' do
+        let(:fields) do
+          {
+            parent_id: true,
+            aliased_association: {
+              display_name: true
+            }
+          }
+        end
+        let(:selectors) do
+          {
+            model: SimpleModel,
+            columns: %i[other_model_id parent_id simple_name],
+            tracks: {
+              other_model: {
+                model: OtherModel,
+                columns: %i[id name]
+              }
+            }
+          }
+        end
+        it_behaves_like 'a proper selector'
+      end
     end
 
     context 'string associations' do

data/spec/support/spec_resources.rb

@@ -125,6 +125,12 @@ class SimpleResource < BaseResource
     other_model
   end
 
+  def overriden_aliased_association
+    # My custom override (instead of the auto-generated delegator)
+    # For fun, we'll just return the raw model, without wrapping it in the resource
+    record.other_model
+  end
+
   batch_computed(:computed_name) do |rows_by_id:|
     rows_by_id.transform_values do |v|
       "BATCH_COMPUTED_#{v.name}"
@@ -146,6 +152,8 @@ class SimpleResource < BaseResource
   property :no_deps, dependencies: []
 
   property :deep_nested_deps, dependencies: ['parent.simple_children.other_model.parent.display_name']
+  property :aliased_association, as: :other_model, dependencies: [:name]
+  property :overriden_aliased_association, as: :other_model, dependencies: [:name]
 
   before(:update!, :do_before_update)
   around(:update!, :do_around_update_nested)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: praxis
 version: !ruby/object:Gem::Version
-  version: 2.0.pre.26
+  version: 2.0.pre.27
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-14 00:00:00.000000000 Z
+date: 2022-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport